From e2141da81ea059c6946c7c7c674babd7ef62443a Mon Sep 17 00:00:00 2001
From: yassin <yassin@berri.ai>
Date: Sat, 19 Sep 2026 00:23:11 +0000
Subject: [PATCH] fix(ui): treat MCP allowed clients with an empty alias or
 value as malformed

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
---
 .../_components/MCPNetworkSettings.test.tsx           | 11 +++++++++++
 .../mcp-servers/_components/MCPNetworkSettings.tsx    |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.test.tsx b/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.test.tsx
index 4cc87f1455c..4a486bfc648 100644
--- a/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.test.tsx
+++ b/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.test.tsx
@@ -211,6 +211,17 @@ describe("MCPNetworkSettings", () => {
     await waitFor(() => expect(screen.queryByText(/stored allowlist is not a list/)).not.toBeInTheDocument());
   });
 
+  it("treats a stored entry with an empty alias or value as denying every client, like the gateway does", async () => {
+    vi.mocked(getGeneralSettingsCall).mockResolvedValue([
+      { field_name: "mcp_allowed_clients", field_value: [ANTIGRAVITY, { alias: "", value: "claude-code" }] },
+    ]);
+
+    renderSettings();
+
+    expect(await screen.findByText(/stored allowlist is not a list of alias and value pairs/)).toBeVisible();
+    expect(screen.queryByRole("button", { name: /^Antigravity CLI/ })).not.toBeInTheDocument();
+  });
+
   it("adds clients as alias and value pairs and saves them under mcp_allowed_clients", async () => {
     renderSettings();
     await screen.findByText("Allowed Clients");
diff --git a/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.tsx b/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.tsx
index db45cfdedd1..2fd62c7f1ef 100644
--- a/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.tsx
+++ b/ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/MCPNetworkSettings.tsx
@@ -52,7 +52,7 @@ interface ClientDraft extends AllowedClient {
 const isAllowedClient = (entry: unknown): entry is AllowedClient => {
   if (typeof entry !== "object" || entry === null) return false;
   const { alias, value } = entry as Partial<Record<keyof AllowedClient, unknown>>;
-  return typeof alias === "string" && typeof value === "string";
+  return typeof alias === "string" && typeof value === "string" && !isIncomplete({ alias, value });
 };
 
 type StoredAllowlist =