From df130fea02213e0cfd90c178d328caaca3dffb2c Mon Sep 17 00:00:00 2001 From: factnn <166481866+factnn@users.noreply.github.com> Date: Sun, 21 Jun 2026 14:11:21 +0800 Subject: [PATCH] fix: avoid shadowing logging_obj in overhead duration code path Renamed local logging_obj to _logging_obj and start_time to _start_time to prevent overwriting the function-level logging_obj variable, which caused proxy-infra test failures when self.data had no litellm_logging_obj. --- litellm/proxy/common_request_processing.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/litellm/proxy/common_request_processing.py b/litellm/proxy/common_request_processing.py index f08962000c5..4349ec130c4 100644 --- a/litellm/proxy/common_request_processing.py +++ b/litellm/proxy/common_request_processing.py @@ -1431,19 +1431,19 @@ class ProxyBaseLLMRequestProcessing: _hidden_params = getattr(response, "_hidden_params", {}) or {} if not _hidden_params.get("litellm_overhead_time_ms"): end_time = datetime.now() - logging_obj = self.data.get("litellm_logging_obj") - if logging_obj is not None: + _logging_obj = self.data.get("litellm_logging_obj") + if _logging_obj is not None: from litellm.litellm_core_utils.llm_response_utils.response_metadata import ( update_response_metadata, ) - start_time = logging_obj.start_time or end_time + _start_time = _logging_obj.start_time or end_time update_response_metadata( result=response, - logging_obj=logging_obj, + logging_obj=_logging_obj, model=self.data.get("model"), kwargs=self.data, - start_time=start_time, + start_time=_start_time, end_time=end_time, )