diff --git a/litellm/integrations/SlackAlerting/slack_alerting.py b/litellm/integrations/SlackAlerting/slack_alerting.py index caac8e888fd..9c754e378aa 100644 --- a/litellm/integrations/SlackAlerting/slack_alerting.py +++ b/litellm/integrations/SlackAlerting/slack_alerting.py @@ -137,8 +137,9 @@ class SlackAlerting(CustomBatchLogger): ): if alerting is not None: self.alerting = alerting - asyncio.create_task(self.periodic_flush()) - self.periodic_started = True + if not self.periodic_started: + asyncio.create_task(self.periodic_flush()) + self.periodic_started = True if alerting_threshold is not None: self.alerting_threshold = alerting_threshold if alert_types is not None: diff --git a/tests/test_litellm/integrations/SlackAlerting/test_slack_alerting.py b/tests/test_litellm/integrations/SlackAlerting/test_slack_alerting.py index 44dda57dd27..6c1ae16242b 100644 --- a/tests/test_litellm/integrations/SlackAlerting/test_slack_alerting.py +++ b/tests/test_litellm/integrations/SlackAlerting/test_slack_alerting.py @@ -179,6 +179,20 @@ class TestSlackAlerting(unittest.TestCase): self.slack_alerting.update_values(alerting_args={"slack_alerting": "True"}) assert self.slack_alerting.periodic_started == True + @patch("asyncio.create_task") + def test_update_values_alerting_does_not_restart_periodic_task(self, mock_create_task): + mock_create_task.return_value = AsyncMock() + + self.assertFalse(self.slack_alerting.periodic_started) + + self.slack_alerting.update_values(alerting=["slack"]) + self.assertTrue(self.slack_alerting.periodic_started) + assert mock_create_task.call_count == 1 + + self.slack_alerting.update_values(alerting=["slack"]) + self.slack_alerting.update_values(alerting=["slack"]) + assert mock_create_task.call_count == 1 + @patch("litellm.integrations.SlackAlerting.slack_alerting.datetime") def test_alert_type_in_formatted_message(self, mock_datetime): # Setup mocks