diff --git a/deploy/charts/litellm-helm/Chart.yaml b/deploy/charts/litellm-helm/Chart.yaml index 0aef2442bfe..868e1ad876e 100644 --- a/deploy/charts/litellm-helm/Chart.yaml +++ b/deploy/charts/litellm-helm/Chart.yaml @@ -18,7 +18,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 1.1.0 +version: 1.2.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to diff --git a/deploy/charts/litellm-helm/templates/deployment.yaml b/deploy/charts/litellm-helm/templates/deployment.yaml index b9cd1be06ec..a7fcb3be163 100644 --- a/deploy/charts/litellm-helm/templates/deployment.yaml +++ b/deploy/charts/litellm-helm/templates/deployment.yaml @@ -183,6 +183,7 @@ spec: httpGet: path: {{ .Values.livenessProbe.path | quote }} port: "http" + scheme: {{ .Values.livenessProbe.scheme | default "HTTP" }} initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }} periodSeconds: {{ .Values.livenessProbe.periodSeconds }} timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }} @@ -192,6 +193,7 @@ spec: httpGet: path: {{ .Values.readinessProbe.path | quote }} port: "http" + scheme: {{ .Values.readinessProbe.scheme | default "HTTP" }} initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }} periodSeconds: {{ .Values.readinessProbe.periodSeconds }} timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }} @@ -201,6 +203,7 @@ spec: httpGet: path: {{ .Values.startupProbe.path | quote }} port: "http" + scheme: {{ .Values.startupProbe.scheme | default "HTTP" }} initialDelaySeconds: {{ .Values.startupProbe.initialDelaySeconds }} periodSeconds: {{ .Values.startupProbe.periodSeconds }} timeoutSeconds: {{ .Values.startupProbe.timeoutSeconds }} diff --git a/deploy/charts/litellm-helm/tests/deployment_tests.yaml b/deploy/charts/litellm-helm/tests/deployment_tests.yaml index f3d62651d8f..5f58f40e838 100644 --- a/deploy/charts/litellm-helm/tests/deployment_tests.yaml +++ b/deploy/charts/litellm-helm/tests/deployment_tests.yaml @@ -402,3 +402,34 @@ tests: - equal: path: spec.template.metadata.annotations["example.com/literal"] value: "plain-string-value" + - it: should default probe httpGet scheme to HTTP + template: deployment.yaml + set: + image.tag: test + asserts: + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.scheme + value: HTTP + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.scheme + value: HTTP + - equal: + path: spec.template.spec.containers[0].startupProbe.httpGet.scheme + value: HTTP + - it: should set probe httpGet scheme to HTTPS when configured + template: deployment.yaml + set: + image.tag: test + livenessProbe.scheme: HTTPS + readinessProbe.scheme: HTTPS + startupProbe.scheme: HTTPS + asserts: + - equal: + path: spec.template.spec.containers[0].livenessProbe.httpGet.scheme + value: HTTPS + - equal: + path: spec.template.spec.containers[0].readinessProbe.httpGet.scheme + value: HTTPS + - equal: + path: spec.template.spec.containers[0].startupProbe.httpGet.scheme + value: HTTPS diff --git a/deploy/charts/litellm-helm/values.yaml b/deploy/charts/litellm-helm/values.yaml index 6e30a6af444..27872813ebd 100644 --- a/deploy/charts/litellm-helm/values.yaml +++ b/deploy/charts/litellm-helm/values.yaml @@ -91,6 +91,10 @@ service: # Probes for LiteLLM gateway container livenessProbe: path: /health/liveliness + # Scheme for the probe request: HTTP (default) or HTTPS. Set to HTTPS when the + # proxy terminates TLS on the container port (ssl_keyfile_path/ssl_certfile_path), + # otherwise the kubelet's plain-HTTP probe fails the TLS handshake. + scheme: HTTP initialDelaySeconds: 0 periodSeconds: 15 timeoutSeconds: 5 @@ -99,6 +103,8 @@ livenessProbe: readinessProbe: path: /health/readiness + # See livenessProbe.scheme. HTTP (default) or HTTPS. + scheme: HTTP initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 5 @@ -107,6 +113,8 @@ readinessProbe: startupProbe: path: /health/readiness + # See livenessProbe.scheme. HTTP (default) or HTTPS. + scheme: HTTP initialDelaySeconds: 0 periodSeconds: 10 timeoutSeconds: 5