From daf620353d64b2d7adb6525e05d43b2a9c3adb52 Mon Sep 17 00:00:00 2001
From: Yuneng Jiang <yuneng@berri.ai>
Date: Sat, 31 Oct 2026 19:07:49 -0700
Subject: [PATCH] fix(ui): guard i18n label lookups against prototype-named
 values

A server value such as "toString" used as a key into a label map
resolved to an Object.prototype member and was passed to t(), which
throws. Check own properties before translating so those values fall
back to the raw string as before
---
 .../cache_settings/RedisTypeSelector.tsx           |  9 +++++++--
 .../CoordinationRedisTypeSelector.tsx              |  6 +++++-
 .../coordinationRedisUtils.ts                      |  2 +-
 .../Settings/AdminSettings/CyberArk/CyberArk.tsx   | 12 +++++++-----
 .../AdminSettings/CyberArk/EditCyberArkModal.tsx   |  2 +-
 .../HashicorpVault/EditHashicorpVaultModal.tsx     |  2 +-
 .../HashicorpVault/HashicorpVault.tsx              | 12 +++++++-----
 .../SSOSettings/Modals/BaseSSOSettingsForm.tsx     |  6 ++++--
 .../AdminSettings/SSOSettings/RoleMappings.tsx     | 14 ++++++++++++--
 .../AdminSettings/SSOSettings/SSOSettings.tsx      |  2 +-
 .../LoggingCallbacksTableColumns.tsx               |  2 +-
 .../src/components/routing_groups/strategy.ts      |  2 +-
 12 files changed, 48 insertions(+), 23 deletions(-)

diff --git a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/cache_settings/RedisTypeSelector.tsx b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/cache_settings/RedisTypeSelector.tsx
index db8d0cd8b84..d88d9390bf5 100644
--- a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/cache_settings/RedisTypeSelector.tsx
+++ b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/cache_settings/RedisTypeSelector.tsx
@@ -23,7 +23,9 @@ const RedisTypeSelector: React.FC<RedisTypeSelectorProps> = ({ redisType, redisT
       <label className="text-sm font-medium">{t("caching.settings.redisType.label")}</label>
       <Select value={redisType} onValueChange={(value) => value !== null && onTypeChange(value)}>
         <SelectTrigger className="w-full">
-          <SelectValue>{REDIS_TYPE_LABELS[redisType] ? t(REDIS_TYPE_LABELS[redisType]) : redisType}</SelectValue>
+          <SelectValue>
+            {Object.hasOwn(REDIS_TYPE_LABELS, redisType) ? t(REDIS_TYPE_LABELS[redisType]) : redisType}
+          </SelectValue>
         </SelectTrigger>
         <SelectContent>
           {Object.entries(REDIS_TYPE_LABELS).map(([value, label]) => (
@@ -34,7 +36,10 @@ const RedisTypeSelector: React.FC<RedisTypeSelectorProps> = ({ redisType, redisT
         </SelectContent>
       </Select>
       <p className="text-xs text-muted-foreground">
-        {t(redisTypeDescriptions[redisType] || "caching.settings.redisType.fallbackDescription")}
+        {t(
+          (Object.hasOwn(redisTypeDescriptions, redisType) && redisTypeDescriptions[redisType]) ||
+            "caching.settings.redisType.fallbackDescription",
+        )}
       </p>
     </div>
   );
diff --git a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/CoordinationRedisTypeSelector.tsx b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/CoordinationRedisTypeSelector.tsx
index 39e5ee89778..9dd2c6b24d7 100644
--- a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/CoordinationRedisTypeSelector.tsx
+++ b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/CoordinationRedisTypeSelector.tsx
@@ -22,7 +22,11 @@ const CoordinationRedisTypeSelector: React.FC<CoordinationRedisTypeSelectorProps
       </label>
       <Select value={redisType} onValueChange={(value) => value !== null && onTypeChange(value)}>
         <SelectTrigger id="coordination-redis-type" className="w-full">
-          <SelectValue>{t(COORDINATION_REDIS_TYPE_LABELS[redisType])}</SelectValue>
+          <SelectValue>
+            {Object.hasOwn(COORDINATION_REDIS_TYPE_LABELS, redisType)
+              ? t(COORDINATION_REDIS_TYPE_LABELS[redisType])
+              : ""}
+          </SelectValue>
         </SelectTrigger>
         <SelectContent>
           {COORDINATION_REDIS_TYPES.map((type) => (
diff --git a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/coordinationRedisUtils.ts b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/coordinationRedisUtils.ts
index 553a996c8bd..008f9ba9ffa 100644
--- a/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/coordinationRedisUtils.ts
+++ b/ui/litellm-dashboard/src/app/(dashboard)/caching/_components/coordination_redis_settings/coordinationRedisUtils.ts
@@ -156,6 +156,6 @@ export const sourceBadge = (
   t: TFunction = i18n.t.bind(i18n),
 ): SourceBadgeDescriptor => {
   const known: Readonly<Record<string, SourceBadgeKeys>> = SOURCE_BADGES;
-  const badge = (source && known[source]) || NOT_CONFIGURED_BADGE;
+  const badge = source && Object.hasOwn(known, source) ? known[source] : NOT_CONFIGURED_BADGE;
   return { tone: badge.tone, label: t(badge.label), tooltip: t(badge.tooltip) };
 };
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/CyberArk.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/CyberArk.tsx
index 9d5ea361ead..97ab9654e4b 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/CyberArk.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/CyberArk.tsx
@@ -80,7 +80,7 @@ export default function CyberArk() {
         onSuccess: () => {
           toast.success(
             t("adminPanel.cyberArk.toasts.fieldCleared", {
-              field: (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField,
+              field: (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField,
             }),
           );
           setClearingField(null);
@@ -103,7 +103,7 @@ export default function CyberArk() {
           variant="ghost"
           size="icon-sm"
           aria-label={t("adminPanel.cyberArk.actions.clearField", {
-            field: (FIELD_LABELS[key] && t(FIELD_LABELS[key])) ?? key,
+            field: (Object.hasOwn(FIELD_LABELS, key) && t(FIELD_LABELS[key])) || key,
           })}
           onClick={() => setClearingField(key)}
         >
@@ -191,7 +191,7 @@ export default function CyberArk() {
               <dl className="divide-y divide-border overflow-hidden rounded-md border border-border">
                 <DetailRow label={t("adminPanel.cyberArk.authMethodLabel")}>{detectAuthMethod(rawValues, t)}</DetailRow>
                 {fieldsToShow.map(([key]) => (
-                  <DetailRow key={key} label={(FIELD_LABELS[key] && t(FIELD_LABELS[key])) ?? key}>
+                  <DetailRow key={key} label={(Object.hasOwn(FIELD_LABELS, key) && t(FIELD_LABELS[key])) || key}>
                     {renderValue(key)}
                   </DetailRow>
                 ))}
@@ -229,7 +229,9 @@ export default function CyberArk() {
       <DeleteResourceModal
         isOpen={clearingField !== null}
         title={t("adminPanel.cyberArk.clearModal.title", {
-          field: clearingField ? (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField : "",
+          field: clearingField
+            ? (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField
+            : "",
         })}
         message={t("adminPanel.cyberArk.clearModal.message")}
         resourceInformationTitle={t("adminPanel.cyberArk.clearModal.resourceTitle")}
@@ -237,7 +239,7 @@ export default function CyberArk() {
           {
             label: t("adminPanel.cyberArk.clearModal.fieldLabel"),
             value: clearingField
-              ? (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField
+              ? (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField
               : "",
           },
         ]}
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/EditCyberArkModal.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/EditCyberArkModal.tsx
index b10f0e634bf..f1c9d1df337 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/EditCyberArkModal.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/CyberArk/EditCyberArkModal.tsx
@@ -139,7 +139,7 @@ const EditCyberArkModal: React.FC<EditCyberArkModalProps> = ({ isVisible, onCanc
         key={fieldName}
         control={form.control}
         name={fieldName}
-        label={(FIELD_LABELS[fieldName] && t(FIELD_LABELS[fieldName])) ?? fieldName}
+        label={(Object.hasOwn(FIELD_LABELS, fieldName) && t(FIELD_LABELS[fieldName])) || fieldName}
       >
         {({ ref, ...field }) =>
           isSensitive ? (
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/EditHashicorpVaultModal.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/EditHashicorpVaultModal.tsx
index 6915b9c14bc..77933210957 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/EditHashicorpVaultModal.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/EditHashicorpVaultModal.tsx
@@ -146,7 +146,7 @@ const EditHashicorpVaultModal: React.FC<EditHashicorpVaultModalProps> = ({ isVis
         key={fieldName}
         control={form.control}
         name={fieldName}
-        label={(FIELD_LABELS[fieldName] && t(FIELD_LABELS[fieldName])) ?? fieldName}
+        label={(Object.hasOwn(FIELD_LABELS, fieldName) && t(FIELD_LABELS[fieldName])) || fieldName}
       >
         {({ ref, ...field }) =>
           isSensitive ? (
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/HashicorpVault.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/HashicorpVault.tsx
index 1d2fa542e85..5d23be5b967 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/HashicorpVault.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/HashicorpVault/HashicorpVault.tsx
@@ -81,7 +81,7 @@ export default function HashicorpVault() {
         onSuccess: () => {
           toast.success(
             t("adminPanel.hashicorpVault.toasts.fieldCleared", {
-              field: (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField,
+              field: (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField,
             }),
           );
           setClearingField(null);
@@ -105,7 +105,7 @@ export default function HashicorpVault() {
           variant="ghost"
           size="icon-sm"
           aria-label={t("adminPanel.hashicorpVault.actions.clearField", {
-            field: (FIELD_LABELS[key] && t(FIELD_LABELS[key])) ?? key,
+            field: (Object.hasOwn(FIELD_LABELS, key) && t(FIELD_LABELS[key])) || key,
           })}
           onClick={() => setClearingField(key)}
         >
@@ -193,7 +193,7 @@ export default function HashicorpVault() {
                     {detectAuthMethod(rawValues, t)}
                   </DetailRow>
                   {fieldsToShow.map(([key]) => (
-                    <DetailRow key={key} label={(FIELD_LABELS[key] && t(FIELD_LABELS[key])) ?? key}>
+                    <DetailRow key={key} label={(Object.hasOwn(FIELD_LABELS, key) && t(FIELD_LABELS[key])) || key}>
                       {renderValue(key)}
                     </DetailRow>
                   ))}
@@ -226,7 +226,9 @@ export default function HashicorpVault() {
       <DeleteResourceModal
         isOpen={clearingField !== null}
         title={t("adminPanel.hashicorpVault.clearModal.title", {
-          field: clearingField ? (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField : "",
+          field: clearingField
+            ? (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField
+            : "",
         })}
         message={t("adminPanel.hashicorpVault.clearModal.message")}
         resourceInformationTitle={t("adminPanel.hashicorpVault.clearModal.resourceTitle")}
@@ -234,7 +236,7 @@ export default function HashicorpVault() {
           {
             label: t("adminPanel.hashicorpVault.clearModal.fieldLabel"),
             value: clearingField
-              ? (FIELD_LABELS[clearingField] && t(FIELD_LABELS[clearingField])) ?? clearingField
+              ? (Object.hasOwn(FIELD_LABELS, clearingField) && t(FIELD_LABELS[clearingField])) || clearingField
               : "",
           },
         ]}
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/Modals/BaseSSOSettingsForm.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/Modals/BaseSSOSettingsForm.tsx
index b35f9e1fbce..f3f1332a093 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/Modals/BaseSSOSettingsForm.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/Modals/BaseSSOSettingsForm.tsx
@@ -387,7 +387,9 @@ export const SSOProviderSelectField = () => {
                     <Logo
                       src={logo}
                       label={
-                        ssoProviderDisplayNames[optionValue] ? t(ssoProviderDisplayNames[optionValue]) : optionValue
+                        Object.hasOwn(ssoProviderDisplayNames, optionValue)
+                          ? t(ssoProviderDisplayNames[optionValue])
+                          : optionValue
                       }
                       className="h-6 w-6 mr-3 object-contain"
                     />
@@ -477,7 +479,7 @@ const DEFAULT_ROLE_OPTIONS: ReadonlyArray<{ value: string; label: ParseKeys }> =
 ];
 
 const providerOptionLabel = (value: string, t: TFunction) =>
-  ssoProviderDisplayNames[value]
+  Object.hasOwn(ssoProviderDisplayNames, value)
     ? t(ssoProviderDisplayNames[value])
     : t("adminPanel.ssoSettings.providers.fallback", { name: value.charAt(0).toUpperCase() + value.slice(1) });
 
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/RoleMappings.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/RoleMappings.tsx
index b6c0356b1e8..c3cdd81ee69 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/RoleMappings.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/RoleMappings.tsx
@@ -27,7 +27,13 @@ export default function RoleMappings({ roleMappings }: { roleMappings: RoleMappi
       id: "role",
       accessorKey: "role",
       header: t("adminPanel.ssoSettings.roleMappings.columns.role"),
-      cell: ({ row }) => <strong className="font-semibold">{t(defaultRoleDisplayNames[row.original.role])}</strong>,
+      cell: ({ row }) => (
+        <strong className="font-semibold">
+          {Object.hasOwn(defaultRoleDisplayNames, row.original.role)
+            ? t(defaultRoleDisplayNames[row.original.role])
+            : ""}
+        </strong>
+      ),
     },
     {
       id: "groups",
@@ -69,7 +75,11 @@ export default function RoleMappings({ roleMappings }: { roleMappings: RoleMappi
                 {t("adminPanel.ssoSettings.roleMappings.defaultRole")}
               </h5>
               <div>
-                <strong className="font-semibold">{t(defaultRoleDisplayNames[roleMappings.default_role])}</strong>
+                <strong className="font-semibold">
+                  {Object.hasOwn(defaultRoleDisplayNames, roleMappings.default_role)
+                    ? t(defaultRoleDisplayNames[roleMappings.default_role])
+                    : ""}
+                </strong>
               </div>
             </div>
           </div>
diff --git a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/SSOSettings.tsx b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/SSOSettings.tsx
index 6e2a28b3d14..f1ad427be8c 100644
--- a/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/SSOSettings.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/AdminSettings/SSOSettings/SSOSettings.tsx
@@ -248,7 +248,7 @@ export default function SSOSettings() {
               <Logo
                 src={ssoProviderLogoMap[selectedProvider]}
                 label={
-                  ssoProviderDisplayNames[selectedProvider]
+                  Object.hasOwn(ssoProviderDisplayNames, selectedProvider)
                     ? t(ssoProviderDisplayNames[selectedProvider])
                     : selectedProvider
                 }
diff --git a/ui/litellm-dashboard/src/components/Settings/LoggingAndAlerts/LoggingCallbacks/LoggingCallbacksTableColumns.tsx b/ui/litellm-dashboard/src/components/Settings/LoggingAndAlerts/LoggingCallbacks/LoggingCallbacksTableColumns.tsx
index dad1eccecac..ca53f9f7b2e 100644
--- a/ui/litellm-dashboard/src/components/Settings/LoggingAndAlerts/LoggingCallbacks/LoggingCallbacksTableColumns.tsx
+++ b/ui/litellm-dashboard/src/components/Settings/LoggingAndAlerts/LoggingCallbacks/LoggingCallbacksTableColumns.tsx
@@ -126,7 +126,7 @@ export const getLoggingCallbacksTableColumns = (
       return (
         <StatusBadge
           tone={callbackModeTone(mode)}
-          label={CALLBACK_MODE_LABELS[mode] ? t(CALLBACK_MODE_LABELS[mode]) : mode}
+          label={Object.hasOwn(CALLBACK_MODE_LABELS, mode) ? t(CALLBACK_MODE_LABELS[mode]) : mode}
         />
       );
     },
diff --git a/ui/litellm-dashboard/src/components/routing_groups/strategy.ts b/ui/litellm-dashboard/src/components/routing_groups/strategy.ts
index 123909c786c..d3c1334563c 100644
--- a/ui/litellm-dashboard/src/components/routing_groups/strategy.ts
+++ b/ui/litellm-dashboard/src/components/routing_groups/strategy.ts
@@ -9,4 +9,4 @@ const STRATEGY_LABELS: Readonly<Record<string, ParseKeys>> = {
 };
 
 export const formatStrategyLabel = (strategy: string, t: TFunction): string =>
-  STRATEGY_LABELS[strategy] ? t(STRATEGY_LABELS[strategy]) : strategy;
+  Object.hasOwn(STRATEGY_LABELS, strategy) ? t(STRATEGY_LABELS[strategy]) : strategy;