From da5cab690ea9b6c94d60f462b7547bf90f4a204c Mon Sep 17 00:00:00 2001 From: Avgany-23 Date: Wed, 12 Aug 2026 22:42:13 +0300 Subject: [PATCH] fix: add filter_time_by parameter to spend query optimization tests, delete comment. --- litellm/proxy/spend_tracking/spend_management_endpoints.py | 1 - .../proxy/spend_tracking/test_spend_query_optimization.py | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/litellm/proxy/spend_tracking/spend_management_endpoints.py b/litellm/proxy/spend_tracking/spend_management_endpoints.py index b673d98a64c..cede5049101 100644 --- a/litellm/proxy/spend_tracking/spend_management_endpoints.py +++ b/litellm/proxy/spend_tracking/spend_management_endpoints.py @@ -2305,7 +2305,6 @@ async def ui_view_spend_logs( code=status.HTTP_400_BAD_REQUEST, ) - # Validate filter_time_by valid_filter_fields: Final = ("startTime", "endTime") if filter_time_by not in valid_filter_fields: raise ProxyException( diff --git a/tests/test_litellm/proxy/spend_tracking/test_spend_query_optimization.py b/tests/test_litellm/proxy/spend_tracking/test_spend_query_optimization.py index 19083486974..80898e05032 100644 --- a/tests/test_litellm/proxy/spend_tracking/test_spend_query_optimization.py +++ b/tests/test_litellm/proxy/spend_tracking/test_spend_query_optimization.py @@ -194,6 +194,7 @@ async def test_spend_logs_ui_wraps_params_in_at_time_zone_utc(monkeypatch): sort_by="startTime", sort_order="desc", user_api_key_dict=auth, + filter_time_by="startTime", ) assert mock_prisma.db.query_raw.called, "query_raw should have been called" @@ -257,6 +258,7 @@ async def test_spend_logs_ui_uses_bounded_count_not_full_scan(monkeypatch): sort_by="startTime", sort_order="desc", user_api_key_dict=auth, + filter_time_by="startTime", ) mock_prisma.db.litellm_spendlogs.count.assert_not_called() @@ -321,6 +323,7 @@ async def test_spend_logs_ui_caps_total_for_large_result_sets(monkeypatch): sort_by="startTime", sort_order="desc", user_api_key_dict=auth, + filter_time_by="startTime", ) assert response["total"] == SPEND_LOGS_PAGINATION_COUNT_CAP @@ -366,6 +369,7 @@ async def test_spend_logs_ui_empty_page_reports_zero_total(monkeypatch): sort_by="startTime", sort_order="desc", user_api_key_dict=auth, + filter_time_by="startTime", ) mock_prisma.db.litellm_spendlogs.count.assert_not_called() @@ -413,6 +417,7 @@ async def test_spend_logs_ui_out_of_range_page_keeps_total(monkeypatch): sort_by="startTime", sort_order="desc", user_api_key_dict=auth, + filter_time_by="startTime", ) mock_prisma.db.litellm_spendlogs.count.assert_not_called()