diff --git a/litellm/main.py b/litellm/main.py index f30d93361e5..3c06f5adfc4 100644 --- a/litellm/main.py +++ b/litellm/main.py @@ -6054,7 +6054,7 @@ def completion( custom_llm_provider=custom_llm_provider, model_id=optional_params.get("model_id"), ) - if mock_response or mock_tool_calls or mock_timeout: + if mock_response is not None or mock_tool_calls or mock_timeout: kwargs.pop("mock_timeout", None) # remove for any fallbacks triggered return mock_completion( model, diff --git a/litellm/utils.py b/litellm/utils.py index e2820f9c682..a4ea903b162 100644 --- a/litellm/utils.py +++ b/litellm/utils.py @@ -11157,7 +11157,7 @@ def should_run_mock_completion( mock_tool_calls: object | None, mock_timeout: object | None, ) -> bool: - if mock_response or mock_tool_calls or mock_timeout: + if mock_response is not None or mock_tool_calls or mock_timeout: return True return False diff --git a/tests/unit/test_mock_response_empty_string.py b/tests/unit/test_mock_response_empty_string.py new file mode 100644 index 00000000000..605bf5972e2 --- /dev/null +++ b/tests/unit/test_mock_response_empty_string.py @@ -0,0 +1,49 @@ +import pytest +import litellm +from litellm.utils import should_run_mock_completion + + +def test_should_run_mock_completion_with_empty_string(): + assert ( + should_run_mock_completion( + mock_response="", mock_tool_calls=None, mock_timeout=None + ) + is True + ) + assert ( + should_run_mock_completion( + mock_response=None, mock_tool_calls=None, mock_timeout=None + ) + is False + ) + assert ( + should_run_mock_completion( + mock_response="test", mock_tool_calls=None, mock_timeout=None + ) + is True + ) + + +def test_completion_mock_response_empty_string(): + response = litellm.completion( + model="openai/gpt-4o-mini", + messages=[{"role": "user", "content": "hi"}], + mock_response="", + api_base="http://127.0.0.1:9", + api_key="sk-test", + num_retries=0, + ) + assert response.choices[0].message.content == "" + + +@pytest.mark.asyncio +async def test_acompletion_mock_response_empty_string(): + response = await litellm.acompletion( + model="openai/gpt-4o-mini", + messages=[{"role": "user", "content": "hi"}], + mock_response="", + api_base="http://127.0.0.1:9", + api_key="sk-test", + num_retries=0, + ) + assert response.choices[0].message.content == ""