diff --git a/litellm-rust/crates/secrets-hashicorp/src/cert_login.rs b/litellm-rust/crates/secrets-hashicorp/src/cert_login.rs index 1eb09a89715..f99df62db12 100644 --- a/litellm-rust/crates/secrets-hashicorp/src/cert_login.rs +++ b/litellm-rust/crates/secrets-hashicorp/src/cert_login.rs @@ -3,22 +3,19 @@ pub struct CertLoginRequest { #[endpoint(skip)] pub mount: String, - #[endpoint(skip)] - #[allow(dead_code)] - pub name: Option, #[endpoint(raw)] body: Vec, } impl CertLoginRequest { - pub fn new(name: Option) -> Self { - let body: Vec = match name.as_deref() { - Some(name) => serde_json::to_vec(&serde_json::json!({ "name": name })).unwrap(), + pub fn new(name: Option<&str>) -> Self { + let body: Vec = match name { + Some(name) => serde_json::to_vec(&serde_json::json!({ "name": name })) + .expect("json object serialization is infallible"), None => b"{}".to_vec(), }; Self { mount: "cert".to_owned(), - name, body, } } diff --git a/litellm-rust/crates/secrets-hashicorp/src/secret_manager.rs b/litellm-rust/crates/secrets-hashicorp/src/secret_manager.rs index 7937fa93f8f..3ad9a549438 100644 --- a/litellm-rust/crates/secrets-hashicorp/src/secret_manager.rs +++ b/litellm-rust/crates/secrets-hashicorp/src/secret_manager.rs @@ -207,7 +207,7 @@ impl HashicorpVault { (None, Some(tls)) => { let login_client: VaultClient = self.build_client(self.config.login_namespace(), "")?; - let endpoint: CertLoginRequest = CertLoginRequest::new(tls.role.clone()); + let endpoint: CertLoginRequest = CertLoginRequest::new(tls.role.as_deref()); let auth = api::auth(&login_client, endpoint) .await .map_err(|error| map_api_error(error, ErrorContext::Login))?;