From d8f81082b6a898d960db87fe69d1a56399d687aa Mon Sep 17 00:00:00 2001 From: Ranjan G <76397067+ranjan-del@users.noreply.github.com> Date: Sat, 5 Sep 2026 15:10:48 +0530 Subject: [PATCH] test(logging): undo the stdout patch inside the test so capsys never restores a closed stream Fixes #39882 --- tests/test_litellm/test_logging.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/test_litellm/test_logging.py b/tests/test_litellm/test_logging.py index bf3757e6886..4de79e21d98 100644 --- a/tests/test_litellm/test_logging.py +++ b/tests/test_litellm/test_logging.py @@ -929,7 +929,7 @@ def test_plain_log_format_survives_hostile_streams(stdout, stderr): assert _plain_log_format(stdout, stderr) == _PLAIN_LOG_FORMAT -def test_level_routing_handler_falls_back_to_stderr_when_stdout_is_unusable(monkeypatch, capsys): +def test_level_routing_handler_falls_back_to_stderr_when_stdout_is_unusable(capsys): logger = logging.getLogger("test_level_routing_fallback") logger.handlers.clear() logger.propagate = False @@ -938,9 +938,13 @@ def test_level_routing_handler_falls_back_to_stderr_when_stdout_is_unusable(monk handler.setFormatter(logging.Formatter("%(levelname)s %(message)s")) logger.addHandler(handler) + # Undo the stdout patch before the test returns. The autouse conftest fixtures + # request `monkeypatch`, so it tears down after `capsys` and would restore + # sys.stdout to capsys's already-closed stream (see #39882). try: - monkeypatch.setattr(sys, "stdout", None) - logger.info("stdout is gone") + with pytest.MonkeyPatch.context() as mp: + mp.setattr(sys, "stdout", None) + logger.info("stdout is gone") finally: logger.handlers.clear()