scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-05 08:07:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 136

fix(langfuse): avoid provider shutdown during registry eviction

Browse source
This commit is contained in:
Yucheng Zhu 2026-09-01 14:09:50 -07:00
parent 9a542fb9f7
commit d4a1cd312f
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
litellm/integrations/langfuse/langfuse_sdk.py
View file

@ -216,16 +216,7 @@ class DiscardingSpanExporter(SpanExporter):
def _evict_if_stale_locked(
*, public_key: object, secret_key: object, base_url: object
) -> LangfuseResourceManager | None:
"""Assumes ``LangfuseResourceManager._lock`` is held; returns the still-valid cached bundle, if any.
langfuse keys its client registry on the public key alone, so a rotated
secret or a moved host silently keeps exporting with the original values.
Only the one stale entry is removed; the SDK's own reset would shut down
every other tenant in the process. A stale bundle no live litellm client
still holds also has its export thread stopped — but only when litellm
built the provider, because a bundle adopted from user code may share the
process-global provider.
"""
"""Assumes ``LangfuseResourceManager._lock`` is held; returns the still-valid cached bundle, if any."""
if not public_key:
return None
cached: Final = LangfuseResourceManager._instances.get(public_key) # pyright: ignore[reportPrivateUsage] # registry has no public accessor
@ -234,12 +225,6 @@ def _evict_if_stale_locked(
if getattr(cached, "secret_key", None) == secret_key and getattr(cached, "base_url", None) == base_url:
return cached
LangfuseResourceManager._instances.pop(public_key, None) # pyright: ignore[reportPrivateUsage] # registry has no public accessor
with _LIVE_CLIENTS_LOCK:
holders: Final = _live_clients.get(cached)
abandoned: Final = holders is None or len(holders) == 0
provider: Final = getattr(cached, "tracer_provider", None)
if abandoned and provider is not None and provider in _litellm_built_providers:
provider.shutdown()
return None