scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-03 02:22:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 81

fix(test): remove only the routes this test adds instead of restoring a full snapshot

Browse source 
The previous fix (2aa7fc934a) snapshotted app.router.routes before the test
and restored the whole snapshot in a finally block. Under pytest-xdist,
another test on the same worker can legitimately register a route on the
same process-wide app between this test's start and its cleanup; wholesale
restore silently dropped that too, breaking
test_native_provider_routes_are_unchanged[POST-/openai/v1/chat/completions-openai_proxy_route]
in CI.

Track only the two paths this test adds and filter exactly those back out
of app.router.routes afterward, leaving every other route (and whatever
order/objects exist at cleanup time) untouched.
This commit is contained in:
IdoPort 2026-09-14 11:43:14 +03:00
parent 2aa7fc934a
commit d38ec59f5e
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tests/test_litellm/proxy/pass_through_endpoints/test_llm_pass_through_endpoints.py
View file

@ -3415,8 +3415,12 @@ def test_custom_pass_through_endpoint_prefix_wins_over_native_provider_routes():
# app is the real, process-wide proxy app -- registering routes on it leaks
# into every other test (e.g. test_component_allowlists.py's full-route-coverage
# check) unless restored, so snapshot and restore app.router.routes afterward.
original_routes = list(app.router.routes)
# check) unless removed again. Track exactly the paths this test adds and
# filter only those back out afterward, rather than restoring a full
# snapshot -- under pytest-xdist, another test on the same worker can
# legitimately register routes between this test's start and its cleanup,
# and a wholesale snapshot restore would silently drop those too.
added_paths = {f"/claude-aws/v1/{suffix}" for suffix in ("files", "batches")}
try:
for suffix in ("files", "batches"):
InitPassThroughEndpointHelpers.add_exact_path_route(
@ -3441,7 +3445,10 @@ def test_custom_pass_through_endpoint_prefix_wins_over_native_provider_routes():
assert _resolve_route_name("POST", "/v1/files") == "create_file"
assert _resolve_route_name("POST", "/v1/batches") == "create_batch"
finally:
app.router.routes = original_routes
app.router.routes = [
route for route in app.router.routes
if getattr(route, "path", None) not in added_paths
]
def test_move_before_generic_provider_routes_is_a_no_op_without_a_generic_route():