style(agents): tidy typing and docstring in access group ceiling helpers
Some checks failed
LiteLLM Rust / rust-lint (push) Has been cancelled
LiteLLM Rust / rust-test (push) Has been cancelled
LiteLLM Rust / rust-wheel (push) Has been cancelled
Terraform Provider / gofmt, vet, build, test (push) Has been cancelled
Terraform Provider / Provider endpoints vs proxy OpenAPI schema (push) Has been cancelled
Terraform Modules / fmt, validate, test (aws) (push) Has been cancelled
Terraform Modules / fmt, validate, test (gcp) (push) Has been cancelled

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
yassin 2026-09-20 09:40:46 +00:00
parent 85da9cb588
commit d338d3f2d2
4 changed files with 6 additions and 6 deletions

View file

@ -4332,7 +4332,7 @@ async def _check_agent_access_group_model_access(
llm_router: Router | None,
resolve_ceiling: CeilingResolver = resolve_agent_access_group_ceiling,
) -> Literal[True]:
"""Attached groups naming no model deny every model, unlike the empty allowlist ``_can_object_call_model`` allows."""
"""Attached groups naming no model deny every model; the empty allowlist in ``_can_object_call_model`` allows."""
if not model or valid_token is None or not valid_token.agent_id:
return True
ceiling: Final = await resolve_ceiling(valid_token.agent_id)

View file

@ -8188,7 +8188,7 @@ async def _get_access_group_models(
async def _agent_access_group_visible_models(
user_api_key_dict: "UserAPIKeyAuth",
llm_router: Optional["Router"],
llm_router: "Router | None",
include_model_access_groups: bool,
return_wildcard_routes: bool,
team_id: str | None,

View file

@ -15,6 +15,7 @@ from litellm.proxy.agent_endpoints.agent_registry import (
_restore_redacted_litellm_params,
redact_sensitive_agent_litellm_params,
)
from litellm.types.agents import PatchAgentRequest
# Obviously-fake stand-ins for a real AWS credential pair (LIT-6736 regression
# fixtures) -- never a real key shape, and must never appear in any response.
@ -1052,7 +1053,9 @@ async def test_add_agent_to_db_without_access_group_ids_leaves_column_to_its_def
({"access_group_ids": None}, []),
],
)
async def test_patch_agent_in_db_replaces_access_group_ids_when_provided(patch_body: dict, expected: list[str]):
async def test_patch_agent_in_db_replaces_access_group_ids_when_provided(
patch_body: PatchAgentRequest, expected: list[str]
):
registry: Final = AgentRegistry()
mock_prisma: Final = MagicMock()
mock_prisma.db.litellm_agentstable.find_unique = AsyncMock(

View file

@ -8900,9 +8900,6 @@ def test_request_skips_budget_checks_extends_route_rule_with_zero_cost_models()
assert request_skips_budget_checks(route="/v1/chat/completions", model=None, llm_router=None) is False
# Agent access group model ceiling
def _agent_model_ceiling_resolver(
models: frozenset[str] | None,
) -> tuple[CeilingResolver, list[str]]: