Addressing feedback.

This commit is contained in:
Josh Bonczkowski 2026-03-17 14:44:02 -04:00
parent f5cc45f04c
commit d21a31d40c
2 changed files with 14 additions and 3 deletions

View file

@ -329,9 +329,9 @@ class NewRelicLogger(CustomLogger):
return {"prompt_tokens": 0, "completion_tokens": 0, "total_tokens": 0}
return {
"prompt_tokens": usage.get("prompt_tokens", 0),
"completion_tokens": usage.get("completion_tokens", 0),
"total_tokens": usage.get("total_tokens", 0),
"prompt_tokens": usage.get("prompt_tokens") or 0,
"completion_tokens": usage.get("completion_tokens") or 0,
"total_tokens": usage.get("total_tokens") or 0,
}
def _get_finish_reason(self, response_obj: ModelResponse) -> str:

View file

@ -426,6 +426,17 @@ class TestExtractUsage:
usage = self.logger._extract_usage(response)
assert usage == {"prompt_tokens": 0, "completion_tokens": 0, "total_tokens": 0}
def test_explicit_none_token_fields_return_zeros(self):
response = {
"usage": {
"prompt_tokens": None,
"completion_tokens": None,
"total_tokens": None,
}
}
usage = self.logger._extract_usage(response)
assert usage == {"prompt_tokens": 0, "completion_tokens": 0, "total_tokens": 0}
class TestGetFinishReason:
def setup_method(self):