fix(proxy): keep budget_rollover overage carry for zero max_budget rows

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
ryan 2026-09-18 11:13:40 +00:00
parent f3e5052ace
commit cfcdc3e45f
2 changed files with 14 additions and 2 deletions

View file

@ -143,12 +143,15 @@ class _ResetBand:
def _reset_band(max_budget: float | None, rollover_max_budget: float | None) -> _ResetBand | None:
if max_budget is None or not math.isfinite(max_budget) or max_budget <= 0:
if max_budget is None or not math.isfinite(max_budget):
return None
keep_overage: Final = litellm.budget_rollover is True
lo: Final = (
max_budget - rollover_max_budget
if rollover_max_budget is not None and math.isfinite(rollover_max_budget) and rollover_max_budget > max_budget
if max_budget > 0
and rollover_max_budget is not None
and math.isfinite(rollover_max_budget)
and rollover_max_budget > max_budget
else 0.0
)
if lo == 0.0 and not keep_overage:

View file

@ -3687,6 +3687,15 @@ def test_reset_spend_forgives_overage_when_rollover_off():
assert _reset_spend(30.0, band) == -70.0
def test_reset_band_zero_max_budget_keeps_overage_without_credit(rollover_enabled):
"""budget_rollover on with max_budget 0 still carries the whole overage, as it
did before caps existed, and a cap on a zero allowance never opens a credit floor."""
band = _reset_band(0.0, 600.0)
assert band == _ResetBand(base=0.0, lo=0.0, keep_overage=True)
assert _reset_spend(40.0, band) == 40.0
assert _reset_spend(0.0, band) == 0.0
def test_direct_reset_carries_unused_allowance_as_negative_spend(
reset_budget_job, mock_prisma_client, monkeypatch
):