scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-26 01:12:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 99

fix(triage): reopen before posting on reconsider so a failed reopen does not leave a misleading comment

Browse source
This commit is contained in:
mateo-berri 2026-05-19 07:41:44 +00:00
parent 542dde7990
commit cf65237a10
No known key found for this signature in database
2 changed files with 110 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.github/scripts/triage_with_llm.py vendored
View file

@ -699,9 +699,11 @@ def triage(
"action": "would-reopen",
"comment": reopen_body,
}
# Pass-on-reconsider -> reopen the PR with a friendly comment.
post_comment(repo, number, reopen_body)
# Reopen before posting so a failed reopen call doesn't
# leave a misleading "we reopened it" comment on a still-
# closed PR.
reopen_pr(repo, number)
post_comment(repo, number, reopen_body)
return {
**base,
"action": "reopened",
@ -753,11 +755,13 @@ def triage(
"verdict": verdict,
"comment": reopen_body,
}
post_comment(repo, number, reopen_body)
# Reopen before posting so a failed reopen call doesn't leave a
# misleading "reopened" comment on a still-closed item.
if kind == "pr":
reopen_pr(repo, number)
else:
reopen_issue(repo, number)
post_comment(repo, number, reopen_body)
return {
**base_result,
"action": "reopened",

103
tests/test_litellm/test_github_triage_with_llm.py
View file

@ -1098,6 +1098,109 @@ class TestTriageOrchestration:
assert reopened["n"] == 7
assert "reopened" in posted["body"].lower()
def test_should_reopen_before_posting_on_reconsider_pass(
self, triage_module, monkeypatch
):
# A failed reopen call must not leave a misleading "we reopened it"
# comment on a still-closed PR. Pin the order: reopen happens first;
# if reopen raises, post_comment must not run.
pr = self._make_pr(state="closed", body="Updated body with QA proof.")
monkeypatch.setattr(triage_module, "fetch_pr", lambda repo, n: pr)
monkeypatch.setattr(
triage_module, "was_auto_closed_by_agent_shin", lambda repo, n: True
)
monkeypatch.setattr(
triage_module,
"post_comment",
lambda *a, **kw: pytest.fail("must not post comment if reopen fails"),
)
def boom(*a, **kw):
raise RuntimeError("reopen 422")
monkeypatch.setattr(triage_module, "reopen_pr", boom)
with pytest.raises(RuntimeError):
triage_module.triage(
repo="o/r",
kind="pr",
number=42,
close=True,
model="m",
judge=lambda p: json.dumps(
{"verdict": "pass", "missing": [], "explanation": "ok"}
),
reconsider=True,
)
def test_should_reopen_before_posting_on_reconsider_linked_issue(
self, triage_module, monkeypatch
):
# Same ordering invariant for the linked-issue short-circuit.
pr = self._make_pr(state="closed", body="Fixes #1234")
monkeypatch.setattr(triage_module, "fetch_pr", lambda repo, n: pr)
monkeypatch.setattr(
triage_module, "was_auto_closed_by_agent_shin", lambda repo, n: True
)
monkeypatch.setattr(
triage_module,
"post_comment",
lambda *a, **kw: pytest.fail("must not post comment if reopen fails"),
)
def boom(*a, **kw):
raise RuntimeError("reopen 422")
monkeypatch.setattr(triage_module, "reopen_pr", boom)
with pytest.raises(RuntimeError):
triage_module.triage(
repo="o/r",
kind="pr",
number=55,
close=True,
model="m",
judge=lambda p: pytest.fail("LLM must not run for linked-issue path"),
reconsider=True,
)
def test_should_reopen_before_posting_on_reconsider_issue_pass(
self, triage_module, monkeypatch
):
# Same ordering invariant for issues (reopen_issue, not reopen_pr).
issue = {
"number": 7,
"title": "Bug",
"body": "Repro: curl ...",
"state": "closed",
"author_association": "NONE",
"user": {"login": "outside"},
}
monkeypatch.setattr(triage_module, "fetch_issue", lambda repo, n: issue)
monkeypatch.setattr(
triage_module, "was_auto_closed_by_agent_shin", lambda repo, n: True
)
monkeypatch.setattr(
triage_module,
"post_comment",
lambda *a, **kw: pytest.fail("must not post comment if reopen fails"),
)
def boom(*a, **kw):
raise RuntimeError("reopen 422")
monkeypatch.setattr(triage_module, "reopen_issue", boom)
with pytest.raises(RuntimeError):
triage_module.triage(
repo="o/r",
kind="issue",
number=7,
close=True,
model="m",
judge=lambda p: json.dumps(
{"verdict": "pass", "missing": [], "explanation": "ok"}
),
reconsider=True,
)
def test_should_triage_issues_kind(self, triage_module, monkeypatch):
issue = {
"number": 7,