diff --git a/tests/test_litellm/litellm_core_utils/test_embedding_optional_params.py b/tests/test_litellm/litellm_core_utils/test_embedding_optional_params.py index 100d72baa74..376467685be 100644 --- a/tests/test_litellm/litellm_core_utils/test_embedding_optional_params.py +++ b/tests/test_litellm/litellm_core_utils/test_embedding_optional_params.py @@ -4,51 +4,47 @@ import litellm @pytest.mark.parametrize("provider", ["azure", "together_ai"]) -def test_embedding_dimensions_drop_params_for_openai_compatible_provider(provider): - previous_drop_params = litellm.drop_params - try: - litellm.drop_params = False - dropped = litellm.utils.get_optional_params_embeddings( - model=f"{provider}/dummy-model", - custom_llm_provider=provider, - dimensions=512, - drop_params=True, - ) - assert "dimensions" not in dropped +def test_embedding_dimensions_drop_params_for_openai_compatible_provider(provider, monkeypatch): + monkeypatch.setattr(litellm, "drop_params", False) + dropped = litellm.utils.get_optional_params_embeddings( + model=f"{provider}/dummy-model", + custom_llm_provider=provider, + dimensions=512, + drop_params=True, + ) + assert "dimensions" not in dropped - litellm.drop_params = True - dropped_globally = litellm.utils.get_optional_params_embeddings( - model=f"{provider}/dummy-model", - custom_llm_provider=provider, - dimensions=512, - ) - assert "dimensions" not in dropped_globally + monkeypatch.setattr(litellm, "drop_params", True) + dropped_globally = litellm.utils.get_optional_params_embeddings( + model=f"{provider}/dummy-model", + custom_llm_provider=provider, + dimensions=512, + ) + assert "dimensions" not in dropped_globally - litellm.drop_params = False - preserved = litellm.utils.get_optional_params_embeddings( - model=f"{provider}/dummy-model", - custom_llm_provider=provider, - dimensions=512, - ) - assert preserved["dimensions"] == 512 + monkeypatch.setattr(litellm, "drop_params", False) + preserved = litellm.utils.get_optional_params_embeddings( + model=f"{provider}/dummy-model", + custom_llm_provider=provider, + dimensions=512, + ) + assert preserved["dimensions"] == 512 - litellm.drop_params = True - model_supported = litellm.utils.get_optional_params_embeddings( - model=f"{provider}/text-embedding-3-small", - custom_llm_provider=provider, - dimensions=512, - ) - assert model_supported["dimensions"] == 512 + monkeypatch.setattr(litellm, "drop_params", True) + model_supported = litellm.utils.get_optional_params_embeddings( + model=f"{provider}/text-embedding-3-small", + custom_llm_provider=provider, + dimensions=512, + ) + assert model_supported["dimensions"] == 512 - explicitly_allowed = litellm.utils.get_optional_params_embeddings( - model=f"{provider}/legacy-model", - custom_llm_provider=provider, - dimensions=512, - allowed_openai_params=["dimensions"], - ) - assert explicitly_allowed["dimensions"] == 512 - finally: - litellm.drop_params = previous_drop_params + explicitly_allowed = litellm.utils.get_optional_params_embeddings( + model=f"{provider}/legacy-model", + custom_llm_provider=provider, + dimensions=512, + allowed_openai_params=["dimensions"], + ) + assert explicitly_allowed["dimensions"] == 512 @pytest.mark.parametrize(