mirror of
https://github.com/BerriAI/litellm.git
synced 2026-11-13 08:52:02 +00:00
fix(tests): exempt mock-echo assertions from TQ002 in #44504 otel tests
Both new regression tests for #44504 assert on the OpenTelemetry tracer mock, which the repository's test-quality TQ002 rule flags as mock-echo. The observable behavior under test is precisely the absence/presence of a raw span, which can only be observed through the tracer mock, so both carry an explicit test-quality-ok exemption. Signed-off-by: apex-mochen <2756823972@qq.com>
This commit is contained in:
parent
252395eb70
commit
ce23baa0bc
1 changed files with 2 additions and 0 deletions
|
|
@ -7342,6 +7342,7 @@ class TestOpenTelemetryRawSpanRespectsRedaction(unittest.TestCase):
|
|||
|
||||
@patch.dict(os.environ, {"OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT": ""})
|
||||
def test_skips_raw_span_when_redaction_header_set(self):
|
||||
# test-quality-ok: negative-path test; the observable behavior is precisely that no raw span is created, which is only assertable on the tracer mock
|
||||
"""Redaction requested via the per-request header -> raw span is not created."""
|
||||
from litellm.integrations.opentelemetry import OpenTelemetry
|
||||
|
||||
|
|
@ -7362,6 +7363,7 @@ class TestOpenTelemetryRawSpanRespectsRedaction(unittest.TestCase):
|
|||
|
||||
@patch.dict(os.environ, {"OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT": ""})
|
||||
def test_creates_raw_span_when_no_redaction_requested(self):
|
||||
# test-quality-ok: positive-path twin of the test above; asserts the span name and raw-attribute hook via the tracer mock, matching the existing file style
|
||||
"""No redaction requested (empty headers dict) -> raw span is still created."""
|
||||
from litellm.integrations.opentelemetry import RAW_REQUEST_SPAN_NAME, OpenTelemetry
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue