From be649f66a6404d38e33e90a8d11938ec2aefb9f2 Mon Sep 17 00:00:00 2001 From: Mateo Wang <277851410+mateo-berri@users.noreply.github.com> Date: Wed, 28 Oct 2026 20:49:58 -0700 Subject: [PATCH 01/23] feat(azure_ai): reach Foundry agents through the project Responses API (#47717) * test(azure_ai): cover Foundry agents on the project Responses API * feat(azure_ai): reach Foundry agents through the project Responses API * fix(azure_ai): keep system prompts and project-endpoint auth on Foundry agent calls and follow-ups * fix(azure_ai): read AZURE_SCOPE before the Foundry audience default on project endpoints * fix(azure_ai): reject or drop instructions on previous_response_id turns and a caller's other agent for Foundry agents * fix(azure_ai): apply the other-agent rule to agent_reference sent at the top level of a Foundry agent request * fix(azure_ai): match the caller's agent by name and version, and hide the agent's own instructions * fix(azure_ai): keep instructions on plain Foundry models that return a null agent_reference * fix(azure_ai): keep a Foundry agent version requested at the top level when extra_body also names the agent * fix(azure_ai): answer 400 for /responses/compact on a Foundry agent instead of calling the project with the agent name --- litellm/llms/azure_ai/common_utils.py | 9 + .../llms/azure_ai/responses/transformation.py | 263 +++++++- .../public_endpoints/agent_create_fields.json | 4 +- litellm/responses/bridge_check.py | 4 + litellm/types/llms/azure_ai.py | 8 +- litellm/utils.py | 6 + .../test_azure_ai_responses_transformation.py | 570 +++++++++++++++++- 7 files changed, 849 insertions(+), 15 deletions(-) diff --git a/litellm/llms/azure_ai/common_utils.py b/litellm/llms/azure_ai/common_utils.py index 65d73363b30..147bf69e91e 100644 --- a/litellm/llms/azure_ai/common_utils.py +++ b/litellm/llms/azure_ai/common_utils.py @@ -140,6 +140,15 @@ def get_azure_ai_auth_headers( AZURE_MODEL_ROUTER_SELECTED_MODEL_KEY: Final = "azure_model_router_selected_model" +FOUNDRY_CLASSIC_AGENT_ID_PREFIX: Final = "asst_" + + +def is_foundry_project_agent(model: str | None) -> bool: + if model is None or AzureFoundryModelInfo.get_azure_ai_route(model) != "agents": + return False + return not model.split("agents/", 1)[1].startswith(FOUNDRY_CLASSIC_AGENT_ID_PREFIX) + + def azure_ai_supports_native_responses(model: str | None, api_base: str | None) -> bool: resolved_base: Final = AzureFoundryModelInfo.get_api_base(api_base) if resolved_base is not None and not is_azure_openai_v1_host(resolved_base): diff --git a/litellm/llms/azure_ai/responses/transformation.py b/litellm/llms/azure_ai/responses/transformation.py index d23de05e148..da734cf8189 100644 --- a/litellm/llms/azure_ai/responses/transformation.py +++ b/litellm/llms/azure_ai/responses/transformation.py @@ -1,26 +1,64 @@ -from typing import Final +import os +from collections.abc import Collection, Mapping, Sequence +from typing import TYPE_CHECKING, Final, NoReturn import httpx +from pydantic import BaseModel, ConfigDict, TypeAdapter, ValidationError +import litellm +from litellm.exceptions import UnsupportedParamsError from litellm.llms.azure.responses.transformation import AzureOpenAIResponsesAPIConfig from litellm.llms.azure_ai.chat.transformation import AzureAIGPT5Config from litellm.llms.azure_ai.common_utils import ( + AZURE_AI_AGENTS_SCOPE, AzureFoundryModelInfo, api_key_header_for_base, get_azure_ai_auth_headers, ) +from litellm.types.llms.azure_ai import FoundryAgentReference +from litellm.types.llms.openai import ( + ResponseInputParam, + ResponsesAPIOptionalRequestParams, + ResponsesAPIResponse, + ResponsesAPIStreamingResponse, +) from litellm.types.router import GenericLiteLLMParams from litellm.types.utils import LlmProviders +if TYPE_CHECKING: + from litellm.litellm_core_utils.litellm_logging import Logging as LiteLLMLoggingObj + _PROJECT_PATH_PREFIX: Final = ("api", "projects") _RESPONSES_PATH: Final = ("openai", "v1", "responses") +_AGENT_OWNED_PARAMS: Final = frozenset({"temperature", "top_p", "tools", "text", "reasoning"}) +_CALLER_AGENT_KEYS: Final = ("agent", "agent_reference") +_RESPONSE_FIELDS: Final = TypeAdapter(dict[str, object]) + + +def _project_root(base_url: httpx.URL) -> tuple[str, ...]: + segments: Final = tuple(segment for segment in base_url.path.split("/") if segment) + return segments[:3] if segments[:2] == _PROJECT_PATH_PREFIX else () def _responses_url(api_base: str) -> str: base_url: Final = httpx.URL(api_base) - segments: Final = tuple(segment for segment in base_url.path.split("/") if segment) - project_root: Final = segments[:3] if segments[:2] == _PROJECT_PATH_PREFIX else () - return str(base_url.copy_with(path="/" + "/".join((*project_root, *_RESPONSES_PATH)), query=None)) + return str(base_url.copy_with(path="/" + "/".join((*_project_root(base_url), *_RESPONSES_PATH)), query=None)) + + +def _without_agent_instructions(response: ResponsesAPIResponse) -> ResponsesAPIResponse: + if (response.model_extra or {}).get("agent_reference") is None: + return response + return response.model_copy(update={"instructions": None}) + + +def _event_without_agent_instructions(event: Mapping[str, object]) -> Mapping[str, object]: + response: Final = event.get("response") + if not isinstance(response, Mapping): + return event + fields: Final = _RESPONSE_FIELDS.validate_python(response) + if fields.get("agent_reference") is None: + return event + return {**event, "response": {**fields, "instructions": None}} class AzureAIResponsesAPIConfig(AzureOpenAIResponsesAPIConfig): @@ -42,10 +80,19 @@ class AzureAIResponsesAPIConfig(AzureOpenAIResponsesAPIConfig): def validate_environment(self, headers: dict, model: str, litellm_params: GenericLiteLLMParams | None) -> dict: params: Final = litellm_params or GenericLiteLLMParams() + api_base: Final = AzureFoundryModelInfo.get_api_base(params.api_base) + on_project: Final = api_base is not None and bool(_project_root(httpx.URL(api_base))) + auth_params: Final = ( + params.model_copy( + update={"azure_scope": params.azure_scope or os.getenv("AZURE_SCOPE") or AZURE_AI_AGENTS_SCOPE} + ) + if on_project + else params + ) auth_headers: Final = get_azure_ai_auth_headers( api_key=AzureFoundryModelInfo.get_api_key(params.api_key), - litellm_params=params.model_dump(), - api_key_header=api_key_header_for_base(AzureFoundryModelInfo.get_api_base(params.api_base)), + litellm_params=auth_params.model_dump(), + api_key_header="Authorization" if on_project else api_key_header_for_base(api_base), ) return { **headers, @@ -64,3 +111,207 @@ class AzureAIResponsesAPIConfig(AzureOpenAIResponsesAPIConfig): "Set the api_base parameter or the AZURE_AI_API_BASE environment variable." ) return _responses_url(resolved_base) + + def transform_response_api_response( + self, model: str, raw_response: httpx.Response, logging_obj: "LiteLLMLoggingObj" + ) -> ResponsesAPIResponse: + return _without_agent_instructions(super().transform_response_api_response(model, raw_response, logging_obj)) + + def transform_streaming_response( + self, + model: str, + parsed_chunk: Mapping[str, object], + logging_obj: "LiteLLMLoggingObj", + ) -> ResponsesAPIStreamingResponse: + return super().transform_streaming_response( # pyright: ignore[reportUnknownMemberType] # parent types parsed_chunk as a bare dict + model=model, parsed_chunk=dict(_event_without_agent_instructions(parsed_chunk)), logging_obj=logging_obj + ) + + def transform_get_response_api_response( + self, raw_response: httpx.Response, logging_obj: "LiteLLMLoggingObj" + ) -> ResponsesAPIResponse: + return _without_agent_instructions(super().transform_get_response_api_response(raw_response, logging_obj)) + + def transform_cancel_response_api_response( + self, raw_response: httpx.Response, logging_obj: "LiteLLMLoggingObj" + ) -> ResponsesAPIResponse: + return _without_agent_instructions(super().transform_cancel_response_api_response(raw_response, logging_obj)) + + +def _agent_reference(model: str) -> FoundryAgentReference: + name, _, version = model.split("agents/", 1)[1].partition(":") + if version: + return FoundryAgentReference(type="agent_reference", name=name, version=version) + return FoundryAgentReference(type="agent_reference", name=name) + + +class _CallerAgentReference(BaseModel): + model_config = ConfigDict(frozen=True, coerce_numbers_to_str=True) + + name: str + version: str | None = None + + +def _caller_agent_reference(value: object) -> _CallerAgentReference | None: + try: + return _CallerAgentReference.model_validate(value) + except ValidationError: + return None + + +def _requested_agent( + deployment_agent: FoundryAgentReference, caller_agents: Sequence[_CallerAgentReference | None] +) -> FoundryAgentReference: + requested_versions: Final = frozenset( + agent.version + for agent in caller_agents + if agent is not None and agent.name == deployment_agent["name"] and agent.version is not None + ) + if "version" in deployment_agent or len(requested_versions) != 1: + return deployment_agent + return FoundryAgentReference( + type="agent_reference", name=deployment_agent["name"], version=next(iter(requested_versions)) + ) + + +def _caller_agent_fields(fields: Mapping[str, object]) -> tuple[tuple[str, object], ...]: + return tuple((key, fields[key]) for key in _CALLER_AGENT_KEYS if key in fields) + + +def _deployment_agent( + model: str, caller_fields: Sequence[tuple[str, object]], litellm_params: GenericLiteLLMParams +) -> FoundryAgentReference: + caller_keys: Final = tuple(key for key, _ in caller_fields) + caller_agents: Final = tuple(_caller_agent_reference(value) for _, value in caller_fields) + agent: Final = _requested_agent(_agent_reference(model), caller_agents) + other_agents: Final = tuple( + key + for key, caller_agent in zip(caller_keys, caller_agents) + if caller_agent is None + or caller_agent.name != agent["name"] + or caller_agent.version not in (None, agent.get("version")) + ) + if other_agents and not (litellm.drop_params is True or litellm_params.drop_params is True): + raise UnsupportedParamsError( + message=( + f"This model entry always calls Foundry agent {agent['name']!r}, so `{other_agents[0]}` " + "in the request cannot pick another agent or version. Remove it, call the model entry for that " + "agent, or set `drop_params: true` to drop it" + ), + llm_provider=LlmProviders.AZURE_AI.value, + model=model, + ) + return agent + + +_INPUT_ITEMS: Final = TypeAdapter(list[object]) + + +def _with_system_prompt(instructions: str, request_input: object) -> Sequence[object]: + conversation: Final = ( + [{"type": "message", "role": "user", "content": request_input}] + if isinstance(request_input, str) + else _INPUT_ITEMS.validate_python(request_input) + ) + return [{"type": "message", "role": "system", "content": instructions}, *conversation] + + +class AzureAIAgentResponsesAPIConfig(AzureAIResponsesAPIConfig): + def should_fake_stream( + self, model: str | None, stream: bool | None, custom_llm_provider: str | None = None + ) -> bool: + return False + + def get_supported_openai_params(self, model: str) -> list[str]: # mutable-ok: override contract + inherited: Final[list[str]] = super().get_supported_openai_params(model) # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType] # parent returns a bare list # mutable-ok: same + return [param for param in inherited if param not in _AGENT_OWNED_PARAMS] + + def map_openai_params_for_deployment( + self, + response_api_optional_params: ResponsesAPIOptionalRequestParams, + model: str, + drop_params: bool, + *, + declared_reasoning_efforts: Collection[str], + ) -> Mapping[str, object]: + mapped: Final = super().map_openai_params_for_deployment( + response_api_optional_params, model, drop_params, declared_reasoning_efforts=declared_reasoning_efforts + ) + resends_instructions: Final = bool(mapped.get("instructions")) and bool(mapped.get("previous_response_id")) + if resends_instructions and not drop_params: + raise UnsupportedParamsError( + message=( + "azure_ai Foundry agents store a turn's system message with the conversation, so `instructions` " + "with `previous_response_id` would add another copy each turn. Send `instructions` on the first " + "turn only, or set `drop_params: true` to drop it" + ), + llm_provider=LlmProviders.AZURE_AI.value, + model=model, + ) + dropped: Final = _AGENT_OWNED_PARAMS | ( + frozenset({"instructions"}) if resends_instructions else frozenset[str]() + ) + return {key: value for key, value in mapped.items() if key not in dropped} + + def transform_responses_api_request( + self, + model: str, + input: str | ResponseInputParam, + response_api_optional_request_params: dict[str, object], # mutable-ok: signature fixed by the override contract + litellm_params: GenericLiteLLMParams, + headers: dict[str, str], # mutable-ok: same + ) -> dict[str, object]: # mutable-ok: same + request: Final[dict[str, object]] = super().transform_responses_api_request( # pyright: ignore[reportUnknownMemberType, reportUnknownVariableType] # parent returns a bare dict # mutable-ok: same + model=model, + input=input, + response_api_optional_request_params=response_api_optional_request_params, + litellm_params=litellm_params, + headers=headers, + ) + instructions: Final = request.get("instructions") + return { + **{key: value for key, value in request.items() if key not in ("model", "instructions")}, + **( + {"input": _with_system_prompt(instructions, request.get("input"))} + if isinstance(instructions, str) and instructions + else {} + ), + "agent_reference": _deployment_agent( + model, _caller_agent_fields(litellm_params.model_extra or {}), litellm_params + ), + } + + def transform_extra_body( + self, + extra_body: Mapping[str, object], + request: Mapping[str, object], + model: str, + litellm_params: GenericLiteLLMParams, + ) -> Mapping[str, object]: + passthrough: Final = {key: value for key, value in extra_body.items() if key not in _CALLER_AGENT_KEYS} + if len(passthrough) == len(extra_body): + return passthrough + return { + **passthrough, + "agent_reference": _deployment_agent( + model, (*_caller_agent_fields(request), *_caller_agent_fields(extra_body)), litellm_params + ), + } + + def transform_compact_response_api_request( + self, + model: str, + input: str | ResponseInputParam, + response_api_optional_request_params: dict[str, object], # mutable-ok: signature fixed by the override contract + api_base: str, + litellm_params: GenericLiteLLMParams, + headers: dict[str, str], # mutable-ok: same + ) -> NoReturn: + raise UnsupportedParamsError( + message=( + "azure_ai Foundry agents cannot be compacted, because the project's /responses/compact endpoint " + "takes a model deployment, not an agent. Call compact on a model entry for that deployment instead" + ), + llm_provider=LlmProviders.AZURE_AI.value, + model=model, + ) diff --git a/litellm/proxy/public_endpoints/agent_create_fields.json b/litellm/proxy/public_endpoints/agent_create_fields.json index f289a6c1805..53b32d249c7 100644 --- a/litellm/proxy/public_endpoints/agent_create_fields.json +++ b/litellm/proxy/public_endpoints/agent_create_fields.json @@ -127,8 +127,8 @@ { "key": "agent_id", "label": "Agent ID", - "placeholder": "asst_abc123", - "tooltip": "The agent/assistant ID from your Azure AI Foundry project (e.g., asst_abc123)", + "placeholder": "my-agent", + "tooltip": "The agent name from your Azure AI Foundry project, optionally with a version (e.g., my-agent or my-agent:2), or a classic assistant ID (e.g., asst_abc123)", "required": true, "field_type": "text", "default_value": null, diff --git a/litellm/responses/bridge_check.py b/litellm/responses/bridge_check.py index 504150b330c..826de8cfdc9 100644 --- a/litellm/responses/bridge_check.py +++ b/litellm/responses/bridge_check.py @@ -9,6 +9,7 @@ from litellm.llms.azure_ai.chat.transformation import AzureAIGPT5Config from litellm.llms.azure_ai.common_utils import ( azure_ai_supports_native_responses, foundry_chat_rejects_function_tools_while_reasoning, + is_foundry_project_agent, ) from litellm.llms.openai.chat.gpt_reasoning_transformation import OpenAIGPT5Config from litellm.secret_managers.main import get_secret_str @@ -181,6 +182,9 @@ def responses_api_bridge_check( elif pinned_mode == "chat" and backend_serves_chat_completions(model_info): model_info["mode"] = "chat" + if custom_llm_provider == LlmProviders.AZURE_AI.value and is_foundry_project_agent(model): + model_info["mode"] = "responses" + if web_search_options is not None and custom_llm_provider == "xai": model_info["mode"] = "responses" model = model.replace("responses/", "") diff --git a/litellm/types/llms/azure_ai.py b/litellm/types/llms/azure_ai.py index 722bc53f429..419e6c0cec5 100644 --- a/litellm/types/llms/azure_ai.py +++ b/litellm/types/llms/azure_ai.py @@ -1,6 +1,6 @@ from typing import Literal -from typing_extensions import Required, TypedDict +from typing_extensions import NotRequired, ReadOnly, Required, TypedDict class ImageEmbeddingInput(TypedDict, total=False): @@ -15,3 +15,9 @@ class ImageEmbeddingRequest(TypedDict, total=False): input: Required[list[ImageEmbeddingInput]] dimensions: int encoding_format: EncodingFormat + + +class FoundryAgentReference(TypedDict): + type: ReadOnly[Literal["agent_reference"]] + name: ReadOnly[str] + version: ReadOnly[NotRequired[str]] diff --git a/litellm/utils.py b/litellm/utils.py index 63fa848d453..72c37c3760e 100644 --- a/litellm/utils.py +++ b/litellm/utils.py @@ -9948,8 +9948,14 @@ class ProviderConfigManager: elif litellm.LlmProviders.AZURE_AI == provider: from litellm.llms.azure_ai.common_utils import ( azure_ai_supports_native_responses, + is_foundry_project_agent, + ) + from litellm.llms.azure_ai.responses.transformation import ( + AzureAIAgentResponsesAPIConfig, ) + if is_foundry_project_agent(model): + return AzureAIAgentResponsesAPIConfig() if azure_ai_supports_native_responses(model, api_base): return litellm.AzureAIResponsesAPIConfig() return None diff --git a/tests/unit/llms/azure_ai/responses/test_azure_ai_responses_transformation.py b/tests/unit/llms/azure_ai/responses/test_azure_ai_responses_transformation.py index 26076f8bb34..b750972fe68 100644 --- a/tests/unit/llms/azure_ai/responses/test_azure_ai_responses_transformation.py +++ b/tests/unit/llms/azure_ai/responses/test_azure_ai_responses_transformation.py @@ -1,5 +1,6 @@ import json from typing import Final +from unittest.mock import patch import httpx import pytest @@ -7,6 +8,7 @@ import respx import litellm from litellm.llms.azure.responses.transformation import AzureOpenAIResponsesAPIConfig +from litellm.llms.azure_ai.common_utils import AZURE_AI_AGENTS_SCOPE from litellm.llms.azure_ai.responses.transformation import AzureAIResponsesAPIConfig from litellm.responses.main import _will_bridge_to_chat_completions from litellm.types.llms.openai import ResponsesAPIOptionalRequestParams @@ -103,7 +105,7 @@ def test_other_hosts_keep_chat_bridge(model, api_base): assert config is None -@pytest.mark.parametrize("model", ["claude-3-5-sonnet", "model_router/gpt-5", "agents/my-agent"]) +@pytest.mark.parametrize("model", ["claude-3-5-sonnet", "model_router/gpt-5", "agents/asst_abc123"]) def test_non_openai_surfaces_keep_chat_bridge(model): config = ProviderConfigManager.get_provider_responses_api_config( provider="azure_ai", model=model, api_base=FOUNDRY_PROJECT_BASE @@ -161,19 +163,26 @@ def test_native_websocket_stays_off(): assert AzureAIResponsesAPIConfig().supports_native_websocket() is False -def test_validate_environment_sends_api_key_header(): +@pytest.mark.parametrize( + "api_base,expected_auth", + [ + ("https://res.services.ai.azure.com", {"api-key": "secret"}), + (FOUNDRY_PROJECT_BASE, {"Authorization": "Bearer secret"}), + ], +) +def test_validate_environment_sends_the_api_key_the_way_the_endpoint_takes_it(api_base, expected_auth): headers = AzureAIResponsesAPIConfig().validate_environment( headers={"x-custom": "1"}, model="gpt-5.6-luna", - litellm_params=GenericLiteLLMParams(api_key="secret", api_base=FOUNDRY_PROJECT_BASE), + litellm_params=GenericLiteLLMParams(api_key="secret", api_base=api_base), ) - assert headers == {"x-custom": "1", "api-key": "secret", "Content-Type": "application/json"} + assert headers == {"x-custom": "1", **expected_auth, "Content-Type": "application/json"} def test_validate_environment_reads_api_key_from_env(monkeypatch): monkeypatch.setenv("AZURE_AI_API_KEY", "env-secret") headers = AzureAIResponsesAPIConfig().validate_environment( - headers={}, model="gpt-5.6-luna", litellm_params=GenericLiteLLMParams(api_base=FOUNDRY_PROJECT_BASE) + headers={}, model="gpt-5.6-luna", litellm_params=GenericLiteLLMParams(api_base="https://res.services.ai.azure.com") ) assert headers["api-key"] == "env-secret" @@ -228,7 +237,10 @@ def _assert_native_responses_request(route, expected_url, expected_model): request = route.calls.last.request body = json.loads(request.content) assert f"{request.url.scheme}://{request.url.host}{request.url.path}" == expected_url - assert request.headers["api-key"] == "fake-key" + on_project: Final = expected_url == FOUNDRY_RESPONSES_URL + assert request.headers.get("authorization" if on_project else "api-key") == ( + "Bearer fake-key" if on_project else "fake-key" + ) assert body["model"] == expected_model assert body["input"] == "What is the weather in SF?" assert "messages" not in body @@ -383,3 +395,549 @@ def test_foundry_responses_none_unlocks_temperature_off_the_azure_ai_row( assert params["temperature"] == 0.2 assert params["reasoning"] == {"effort": "none"} + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "model,expected_reference", + [ + ("azure_ai/agents/support-agent", {"type": "agent_reference", "name": "support-agent"}), + ("azure_ai/agents/support-agent:3", {"type": "agent_reference", "name": "support-agent", "version": "3"}), + ], +) +async def test_aresponses_sends_agent_reference_instead_of_model(model, expected_reference): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await litellm.aresponses( + model=model, input="What is 2+2?", max_output_tokens=50, api_base=FOUNDRY_PROJECT_BASE, api_key="fake-key" + ) + + request = route.calls.last.request + body = json.loads(request.content) + assert f"{request.url.scheme}://{request.url.host}{request.url.path}" == FOUNDRY_RESPONSES_URL + assert body["agent_reference"] == expected_reference + assert "model" not in body + assert body["input"] == "What is 2+2?" + assert body["max_output_tokens"] == 50 + + +def _support_agent_router(model: str = "azure_ai/agents/support-agent") -> litellm.Router: + return litellm.Router( + model_list=[ + { + "model_name": "support-agent", + "litellm_params": { + "model": model, + "api_base": FOUNDRY_PROJECT_BASE, + "api_key": "fake-key", + }, + } + ], + num_retries=0, + ) + + +OTHER_AGENT_EXTRA_BODIES = [ + {"agent_reference": {"type": "agent_reference", "name": "billing-agent", "version": "3"}}, + {"agent": {"type": "agent_reference", "name": "billing-agent"}}, + {"agent_reference": "support-agent"}, + {"agent": {"name": "support-agent", "version": "3"}, "agent_reference": {"name": "support-agent", "version": "4"}}, +] + + +CALLER_PLACEMENTS = [ + pytest.param(lambda fields: {"extra_body": {**fields, "store": False}}, id="extra_body"), + pytest.param(lambda fields: {**fields, "extra_body": {"store": False}}, id="openai_sdk_extra_body_top_level"), +] + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("placement", CALLER_PLACEMENTS) +@pytest.mark.parametrize("caller_fields", OTHER_AGENT_EXTRA_BODIES) +async def test_router_aresponses_rejects_another_agent_without_drop_params(caller_fields, placement): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$") + + with pytest.raises(litellm.UnsupportedParamsError, match="support-agent"): + await _support_agent_router().aresponses(model="support-agent", input="What is 2+2?", **placement(caller_fields)) + + assert not route.called + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("placement", CALLER_PLACEMENTS) +@pytest.mark.parametrize( + "caller_fields,drop_params", + [ + *((caller_fields, True) for caller_fields in OTHER_AGENT_EXTRA_BODIES), + ({"agent": {"type": "agent_reference", "name": "support-agent"}}, None), + ({"agent_reference": {"type": "agent_reference", "name": "support-agent"}}, None), + ({"agent_reference": {"name": "support-agent"}}, None), + ], +) +async def test_router_aresponses_sends_only_the_deployment_agent(caller_fields, drop_params, placement): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await _support_agent_router().aresponses( + model="support-agent", input="What is 2+2?", drop_params=drop_params, **placement(caller_fields) + ) + + body = json.loads(route.calls.last.request.content) + assert body["agent_reference"] == {"type": "agent_reference", "name": "support-agent"} + assert "agent" not in body + assert body["store"] is False + assert "model" not in body + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("placement", CALLER_PLACEMENTS) +@pytest.mark.parametrize( + "entry_model,caller_fields,drop_params,expected_version", + [ + ("azure_ai/agents/support-agent", {"agent_reference": {"type": "agent_reference", "name": "support-agent", "version": "3"}}, None, "3"), + ("azure_ai/agents/support-agent", {"agent": {"name": "support-agent", "version": 3}}, None, "3"), + ("azure_ai/agents/support-agent:2", {"agent_reference": {"name": "support-agent"}}, None, "2"), + ("azure_ai/agents/support-agent:2", {"agent_reference": {"name": "support-agent", "version": 2}}, None, "2"), + ("azure_ai/agents/support-agent:2", {"agent_reference": {"name": "support-agent", "version": "3"}}, True, "2"), + ], +) +async def test_router_aresponses_sends_the_version_of_the_deployment_agent_the_entry_allows( + entry_model, caller_fields, drop_params, expected_version, placement +): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await _support_agent_router(entry_model).aresponses( + model="support-agent", input="What is 2+2?", drop_params=drop_params, **placement(caller_fields) + ) + + body = json.loads(route.calls.last.request.content) + assert body["agent_reference"] == {"type": "agent_reference", "name": "support-agent", "version": expected_version} + assert body["store"] is False + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("placement", CALLER_PLACEMENTS) +async def test_router_aresponses_rejects_another_version_of_a_pinned_agent_without_drop_params(placement): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$") + caller_fields: Final = {"agent_reference": {"type": "agent_reference", "name": "support-agent", "version": "3"}} + + with pytest.raises(litellm.UnsupportedParamsError, match="drop_params"): + await _support_agent_router("azure_ai/agents/support-agent:2").aresponses( + model="support-agent", input="What is 2+2?", **placement(caller_fields) + ) + + assert not route.called + + +VERSION_THREE: Final = {"name": "support-agent", "version": "3"} +NAME_ONLY: Final = {"name": "support-agent"} + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "top_level,in_extra_body", + [ + ({"agent_reference": VERSION_THREE}, {"agent_reference": NAME_ONLY}), + ({"agent": VERSION_THREE}, {"agent_reference": NAME_ONLY}), + ({"agent_reference": NAME_ONLY}, {"agent_reference": VERSION_THREE}), + ], +) +async def test_router_aresponses_keeps_a_version_requested_at_the_top_level_or_in_extra_body(top_level, in_extra_body): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await _support_agent_router().aresponses( + model="support-agent", input="What is 2+2?", **top_level, extra_body={**in_extra_body, "store": False} + ) + + body = json.loads(route.calls.last.request.content) + assert body["agent_reference"] == {"type": "agent_reference", **VERSION_THREE} + assert body["store"] is False + + +@pytest.mark.asyncio +@respx.mock +async def test_router_aresponses_rejects_different_versions_at_the_top_level_and_in_extra_body(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$") + + with pytest.raises(litellm.UnsupportedParamsError, match="drop_params"): + await _support_agent_router().aresponses( + model="support-agent", + input="What is 2+2?", + agent_reference=VERSION_THREE, + extra_body={"agent_reference": {"name": "support-agent", "version": "4"}}, + ) + + assert not route.called + + +AGENT_OWNED_PARAMS = { + "temperature": 0.2, + "top_p": 0.5, + "tools": [WEATHER_TOOL], + "text": {"format": {"type": "text"}}, + "reasoning": {"effort": "high"}, +} + + +@pytest.mark.asyncio +@respx.mock +async def test_aresponses_drops_agent_owned_params_under_drop_params(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input="What is 2+2?", + tool_choice="auto", + drop_params=True, + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + **AGENT_OWNED_PARAMS, + ) + + body = json.loads(route.calls.last.request.content) + assert body.keys().isdisjoint(AGENT_OWNED_PARAMS) + assert body["tool_choice"] == "auto" + + +@pytest.mark.asyncio +@respx.mock +async def test_aresponses_reaches_the_agent_when_the_deployment_declares_reasoning_efforts(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input="What is 2+2?", + max_output_tokens=50, + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + model_info={"reasoning_effort_levels": ["low", "medium", "high"]}, + ) + + body = json.loads(route.calls.last.request.content) + assert body["agent_reference"] == {"type": "agent_reference", "name": "support-agent"} + assert body["max_output_tokens"] == 50 + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("param", sorted(AGENT_OWNED_PARAMS)) +async def test_aresponses_rejects_agent_owned_params_without_drop_params(param): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$") + + with pytest.raises(litellm.UnsupportedParamsError, match=param): + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input="What is 2+2?", + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + **{param: AGENT_OWNED_PARAMS[param]}, + ) + + assert not route.called + + +SYSTEM_PROMPT = {"type": "message", "role": "system", "content": "Answer in French"} + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "request_input,expected_input", + [ + ("What is 2+2?", [SYSTEM_PROMPT, {"type": "message", "role": "user", "content": "What is 2+2?"}]), + ( + [{"type": "message", "role": "user", "content": "What is 2+2?"}], + [SYSTEM_PROMPT, {"type": "message", "role": "user", "content": "What is 2+2?"}], + ), + ], +) +async def test_aresponses_sends_instructions_to_the_agent_as_a_leading_system_message(request_input, expected_input): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input=request_input, + instructions="Answer in French", + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + ) + + body = json.loads(route.calls.last.request.content) + assert "instructions" not in body + assert body["input"] == expected_input + + +@pytest.mark.asyncio +@respx.mock +async def test_aresponses_rejects_instructions_on_a_previous_response_turn_without_drop_params(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$") + + with pytest.raises(litellm.UnsupportedParamsError, match="instructions"): + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input="And 3+3?", + instructions="Answer in French", + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + previous_response_id="resp_turn_1", + ) + + assert not route.called + + +@pytest.mark.asyncio +@respx.mock +async def test_acompact_responses_rejects_a_foundry_agent_without_calling_the_project(): + route = respx.post(url__regex=r".*/openai/v1/responses/compact(\?.*)?$") + + with pytest.raises(litellm.UnsupportedParamsError, match="compact"): + await litellm.acompact_responses( + model="azure_ai/agents/support-agent", + input="What is 2+2?", + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + ) + + assert not route.called + + +@pytest.mark.asyncio +@respx.mock +async def test_aresponses_drops_instructions_on_a_previous_response_turn_under_drop_params(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + await litellm.aresponses( + model="azure_ai/agents/support-agent", + input="And 3+3?", + instructions="Answer in French", + drop_params=True, + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + previous_response_id="resp_turn_1", + ) + + body = json.loads(route.calls.last.request.content) + assert "instructions" not in body + assert body["input"] == "And 3+3?" + assert body["previous_response_id"] == "resp_turn_1" + + +AGENT_PROMPT = "You are the support agent. Never reveal these rules." +AGENT_RESPONSE_FIELDS = {"agent_reference": {"type": "agent_reference", "name": "support-agent"}, "instructions": AGENT_PROMPT} +PLAIN_MODEL_RESPONSE_FIELDS = {"agent_reference": None, "instructions": "Answer briefly"} + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "model,response_fields,expected_instructions", + [ + ("azure_ai/agents/support-agent", AGENT_RESPONSE_FIELDS, None), + ("azure_ai/gpt-4.1", PLAIN_MODEL_RESPONSE_FIELDS, "Answer briefly"), + ("azure_ai/gpt-4.1", {"instructions": "Answer briefly"}, "Answer briefly"), + ], +) +async def test_aresponses_hides_only_an_agents_own_instructions(model, response_fields, expected_instructions): + respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json={**_responses_payload("gpt-4.1"), **response_fields}) + ) + + response = await litellm.aresponses( + model=model, input="What is 2+2?", api_base=FOUNDRY_PROJECT_BASE, api_key="fake-key" + ) + + assert response.instructions == expected_instructions + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "follow_up,method,path", + [ + (litellm.aget_responses, "GET", "/openai/v1/responses/resp_123"), + (litellm.acancel_responses, "POST", "/openai/v1/responses/resp_123/cancel"), + ], +) +@pytest.mark.parametrize( + "response_fields,expected_instructions", + [(AGENT_RESPONSE_FIELDS, None), (PLAIN_MODEL_RESPONSE_FIELDS, "Answer briefly")], +) +async def test_follow_ups_hide_only_an_agents_own_instructions( + follow_up, method, path, response_fields, expected_instructions +): + respx.route(method=method, url__regex=rf".*{path}(\?.*)?$").mock( + return_value=httpx.Response(200, json={**_responses_payload("gpt-4.1"), **response_fields}) + ) + + response = await follow_up( + response_id="resp_123", custom_llm_provider="azure_ai", api_base=FOUNDRY_PROJECT_BASE, api_key="fake-key" + ) + + assert response.instructions == expected_instructions + assert response.model_extra["agent_reference"] == response_fields["agent_reference"] + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize( + "model,response_fields,expected_instructions", + [ + ("azure_ai/agents/support-agent", AGENT_RESPONSE_FIELDS, None), + ("azure_ai/gpt-4.1", PLAIN_MODEL_RESPONSE_FIELDS, "Answer briefly"), + ("azure_ai/gpt-4.1", {"instructions": "Answer briefly"}, "Answer briefly"), + ], +) +async def test_aresponses_streams_answers_from_foundry_without_an_agents_own_instructions( + model, response_fields, expected_instructions +): + completed = {**_responses_payload("gpt-4.1"), **response_fields} + stream_body = "".join( + f"event: {event['type']}\ndata: {json.dumps(event)}\n\n" + for event in ( + {"type": "response.created", "response": {**completed, "status": "in_progress"}}, + {"type": "response.output_text.delta", "item_id": "msg_1", "output_index": 0, "content_index": 0, "delta": "4"}, + {"type": "response.completed", "response": completed}, + ) + ) + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, text=stream_body, headers={"content-type": "text/event-stream"}) + ) + + stream = await litellm.aresponses( + model=model, + input="What is 2+2?", + stream=True, + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + ) + events = [event async for event in stream] + + assert json.loads(route.calls.last.request.content)["stream"] is True + assert [event.type for event in events] == ["response.created", "response.output_text.delta", "response.completed"] + assert events[1].delta == "4" + assert [events[0].response.instructions, events[2].response.instructions] == [expected_instructions] * 2 + + +@pytest.mark.asyncio +@respx.mock +@pytest.mark.parametrize("model", ["azure_ai/agents/support-agent", "azure_ai/gpt-4.1"]) +@pytest.mark.parametrize( + "configured_scope,env_scope,expected_scope", + [ + (None, None, AZURE_AI_AGENTS_SCOPE), + ("api://custom-app/.default", None, "api://custom-app/.default"), + (None, "https://ai.azure.us/.default", "https://ai.azure.us/.default"), + ("api://custom-app/.default", "https://ai.azure.us/.default", "api://custom-app/.default"), + ], +) +async def test_aresponses_mints_the_service_principal_token_for_the_project_scope( + monkeypatch, model, configured_scope, env_scope, expected_scope +): + if env_scope is None: + monkeypatch.delenv("AZURE_SCOPE", raising=False) + else: + monkeypatch.setenv("AZURE_SCOPE", env_scope) + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + with patch("litellm.llms.azure.common_utils.get_azure_ad_token_from_entra_id") as mock_entra_id: # test-quality-ok: stubs the Entra token fetch to assert the scope a project entry requests and the bearer it sends; live service principal path proven by the PR's Foundry e2e QA + mock_entra_id.return_value = lambda: "agent-sp-token" + await litellm.aresponses( + model=model, + input="What is 2+2?", + api_base=FOUNDRY_PROJECT_BASE, + tenant_id="tenant", + client_id="client", + client_secret="secret", + azure_scope=configured_scope, + ) + + mock_entra_id.assert_called_once_with( + tenant_id="tenant", client_id="client", client_secret="secret", scope=expected_scope + ) + assert route.calls.last.request.headers["Authorization"] == "Bearer agent-sp-token" + + +@pytest.mark.asyncio +@respx.mock +async def test_aget_responses_mints_the_service_principal_token_for_the_project_scope(): + route = respx.get(url__regex=r".*/api/projects/proj/openai/v1/responses/resp_123(\?.*)?$").mock( + return_value=httpx.Response(200, json=_responses_payload("gpt-4.1")) + ) + + with patch("litellm.llms.azure.common_utils.get_azure_ad_token_from_entra_id") as mock_entra_id: # test-quality-ok: stubs the Entra token fetch to assert the scope a follow-up on a project endpoint requests; live service principal path proven by the PR's Foundry e2e QA + mock_entra_id.return_value = lambda: "project-sp-token" + response = await litellm.aget_responses( + response_id="resp_123", + custom_llm_provider="azure_ai", + model="azure_ai/agents/support-agent", + api_base=FOUNDRY_PROJECT_BASE, + tenant_id="tenant", + client_id="client", + client_secret="secret", + ) + + mock_entra_id.assert_called_once_with( + tenant_id="tenant", client_id="client", client_secret="secret", scope=AZURE_AI_AGENTS_SCOPE + ) + assert route.calls.last.request.headers["Authorization"] == "Bearer project-sp-token" + assert response.status == "completed" + + +def _agent_answer_payload(text: str) -> dict: + return { + **_responses_payload("gpt-4.1"), + "output": [ + { + "type": "message", + "id": "msg_1", + "status": "completed", + "role": "assistant", + "content": [{"type": "output_text", "text": text, "annotations": []}], + } + ], + } + + +@pytest.mark.asyncio +@respx.mock +async def test_acompletion_reaches_the_agent_through_the_project_responses_api(): + route = respx.post(url__regex=r".*/openai/v1/responses(\?.*)?$").mock( + return_value=httpx.Response(200, json=_agent_answer_payload("4")) + ) + + response = await litellm.acompletion( + model="azure_ai/agents/support-agent", + messages=[{"role": "system", "content": "Answer in French"}, {"role": "user", "content": "What is 2+2?"}], + api_base=FOUNDRY_PROJECT_BASE, + api_key="fake-key", + ) + + body = json.loads(route.calls.last.request.content) + assert body["agent_reference"] == {"type": "agent_reference", "name": "support-agent"} + assert "model" not in body + assert "instructions" not in body + assert body["input"][0] == SYSTEM_PROMPT + assert response.choices[0].message.content == "4" From b1b5d16f0be93d424f1b784a9df213901c390c25 Mon Sep 17 00:00:00 2001 From: "devin-ai-integration[bot]" <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:09:04 -0700 Subject: [PATCH 02/23] docs(adrs): add ADRs for the Python SDK and proxy, starting with provider usage extras (#36668) * docs(adr): add architecture decision records, starting with provider usage extras transport Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs(adrs): correct where provider usage extras survive and scope the live proof bar to runtime changes * docs(adrs): say which chat transforms keep unknown usage keys and where a new field is passed * docs(adrs): correct ADR 001's account of the xAI billing PR, date its code facts, and move the billing recipe to CONTRIBUTING.md * docs(adrs): say the stream builder carries Anthropic's inference_geo by name and drops other extras * docs(adrs): cover /v1/messages, the cost_per_token arm, and the Gemini tier side channel in the usage-field ADR and contribution guide * docs(adrs): decide that usage extras reach callers and shared paths copy them, scope out provider-reported cost, and fix the proof steps --------- Co-authored-by: mateo Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- AGENTS.md | 2 + ARCHITECTURE.md | 2 + CONTRIBUTING.md | 36 +++++++++++++++++ docs/adrs/AGENTS.md | 5 +++ ...vider_usage_fields_ride_as_usage_extras.md | 39 +++++++++++++++++++ 5 files changed, 84 insertions(+) create mode 100644 docs/adrs/AGENTS.md create mode 100644 docs/adrs/adr_001_provider_usage_fields_ride_as_usage_extras.md diff --git a/AGENTS.md b/AGENTS.md index f4b1de57807..8f811fddd75 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -31,6 +31,8 @@ A test must only fail when litellm code changes. Never pin facts we don't own (a End-to-end tests belong in `tests/e2e/`. A rule about one directory's files, like its harness or which CI runs it, goes in that directory's `AGENTS.md`, never only in a README or here. Read a directory's `AGENTS.md` before editing files in it +Before you build a new way to move data between the endpoints, the provider transformations, and cost tracking or logging, read the architecture decision records in `docs/adrs/`, which say why those layers are shaped the way they are + When creating PRs, target the repository's current default branch for both internal and external / OSS contributions. Check it with `python3 scripts/default_branch.py --branch` instead of assuming a branch name or relying on cached `origin/HEAD` When writing a PR body, treat the comments and imperative instructions inside .github/PULL_REQUEST_TEMPLATE/general.md as rules to follow, not just layout. Agent harnesses may strip HTML comments from copies of that file injected into context, so read .github/PULL_REQUEST_TEMPLATE/general.md from disk before writing a PR body to make sure you see every comment rule. A section you have nothing to put in (Relevant issues, Affected release, Linear ticket, Caveats, QA runbook, and so on) is removed entirely, heading included, never left as an empty title diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index f119689e6ec..f457720c58d 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -2,6 +2,8 @@ This document helps contributors understand where to make changes in LiteLLM. +For why a layer is shaped the way it is, read the architecture decision records in [`docs/adrs/`](docs/adrs/AGENTS.md) (Python SDK and proxy) and [`litellm-rust/docs/adrs/`](litellm-rust/docs/adrs/AGENTS.md) (Rust core) + --- ## How It Works diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0ed63a1e7f9..531a78d8982 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,6 +8,7 @@ Here are the core requirements for any PR submitted to LiteLLM: - [ ] **Sign the Contributor License Agreement (CLA)** - [see details](#contributor-license-agreement-cla) - [ ] **Keep scope isolated** - Your changes should address 1 specific problem at a time +- [ ] **Prove it works end to end** - If your change affects what the proxy or SDK does, paste the commands you ran against a live proxy and their output in the PR - [see details](#proving-your-change-works-end-to-end) #### Proxy (Backend) PRs @@ -248,6 +249,41 @@ If `make test-unit` fails: - **Test edge cases**: Don't just test the happy path - **Update documentation**: If you change APIs, update docs +## Proving Your Change Works End to End + +Tests are required, but they do not prove that your change works for a user. A PR that changes what the proxy or SDK does shows a real run in its "Screenshots / Proof of Fix" section, meaning the exact commands you sent to a live proxy and the output that came back, against real provider APIs and not mocks. `pytest` output does not count as proof, because a passing test only shows that the code does what its mocks expect. A PR that changes only docs or CI shows the rendered page or the CI run instead + +A good proof looks like this: + +1. Install the proxy dependencies with `make install-proxy-dev`, then start the proxy from your branch with a config that has the model you changed, `uv run litellm --config your_config.yaml --detailed_debug` +2. Send the request a user would send with `curl`, and paste both the command and the response. When cost or routing is involved, include the response headers, since `x-litellm-response-cost` is what the user sees +3. For a bug fix, do this twice, once at the merge base with BerriAI/litellm's main (`git merge-base origin/main HEAD`, with your remote for BerriAI/litellm in place of `origin` in a fork clone) to show the bug and once at your branch's latest commit to show the fix. Name both commit hashes +4. If your change is reachable from more than one endpoint (`/v1/chat/completions`, `/v1/responses`, `/v1/messages`), show each one +5. If the request can stream, show a `"stream": true` run too, because streaming builds usage and cost on a different path. A stream sends its headers before its usage exists, so show the `usage.cost` on the last chunk, which `/v1/chat/completions` sends when the request has `"stream_options": {"include_usage": true}` and other endpoints send with `include_cost_in_streaming_usage: true` under `litellm_settings`, or, when the proxy has a database, the request's row on the Admin UI's Logs page or `GET /spend/logs` +6. For UI changes, add before and after screenshots and name the page +7. If users reach your change through a coding tool such as Claude Code or Codex, drive that tool the way a user does and add before and after screenshots of it, because a `curl` or a headless run alone does not show what the user sees + +```bash +curl -sD - http://localhost:4000/v1/chat/completions \ + -H "Authorization: Bearer $LITELLM_MASTER_KEY" \ + -H "Content-Type: application/json" \ + -d '{"model": "your-model", "messages": [{"role": "user", "content": "hi"}]}' +``` + +When the provider reports its own usage or spend numbers, compare the proxy's numbers against them in the proof + +## Contributing an LLM Provider Integration + +Provider work (a new provider, a new parameter, a new usage or cost field) is the most common kind of contribution, and it is where PRs get reworked most often. Follow these rules + +**Find the existing machinery before you add plumbing.** LiteLLM already has generic paths that move data between the endpoints, the provider transformations, and cost tracking. A second, hand-rolled path for the same data is a common reason a provider PR gets rewritten before merge. [`ARCHITECTURE.md`](ARCHITECTURE.md) shows where the layers live, and the decision records in [`docs/adrs/`](docs/adrs/AGENTS.md) explain why they are shaped that way. For example, [the ADR on provider usage fields](docs/adrs/adr_001_provider_usage_fields_ride_as_usage_extras.md) covers how provider-specific usage fields reach cost tracking. If you cannot find a mechanism for what you need, say so in the PR or ask in [#pr-review on Slack](https://join.slack.com/t/litellmossslack/shared_invite/zt-3o7nkuyfr-p_kbNJj8taRfXGgQI1~YyA) before you build one + +**Bill a new provider usage field from the usage object.** Leave the field on the usage object as an extra and read it in that provider's `cost_calculator.py`. A provider without one gets a new `cost_calculator.py` and an arm for it in `cost_per_token` (`litellm/cost_calculator.py`), which picks the calculator by provider. If the provider's transform builds `Usage` from named fields, as the Anthropic, Gemini, and Bedrock Converse ones do, pass the new field there too. Streamed requests rebuild usage in `ChunkProcessor.calculate_usage` (`litellm/litellm_core_utils/streaming_chunk_builder_utils.py`), which does not copy extras yet the way the Responses-to-chat bridge does (minus a short exclusion list), so until it does, bill the field on streams by naming it there, as Anthropic's `inference_geo` is. A provider that reports its own charge for the request, as OpenRouter does in `usage.cost`, is billed at that charge from `_hidden_params` before any calculator runs, unless the deployment sets its own prices. When the field counts a built-in tool such as web search, add the provider to `get_cost_for_web_search_request` in `litellm/llms/__init__.py`, and add a gate to `litellm/litellm_core_utils/llm_cost_calc/tool_call_cost_tracking.py` only when no existing gate fires. Then show the field's cost in your proof on every endpoint it reaches, streaming included + +**Do not change what a caller sees to make internals easier.** Each endpoint keeps the schema of the API it emulates. A `/v1/responses` caller gets `input_tokens` and a `/v1/chat/completions` caller gets `prompt_tokens`, whatever the provider sent and whatever cost tracking needs. A provider usage field that shows up as an extra key is fine, since it only adds a key, but renaming, removing, or reshaping a key the endpoint defines is not. Reshaping a public response to feed an internal consumer breaks every user of that endpoint + +If your change makes an architecture decision, such as a new cross-cutting mechanism or a deliberate difference from a provider's API shape, add an ADR to [`docs/adrs/`](docs/adrs/AGENTS.md) in the same PR + ## Building and Running Locally ### LiteLLM Proxy Server diff --git a/docs/adrs/AGENTS.md b/docs/adrs/AGENTS.md new file mode 100644 index 00000000000..ba92b1131d8 --- /dev/null +++ b/docs/adrs/AGENTS.md @@ -0,0 +1,5 @@ +# Architecture decision records for the Python SDK and proxy + +This folder records decisions about the Python SDK and proxy the way [`litellm-rust/docs/adrs/`](../../litellm-rust/docs/adrs/AGENTS.md) records them for the Rust core, and that file's process applies here unchanged: one short `adr_NNN_short_title.md` per decision that is hard to reverse or that a new contributor would reasonably question, with Context, Decision, Alternatives Considered, and Consequences, superseded by a new ADR instead of edited once accepted. Each folder numbers its own ADRs, so a reference to an ADR in the other folder names its path + +Read the ADRs here before you build a new way to move data between the endpoints, the provider transformations, and cost tracking or logging. A PR that makes a decision of that kind adds its ADR in the same PR diff --git a/docs/adrs/adr_001_provider_usage_fields_ride_as_usage_extras.md b/docs/adrs/adr_001_provider_usage_fields_ride_as_usage_extras.md new file mode 100644 index 00000000000..8c729c09d0c --- /dev/null +++ b/docs/adrs/adr_001_provider_usage_fields_ride_as_usage_extras.md @@ -0,0 +1,39 @@ +# ADR 001: Provider usage fields ride as extras on the normalized usage object + +Status: Accepted + +## Context + +Providers report usage fields that no other provider has, such as xAI's `usage.server_side_tool_usage_details.web_search_calls` or Anthropic's `usage.inference_geo`, and cost tracking has to read them or that spend never reaches `LiteLLM_SpendLogs`. One provider response can be served on `/v1/chat/completions`, `/v1/responses`, and `/v1/messages`, streaming or not, so a field that only one of those paths carries is billed wrong on the others + +[#30817](https://github.com/BerriAI/litellm/pull/30817) fixed unbilled xAI web searches. One draft did the copy in the xAI Responses transform to keep provider code out of shared files, and that swapped `/v1/responses` usage to the chat shape, so callers of that endpoint lost the Responses schema. The merged version keeps the schema, copies unknown usage fields in the shared Responses-to-chat bridge for every provider, and gates on the reported field without naming the provider + +In October 2026, `Usage` and `ResponseAPIUsage` kept unknown usage keys as pydantic extras, and that bridge copied them. Paths that build usage from named fields kept only the fields they name: the Anthropic, Gemini, and Bedrock Converse transforms, the stream builder, and the bridges from chat usage to `/v1/responses` and `/v1/messages` + +## Decision + +Provider-only usage fields stay on the usage object as pydantic extras, and cost tracking reads them there, in that provider's cost calculator or in a shared gate that checks the field instead of the provider. An extra reaches callers as an added usage key. No transform renames, removes, or reshapes a usage field the endpoint's schema defines to feed cost tracking, though it may fill one LiteLLM's usage object already defines, such as `server_tool_use` + +A shared path that rebuilds usage, such as the stream builder or a bridge between endpoint shapes, copies the extras instead of naming provider fields. A provider transform that builds usage from named fields names the new field. Neither is bypassed with a side channel. Older code that differs, such as the Azure branches in the shared tracker and the Gemini pricing tier read from `_hidden_params`, predates this ADR + +## Alternatives Considered + +**Reshape usage in the provider transform**, as a draft of #30817 did. It changes the schema that callers of that endpoint rely on, and every provider and endpoint needs its own copy + +**A typed field on `ResponseAPIUsage` and `Usage` for each provider's quirk**. The types grow without bound and every bridge needs an update for each one. A field several providers report, like `server_tool_use`, does get one + +**A side channel such as `_hidden_params`**. Cost calculators receive `Usage`, so a side channel makes a second source of truth for the same number + +**Provider branches or provider field names in shared code**. They put one provider's logic in a file every provider shares, which is why #30817 replaced its xAI-only gate with one that checks the reported field + +## Consequences + +Benefits: + +- Billing a new provider usage field touches that provider's calculator (plus a `cost_per_token` arm when the calculator is new), its transform when that names fields, and for a built-in tool at most one gate and one `get_cost_for_web_search_request` arm + +Costs: + +- Extras are untyped, so a reader validates them before use, as `_usage_reports_server_side_web_search_calls` does +- The stream builder and the bridges from chat usage did not copy extras when this was written, so until they do, a field billed on those paths is named in them, and tests and proof runs cover each endpoint and `"stream": true` +- This covers usage fields LiteLLM prices, not request-side params or a provider's own charge for the request, which OpenRouter and opencode Go report and `response_cost_calculator` reads from `_hidden_params` first From dbaae521f92739aff798ba239604bcc4af8e7ff9 Mon Sep 17 00:00:00 2001 From: tessellark <349031000+tessellark@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:11:49 -0700 Subject: [PATCH 03/23] fix(responses): drop the null created_by OpenAI rejects when output items are replayed (#48783) * fix(responses): drop the null created_by OpenAI rejects when output items are replayed * fix(responses): drop a null created_by from replayed input items too A conversation saved from an older proxy still carries created_by: null on its compaction, apply_patch and shell items, so OpenAI keeps rejecting the replay. Drop the null from input items on the HTTP request transform and the WebSocket response.create rewrite, keeping a created_by that is not null. * fix(responses): drop a null created_by from counted input items too * test(responses): cover saved reasoning nulls and re-compaction of a saved conversation * fix(responses): drop a set created_by from input under drop_params * fix(types): type the Responses output serializer's parameters * fix(responses): drop a set created_by on reasoning items and Perplexity presets under drop_params --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- .../llms/azure/responses/transformation.py | 6 +- .../responses/count_tokens/transformation.py | 13 ++- .../llms/openai/responses/transformation.py | 36 +++--- .../perplexity/responses/transformation.py | 4 +- litellm/responses/streaming_iterator.py | 9 +- litellm/types/llms/openai.py | 106 ++++++++++++------ .../providers/test_responses_compact_wire.py | 41 ++++--- ...test_openai_count_tokens_transformation.py | 55 +++++++++ .../test_openai_responses_transformation.py | 88 +++++++++++++++ ...est_perplexity_responses_transformation.py | 14 +++ .../test_responses_websocket_all_providers.py | 42 +++++++ .../unit/types/llms/test_types_llms_openai.py | 78 +++++++++++++ 12 files changed, 416 insertions(+), 76 deletions(-) diff --git a/litellm/llms/azure/responses/transformation.py b/litellm/llms/azure/responses/transformation.py index cdeeef1d96c..eb6d103efb9 100644 --- a/litellm/llms/azure/responses/transformation.py +++ b/litellm/llms/azure/responses/transformation.py @@ -142,7 +142,9 @@ class AzureOpenAIResponsesAPIConfig(OpenAIResponsesAPIConfig): return filtered_item return item - def _validate_input_param(self, input: str | ResponseInputParam) -> str | ResponseInputParam: + def _validate_input_param( + self, input: str | ResponseInputParam, *, drops_set_created_by: bool = False + ) -> str | ResponseInputParam: """ Override parent method to also filter out 'status' field from message items. Azure OpenAI API does not accept 'status' field in input messages. @@ -150,7 +152,7 @@ class AzureOpenAIResponsesAPIConfig(OpenAIResponsesAPIConfig): from typing import cast # First call parent's validation - validated_input: Final = super()._validate_input_param(input) + validated_input: Final = super()._validate_input_param(input, drops_set_created_by=drops_set_created_by) # Then filter out status from message items if isinstance(validated_input, list): diff --git a/litellm/llms/openai/responses/count_tokens/transformation.py b/litellm/llms/openai/responses/count_tokens/transformation.py index b4e152ff406..a45a0448326 100644 --- a/litellm/llms/openai/responses/count_tokens/transformation.py +++ b/litellm/llms/openai/responses/count_tokens/transformation.py @@ -22,7 +22,7 @@ from litellm.llms.anthropic.messages.responses_adapters.transformation import ( ) from litellm.responses.utils import ResponsesAPIRequestUtils from litellm.types.llms.anthropic import AnthropicMessagesRequest, AnthropicOutputSchema -from litellm.types.llms.openai import ResponsesAPIRequestParams +from litellm.types.llms.openai import ResponsesAPIRequestParams, replayable_responses_input from litellm.types.utils import all_litellm_params @@ -387,10 +387,13 @@ def _forwards(field: str, policy: DropPolicy) -> bool: return field in _COUNT_REQUEST_FIELDS or (not policy.drop_params and field in _INFERENCE_REQUEST_FIELDS) -def _restored(field: str, value: object) -> object: +def _restored(field: str, value: object, policy: DropPolicy) -> object: match field, value: case "input", _: - return ResponsesAPIRequestUtils.restore_encrypted_content_item_ids_in_input(copy.deepcopy(value)) + return replayable_responses_input( + ResponsesAPIRequestUtils.restore_encrypted_content_item_ids_in_input(copy.deepcopy(value)), + drops_set_created_by=policy.drop_params, + ) case "previous_response_id", str(): return ResponsesAPIRequestUtils.decode_previous_response_id_to_original_previous_response_id(value) case _: @@ -398,5 +401,7 @@ def _restored(field: str, value: object) -> object: def native_count_request(request: Mapping[str, object], model: str, policy: DropPolicy) -> Mapping[str, object]: - forwarded: Final = {field: _restored(field, value) for field, value in request.items() if _forwards(field, policy)} + forwarded: Final = { + field: _restored(field, value, policy) for field, value in request.items() if _forwards(field, policy) + } return {**forwarded, "model": model} diff --git a/litellm/llms/openai/responses/transformation.py b/litellm/llms/openai/responses/transformation.py index 033326e653f..64b2e61130d 100644 --- a/litellm/llms/openai/responses/transformation.py +++ b/litellm/llms/openai/responses/transformation.py @@ -108,7 +108,7 @@ class _DropParamsSetting(BaseModel): drop_params: object = None -def _drops_params(litellm_params: GenericLiteLLMParams) -> bool: +def drops_params(litellm_params: GenericLiteLLMParams) -> bool: setting: Final = _DropParamsSetting.model_validate(litellm_params) return litellm.drop_params is True or normalize_drop_params(setting.drop_params) is True @@ -541,7 +541,9 @@ class OpenAIResponsesAPIConfig(BaseResponsesAPIConfig): litellm_params: GenericLiteLLMParams, prompt_cache_options: object = None, ) -> tuple[str | ResponseInputParam, Sequence[ALL_RESPONSES_API_TOOL_PARAMS] | None]: - validated_input: Final = self._validate_input_param(self._drop_bridge_minted_reasoning_items(input)) + validated_input: Final = self._validate_input_param( + self._drop_bridge_minted_reasoning_items(input), drops_set_created_by=drops_params(litellm_params) + ) marked_input: Final = ( self._input_with_prompt_cache_breakpoints(validated_input) if self._reads_prompt_cache_breakpoints( @@ -582,7 +584,7 @@ class OpenAIResponsesAPIConfig(BaseResponsesAPIConfig): if tools is None or not any(is_anthropic_tool_search_chat_tool(tool) for tool in tools): return tools callers_own_search: Final = any(is_openai_tool_search_tool(tool) for tool in tools) - if callers_own_search or not _drops_params(litellm_params) or _runs_tool_search(model, tools): + if callers_own_search or not drops_params(litellm_params) or _runs_tool_search(model, tools): return tools_with_anthropic_tool_search_mapped(tools) verbose_logger.warning( "Dropping tool search under drop_params: OpenAI model '%s' cannot run it or no tool is deferred, so every " @@ -775,7 +777,9 @@ class OpenAIResponsesAPIConfig(BaseResponsesAPIConfig): ] return tools if all(new is old for new, old in zip(sanitized, tools, strict=True)) else sanitized - def _validate_input_param(self, input: str | ResponseInputParam) -> str | ResponseInputParam: + def _validate_input_param( + self, input: str | ResponseInputParam, *, drops_set_created_by: bool = False + ) -> str | ResponseInputParam: """ Ensure all input fields if pydantic are converted to dict @@ -787,18 +791,20 @@ class OpenAIResponsesAPIConfig(BaseResponsesAPIConfig): for item in input: # if it's pydantic, convert to dict if isinstance(item, BaseModel): - validated_input.append(item.model_dump(exclude_none=True)) + validated_input.append( + replayable_responses_item( + item.model_dump(exclude_none=True), drops_set_created_by=drops_set_created_by + ) + ) elif isinstance(item, dict): - # Handle reasoning items specifically to filter out status=None - if item.get("type") == "reasoning": - verbose_logger.debug("Handling reasoning item: %s", item) - # Type assertion since we know it's a dict at this point - dict_item = cast(dict[str, object], item) - filtered_item = self._handle_reasoning_item(dict_item) - else: - # For other dict items, just pass through - filtered_item = cast(dict[str, object], item) - validated_input.append(filtered_item) + validated_input.append( + replayable_responses_item( + self._handle_reasoning_item(cast(dict[str, object], item)) + if item.get("type") == "reasoning" + else item, + drops_set_created_by=drops_set_created_by, + ) + ) else: validated_input.append(item) return validated_input diff --git a/litellm/llms/perplexity/responses/transformation.py b/litellm/llms/perplexity/responses/transformation.py index 77817a5e5bb..58f71028451 100644 --- a/litellm/llms/perplexity/responses/transformation.py +++ b/litellm/llms/perplexity/responses/transformation.py @@ -17,7 +17,7 @@ from pydantic import TypeAdapter from litellm.litellm_core_utils.litellm_logging import Logging as LiteLLMLoggingObj from litellm.litellm_core_utils.url_utils import join_api_base from litellm.llms.base_llm.chat.transformation import BaseLLMException -from litellm.llms.openai.responses.transformation import OpenAIResponsesAPIConfig +from litellm.llms.openai.responses.transformation import OpenAIResponsesAPIConfig, drops_params from litellm.secret_managers.main import get_secret_str from litellm.types.llms.openai import ResponseInputParam, ResponsesAPIResponse from litellm.types.router import GenericLiteLLMParams @@ -84,7 +84,7 @@ class PerplexityResponsesConfig(OpenAIResponsesAPIConfig): """Handle preset/ model prefix: send as {"preset": name} instead of {"model": name}.""" input = self._ensure_message_type(input) if model.startswith("preset/"): - input = self._validate_input_param(input) + input = self._validate_input_param(input, drops_set_created_by=drops_params(litellm_params)) data: Final[dict] = { "preset": model[len("preset/") :], "input": input, diff --git a/litellm/responses/streaming_iterator.py b/litellm/responses/streaming_iterator.py index 5060e03f040..6c57bfd2a3f 100644 --- a/litellm/responses/streaming_iterator.py +++ b/litellm/responses/streaming_iterator.py @@ -71,6 +71,7 @@ from litellm.types.llms.openai import ( ResponsesAPIResponse, ResponsesAPIStreamEvents, ResponsesAPIStreamingResponse, + replayable_responses_input, ) from litellm.types.responses.main import GenericResponseOutputItem, OutputText from litellm.types.utils import CallTypes, ModelResponse @@ -2365,15 +2366,17 @@ def _ws_event_error(event: Mapping[str, object]) -> object: return response.get("error") if _is_json_object(response) else None -def _restore_input_item_ids(items: Sequence[object]) -> Sequence[object]: - return ResponsesAPIRequestUtils.restore_encrypted_content_item_ids_in_input(copy.deepcopy(list(items))) +def _replayable_input_items(items: Sequence[object]) -> object: + return replayable_responses_input( + ResponsesAPIRequestUtils.restore_encrypted_content_item_ids_in_input(copy.deepcopy(list(items))) + ) def _restored_container_fields(container: Mapping[str, object]) -> Mapping[str, object]: input_items: Final = container.get("input") previous_response_id: Final = container.get("previous_response_id") restored: Final = { - "input": _restore_input_item_ids(input_items) if _is_json_array(input_items) else input_items, + "input": _replayable_input_items(input_items) if _is_json_array(input_items) else input_items, "previous_response_id": ( ResponsesAPIRequestUtils.decode_previous_response_id_to_original_previous_response_id(previous_response_id) if isinstance(previous_response_id, str) diff --git a/litellm/types/llms/openai.py b/litellm/types/llms/openai.py index 8e1db87c16f..6ce51abcd8a 100644 --- a/litellm/types/llms/openai.py +++ b/litellm/types/llms/openai.py @@ -1,5 +1,5 @@ import builtins -from collections.abc import Iterable, Mapping +from collections.abc import Iterable, Mapping, Sequence from enum import Enum from os import PathLike from typing import IO, TYPE_CHECKING, Any, Final, Generic, Literal, Optional, TypeAlias, Union @@ -66,6 +66,7 @@ from pydantic import ( ConfigDict, Discriminator, Field, + FieldSerializationInfo, NonNegativeInt, PrivateAttr, SerializerFunctionWrapHandler, @@ -1487,15 +1488,66 @@ One of: completed, failed, in_progress, cancelled, queued, or incomplete. """ -_NULL_DROPPED_OUTPUT_ITEM_KEYS: Final = frozenset( - ( - ("reasoning", "status"), - ("reasoning", "content"), - ("reasoning", "encrypted_content"), - ("tool_search_call", "created_by"), - ("tool_search_output", "created_by"), - ) -) +_NULL_DROPPED_REASONING_ITEM_KEYS: Final = frozenset(("status", "content", "encrypted_content")) + + +def _as_json_object(value: object) -> Mapping[str, object] | None: + return value if isinstance(value, dict) else None + + +def _as_json_array(value: object) -> Sequence[object] | None: + return value if isinstance(value, list) else None + + +def _drops_created_by(value: object, *, drops_set_created_by: bool) -> bool: + return value is None or drops_set_created_by + + +def _drops(item_type: object, key: object, value: object, *, drops_set_created_by: bool) -> bool: + if key == "created_by": + return _drops_created_by(value, drops_set_created_by=drops_set_created_by) + return value is None and item_type == "reasoning" and key in _NULL_DROPPED_REASONING_ITEM_KEYS + + +def _without_created_by(entry: object, *, drops_set_created_by: bool) -> object: + entry_object: Final = _as_json_object(entry) + if entry_object is None: + return entry + return { + k: v + for k, v in entry_object.items() + if k != "created_by" or not _drops_created_by(v, drops_set_created_by=drops_set_created_by) + } + + +def _replayable_output_value(item_type: object, key: object, value: object, *, drops_set_created_by: bool) -> object: + entries: Final = _as_json_array(value) + if item_type != "shell_call_output" or key != "output" or entries is None: + return value + return [_without_created_by(entry, drops_set_created_by=drops_set_created_by) for entry in entries] + + +def replayable_responses_item( + item: Mapping[str, object], *, drops_set_created_by: bool = False +) -> Mapping[str, object]: + item_type: Final = item.get("type") + return { + k: _replayable_output_value(item_type, k, v, drops_set_created_by=drops_set_created_by) + for k, v in item.items() + if not _drops(item_type, k, v, drops_set_created_by=drops_set_created_by) + } + + +def replayable_responses_input(value: object, *, drops_set_created_by: bool = False) -> object: + items: Final = _as_json_array(value) + if items is None: + return value + return [ + replayable_responses_item(obj, drops_set_created_by=drops_set_created_by) + if (obj := _as_json_object(item)) is not None + else item + for item in items + ] class ResponsesAPIResponse(BaseLiteLLMOpenAIResponseObject): @@ -1570,34 +1622,16 @@ class ResponsesAPIResponse(BaseLiteLLMOpenAIResponseObject): @field_serializer("output", mode="wrap") @classmethod - def _serialize_output_filter_reasoning_nulls(cls, value, handler, _info): + def _serialize_output_as_replayable( + cls, value: builtins.object, handler: SerializerFunctionWrapHandler, _info: FieldSerializationInfo + ): """ - Filter null status/content/encrypted_content from reasoning output items. - - Mirrors the request-side filtering in - OpenAIResponsesAPIConfig._handle_reasoning_item() which filters these - same fields before sending requests to providers. - - Without this, reasoning items include null fields that cause SDK errors - (e.g., the OpenAI C# SDK crashes on status=null). - - Issue: https://github.com/BerriAI/litellm/issues/16824 + Drop the nulls the SDK types default in but providers never send: created_by on every output item + (OpenAI rejects it when `output` is replayed as `input`), and status/content/encrypted_content on + reasoning items (the OpenAI C# SDK crashes on status=null, issue #16824). """ - serialized: Final = handler(value) - if not isinstance(serialized, list): - return serialized - return [ - ( - { - k: v - for k, v in item.items() - if v is not None or (item.get("type"), k) not in _NULL_DROPPED_OUTPUT_ITEM_KEYS - } - if isinstance(item, dict) - else item - ) - for item in serialized - ] + serialized: Final[object] = handler(value) + return replayable_responses_input(serialized) @property def output_text(self) -> str: diff --git a/tests/integration/providers/test_responses_compact_wire.py b/tests/integration/providers/test_responses_compact_wire.py index 4da3f411cb5..88fbec27c07 100644 --- a/tests/integration/providers/test_responses_compact_wire.py +++ b/tests/integration/providers/test_responses_compact_wire.py @@ -3,6 +3,7 @@ from __future__ import annotations import json import os import uuid +from types import MappingProxyType from typing import Final import openai @@ -65,6 +66,11 @@ def test_responses_compact_routes_forward_complete_request_and_typed_items(gatew "call_id": "call_previous", "output": "The record is ready.", } + saved_compaction_item: Final = { + "id": f"cmp_{uuid.uuid4().hex}", + "type": "compaction", + "encrypted_content": "synthetic-saved-state", + } requests: Final = ( { "input": "Compact this conversation.", @@ -75,6 +81,20 @@ def test_responses_compact_routes_forward_complete_request_and_typed_items(gatew "tools": [_FUNCTION_TOOL], }, ) + saved_compaction_request: Final = { + "input": [{**saved_compaction_item, "created_by": None}, {**function_output_item, "created_by": None}], + "instructions": "Compact the saved conversation again.", + } + forwarded_bodies: Final = MappingProxyType( + { + None: requests[0], + requests[1]["instructions"]: requests[1], + saved_compaction_request["instructions"]: { + **saved_compaction_request, + "input": [saved_compaction_item, function_output_item], + }, + } + ) output_items: Final = [ { "id": f"rs_compact_{uuid.uuid4().hex}", @@ -98,18 +118,7 @@ def test_responses_compact_routes_forward_complete_request_and_typed_items(gatew assert request.method == "POST" assert request.headers["authorization"] == f"Bearer {_API_KEY}", dict(request.headers) body: Final = _JSON_OBJECT.validate_json(request.body) - compact_params: Final = ( - { - "model": _MODEL, - **requests[0], - } - if body.get("input") == requests[0]["input"] - else { - "model": _MODEL, - **requests[1], - } - ) - assert body == compact_params, request.body + assert body == {"model": _MODEL, **forwarded_bodies[body.get("instructions")]}, request.body return Reply( body=json.dumps( { @@ -128,16 +137,20 @@ def test_responses_compact_routes_forward_complete_request_and_typed_items(gatew ).encode() ) + sent_bodies: Final = (*requests, saved_compaction_request) with wire_server(respond) as wire, gateway.scenario() as scenario: model: Final = _deployment(scenario, wire) for alias in _ALIASES: - for request_body in requests: + for request_body in sent_bodies: response: Final = gateway.request( "POST", alias, {"model": model, **request_body}, ) assert response.status_code == 200, response.text + wire_output: Final = _JSON_OBJECT.validate_json(response.content)["output"] + assert isinstance(wire_output, list), response.text + assert [item for item in wire_output if not isinstance(item, dict) or "created_by" in item] == [] compacted: Final = CompactedResponse.model_validate_json(response.content) assert compacted.id != completed_id, compacted.model_dump_json() assert same_response(compacted.id, completed_id), compacted.model_dump_json() @@ -201,7 +214,7 @@ def test_responses_compact_routes_forward_complete_request_and_typed_items(gatew "user": None, "store": None, }, response.text - assert [request.target for request in drain_contract_requests(wire)] == ["/v1/responses/compact"] * 6 + assert [request.target for request in drain_contract_requests(wire)] == ["/v1/responses/compact"] * (len(_ALIASES) * len(sent_bodies)) @pytest.mark.parametrize("prefix", ("/v1", "", "/openai/v1")) diff --git a/tests/unit/llms/openai/responses/test_openai_count_tokens_transformation.py b/tests/unit/llms/openai/responses/test_openai_count_tokens_transformation.py index d5e7bb4f93b..575183772f9 100644 --- a/tests/unit/llms/openai/responses/test_openai_count_tokens_transformation.py +++ b/tests/unit/llms/openai/responses/test_openai_count_tokens_transformation.py @@ -5,8 +5,10 @@ import pytest from litellm.llms.anthropic.messages.responses_adapters.transformation import ( LiteLLMAnthropicToResponsesAPIAdapter, ) +from litellm.litellm_core_utils.tool_fields import DropPolicy from litellm.llms.openai.responses.count_tokens.transformation import ( OpenAICountTokensConfig, + native_count_request, ) from tests.unit.litellm_core_utils.attribute_forwarder import AttributeForwarder @@ -610,3 +612,56 @@ def test_anthropic_list_system_becomes_joined_instruction_text() -> None: ) assert instructions == "First rule.\nSecond rule." + + +def test_a_saved_conversation_with_a_null_created_by_is_counted_without_it() -> None: + compaction: Final = {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"} + tool_output: Final = {"type": "function_call_output", "call_id": "call_1", "output": "42"} + sent_created_by: Final = { + "type": "function_call_output", + "call_id": "call_2", + "output": "7", + "created_by": "user_1", + } + request: Final = { + "model": "gpt-5.6", + "input": [{**compaction, "created_by": None}, {**tool_output, "created_by": None}, sent_created_by], + } + + policy: Final = DropPolicy(drop_params=False, additional_drop_params=frozenset()) + + body: Final = native_count_request(request, "gpt-5.6", policy) + + assert body["input"] == [compaction, tool_output, sent_created_by] + + + +def test_a_set_created_by_is_counted_without_it_under_drop_params() -> None: + tool_output: Final = {"type": "function_call_output", "call_id": "call_1", "output": "42"} + request: Final = {"model": "gpt-5.6", "input": [{**tool_output, "created_by": "user_1"}]} + policy: Final = DropPolicy(drop_params=True, additional_drop_params=frozenset()) + + body: Final = native_count_request(request, "gpt-5.6", policy) + + assert body["input"] == [tool_output] + + +def test_a_text_input_is_counted_as_sent() -> None: + policy: Final = DropPolicy(drop_params=False, additional_drop_params=frozenset()) + + body: Final = native_count_request({"model": "gpt-5.6", "input": "Hello"}, "gpt-5.6", policy) + + assert body["input"] == "Hello" + + +def test_a_reasoning_item_is_counted_without_its_null_fields() -> None: + reasoning: Final = {"id": "rs_1", "type": "reasoning", "summary": []} + request: Final = { + "model": "gpt-5.6", + "input": [{**reasoning, "status": None, "content": None, "encrypted_content": None}], + } + policy: Final = DropPolicy(drop_params=False, additional_drop_params=frozenset()) + + body: Final = native_count_request(request, "gpt-5.6", policy) + + assert body["input"] == [reasoning] diff --git a/tests/unit/llms/openai/responses/test_openai_responses_transformation.py b/tests/unit/llms/openai/responses/test_openai_responses_transformation.py index 66e23115f3e..48bb0955f34 100644 --- a/tests/unit/llms/openai/responses/test_openai_responses_transformation.py +++ b/tests/unit/llms/openai/responses/test_openai_responses_transformation.py @@ -7,6 +7,7 @@ from unittest.mock import AsyncMock, MagicMock, Mock, patch import httpx import pytest import respx +from openai.types.responses.response_compaction_item import ResponseCompactionItem from pydantic import JsonValue, TypeAdapter import litellm @@ -1376,6 +1377,80 @@ class TestOpenAIResponsesAPIConfig: assert request["input"] == [expected, {"role": "user", "content": "And Berlin?"}] + @pytest.mark.parametrize( + ("item", "expected"), + [ + ( + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": None}, + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"}, + ), + ( + { + "type": "shell_call_output", + "call_id": "call_1", + "created_by": None, + "output": [{"stdout": "a.py", "stderr": "", "created_by": None}], + }, + {"type": "shell_call_output", "call_id": "call_1", "output": [{"stdout": "a.py", "stderr": ""}]}, + ), + ( + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": "user_1"}, + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": "user_1"}, + ), + ], + ids=("compaction", "shell-call-output-entries", "sent-created-by"), + ) + def test_an_input_item_saved_with_a_null_created_by_replays_without_it( + self, item: dict[str, object], expected: dict[str, object] + ): + request: Final = self.config.transform_responses_api_request( + model="gpt-5.6", + input=[item, {"role": "user", "content": "And Berlin?"}], + response_api_optional_request_params={}, + litellm_params=GenericLiteLLMParams(), + headers={}, + ) + + assert request["input"] == [expected, {"role": "user", "content": "And Berlin?"}] + + @pytest.mark.parametrize( + ("item", "expected"), + [ + ( + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": "user_1"}, + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"}, + ), + ( + ResponseCompactionItem(id="cmp_1", type="compaction", encrypted_content="gAAAA", created_by="user_1"), + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"}, + ), + ( + { + "type": "shell_call_output", + "call_id": "call_1", + "created_by": "user_1", + "output": [{"stdout": "a.py", "stderr": "", "created_by": "user_1"}], + }, + {"type": "shell_call_output", "call_id": "call_1", "output": [{"stdout": "a.py", "stderr": ""}]}, + ), + ( + {"id": "rs_1", "type": "reasoning", "summary": [], "created_by": "user_1"}, + {"id": "rs_1", "type": "reasoning", "summary": []}, + ), + ], + ids=("compaction", "sdk-compaction-item", "shell-call-output-entries", "reasoning"), + ) + def test_a_set_created_by_is_dropped_under_drop_params(self, item: object, expected: dict[str, object]): + request: Final = self.config.transform_responses_api_request( + model="gpt-5.6", + input=cast("list[dict[str, object]]", [item]), # cast-ok: an SDK item stands in for its JSON shape + response_api_optional_request_params={}, + litellm_params=GenericLiteLLMParams(drop_params=True), + headers={}, + ) + + assert request["input"] == [expected] + class TestAzureResponsesAPIConfig: def setup_method(self): @@ -1383,6 +1458,19 @@ class TestAzureResponsesAPIConfig: self.model = "gpt-4o" self.logging_obj = MagicMock() + def test_azure_drops_a_set_created_by_under_drop_params(self): + compaction: Final = {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"} + + request: Final = self.config.transform_responses_api_request( + model=self.model, + input=[{**compaction, "created_by": "user_1"}], + response_api_optional_request_params={}, + litellm_params=GenericLiteLLMParams(drop_params=True), + headers={}, + ) + + assert request["input"] == [compaction] + def test_azure_decodes_json_string_tool_parameters(self): """Azure reaches the same wire through `super()`, after un-nesting a chat-shaped tool.""" result = self.config.transform_responses_api_request( diff --git a/tests/unit/llms/perplexity/responses/test_perplexity_responses_transformation.py b/tests/unit/llms/perplexity/responses/test_perplexity_responses_transformation.py index b6d26aa1de6..0247ffc361d 100644 --- a/tests/unit/llms/perplexity/responses/test_perplexity_responses_transformation.py +++ b/tests/unit/llms/perplexity/responses/test_perplexity_responses_transformation.py @@ -20,6 +20,7 @@ from litellm.litellm_core_utils.litellm_logging import Logging as LiteLLMLogging from litellm.llms.base_llm.chat.transformation import BaseLLMException from litellm.llms.perplexity.responses.transformation import PerplexityResponsesConfig from litellm.types.llms.openai import ResponsesAPIOptionalRequestParams +from litellm.types.router import GenericLiteLLMParams from litellm.types.utils import LlmProviders from litellm.utils import ProviderConfigManager @@ -362,6 +363,19 @@ class TestPerplexityResponsesTransformation: assert data["input"][0]["type"] == "message" assert data["input"][0]["role"] == "user" + def test_preset_drops_a_set_created_by_under_drop_params(self): + tool_output: Final = {"type": "function_call_output", "call_id": "call_1", "output": "sunny"} + + data: Final = PerplexityResponsesConfig().transform_responses_api_request( + model="preset/pro-search", + input=[{**tool_output, "created_by": "user_1"}], + response_api_optional_request_params={}, + litellm_params=GenericLiteLLMParams(drop_params=True), + headers={}, + ) + + assert data["input"] == [tool_output] + def test_non_preset_list_input(self): """Non-preset with list input preserves type field""" config = PerplexityResponsesConfig() diff --git a/tests/unit/responses/test_responses_websocket_all_providers.py b/tests/unit/responses/test_responses_websocket_all_providers.py index bfb2e16e1a7..ab52e6d29c3 100644 --- a/tests/unit/responses/test_responses_websocket_all_providers.py +++ b/tests/unit/responses/test_responses_websocket_all_providers.py @@ -2197,6 +2197,48 @@ class TestNativeWebSocketDeploymentDefaults: assert await handler._mask_response_create(cancel_frame) is cancel_frame assert await handler._mask_response_create(complete_frame) is complete_frame + @pytest.mark.asyncio + @pytest.mark.parametrize("nested", (False, True), ids=("flat", "nested")) + async def test_saved_output_item_with_a_null_created_by_is_forwarded_without_it(self, nested: bool): + handler: Final = _make_streaming(authorized_model="gpt-5-pro") + compaction: Final = {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"} + user_turn: Final = {"role": "user", "content": "hi"} + request: Final = {"model": "gpt-5-pro", "input": [{**compaction, "created_by": None}, user_turn]} + frame: Final = ( + {"type": "response.create", "response": request} if nested else {"type": "response.create", **request} + ) + + forwarded: Final = json.loads(await handler._mask_response_create(json.dumps(frame))) + + assert (forwarded["response"] if nested else forwarded)["input"] == [compaction, user_turn] + + @pytest.mark.asyncio + async def test_saved_reasoning_item_is_forwarded_without_its_null_fields(self): + handler: Final = _make_streaming(authorized_model="gpt-5-pro") + reasoning: Final = {"id": "rs_1", "type": "reasoning", "summary": []} + frame: Final = { + "type": "response.create", + "model": "gpt-5-pro", + "input": [{**reasoning, "status": None, "content": None, "encrypted_content": None}], + } + + forwarded: Final = json.loads(await handler._mask_response_create(json.dumps(frame))) + + assert forwarded["input"] == [reasoning] + + @pytest.mark.asyncio + async def test_input_items_with_nothing_to_drop_pass_through_untouched(self): + handler: Final = _make_streaming(authorized_model="gpt-5-pro") + frame: Final = json.dumps( + { + "type": "response.create", + "model": "gpt-5-pro", + "input": [{"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": "user_1"}], + } + ) + + assert await handler._mask_response_create(frame) is frame + @pytest.mark.asyncio async def test_handler_applies_defaults_to_the_first_frame_sent_upstream(self): import asyncio diff --git a/tests/unit/types/llms/test_types_llms_openai.py b/tests/unit/types/llms/test_types_llms_openai.py index 6d5f8fabaed..1b7a9693f7b 100644 --- a/tests/unit/types/llms/test_types_llms_openai.py +++ b/tests/unit/types/llms/test_types_llms_openai.py @@ -1,4 +1,6 @@ import asyncio +from collections.abc import Mapping +from itertools import chain from typing import Final, Optional from unittest.mock import AsyncMock, patch @@ -494,6 +496,82 @@ class TestResponsesAPIReasoningNullFields: assert dumped["instructions"] is None +_OUTPUT_ITEMS_OPENAI_SENDS_WITHOUT_CREATED_BY: Final = ( + {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA"}, + { + "id": "apc_1", + "type": "apply_patch_call", + "call_id": "call_1", + "status": "completed", + "operation": {"type": "delete_file", "path": "a.py"}, + }, + {"id": "apco_1", "type": "apply_patch_call_output", "call_id": "call_1", "status": "completed"}, + { + "id": "sh_1", + "type": "shell_call", + "call_id": "call_2", + "status": "completed", + "action": {"commands": ["ls"], "max_output_length": None, "timeout_ms": None}, + }, + { + "id": "sho_1", + "type": "shell_call_output", + "call_id": "call_2", + "status": "completed", + "output": [{"stdout": "a.py", "stderr": "", "outcome": {"type": "exit", "exit_code": 0}}], + }, + {"id": "tsc_1", "type": "tool_search_call", "arguments": {}, "execution": "server", "status": "completed"}, + {"id": "fco_1", "type": "function_call_output", "call_id": "call_3", "output": "42", "status": "completed"}, + { + "id": "cco_1", + "type": "computer_call_output", + "call_id": "call_4", + "output": {"type": "computer_screenshot", "image_url": "data:image/png;base64,AAAA"}, + "status": "completed", + }, +) + + +def _created_by_paths_under_key(key: object, child: object, path: str) -> tuple[str, ...]: + return (f"{path}.{key}",) if key == "created_by" else _created_by_paths(child, f"{path}.{key}") + + +def _created_by_paths(value: object, path: str = "") -> tuple[str, ...]: + if isinstance(value, dict): + return tuple(chain.from_iterable(_created_by_paths_under_key(k, v, path) for k, v in value.items())) + if isinstance(value, list): + return tuple(chain.from_iterable(_created_by_paths(v, f"{path}[{i}]") for i, v in enumerate(value))) + return () + + +@pytest.mark.parametrize("item", _OUTPUT_ITEMS_OPENAI_SENDS_WITHOUT_CREATED_BY, ids=lambda item: item["type"]) +def test_output_item_replays_without_a_created_by_the_provider_never_sent(item: Mapping[str, object]): + response: Final = ResponsesAPIResponse.model_validate( + {"id": "resp_1", "created_at": 1741476542, "object": "response", "status": "completed", "output": [item]} + ) + + assert _created_by_paths(json.loads(response.model_dump_json())["output"]) == () + assert _created_by_paths(response.model_dump()["output"]) == () + + +def test_output_item_keeps_a_created_by_the_provider_sent(): + item: Final = {"id": "cmp_1", "type": "compaction", "encrypted_content": "gAAAA", "created_by": "user_1"} + response: Final = ResponsesAPIResponse.model_validate( + {"id": "resp_1", "created_at": 1741476542, "object": "response", "status": "completed", "output": [item]} + ) + + assert json.loads(response.model_dump_json())["output"] == [item] + + +def test_shell_call_output_the_sdk_cannot_type_serializes_as_sent(): + item: Final = {"id": "sho_1", "type": "shell_call_output", "output": ["a.py"]} + response: Final = ResponsesAPIResponse.model_validate( + {"id": "resp_1", "created_at": 1741476542, "object": "response", "status": "completed", "output": [item]} + ) + + assert json.loads(response.model_dump_json())["output"] == [item] + + def test_normalize_fine_tuning_job_dict_maps_azure_pending(): from litellm.llms.openai.fine_tuning.handler import _normalize_fine_tuning_job_dict From 5bd47442fb1f1d237b1483dfcc9cd919ec1414c8 Mon Sep 17 00:00:00 2001 From: tessellark <349031000+tessellark@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:23:55 -0700 Subject: [PATCH 04/23] fix(cli): give lite codex aliases of a Codex-known model that model's catalog entry (#48894) * fix(cli): give lite codex aliases of a Codex-known model that model's catalog entry lite codex built its Codex model catalog from /v1/models ids only, so a proxy alias of a model Codex knows (api-gpt-6-luna for openai/gpt-6-luna) got the fallback entry. That entry has no supports_search_tool or tool_mode, so Codex sent every MCP and app tool inline and each turn cost far more input tokens. lite now reads each listed model's upstream from the proxy's /v1/model/info (team_public_model_name when set, else model_name, first deployment wins) and passes it to the shared catalog builder, the same way the proxy's own Codex route does. If that request fails, the catalog is built as before. * fix(cli): give a lite codex alias an upstream only when all its deployments route to one OpenAI model * fix(cli): cap a lite codex alias's context window at its listed max_input_tokens and count only OpenAI-hosted deployments * fix(cli): keep Codex's tier, upgrade and reasoning defaults off lite codex aliases * fix(cli): keep Codex's own effort, verbosity and promo off lite codex aliases and skip credential-hosted deployments --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- litellm/proxy/client/cli/commands/agents.py | 156 ++++++++++++- .../proxy/common_utils/codex_model_catalog.py | 62 +++++- tests/unit/proxy/client/cli/test_agents.py | 206 +++++++++++++++++- .../common_utils/test_codex_model_catalog.py | 78 +++++++ 4 files changed, 483 insertions(+), 19 deletions(-) diff --git a/litellm/proxy/client/cli/commands/agents.py b/litellm/proxy/client/cli/commands/agents.py index 4d09e4d1e0f..f19fb508c7d 100644 --- a/litellm/proxy/client/cli/commands/agents.py +++ b/litellm/proxy/client/cli/commands/agents.py @@ -5,16 +5,18 @@ import shutil import subprocess import sys import tempfile -from collections.abc import Callable, Mapping, Sequence +from collections import Counter +from collections.abc import Callable, Hashable, Iterable, Mapping, Sequence from dataclasses import dataclass from itertools import chain from pathlib import Path from types import MappingProxyType from typing import Final, TypeAlias, TypeVar +from urllib.parse import urlsplit import click import requests -from pydantic import JsonValue, TypeAdapter, ValidationError +from pydantic import ConfigDict, JsonValue, TypeAdapter, ValidationError from litellm.proxy.common_utils.codex_model_catalog import ( CODEX_BASE_INSTRUCTIONS_PATH, @@ -497,6 +499,113 @@ def _fetch_model_listing( return listing.data +class _DeploymentParams(LiteLLMBaseModel): + model_config = ConfigDict(frozen=True) + + model: str + custom_llm_provider: str | None = None + api_base: str | None = None + litellm_credential_name: str | None = None + reasoning_effort: JsonValue = None + + +class _DeploymentInfo(LiteLLMBaseModel): + model_config = ConfigDict(frozen=True) + + team_public_model_name: str | None = None + blocked: bool | None = None + + +class _Deployment(LiteLLMBaseModel): + model_config = ConfigDict(frozen=True) + + model_name: str + litellm_params: _DeploymentParams + model_info: _DeploymentInfo | None = None + + +class _DeploymentListing(LiteLLMBaseModel): + model_config = ConfigDict(frozen=True) + + data: tuple[_Deployment, ...] + + +@dataclass(frozen=True, slots=True) +class ModelUpstream: + """The OpenAI model every deployment behind a public name routes to, and the reasoning effort they all pin.""" + + model: str + reasoning_effort: str | None = None + + +_NO_UPSTREAMS: Final[Mapping[str, ModelUpstream]] = MappingProxyType({}) +_Pinned: Final = TypeVar("_Pinned", bound=Hashable) + + +def _public_name(deployment: _Deployment) -> str: + team_name: Final = deployment.model_info.team_public_model_name if deployment.model_info is not None else None + return team_name or deployment.model_name + + +def _is_paused(deployment: _Deployment) -> bool: + return deployment.model_info is not None and deployment.model_info.blocked is True + + +def _is_openai_host(params: _DeploymentParams) -> bool: + if params.api_base is None: + return not params.litellm_credential_name + host: Final = urlsplit(params.api_base).hostname or "" + return host == "api.openai.com" or host.endswith(".api.openai.com") + + +def _openai_model(params: _DeploymentParams) -> str | None: + if params.custom_llm_provider not in (None, "openai") or not _is_openai_host(params): + return None + provider, slash, name = params.model.partition("/") + if not slash: + return params.model + return name if provider == "openai" else None + + +def _pinned_effort(params: _DeploymentParams) -> str | None: + return params.reasoning_effort if isinstance(params.reasoning_effort, str) else None + + +def _shared_by_every_deployment(values: Iterable[tuple[str, _Pinned]]) -> Mapping[str, _Pinned]: + distinct: Final = frozenset(values) + values_per_name: Final = Counter(name for name, _ in distinct) + return MappingProxyType({name: value for name, value in distinct if values_per_name[name] == 1}) + + +def _upstreams_by_public_name(deployments: Sequence[_Deployment]) -> Mapping[str, ModelUpstream]: + live: Final = tuple(d for d in deployments if not _is_paused(d)) + models: Final = _shared_by_every_deployment((_public_name(d), _openai_model(d.litellm_params)) for d in live) + efforts: Final = _shared_by_every_deployment((_public_name(d), _pinned_effort(d.litellm_params)) for d in live) + return MappingProxyType( + {name: ModelUpstream(model, efforts.get(name)) for name, model in models.items() if model is not None} + ) + + +def _fetch_model_upstreams( + base_url: str, + api_key: str, + *, + get: Callable[..., requests.Response], +) -> Mapping[str, ModelUpstream]: + url: Final = base_url.rstrip("/") + "/v1/model/info" + try: + resp: Final = get(url, headers=MappingProxyType({"Authorization": f"Bearer {api_key}"}), timeout=10) + except requests.RequestException: + return _NO_UPSTREAMS + if resp.status_code != 200: + return _NO_UPSTREAMS + try: + listing: Final = _DeploymentListing.model_validate_json(resp.content) + except ValidationError: + return _NO_UPSTREAMS + return _upstreams_by_public_name(listing.data) + + class _OpenCodeLimit(LiteLLMBaseModel): context: int output: int @@ -576,8 +685,21 @@ def opencode_model_sync_env( return MappingProxyType({OPENCODE_CONFIG_CONTENT_ENV: opencode_provider_config(base_url, listing)}) +def _codex_row(model: ListedModel, upstream: ModelUpstream | None) -> CodexCatalogRow: + return CodexCatalogRow( + id=model.id, + mode=model.mode, + max_input_tokens=model.max_input_tokens, + upstream_model=upstream.model if upstream is not None else None, + reasoning_effort=upstream.reasoning_effort if upstream is not None else None, + ) + + def codex_model_catalog( - models: Sequence[ListedModel], stock: Sequence[CodexStockModel], instructions: str + models: Sequence[ListedModel], + stock: Sequence[CodexStockModel], + instructions: str, + upstreams: Mapping[str, ModelUpstream], ) -> str | None: """The `model_catalog_json` body listing the proxy's chat models, or None if there are none. @@ -586,14 +708,23 @@ def codex_model_catalog( installed Codex knows keeps that Codex's own entry and the proxy only decides its place in the picker: the listing orders it, lists it even when Codex hides it or keeps it off the API, and keeps Codex's upgrade nudge only - when the model it points at is served too. A model Codex does not know gets the fallback + when the model it points at is served too. An alias of such a model, per + `upstreams`, takes that entry too, minus the defaults Codex picks for the + model: no service tier or upgrade nudge, the reasoning effort its + deployments pin, and a window no larger than its listed max_input_tokens. + A model Codex does not know gets the fallback entry, with the same base instructions Codex itself uses so the agent never - runs without a system prompt. The catalog is the one `/v1/models?client_version=...` - serves, built from the installed Codex's own entries instead of the proxy's vendored ones. + runs without a system prompt. Apart from aliases, the catalog is the one + `/v1/models?client_version=...` serves, built from the installed Codex's own + entries instead of the proxy's vendored ones. """ - rows: Final = tuple(CodexCatalogRow(id=m.id, mode=m.mode, max_input_tokens=m.max_input_tokens) for m in models) + rows: Final = tuple(_codex_row(m, upstreams.get(m.id)) for m in models) body: Final = codex_models_response_json( - rows, stock=MappingProxyType({m.slug: m for m in stock}), instructions=instructions, byte_limit=None + rows, + stock=MappingProxyType({m.slug: m for m in stock}), + instructions=instructions, + byte_limit=None, + alias_defaults="deployment", ) return body.json if body.listed else None @@ -678,12 +809,14 @@ def codex_model_sync_args( Codex has no env or inline equivalent of OPENCODE_CONFIG_CONTENT: the catalog must be a file, so it is written under $CODEX_HOME (default ~/.codex) and atomically replaced on every launch. The Codex at `binary` first lists its - own models, so the ones the proxy serves keep that Codex's entries, and then + own models, so the ones the proxy serves keep that Codex's entries, an alias + included when every unpaused deployment /v1/model/info lists for it routes + to the same OpenAI model and Codex knows that model, and then reads the file back once before it is handed over. The key never lands in the file. A failed fetch, read, listing, write or read-back is reported rather than raised: Codex still launches with its built-in catalog and takes a proxy model by name via -m, and a rejected file stays on disk to be looked - at. + at. An unavailable /v1/model/info only leaves every alias on the fallback entry. """ listing: Final = _fetch_model_listing(base_url, api_key, get=get) if isinstance(listing, ModelSyncSkipped): @@ -700,7 +833,8 @@ def codex_model_sync_args( stock: Final = _stock_codex_models(binary, base_env, run=run) if isinstance(stock, ModelSyncSkipped): return stock - catalog: Final = codex_model_catalog(listing, stock, instructions) + upstreams: Final = _fetch_model_upstreams(base_url, api_key, get=get) + catalog: Final = codex_model_catalog(listing, stock, instructions, upstreams) if catalog is None: return ModelSyncSkipped(f"{base_url.rstrip('/')}/v1/models lists no chat models") try: diff --git a/litellm/proxy/common_utils/codex_model_catalog.py b/litellm/proxy/common_utils/codex_model_catalog.py index 9b42f99305e..397523288cf 100644 --- a/litellm/proxy/common_utils/codex_model_catalog.py +++ b/litellm/proxy/common_utils/codex_model_catalog.py @@ -24,7 +24,7 @@ from functools import cache from itertools import accumulate, pairwise from pathlib import Path from types import MappingProxyType, NoneType -from typing import TYPE_CHECKING, Annotated, Final, Literal +from typing import TYPE_CHECKING, Annotated, Final, Literal, TypeAlias from pydantic import ConfigDict, StringConstraints, TypeAdapter, ValidationError @@ -110,6 +110,12 @@ class CodexStockUpgrade(LiteLLMBaseModel): model: str +class CodexReasoningLevel(LiteLLMBaseModel): + model_config = ConfigDict(frozen=True, extra="allow") + + effort: str + + class CodexStockModel(LiteLLMBaseModel): """One `ModelInfo` entry as Codex ships it or prints it from `codex debug models`. @@ -128,6 +134,8 @@ class CodexStockModel(LiteLLMBaseModel): upgrade: CodexStockUpgrade | None = None service_tiers: tuple[CodexServiceTier, ...] = () default_service_tier: str | None = None + supported_reasoning_levels: tuple[CodexReasoningLevel, ...] = () + context_window: int | None = None class CodexStockCatalog(LiteLLMBaseModel): @@ -135,19 +143,21 @@ class CodexStockCatalog(LiteLLMBaseModel): CodexCatalogEntry = CodexFallbackModel | CodexStockModel +CodexAliasDefaults: TypeAlias = Literal["codex", "deployment"] @dataclass(frozen=True, slots=True) class CodexCatalogRow: """What the catalog needs to know about one listed model: its public id, the listing's mode and - input limit, the upstream model behind it, and the `model_info` values the operator set; - `service_tiers` holds one raw `model_info.service_tiers` value per deployment behind the id, None - where a deployment sets none.""" + input limit, the upstream model behind it, the reasoning effort its deployments pin, and the + `model_info` values the operator set; `service_tiers` holds one raw `model_info.service_tiers` + value per deployment behind the id, None where a deployment sets none.""" id: str mode: str | None = None max_input_tokens: int | None = None upstream_model: str | None = None + reasoning_effort: str | None = None display_name: str | None = None service_tiers: tuple[object, ...] = () @@ -254,12 +264,42 @@ def _stock_for(row: CodexCatalogRow, stock: Mapping[str, CodexStockModel]) -> Co return upstream if upstream is not None else stock.get(row.upstream_model.partition("/")[2]) +def _alias_context_window(row: CodexCatalogRow, stock_model: CodexStockModel) -> Mapping[str, int]: + if row.max_input_tokens is None or stock_model.context_window is None: + return MappingProxyType({}) + return MappingProxyType({"context_window": min(stock_model.context_window, row.max_input_tokens)}) + + +def _alias_reasoning_level(row: CodexCatalogRow, stock_model: CodexStockModel) -> str | None: + efforts: Final = frozenset(level.effort for level in stock_model.supported_reasoning_levels) + return row.reasoning_effort if row.reasoning_effort in efforts else None + + +def _deployment_defaults(row: CodexCatalogRow, stock_model: CodexStockModel) -> Mapping[str, object]: + """What an alias's deployments decide in place of the defaults Codex picks for the model they route to: + no service tier, verbosity, upgrade nudge or startup promo of Codex's own, so what the deployment + pins (or OpenAI's API default) stays in force, the pinned reasoning effort when Codex offers it and + none otherwise, and a window no larger than the alias's own limit.""" + return MappingProxyType( + { + "service_tiers": (), + "default_service_tier": None, + "default_verbosity": None, + "upgrade": None, + "availability_nux": None, + "default_reasoning_level": _alias_reasoning_level(row, stock_model), + **_alias_context_window(row, stock_model), + } + ) + + def _entry( index: int, row: CodexCatalogRow, stock: Mapping[str, CodexStockModel], served: frozenset[str], instructions: str, + alias_defaults: CodexAliasDefaults, ) -> CodexCatalogEntry: stock_model: Final = _stock_for(row, stock) stock_tiers: Final = MappingProxyType( @@ -278,7 +318,8 @@ def _entry( upgrade: Final = ( stock_model.upgrade if stock_model.upgrade is not None and stock_model.upgrade.model in served else None ) - stock_name: Final = stock_model.display_name if row.id == stock_model.slug else row.id + is_alias: Final = row.id != stock_model.slug + stock_name: Final = row.id if is_alias else stock_model.display_name listing: Final = { "slug": row.id, "display_name": row.display_name if row.display_name is not None else stock_name, @@ -286,6 +327,7 @@ def _entry( "visibility": "list", "supported_in_api": True, "upgrade": upgrade, + **(_deployment_defaults(row, stock_model) if is_alias and alias_defaults == "deployment" else {}), } if configured is None: return stock_model.model_copy(update=listing) @@ -351,6 +393,7 @@ def codex_models_response_json( stock: Mapping[str, CodexStockModel] | None = None, instructions: str | None = None, byte_limit: int | None = CODEX_CATALOG_BYTE_LIMIT, + alias_defaults: CodexAliasDefaults = "codex", ) -> CodexCatalogBody: """Codex's `ModelsResponse` body for `rows`, in listing order, cut to Codex's byte limit. @@ -359,13 +402,18 @@ def codex_models_response_json( byte limit silently and keeps its bundled one, so the body holds only the entries that fit, the ones offering a service tier taken first and the rest in listing order, an entry too large for the bytes left passed over, every kept entry at its listing position; `byte_limit=None` - keeps every entry. + keeps every entry. A row listed under another name than the Codex model its `upstream_model` + names (an alias) takes that model's entry; `alias_defaults="deployment"` drops the defaults + Codex picks for that model in favor of what the alias's deployments pin, while `"codex"` keeps + them, as Codex would use them for the model's own name. """ known: Final = bundled_codex_models() if stock is None else stock prompt: Final = codex_base_instructions() if instructions is None else instructions drivable: Final = tuple(row for row in rows if _codex_can_drive(row)) served: Final = frozenset(row.id for row in drivable) - entries: Final = tuple(_entry(index, row, known, served, prompt) for index, row in enumerate(drivable)) + entries: Final = tuple( + _entry(index, row, known, served, prompt, alias_defaults) for index, row in enumerate(drivable) + ) serialized: Final = tuple(_serialized(entry) for entry in entries) kept: Final = _kept_positions(entries, serialized, byte_limit) return CodexCatalogBody( diff --git a/tests/unit/proxy/client/cli/test_agents.py b/tests/unit/proxy/client/cli/test_agents.py index 3c79b916202..3716162692d 100644 --- a/tests/unit/proxy/client/cli/test_agents.py +++ b/tests/unit/proxy/client/cli/test_agents.py @@ -92,6 +92,8 @@ _STOCK_MODELS = { "base_instructions": "You are Codex, a coding agent based on GPT-5.6.", "apply_patch_tool_type": "freeform", "supports_parallel_tool_calls": True, + "supports_search_tool": True, + "tool_mode": "code_mode_only", "context_window": 272000, "comp_hash": "terra-hash", }, @@ -669,10 +671,16 @@ class TestCodexModelSync: def _row(model_id, **extra): return {"id": model_id, "object": "model", "created": 1, "owned_by": "openai", **extra} - def _sync(self, listing, codex_home, base_url="http://localhost:4000/", run=None): + def _sync(self, listing, codex_home, base_url="http://localhost:4000/", run=None, model_info=None): captured = {} def fake_get(url, headers, timeout): + if headers.get("Authorization") != "Bearer sk-key": + return _FakeResponse(401) + if url.endswith("/v1/model/info"): + if isinstance(model_info, Exception): + raise model_info + return model_info if model_info is not None else _FakeResponse(200, {"data": []}) captured["url"] = url captured["headers"] = headers return _FakeResponse(200, listing) @@ -737,6 +745,202 @@ class TestCodexModelSync: assert entries["gpt-5.4"]["upgrade"] == _STOCK_MODELS["gpt-5.4"]["upgrade"] assert [entries["gpt-5.4"]["priority"], entries["gpt-5.6-terra"]["priority"]] == [0, 1] + @pytest.mark.parametrize( + "deployment", + [ + {"model_name": "api-terra", "litellm_params": {"model": "openai/gpt-5.6-terra"}}, + {"model_name": "api-terra", "litellm_params": {"model": "gpt-5.6-terra"}, "model_info": None}, + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.6-terra"}, + "model_info": {"id": "d1", "team_public_model_name": ""}, + }, + { + "model_name": "model_name_team-1_d1", + "litellm_params": {"model": "openai/gpt-5.6-terra", "api_base": "https://api.openai.com/v1"}, + "model_info": {"id": "d1", "team_public_model_name": "api-terra"}, + }, + ], + ids=["provider_prefixed", "bare_without_model_info", "empty_team_public_name", "team_public_model_name"], + ) + def test_alias_of_a_codex_model_gets_that_models_entry_under_its_own_name(self, tmp_path, deployment): + listing = self._listing(self._row("api-terra"), self._row("m")) + _, result = self._sync(listing, tmp_path, model_info=_FakeResponse(200, {"data": [deployment]})) + + assert isinstance(result, ModelSyncArgs) + entries = self._entries(tmp_path) + assert entries["api-terra"] == { + **_STOCK_MODELS["gpt-5.6-terra"], + "slug": "api-terra", + "display_name": "api-terra", + "priority": 0, + "service_tiers": [], + "default_service_tier": None, + "default_verbosity": None, + "availability_nux": None, + "default_reasoning_level": None, + } + assert "supports_search_tool" not in entries["m"] + + def test_alias_gets_no_upgrade_nudge_away_from_its_own_name(self, tmp_path): + listing = self._listing(self._row("gpt-5.6-terra"), self._row("api-54")) + deployment = {"model_name": "api-54", "litellm_params": {"model": "openai/gpt-5.4"}} + self._sync(listing, tmp_path, model_info=_FakeResponse(200, {"data": [deployment]})) + + entry = self._entries(tmp_path)["api-54"] + assert (entry["comp_hash"], entry["upgrade"]) == (_STOCK_MODELS["gpt-5.4"]["comp_hash"], None) + + @pytest.mark.parametrize( + ("pins", "expected"), + [ + (("high",), "high"), + (("high", "high"), "high"), + (("high", None), None), + (("high", "low"), None), + (({"effort": "high"},), None), + ], + ids=["one_deployment", "every_deployment_agrees", "one_unpinned", "pins_differ", "non_string_pin"], + ) + def test_alias_starts_at_the_reasoning_effort_every_deployment_pins(self, tmp_path, pins, expected): + deployments = [ + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.6-terra", **({"reasoning_effort": p} if p else {})}, + } + for p in pins + ] + self._sync( + self._listing(self._row("api-terra")), tmp_path, model_info=_FakeResponse(200, {"data": deployments}) + ) + + entry = self._entries(tmp_path)["api-terra"] + assert (entry["comp_hash"], entry["default_reasoning_level"]) == ("terra-hash", expected) + + @pytest.mark.parametrize( + "deployments", + [ + [ + {"model_name": "api-terra", "litellm_params": {"model": "openai/gpt-5.6-terra"}}, + {"model_name": "api-terra", "litellm_params": {"model": "gpt-5.6-terra"}}, + ], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "gpt-5.6-terra", "custom_llm_provider": "openai"}, + } + ], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.5"}, + "model_info": {"id": "paused", "blocked": True}, + }, + {"model_name": "api-terra", "litellm_params": {"model": "openai/gpt-5.6-terra"}}, + ], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.6-terra", "api_base": "https://eu.api.openai.com/v1"}, + } + ], + [ + { + "model_name": "api-terra", + "litellm_params": { + "model": "openai/gpt-5.6-terra", + "api_base": "https://api.openai.com/v1", + "litellm_credential_name": "openai-key", + }, + } + ], + ], + ids=[ + "same_model_with_and_without_prefix", + "openai_custom_llm_provider", + "paused_deployment_ignored", + "openai_regional_host", + "credential_under_an_openai_host", + ], + ) + def test_alias_whose_deployments_all_route_to_one_openai_model_gets_its_entry(self, tmp_path, deployments): + self._sync( + self._listing(self._row("api-terra")), tmp_path, model_info=_FakeResponse(200, {"data": deployments}) + ) + + assert self._entries(tmp_path)["api-terra"]["comp_hash"] == _STOCK_MODELS["gpt-5.6-terra"]["comp_hash"] + + @pytest.mark.parametrize( + "deployments", + [ + [ + {"model_name": "api-terra", "litellm_params": {"model": "openai/gpt-5.5"}}, + { + "model_name": "model_name_team-1_d1", + "litellm_params": {"model": "openai/gpt-5.6-terra"}, + "model_info": {"id": "d1", "team_public_model_name": "api-terra"}, + }, + ], + [ + {"model_name": "api-terra", "litellm_params": {"model": "openai/gpt-5.6-terra"}}, + {"model_name": "api-terra", "litellm_params": {"model": "anthropic/claude-opus-4-7"}}, + ], + [{"model_name": "api-terra", "litellm_params": {"model": "azure/gpt-5.6-terra"}}], + [{"model_name": "api-terra", "litellm_params": {"model": "gpt-5.6-terra", "custom_llm_provider": "azure"}}], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.6-terra", "api_base": "http://vllm.example.invalid/v1"}, + } + ], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "gpt-5.6-terra", "api_base": "https://api.openai.com.example.invalid"}, + } + ], + [ + { + "model_name": "api-terra", + "litellm_params": {"model": "openai/gpt-5.6-terra", "litellm_credential_name": "gateway"}, + } + ], + ], + ids=[ + "team_row_and_global_row_differ", + "load_balanced_across_providers", + "azure_prefix", + "azure_provider", + "openai_prefix_on_another_host", + "openai_lookalike_host", + "host_only_a_credential_knows", + ], + ) + def test_alias_without_one_shared_openai_upstream_keeps_the_fallback_entry(self, tmp_path, deployments): + listing = self._listing(self._row("api-terra")) + self._sync(listing, tmp_path / "with", model_info=_FakeResponse(200, {"data": deployments})) + self._sync(listing, tmp_path / "without") + + assert self._entries(tmp_path / "with")["api-terra"] == self._entries(tmp_path / "without")["api-terra"] + + @pytest.mark.parametrize( + "model_info", + [ + requests.ConnectionError("refused"), + _FakeResponse(500, {"data": [{"model_name": "api-terra", "litellm_params": {"model": "gpt-5.6-terra"}}]}), + _FakeResponse(200, {"data": "nope"}), + _FakeResponse(200, {"data": [{"model_name": "api-terra"}]}), + ], + ids=["unreachable", "http_500", "unexpected_body", "deployment_without_litellm_params"], + ) + def test_unavailable_model_info_keeps_the_alias_on_the_fallback_entry(self, tmp_path, model_info): + _, result = self._sync(self._listing(self._row("api-terra")), tmp_path, model_info=model_info) + + catalog = tmp_path / "litellm-models.json" + assert result == ModelSyncArgs(("-c", f"model_catalog_json={json.dumps(str(catalog))}")) + entry = self._entries(tmp_path)["api-terra"] + assert entry["slug"] == "api-terra" + assert "supports_search_tool" not in entry + def test_stock_catalog_is_decoded_as_utf8_regardless_of_locale(self, tmp_path): description = "Modelo equilibrado para el trabajo diario, con acentos y ñ." catalog = {"models": [{**_STOCK_MODELS["gpt-5.5"], "description": description}]} diff --git a/tests/unit/proxy/common_utils/test_codex_model_catalog.py b/tests/unit/proxy/common_utils/test_codex_model_catalog.py index c9d4127c6d4..b43e43df7c9 100644 --- a/tests/unit/proxy/common_utils/test_codex_model_catalog.py +++ b/tests/unit/proxy/common_utils/test_codex_model_catalog.py @@ -135,6 +135,84 @@ def test_alias_of_a_known_upstream_model_takes_stock_metadata_under_its_own_name assert (entry["slug"], entry["display_name"]) == ("team-55", "team-55") +@pytest.mark.parametrize(("max_input_tokens", "expected"), [(100000, 100000), (922000, 272000), (None, 272000)]) +def test_alias_with_deployment_defaults_caps_codexs_window_at_its_listed_max_input_tokens(max_input_tokens, expected): + stock = MappingProxyType({"gpt-5.5": _stock("gpt-5.5").model_copy(update={"context_window": 272000})}) + alias = _row("team-55", upstream_model="openai/gpt-5.5", max_input_tokens=max_input_tokens) + + body = codex_models_response_json((alias,), stock=stock, instructions=_PROMPT, alias_defaults="deployment") + + assert json.loads(body.json)["models"][0]["context_window"] == expected + + +def test_alias_with_deployment_defaults_drops_codexs_tier_and_upgrade_while_the_native_name_keeps_them(): + rows = (_row("gpt-6-sol"), _row("team-sol", upstream_model="gpt-6-sol"), _row("team-55", upstream_model="gpt-5.5")) + codex = {entry["slug"]: entry for entry in _models(*rows)} + deployment = {entry["slug"]: entry for entry in _models(*rows, alias_defaults="deployment")} + + assert deployment["gpt-6-sol"] == codex["gpt-6-sol"] + assert (codex["team-sol"]["default_service_tier"], codex["team-55"]["upgrade"]) == ( + "priority", + {"model": "gpt-6-sol"}, + ) + assert _tiers(codex["team-sol"]) == _tiers(codex["gpt-6-sol"]) != [] + assert [ + (deployment[slug]["service_tiers"], deployment[slug]["default_service_tier"]) + for slug in ("team-sol", "team-55") + ] == [ + ([], None), + ([], None), + ] + assert deployment["team-55"]["upgrade"] is None + assert deployment["team-sol"]["model_messages"] == codex["team-sol"]["model_messages"] + + +@pytest.mark.parametrize(("pinned", "expected"), [("high", "high"), ("turbo", None), (None, None)]) +def test_alias_with_deployment_defaults_starts_only_at_a_reasoning_effort_its_deployments_pin(pinned, expected): + stock = CodexStockModel.model_validate( + { + "slug": "gpt-5.5", + "display_name": "GPT-5.5", + "priority": 1, + "visibility": "list", + "default_reasoning_level": "medium", + "supported_reasoning_levels": [{"effort": e, "description": e} for e in ("low", "medium", "high")], + } + ) + alias = _row("team-55", upstream_model="gpt-5.5", reasoning_effort=pinned) + + body = codex_models_response_json( + (alias,), stock=MappingProxyType({"gpt-5.5": stock}), instructions=_PROMPT, alias_defaults="deployment" + ) + + assert json.loads(body.json)["models"][0]["default_reasoning_level"] == expected + + +def test_alias_with_deployment_defaults_sends_no_verbosity_or_promo_of_codexs_while_the_native_name_keeps_them(): + stock = CodexStockModel.model_validate( + { + "slug": "gpt-6-sol", + "display_name": "GPT-6 Sol", + "priority": 1, + "visibility": "list", + "support_verbosity": True, + "default_verbosity": "low", + "availability_nux": {"message": "GPT-6 Sol is here"}, + } + ) + rows = (_row("gpt-6-sol"), _row("team-sol", upstream_model="gpt-6-sol")) + + body = codex_models_response_json( + rows, stock=MappingProxyType({"gpt-6-sol": stock}), instructions=_PROMPT, alias_defaults="deployment" + ) + native, alias = json.loads(body.json)["models"] + + assert [(e["support_verbosity"], e["default_verbosity"], e["availability_nux"]) for e in (native, alias)] == [ + (True, "low", {"message": "GPT-6 Sol is here"}), + (True, None, None), + ] + + @pytest.mark.parametrize( ("row", "expected"), [ From de42b6725236fd555c082cfcd3cf799c961eafde Mon Sep 17 00:00:00 2001 From: mika-lt <349045450+mika-lt@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:24:11 -0700 Subject: [PATCH 05/23] fix(proxy)!: enforce an end user's per-model budget from their linked budget (#48815) * fix(proxy): enforce an end user's per-model budget from their linked budget The shared auth checks now refuse a request once the end user's spend on that model reaches the model_max_budget of their budget (a linked budget or the default applied to them), for virtual keys and the master key alike. The cap is read from the end-user row, since the master key's cached auth object keeps whichever end user's limits it was cached with. The per-model end-user check inside virtual-key validation is removed: it read a token field that is never set there, so it never ran. * fix(auth): enforce the end user's per-model budget on JWT auth and skip it on budget-exempt routes JWT tokens now carry the end user's per-model caps so spend is charged against them and over-cap requests are refused. Routes that skip budget checks, like /spend/calculate, skip this check too. The proxy default end-user budget is covered by a test. * fix(auth): write the end user's per-model cap onto every token and check it after the member fallback The shared auth checks now resolve the end user's per-model cap, falling back to the key's or the proxy's default end-user budget when the end user has no row yet, and write it onto the token so the spend hook charges the cap the check enforces on every auth path. The check runs after the team-member budget fallback, on the model it picked, and the JWT builder's duplicate check is removed * fix(auth): keep only a per-model end-user cap that custom auth itself set A key-auth token reached through custom auth's auto hand-back now takes the current end user's cap, so a cached master-key or virtual-key object no longer carries an earlier end user's cap into another end user's request. * test(auth): build the custom-auth token with model_copy instead of setting the flag in place * test(auth): hold an end user to their own or their key's budget cap when the proxy has no default budget * fix(proxy): give each request its own copy of a custom-auth token so end-user caps and ids stay per request --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- litellm/proxy/auth/auth_checks.py | 9 + litellm/proxy/auth/user_api_key_auth.py | 116 +++- .../test_user_api_key_auth_request_flow.py | 596 +++++++++++++++++- 3 files changed, 696 insertions(+), 25 deletions(-) diff --git a/litellm/proxy/auth/auth_checks.py b/litellm/proxy/auth/auth_checks.py index 1ead470bbd2..1ed4f25dc71 100644 --- a/litellm/proxy/auth/auth_checks.py +++ b/litellm/proxy/auth/auth_checks.py @@ -1063,6 +1063,15 @@ def is_mcp_discovery_request(route: str, request_body: Mapping[str, object]) -> return isinstance(method, str) and method in MCP_ZERO_SPEND_JSONRPC_METHODS +class ModelMaxBudgetHolder(Protocol): + @property + def model_max_budget(self) -> Mapping[str, object] | None: ... + + +def model_max_budget_of(holder: ModelMaxBudgetHolder) -> Mapping[str, object] | None: + return holder.model_max_budget + + def route_skips_budget_checks(route: str) -> bool: return route not in BUDGET_ENFORCED_SIDE_EFFECT_ROUTES and ( route in MODEL_DISCOVERY_ROUTES or not RouteChecks.is_llm_api_route(route=route) diff --git a/litellm/proxy/auth/user_api_key_auth.py b/litellm/proxy/auth/user_api_key_auth.py index 79ad4824c92..292a147d200 100644 --- a/litellm/proxy/auth/user_api_key_auth.py +++ b/litellm/proxy/auth/user_api_key_auth.py @@ -40,6 +40,7 @@ from litellm.integrations.otel.model.config import is_otel_v2_enabled from litellm.integrations.otel.runtime import phase_event, phase_span, seed_request_identity from litellm.litellm_core_utils.dd_tracing import tracer from litellm.litellm_core_utils.dot_notation_indexing import get_nested_value +from litellm.models.end_user import LiteLLM_EndUserTable from litellm.proxy._types import * from litellm.proxy.agent_endpoints.auth.agent_caller import agent_caller_from_headers from litellm.proxy.auth.auth_checks import ( # noqa: F401 # legacy module exports @@ -85,6 +86,7 @@ from litellm.proxy.auth.auth_checks import ( # noqa: F401 # legacy module expo jwt_key_mapping_cache_key, key_access_group_grants_model, key_model_aliases_for_auth_check, + model_max_budget_of, resolve_and_validate_end_user_id, resolve_default_end_user_budget, route_skips_budget_checks, @@ -384,6 +386,16 @@ class _TeamModelBudgetLimiter(Protocol): ) -> bool: ... +class _EndUserModelBudgetLimiter(Protocol): + async def is_end_user_within_model_budget( + self, + end_user_id: str, + end_user_model_max_budget: Mapping[str, object], + model: str, + team_id: str | None = None, + ) -> bool: ... + + class _EveryModelBudgetLimiter(Protocol): async def is_key_within_model_budget(self, user_api_key_dict: UserAPIKeyAuth, model: str) -> bool: ... @@ -530,6 +542,49 @@ async def _check_team_model_budget( ) +async def _end_user_model_max_budget( + end_user_id: str | None, + end_user_object: LiteLLM_EndUserTable | None, + key_end_user_budget_id: str | None, + prisma_client: PrismaClient | None, + user_api_key_cache: UserApiKeyCache, + parent_otel_span: Span | None, +) -> Mapping[str, object] | None: + budget_table: Final = ( + end_user_object.litellm_budget_table + if end_user_object is not None + else ( + await resolve_default_end_user_budget( + prisma_client=prisma_client, + user_api_key_cache=user_api_key_cache, + key_end_user_budget_id=key_end_user_budget_id, + parent_otel_span=parent_otel_span, + ) + if end_user_id and prisma_client is not None + else None + ) + ) + return model_max_budget_of(budget_table) if budget_table is not None else None + + +async def _check_end_user_model_budget( + end_user_id: str | None, + end_user_model_max_budget: Mapping[str, object] | None, + model_max_budget_limiter: _EndUserModelBudgetLimiter, + models: Sequence[str], + team_id: str | None, +) -> None: + if not end_user_id or not end_user_model_max_budget: + return + for model_name in models: + await model_max_budget_limiter.is_end_user_within_model_budget( + end_user_id=end_user_id, + end_user_model_max_budget=end_user_model_max_budget, + model=model_name, + team_id=team_id, + ) + + async def _is_within_every_model_budget( valid_token: UserAPIKeyAuth, model_max_budget_limiter: _EveryModelBudgetLimiter, @@ -2094,6 +2149,10 @@ async def _resolve_object_permission_for_unresolvable_team( ) +def _custom_auth_token_for_this_request(response: object) -> UserAPIKeyAuth: + return UserAPIKeyAuth.model_validate(response).model_copy() + + async def user_api_key_auth_builder( request: Request, api_key: str, @@ -2172,7 +2231,7 @@ async def user_api_key_auth_builder( request=request, api_key=api_key, user_custom_auth=user_custom_auth ) if response is not None and isinstance(response, UserAPIKeyAuth): - validated = UserAPIKeyAuth.model_validate(response) + validated = _custom_auth_token_for_this_request(response) if getattr(litellm, "enable_post_custom_auth_checks", False): validated = await _run_post_custom_auth_checks( valid_token=validated, @@ -2188,7 +2247,7 @@ async def user_api_key_auth_builder( custom_auth_api_key = True elif user_custom_auth is not None: response = await user_custom_auth(request=request, api_key=api_key) - validated = UserAPIKeyAuth.model_validate(response) + validated = _custom_auth_token_for_this_request(response) if getattr(litellm, "enable_post_custom_auth_checks", False): validated = await _run_post_custom_auth_checks( valid_token=validated, @@ -3129,7 +3188,7 @@ async def validate_resolved_virtual_key( # noqa: C901 # Preserve ordering of e ) # Recompute after a potential budget-fallback rewrite so - # the end-user check below validates the final model + # the user check below validates the final model current_model = _get_model_from_request_context( request_data=request_data, route=route, @@ -3147,23 +3206,6 @@ async def validate_resolved_virtual_key( # noqa: C901 # Preserve ordering of e models=current_models, ) - # Check 5b. End-user model max budget - end_user_mmb: Final = valid_token.end_user_model_max_budget - if ( - end_user_mmb is not None - and isinstance(end_user_mmb, dict) - and len(end_user_mmb) > 0 - and current_models - and valid_token.end_user_id is not None - ): - for model_name in current_models: - await model_max_budget_limiter.is_end_user_within_model_budget( - end_user_id=valid_token.end_user_id, - end_user_model_max_budget=end_user_mmb, - model=model_name, - team_id=valid_token.team_id, - ) - # Check 6: Additional Common Checks across jwt + key auth if valid_token.team_id is not None: try: @@ -3733,9 +3775,7 @@ async def run_centralized_common_checks( project_object: Final[LiteLLM_ProjectTableCachedObj | None] = ( None if isinstance(project_result, BaseException) else project_result ) - end_user_object: Final[LiteLLM_EndUserTable | None] = ( - None if isinstance(end_user_result, BaseException) else end_user_result - ) + end_user_object: Final = end_user_result if isinstance(end_user_result, LiteLLM_EndUserTable) else None global_proxy_spend: float | None = None if isinstance(global_spend_result, BaseException) else global_spend_result carry_team_and_user_budget_state( valid_token=user_api_key_auth_obj, @@ -3795,6 +3835,21 @@ async def run_centralized_common_checks( parent_otel_span=parent_otel_span, keep_token_limits=user_custom_auth is not None, ) + end_user_model_max_budget: Final = await _end_user_model_max_budget( + end_user_id=end_user_id, + end_user_object=end_user_object, + key_end_user_budget_id=key_end_user_budget_id, + prisma_client=prisma_client, + user_api_key_cache=user_api_key_cache, + parent_otel_span=parent_otel_span, + ) + if end_user_id and ( + not user_api_key_auth_obj.authenticated_by_custom_auth + or user_api_key_auth_obj.end_user_model_max_budget is None + ): + user_api_key_auth_obj.end_user_model_max_budget = ( # rebind-ok: the spend hook charges from this token + dict(end_user_model_max_budget) if end_user_model_max_budget else None + ) skip_budget_checks: Final = _should_skip_budget_checks( request_data=request_data, @@ -3887,6 +3942,21 @@ async def run_centralized_common_checks( user_api_key_cache=user_api_key_cache, proxy_logging_obj=proxy_logging_obj, ) + await _check_end_user_model_budget( + end_user_id=end_user_id, + end_user_model_max_budget=user_api_key_auth_obj.end_user_model_max_budget, + model_max_budget_limiter=model_max_budget_limiter, + team_id=user_api_key_auth_obj.team_id, + models=_get_model_names_for_budget_checks( + model=_get_model_from_request_context( + request_data=request_data, + route=route, + request=request, + llm_router=llm_router, + team_id=user_api_key_auth_obj.team_id, + ) + ), + ) if sub_call and RouteChecks.is_llm_api_route(route=route): await virtual_key_max_budget_check( valid_token=user_api_key_auth_obj, diff --git a/tests/unit/proxy/auth/test_user_api_key_auth_request_flow.py b/tests/unit/proxy/auth/test_user_api_key_auth_request_flow.py index ae7168ed1e1..b7f3ded9291 100644 --- a/tests/unit/proxy/auth/test_user_api_key_auth_request_flow.py +++ b/tests/unit/proxy/auth/test_user_api_key_auth_request_flow.py @@ -5,7 +5,7 @@ import os import subprocess import sys import time -from collections.abc import Mapping, Sequence +from collections.abc import Awaitable, Callable, Mapping, Sequence from contextlib import contextmanager, nullcontext from datetime import datetime, timedelta, timezone from functools import partial @@ -37,6 +37,7 @@ from litellm.proxy.hooks.model_max_budget_limiter import ( team_member_budget_entity_id, ) from litellm.proxy._types import ( + JWTAuthBuilderResult, LiteLLMRoutes, LiteLLM_JWTAuth, LiteLLM_BudgetTable, @@ -55,7 +56,7 @@ from litellm.proxy._types import ( UserAPIKeyAuth, JWTRoutingOverride, ) -from litellm.proxy.auth.handle_jwt import JWTHandler +from litellm.proxy.auth.handle_jwt import JWTAuthManager, JWTHandler from litellm.proxy.auth.auth_checks import ( OrganizationNotFoundError, TeamNotFoundError, @@ -724,6 +725,44 @@ async def test_user_custom_auth_runs_post_custom_auth_checks_when_opt_in(): litellm.enable_post_custom_auth_checks = original_flag +async def _authenticate_through_custom_auth() -> UserAPIKeyAuth: + from starlette.datastructures import URL + + from litellm.proxy.auth.user_api_key_auth import user_api_key_auth_builder + + request: Final = Request(scope={"type": "http"}) + request._url = URL(url="/chat/completions") + return await user_api_key_auth_builder( + request=request, + api_key="Bearer sk-custom-auth-shared", + azure_api_key_header="", + anthropic_api_key_header=None, + google_ai_studio_api_key_header=None, + azure_apim_header=None, + request_data={}, + ) + + +@pytest.mark.asyncio +async def test_user_custom_auth_returning_one_shared_token_keeps_each_requests_end_user_apart( + monkeypatch: pytest.MonkeyPatch, +) -> None: + import litellm.proxy.proxy_server as _proxy_server_mod + + shared_token: Final = UserAPIKeyAuth(api_key="sk-custom-auth-shared", user_id="custom-user-123") + proxy_attrs: Final = _proxy_server_attrs_for_custom_auth(user_custom_auth=AsyncMock(return_value=shared_token)) + for attr, val in proxy_attrs.items(): + monkeypatch.setattr(_proxy_server_mod, attr, val, raising=False) + monkeypatch.setattr(litellm, "enable_post_custom_auth_checks", False, raising=False) + + capped_end_users_request: Final = await _authenticate_through_custom_auth() + capped_end_users_request.end_user_id = "eu-capped" + capped_end_users_request.end_user_model_max_budget = {"gpt-4o": {"max_budget": 0.00001}} + next_end_users_request: Final = await _authenticate_through_custom_auth() + + assert (next_end_users_request.end_user_id, next_end_users_request.end_user_model_max_budget) == (None, None) + + @pytest.mark.asyncio async def test_enterprise_custom_auth_skips_post_custom_auth_checks_by_default(): """ @@ -5293,6 +5332,559 @@ async def test_centralized_common_checks_enforces_team_model_max_budget_from_the assert limiter.calls == [("t1", team_caps, key_caps, "gpt-4o")] +_END_USER_MODEL_CAPS: Final = {"gpt-4o": {"budget_limit": 0.00004, "time_period": "1d"}} + + +def _virtual_key_token_for_end_user() -> UserAPIKeyAuth: + return UserAPIKeyAuth(api_key="sk-test", token="hashed", end_user_id="eu-1") + + +def _master_key_token_cached_with_another_end_users_cap() -> UserAPIKeyAuth: + return UserAPIKeyAuth( + api_key=LITELLM_PROXY_MASTER_KEY_ALIAS, + user_id="admin", + user_role=LitellmUserRoles.PROXY_ADMIN, + end_user_id="eu-1", + end_user_model_max_budget={"gpt-4o": {"budget_limit": 1000.0, "time_period": "1d"}}, + ) + + +def _end_user_linked_to_the_capped_budget() -> LiteLLM_EndUserTable: + return LiteLLM_EndUserTable( + user_id="eu-1", + blocked=False, + budget_id="eu-budget", + litellm_budget_table=LiteLLM_BudgetTable(budget_id="eu-budget", model_max_budget=_END_USER_MODEL_CAPS), + ) + + +def _end_user_on_the_proxy_default_budget() -> LiteLLM_EndUserTable: + return LiteLLM_EndUserTable(user_id="eu-1", blocked=False) + + +def _no_end_user_row_yet() -> None: + return None + + +def _jwt_token(end_user_id: str | None, end_user_object: LiteLLM_EndUserTable | None) -> UserAPIKeyAuth: + return JWTAuthManager.user_api_key_auth_from_result( + JWTAuthBuilderResult( + is_proxy_admin=False, + team_object=None, + user_object=None, + end_user_object=end_user_object, + org_object=None, + token="jwt", + team_id=None, + user_id=None, + user_email=None, + end_user_id=end_user_id, + org_id=None, + team_membership=None, + jwt_claims={}, + agent_id=None, + ) + ) + + +def _jwt_token_with_an_end_user_claim() -> UserAPIKeyAuth: + return _jwt_token(end_user_id="eu-1", end_user_object=_end_user_linked_to_the_capped_budget()) + + +def _jwt_token_naming_the_end_user_only_in_the_body() -> UserAPIKeyAuth: + return _jwt_token(end_user_id=None, end_user_object=None) + + +async def _run_centralized_checks_for_end_user( + monkeypatch: pytest.MonkeyPatch, + token: UserAPIKeyAuth, + end_user: LiteLLM_EndUserTable | None, + gpt_4o_spend: float, + model: str, + route: str, + default_budget_id: str | None, + user_custom_auth: Callable[[Request, str], Awaitable[UserAPIKeyAuth]] | None, +) -> None: + from starlette.datastructures import URL + + import litellm.proxy.proxy_server as _proxy_server_mod + from litellm.proxy.common_utils.user_api_key_cache import end_user_cache_key + from litellm.proxy.utils import ProxyLogging + + monkeypatch.setattr(litellm, "max_end_user_budget_id", default_budget_id) + user_api_key_cache: Final = UserApiKeyCache() + if end_user is not None: + await user_api_key_cache.async_set_cache( + key=end_user_cache_key("eu-1"), + value=end_user, + model_type=LiteLLM_EndUserTable, + ) + for budget_id in ("eu-default", "eu-key-budget"): + await user_api_key_cache.async_set_cache( + key=f"default_end_user_budget:{budget_id}", + value=LiteLLM_BudgetTable(budget_id=budget_id, model_max_budget=_END_USER_MODEL_CAPS), + model_type=LiteLLM_BudgetTable, + ) + await user_api_key_cache.async_set_cache( + key="admin", + value=LiteLLM_UserTable(user_id="admin", user_role=LitellmUserRoles.PROXY_ADMIN), + model_type=LiteLLM_UserTable, + ) + limiter: Final = PROXY_VirtualKeyModelMaxBudgetLimiter(dual_cache=DualCache()) + await limiter.dual_cache.async_set_cache( + key=model_budget_spend_cache_key( + entity_type=Litellm_EntityType.END_USER, + entity_id="eu-1", + budget_model="gpt-4o", + budget_duration="1d", + ), + value=gpt_4o_spend, + ) + router: Final = litellm.Router( + model_list=[ + {"model_name": "gpt-4o", "litellm_params": {"model": "openai/gpt-4o"}}, + {"model_name": "gpt-4o-mini", "litellm_params": {"model": "openai/gpt-4o-mini"}}, + ], + ) + attrs: Final = { + **_proxy_attrs_for_centralized_checks(user_custom_auth=user_custom_auth), + "general_settings": { + "disable_budget_reservation": True, + "custom_auth_run_common_checks": user_custom_auth is not None, + }, + "llm_model_list": router.model_list, + "llm_router": router, + "prisma_client": MagicMock(), + "user_api_key_cache": user_api_key_cache, + "spend_counter_cache": DualCache(), + "proxy_logging_obj": ProxyLogging(user_api_key_cache=user_api_key_cache), + "model_max_budget_limiter": limiter, + } + originals: Final = {attribute: getattr(_proxy_server_mod, attribute, None) for attribute in attrs} + request: Final = Request(scope={"type": "http"}) + request._url = URL(url=route) + try: + for attribute, value in attrs.items(): + setattr(_proxy_server_mod, attribute, value) + await run_centralized_common_checks( + user_api_key_auth_obj=token, + request=request, + request_data={"model": model, "user": "eu-1", "messages": [{"role": "user", "content": "hi"}]}, + route=route, + ) + finally: + for attribute, value in originals.items(): + setattr(_proxy_server_mod, attribute, value) + + + + +@pytest.mark.parametrize( + ("make_token", "make_end_user", "gpt_4o_spend", "model", "route", "must_raise"), + [ + pytest.param( + _virtual_key_token_for_end_user, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="virtual-key-over-cap", + ), + pytest.param( + _master_key_token_cached_with_another_end_users_cap, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="master-key-over-cap", + ), + pytest.param( + _jwt_token_with_an_end_user_claim, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="jwt-claim-over-cap", + ), + pytest.param( + _jwt_token_naming_the_end_user_only_in_the_body, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="jwt-body-user-over-cap", + ), + pytest.param( + _virtual_key_token_for_end_user, + _no_end_user_row_yet, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="new-end-user-on-the-proxy-default-budget-over-cap", + ), + pytest.param( + _virtual_key_token_for_end_user, + _end_user_on_the_proxy_default_budget, + 0.0001, + "gpt-4o", + "/v1/chat/completions", + True, + id="proxy-default-budget-over-cap", + ), + pytest.param( + _virtual_key_token_for_end_user, + _end_user_linked_to_the_capped_budget, + 0.00001, + "gpt-4o", + "/v1/chat/completions", + False, + id="under-cap", + ), + pytest.param( + _virtual_key_token_for_end_user, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o-mini", + "/v1/chat/completions", + False, + id="model-without-a-cap", + ), + pytest.param( + _master_key_token_cached_with_another_end_users_cap, + _end_user_linked_to_the_capped_budget, + 0.0001, + "gpt-4o", + "/spend/calculate", + False, + id="budget-exempt-route", + ), + ], +) +@pytest.mark.asyncio +async def test_centralized_common_checks_enforces_the_end_users_model_max_budget( + monkeypatch: pytest.MonkeyPatch, + make_token: Callable[[], UserAPIKeyAuth], + make_end_user: Callable[[], LiteLLM_EndUserTable | None], + gpt_4o_spend: float, + model: str, + route: str, + must_raise: bool, +) -> None: + token: Final = make_token() + with pytest.raises(litellm.BudgetExceededError) if must_raise else nullcontext(): + await _run_centralized_checks_for_end_user( + monkeypatch=monkeypatch, + token=token, + end_user=make_end_user(), + gpt_4o_spend=gpt_4o_spend, + model=model, + route=route, + default_budget_id="eu-default", + user_custom_auth=None, + ) + assert token.end_user_model_max_budget == _END_USER_MODEL_CAPS + + +def _virtual_key_token_assigning_end_users_a_budget() -> UserAPIKeyAuth: + return UserAPIKeyAuth( + api_key="sk-test", token="hashed", end_user_id="eu-1", metadata={"end_user_budget_id": "eu-key-budget"} + ) + + +@pytest.mark.parametrize( + ("make_token", "make_end_user"), + [ + pytest.param( + _virtual_key_token_for_end_user, + _end_user_linked_to_the_capped_budget, + id="end-users-own-budget", + ), + pytest.param( + _virtual_key_token_assigning_end_users_a_budget, + _end_user_on_the_proxy_default_budget, + id="keys-end-user-budget", + ), + pytest.param( + _virtual_key_token_assigning_end_users_a_budget, + _no_end_user_row_yet, + id="keys-end-user-budget-for-a-new-end-user", + ), + ], +) +@pytest.mark.asyncio +async def test_centralized_common_checks_enforces_the_end_users_model_max_budget_without_a_proxy_default( + monkeypatch: pytest.MonkeyPatch, + make_token: Callable[[], UserAPIKeyAuth], + make_end_user: Callable[[], LiteLLM_EndUserTable | None], +) -> None: + token: Final = make_token() + with pytest.raises(litellm.BudgetExceededError): + await _run_centralized_checks_for_end_user( + monkeypatch=monkeypatch, + token=token, + end_user=make_end_user(), + gpt_4o_spend=0.0001, + model="gpt-4o", + route="/v1/chat/completions", + default_budget_id=None, + user_custom_auth=None, + ) + assert token.end_user_model_max_budget == _END_USER_MODEL_CAPS + + +async def _custom_auth_that_is_never_called(request: Request, api_key: str) -> UserAPIKeyAuth: + raise AssertionError("the shared checks never call custom auth") + + +def _token_built_by_custom_auth_with_its_own_cap() -> UserAPIKeyAuth: + return UserAPIKeyAuth( + api_key="sk-custom", end_user_id="eu-1", end_user_model_max_budget=_END_USER_MODEL_CAPS + ).model_copy(update={"authenticated_by_custom_auth": True}) + + +def _master_key_token_custom_auth_handed_back_with_another_end_users_cap() -> UserAPIKeyAuth: + return UserAPIKeyAuth( + api_key=LITELLM_PROXY_MASTER_KEY_ALIAS, + user_id="admin", + user_role=LitellmUserRoles.PROXY_ADMIN, + end_user_id="eu-1", + end_user_model_max_budget=_END_USER_MODEL_CAPS, + ) + + +@pytest.mark.parametrize( + ("make_token", "must_raise", "expected_cap"), + [ + pytest.param( + _token_built_by_custom_auth_with_its_own_cap, + True, + _END_USER_MODEL_CAPS, + id="custom-auth-token-keeps-its-own-cap", + ), + pytest.param( + _master_key_token_custom_auth_handed_back_with_another_end_users_cap, + False, + None, + id="key-auth-token-behind-custom-auth-drops-another-end-users-cap", + ), + ], +) +@pytest.mark.asyncio +async def test_centralized_common_checks_keeps_only_a_cap_custom_auth_set( + monkeypatch: pytest.MonkeyPatch, + make_token: Callable[[], UserAPIKeyAuth], + must_raise: bool, + expected_cap: Mapping[str, object] | None, +) -> None: + token: Final = make_token() + with pytest.raises(litellm.BudgetExceededError) if must_raise else nullcontext(): + await _run_centralized_checks_for_end_user( + monkeypatch=monkeypatch, + token=token, + end_user=_end_user_on_the_proxy_default_budget(), + gpt_4o_spend=0.0001, + model="gpt-4o", + route="/v1/chat/completions", + default_budget_id=None, + user_custom_auth=_custom_auth_that_is_never_called, + ) + assert token.end_user_model_max_budget == expected_cap + + +@pytest.mark.asyncio +async def test_centralized_common_checks_holds_the_end_user_to_the_model_a_team_member_fallback_picked( + monkeypatch: pytest.MonkeyPatch, +) -> None: + from starlette.datastructures import URL + + import litellm.proxy.proxy_server as _proxy_server_mod + from litellm.proxy.common_utils.user_api_key_cache import end_user_cache_key + from litellm.proxy.utils import ProxyLogging + + budget_id: Final = "member-budget-1" + user_api_key_cache: Final = UserApiKeyCache() + await user_api_key_cache.async_set_cache( + key=team_membership_reservation_cache_key(user_id="u1", team_id="t1"), + value=LiteLLM_TeamMembership(user_id="u1", team_id="t1", budget_id=budget_id), + model_type=LiteLLM_TeamMembership, + ) + await user_api_key_cache.async_set_cache( + key="team_id:t1", + value=LiteLLM_TeamTableCachedObj( + team_id="t1", + models=["gpt-4o", "gpt-4o-mini"], + metadata={"team_member_budget_id": budget_id}, + ), + model_type=LiteLLM_TeamTableCachedObj, + ) + await user_api_key_cache.async_set_cache( + key=f"team_member_default_budget:{budget_id}", + value=LiteLLM_BudgetTable( + budget_id=budget_id, + model_max_budget={ + "gpt-4o": {"max_budget": 0.00004, "budget_duration": "1d"}, + "gpt-4o-mini": {"max_budget": 100.0, "budget_duration": "1d"}, + }, + ), + model_type=LiteLLM_BudgetTable, + ) + await user_api_key_cache.async_set_cache( + key="u1", + value=LiteLLM_UserTable(user_id="u1", user_role=LitellmUserRoles.INTERNAL_USER), + model_type=LiteLLM_UserTable, + ) + await user_api_key_cache.async_set_cache( + key=end_user_cache_key("eu-1"), + value=_end_user_linked_to_the_capped_budget(), + model_type=LiteLLM_EndUserTable, + ) + limiter: Final = PROXY_VirtualKeyModelMaxBudgetLimiter(dual_cache=DualCache()) + for entity_type, entity_id in ( + (Litellm_EntityType.TEAM_MEMBER, team_member_budget_entity_id(user_id="u1", team_id="t1")), + (Litellm_EntityType.END_USER, "eu-1"), + ): + await limiter.dual_cache.async_set_cache( + key=model_budget_spend_cache_key( + entity_type=entity_type, + entity_id=entity_id, + budget_model="gpt-4o", + budget_duration="1d", + ), + value=0.0001, + ) + router: Final = litellm.Router( + model_list=[ + {"model_name": "gpt-4o", "litellm_params": {"model": "openai/gpt-4o"}}, + {"model_name": "gpt-4o-mini", "litellm_params": {"model": "openai/gpt-4o-mini"}}, + ], + fallbacks=[{"gpt-4o": ["gpt-4o-mini"]}], + ) + attrs: Final = { + **_proxy_attrs_for_centralized_checks(), + "general_settings": {"disable_budget_reservation": True}, + "llm_model_list": router.model_list, + "llm_router": router, + "prisma_client": MagicMock(), + "user_api_key_cache": user_api_key_cache, + "spend_counter_cache": DualCache(), + "proxy_logging_obj": ProxyLogging(user_api_key_cache=user_api_key_cache), + "model_max_budget_limiter": limiter, + } + originals: Final = {attribute: getattr(_proxy_server_mod, attribute, None) for attribute in attrs} + request: Final = Request(scope={"type": "http", "path_params": {}, "headers": []}) + request._url = URL(url="/v1/chat/completions") + request_data: Final = {"model": "gpt-4o", "user": "eu-1", "messages": [{"role": "user", "content": "hi"}]} + try: + for attribute, value in attrs.items(): + setattr(_proxy_server_mod, attribute, value) + await run_centralized_common_checks( + user_api_key_auth_obj=UserAPIKeyAuth( + api_key="sk-test", + token="hashed", + user_id="u1", + team_id="t1", + end_user_id="eu-1", + models=["gpt-4o", "gpt-4o-mini"], + user_role=LitellmUserRoles.INTERNAL_USER, + ), + request=request, + request_data=request_data, + route="/v1/chat/completions", + ) + finally: + for attribute, value in originals.items(): + setattr(_proxy_server_mod, attribute, value) + assert request_data["model"] == "gpt-4o-mini" + + +def _access_groups_only_team_t1_puts_gpt_4o_in(model: str, team_id: str | None) -> frozenset[str]: + return frozenset({"t1-group"}) if (model, team_id) == ("gpt-4o", "t1") else frozenset() + + +@pytest.mark.parametrize( + ("team_id", "must_raise"), + [ + pytest.param("t1", True, id="team-whose-access-group-the-end-user-capped"), + pytest.param(None, False, id="no-team-so-the-group-cap-does-not-apply"), + ], +) +@pytest.mark.asyncio +async def test_centralized_common_checks_applies_an_end_user_cap_on_the_tokens_team_access_group( + team_id: str | None, + must_raise: bool, +) -> None: + from starlette.datastructures import URL + + import litellm.proxy.proxy_server as _proxy_server_mod + from litellm.proxy.common_utils.user_api_key_cache import end_user_cache_key + from litellm.proxy.utils import ProxyLogging + + group_cap: Final = {"t1-group": {"budget_limit": 0.00004, "time_period": "1d"}} + user_api_key_cache: Final = UserApiKeyCache() + await user_api_key_cache.async_set_cache( + key="team_id:t1", + value=LiteLLM_TeamTableCachedObj(team_id="t1", models=["gpt-4o"]), + model_type=LiteLLM_TeamTableCachedObj, + ) + await user_api_key_cache.async_set_cache( + key=end_user_cache_key("eu-1"), + value=LiteLLM_EndUserTable( + user_id="eu-1", + blocked=False, + budget_id="eu-group-budget", + litellm_budget_table=LiteLLM_BudgetTable(budget_id="eu-group-budget", model_max_budget=group_cap), + ), + model_type=LiteLLM_EndUserTable, + ) + limiter: Final = PROXY_VirtualKeyModelMaxBudgetLimiter( + dual_cache=DualCache(), model_access_groups=_access_groups_only_team_t1_puts_gpt_4o_in + ) + await limiter.dual_cache.async_set_cache( + key=model_budget_spend_cache_key( + entity_type=Litellm_EntityType.END_USER, + entity_id="eu-1", + budget_model="t1-group", + budget_duration="1d", + ), + value=0.0001, + ) + router: Final = litellm.Router(model_list=[{"model_name": "gpt-4o", "litellm_params": {"model": "openai/gpt-4o"}}]) + attrs: Final = { + **_proxy_attrs_for_centralized_checks(), + "general_settings": {"disable_budget_reservation": True}, + "llm_model_list": router.model_list, + "llm_router": router, + "prisma_client": MagicMock(), + "user_api_key_cache": user_api_key_cache, + "spend_counter_cache": DualCache(), + "proxy_logging_obj": ProxyLogging(user_api_key_cache=user_api_key_cache), + "model_max_budget_limiter": limiter, + } + originals: Final = {attribute: getattr(_proxy_server_mod, attribute, None) for attribute in attrs} + request: Final = Request(scope={"type": "http", "path_params": {}, "headers": []}) + request._url = URL(url="/v1/chat/completions") + try: + for attribute, value in attrs.items(): + setattr(_proxy_server_mod, attribute, value) + with pytest.raises(litellm.BudgetExceededError) if must_raise else nullcontext(): + await run_centralized_common_checks( + user_api_key_auth_obj=UserAPIKeyAuth( + api_key="sk-test", token="hashed", team_id=team_id, end_user_id="eu-1", models=["gpt-4o"] + ), + request=request, + request_data={"model": "gpt-4o", "user": "eu-1", "messages": [{"role": "user", "content": "hi"}]}, + route="/v1/chat/completions", + ) + finally: + for attribute, value in originals.items(): + setattr(_proxy_server_mod, attribute, value) + + @pytest.mark.asyncio async def test_centralized_common_checks_loads_member_budget_and_exempts_discovery_routes(): from litellm.proxy.common_utils.user_api_key_cache import UserApiKeyCache From 764a7a6536ee804af2399c53ec6715399fb34979 Mon Sep 17 00:00:00 2001 From: Alon Sokolovski Date: Thu, 29 Oct 2026 06:35:32 +0200 Subject: [PATCH 06/23] fix(context_management)!: count the system prompt toward the clear_tool_uses input_tokens trigger (#47857) * fix(context_management): count the system prompt toward the clear_tool_uses input_tokens trigger Anthropic's API compares an input_tokens trigger with the whole prompt, system included; the polyfill counted messages and tools only, so it cleared late by the system prompt's size. compact_20260112 already counts it: share its system_to_text. * fix(context_management): take read-only types in the system prompt count The type-discipline gate (LIT001) rejects new list and dict annotations. * chore: rerun CI (proxy-build-from-pip timed out) * fix(context_management): count the system prompt through compact's shared counter Finishes the main merge's conflict in clear_tool_uses.py. The input_tokens trigger now adds the system prompt through count_system_tokens, the same counter compact uses, while the count reused for cleared_input_tokens stays messages and tools only, so the reported savings are just the cleared tool results * perf(context_management): skip the token count when nothing can be cleared The keep check runs before the trigger count, the system prompt reader accepts any mapping block, and the system prompt test gets short parameter ids * test(context_management): keep the off-loop count test counting after the keep check moved first * test(context_management): cover a client compaction summary counting toward the trigger The trigger also skips the system prompt count when messages and tools alone already pass it * fix(context_management): move a client compaction summary into the system prompt when clearing runs before compact * fix(context_management): clear only the history after a client compaction block so compact still replaces its summary * fix(context_management): keep tool calls beside a client compaction block clearable --------- Co-authored-by: AlonSoko <25619863+AlonSoko@users.noreply.github.com> Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- .../editors/clear_tool_uses.py | 40 ++++--- .../context_management/editors/compact.py | 27 ++++- .../test_clear_tool_uses.py | 111 +++++++++++++++++- .../context_management/test_dispatcher.py | 1 + 4 files changed, 158 insertions(+), 21 deletions(-) diff --git a/litellm/llms/anthropic/messages/context_management/editors/clear_tool_uses.py b/litellm/llms/anthropic/messages/context_management/editors/clear_tool_uses.py index d4430ca5ab9..c4f7966f429 100644 --- a/litellm/llms/anthropic/messages/context_management/editors/clear_tool_uses.py +++ b/litellm/llms/anthropic/messages/context_management/editors/clear_tool_uses.py @@ -31,6 +31,7 @@ from ..constants import ( ) from ..errors import AnthropicContextManagementError from ..placeholders import build_cleared_tool_result_content +from .compact import count_system_tokens, history_after_client_compaction if TYPE_CHECKING: from litellm.types.llms.openai import ChatCompletionToolParam @@ -203,9 +204,10 @@ def _trigger_met( model: str, messages: list[dict[str, object]], tools: list[dict[str, object]] | None, + system: str | Sequence[Mapping[str, object]] | None, counted_tool_uses: int, ) -> tuple[bool, int | None]: - """Return (trigger_met, input_tokens if counted for reuse).""" + """Return (trigger_met, message and tool tokens for reuse); like the API, input_tokens adds the system prompt.""" trigger_type: Final = trigger.get("type", "input_tokens") threshold = trigger.get("value") @@ -216,14 +218,17 @@ def _trigger_met( if not isinstance(threshold, int): threshold = DEFAULT_INPUT_TOKENS_TRIGGER - current_tokens: Final = litellm.token_counter( + message_tokens: Final = litellm.token_counter( model=model, messages=messages, tools=cast("list[ChatCompletionToolParam] | None", tools), ) + if message_tokens > threshold: + return True, message_tokens + current_tokens: Final = message_tokens + count_system_tokens(model, system) verbose_logger.debug("context_management polyfill: current_tokens: %s", current_tokens) verbose_logger.debug("context_management polyfill: threshold: %s", threshold) - return current_tokens > threshold, current_tokens + return current_tokens > threshold, message_tokens def _resolve_keep_count(keep: dict[str, object]) -> int: @@ -237,7 +242,7 @@ def _resolve_keep_count(keep: dict[str, object]) -> int: def _last_completed_tool_use_id( - messages: list[dict[str, object]], + messages: Sequence[Mapping[str, object]], ) -> str | None: """Latest completed tool_result id; never cleared.""" last_id: str | None = None @@ -253,7 +258,7 @@ def _last_completed_tool_use_id( def _clear_tool_results( - messages: list[dict[str, object]], ids_to_clear: set[str] + messages: list[dict[str, object]], ids_to_clear: Set[str] ) -> tuple[list[dict[str, object]], int]: """Clear matching tool_result content; return (messages, cleared_count).""" cleared = 0 @@ -311,7 +316,11 @@ def apply_clear_tool_uses_20250919( system: str | list[dict[str, object]] | None, edit_spec: ClearToolUsesEditSpec, ) -> tuple[list[dict[str, object]], AppliedEdit | None]: - """Apply clear_tool_uses to an edit ``check_clear_tool_uses_spec`` returned; return (messages, AppliedEdit or None).""" + """Apply clear_tool_uses to an edit ``check_clear_tool_uses_spec`` returned; return (messages, AppliedEdit or None). + + Like the API, it reads only the history after a client compaction block and counts the block's summary as system. + """ + kept, counted_system = history_after_client_compaction(messages, system) fields: Final = _ClearToolUsesFields.model_validate(edit_spec) clear_at_least: Final = 0 if fields.clear_at_least is None else fields.clear_at_least.value exclude_tools: Final = frozenset(fields.exclude_tools or ()) @@ -326,7 +335,7 @@ def apply_clear_tool_uses_20250919( "value": DEFAULT_KEEP_TOOL_USES, } - blocks: Final = _all_blocks(messages) + blocks: Final = _all_blocks(kept) results: Final = _blocks_by_id(blocks, "tool_result", "tool_use_id") uses: Final = _blocks_by_id(blocks, "tool_use", "id") tiny: Final = _tiny_result_ids(results) @@ -335,15 +344,15 @@ def apply_clear_tool_uses_20250919( for tool_use_id, name in _tool_uses_in_order(blocks) if name not in exclude_tools and (tool_use_id not in tiny or _clears_input(name, input_tools)) ) - met, counted_tokens = _trigger_met(trigger, model, messages, tools, len(clearable)) - if not met: - return messages, None - keep_count: Final = _resolve_keep_count(keep) if len(clearable) <= keep_count: return messages, None - last_completed_id: Final = _last_completed_tool_use_id(messages) + met, counted_tokens = _trigger_met(trigger, model, kept, tools, counted_system, len(clearable)) + if not met: + return messages, None + + last_completed_id: Final = _last_completed_tool_use_id(kept) candidates: Final = tuple( (tool_use_id, name) for tool_use_id, name in clearable[: len(clearable) - keep_count] @@ -358,7 +367,7 @@ def apply_clear_tool_uses_20250919( _select_in_batches(candidate_ids, tokens, clear_at_least) if clear_at_least > 0 else candidate_ids ) - edited, cleared_count = _clear_tool_results(messages, set(ids_to_clear)) + edited, cleared_count = _clear_tool_results(messages, ids_to_clear) verbose_logger.debug("context_management polyfill: edited: %s", edited) if cleared_count == 0: return messages, None @@ -370,11 +379,12 @@ def apply_clear_tool_uses_20250919( counted_tokens if counted_tokens is not None else litellm.token_counter( - model=model, messages=messages, tools=cast("list[ChatCompletionToolParam] | None", tools) + model=model, messages=kept, tools=cast("list[ChatCompletionToolParam] | None", tools) ) ) + kept_after, _ = history_after_client_compaction(final_messages, system) tokens_after: Final = litellm.token_counter( - model=model, messages=final_messages, tools=cast("list[ChatCompletionToolParam] | None", tools) + model=model, messages=kept_after, tools=cast("list[ChatCompletionToolParam] | None", tools) ) cleared_input_tokens: Final = max(tokens_before - tokens_after, 0) diff --git a/litellm/llms/anthropic/messages/context_management/editors/compact.py b/litellm/llms/anthropic/messages/context_management/editors/compact.py index 254d1c4c058..0bf8cac7344 100644 --- a/litellm/llms/anthropic/messages/context_management/editors/compact.py +++ b/litellm/llms/anthropic/messages/context_management/editors/compact.py @@ -189,6 +189,21 @@ def _strip_compaction_blocks( return cleaned +def history_after_client_compaction( + messages: Sequence[dict[str, object]], + system: str | Sequence[Mapping[str, object]] | None, +) -> tuple[list[dict[str, object]], str | Sequence[Mapping[str, object]] | None]: + """Return the history the API keeps after the latest compaction block, without it, and the system with its summary.""" + sliced, block = _slice_around_compaction_block(messages) + if block is None: + return list(messages), system + tail: Final = _strip_compaction_blocks(sliced) + summary: Final = block.get("content") + if not isinstance(summary, str) or not summary: + return tail, system + return tail, _augment_system_with_summary(_system_to_text(system) or None, summary) + + def _augment_system_with_summary( system: str | list[dict[str, object]] | None, summary_text: str, @@ -320,14 +335,16 @@ def _count_effective_tokens( content: Final = compaction_block.get("content") or "" if content: total += litellm.token_counter(model=model, text=content) + return total + count_system_tokens(model, system) + + +def count_system_tokens(model: str, system: str | Sequence[Mapping[str, object]] | None) -> int: system_text: Final = _system_to_text(system) - if system_text: - total += litellm.token_counter(model=model, text=system_text) - return total + return litellm.token_counter(model=model, text=system_text) if system_text else 0 def _system_to_text( - system: str | list[dict[str, object]] | None, + system: str | Sequence[Mapping[str, object]] | None, ) -> str: """Flatten an Anthropic-style ``system`` value into a single string for token counting. Returns ``""`` when ``system`` carries no text.""" @@ -338,7 +355,7 @@ def _system_to_text( return "\n".join( text for block in system - if isinstance(block, dict) + if isinstance(block, Mapping) and block.get("type") == "text" and isinstance(text := block.get("text"), str) and text diff --git a/tests/unit/llms/anthropic/messages/context_management/test_clear_tool_uses.py b/tests/unit/llms/anthropic/messages/context_management/test_clear_tool_uses.py index 2567d1b76db..f03ffb25b2b 100644 --- a/tests/unit/llms/anthropic/messages/context_management/test_clear_tool_uses.py +++ b/tests/unit/llms/anthropic/messages/context_management/test_clear_tool_uses.py @@ -10,7 +10,7 @@ from unittest.mock import AsyncMock, MagicMock import pytest import litellm -from litellm.llms.anthropic.messages.adapters.handler import _run_polyfill_if_enabled +from litellm.llms.anthropic.messages.adapters.handler import _run_polyfill_if_enabled, prepare_context_managed_request from litellm.llms.anthropic.messages.context_management import ( AnthropicContextManagementError, PolyfillResult, @@ -690,6 +690,115 @@ def test_tool_uses_trigger_does_not_count_excluded_tools(trigger_value: int, tri assert (applied is not None) == triggers +@pytest.mark.parametrize( + "system", + ["Reference notes. " * 400, [{"type": "text", "text": "Reference notes. " * 400}]], + ids=["string", "blocks"], +) +def test_input_tokens_trigger_counts_the_system_prompt(system: str | list[dict[str, object]]) -> None: + """Like the API, the trigger compares the whole prompt: a system prompt can push it over.""" + messages = _make_history(n_pairs=3) + history_tokens: Final = litellm.token_counter(model=MODEL, messages=messages) + edit_spec: Final = { + "type": "clear_tool_uses_20250919", + "trigger": {"type": "input_tokens", "value": history_tokens + 100}, + "keep": {"type": "tool_uses", "value": 1}, + } + _, without_system = apply_clear_tool_uses_20250919( + model=MODEL, messages=deepcopy(messages), tools=None, system=None, edit_spec=edit_spec + ) + _, with_system = apply_clear_tool_uses_20250919( + model=MODEL, messages=deepcopy(messages), tools=None, system=system, edit_spec=edit_spec + ) + _, met_without_system = apply_clear_tool_uses_20250919( + model=MODEL, + messages=deepcopy(messages), + tools=None, + system=None, + edit_spec={**edit_spec, "trigger": {"type": "input_tokens", "value": 0}}, + ) + assert without_system is None + assert with_system is not None + assert met_without_system is not None + assert with_system["cleared_tool_uses"] == 2 + assert with_system["cleared_input_tokens"] == met_without_system["cleared_input_tokens"] > 0 + + +@pytest.mark.parametrize("compact_position", [None, "after", "before"], ids=["alone", "before_compact", "after_compact"]) +async def test_input_tokens_trigger_counts_a_client_compaction_summary(compact_position: str | None) -> None: + """A client compaction summary counts toward the trigger and calls beside it stay clearable, in any edit order.""" + tail: Final = _make_history(n_pairs=3) + edit_spec: Final = { + "type": "clear_tool_uses_20250919", + "trigger": {"type": "input_tokens", "value": litellm.token_counter(model=MODEL, messages=tail) + 100}, + "keep": {"type": "tool_uses", "value": 1}, + } + compaction: Final = {"type": "compaction", "content": "Earlier work. " * 400} + compacted_history: Final = [tail[0], {**tail[1], "content": [compaction, *tail[1]["content"]]}, *tail[2:]] + compact_spec: Final = {"type": "compact_20260112", "trigger": {"type": "input_tokens", "value": 50_000}} + edits: Final = {None: [edit_spec], "after": [edit_spec, compact_spec], "before": [compact_spec, edit_spec]}[ + compact_position + ] + + async def prepare(messages: list[dict[str, object]]) -> PolyfillResult | None: + return await prepare_context_managed_request( + model=MODEL, + messages=messages, + tools=None, + system=None, + context_management_spec={"edits": edits}, + litellm_metadata=None, + additional_drop_params=None, + llm_router=None, + ) + + def cleared(result: PolyfillResult | None) -> list[object]: + applied: Final = result.applied_edits if result is not None else [] + return [edit.get("cleared_tool_uses") for edit in applied if edit.get("type") == "clear_tool_uses_20250919"] + + without_summary: Final = await prepare(deepcopy(tail)) + with_summary: Final = await prepare(deepcopy(compacted_history)) + + assert cleared(without_summary) == [] + assert cleared(with_summary) == [2] + + +async def test_compact_after_clearing_replaces_the_client_compaction_summary(monkeypatch: pytest.MonkeyPatch) -> None: + from litellm.proxy.proxy_server import general_settings + + monkeypatch.setitem(general_settings, COMPACT_SUMMARY_MODEL_SETTING_KEY, "summary-model") + summary: Final = MagicMock() + summary.choices = [MagicMock(message=MagicMock(content="Fresh summary"))] + summary.usage = MagicMock(prompt_tokens=50, completion_tokens=100) + router: Final = MagicMock() + router.acompletion = AsyncMock(return_value=summary) + tail: Final = _make_history(n_pairs=3) + result: Final = await prepare_context_managed_request( + model=MODEL, + messages=[{"role": "assistant", "content": [{"type": "compaction", "content": "Old summary. " * 20_000}]}, *tail], + tools=None, + system="You are a helpful assistant.", + context_management_spec={ + "edits": [ + { + "type": "clear_tool_uses_20250919", + "trigger": {"type": "input_tokens", "value": 1_000}, + "keep": {"type": "tool_uses", "value": 1}, + }, + {"type": "compact_20260112", "trigger": {"type": "input_tokens", "value": 50_000}}, + ] + }, + litellm_metadata=None, + additional_drop_params=None, + llm_router=router, + ) + assert result is not None + assert isinstance(result.system, str) + assert "Fresh summary" in result.system + assert "Old summary" not in result.system + assert result.system.endswith("You are a helpful assistant.") + + @pytest.mark.parametrize(("clear_tool_inputs", "triggers"), [(False, False), (True, True)]) def test_tool_uses_trigger_counts_tiny_results_only_when_their_inputs_are_cleared( clear_tool_inputs: bool, triggers: bool diff --git a/tests/unit/llms/anthropic/messages/context_management/test_dispatcher.py b/tests/unit/llms/anthropic/messages/context_management/test_dispatcher.py index b79e33b0c3b..fabb05c2e61 100644 --- a/tests/unit/llms/anthropic/messages/context_management/test_dispatcher.py +++ b/tests/unit/llms/anthropic/messages/context_management/test_dispatcher.py @@ -151,6 +151,7 @@ async def test_sync_editor_counts_tokens_off_the_event_loop(): { "type": "clear_tool_uses_20250919", "trigger": {"type": "input_tokens", "value": 10_000_000}, + "keep": {"type": "tool_uses", "value": 0}, } ] }, From a11e76fe8f861b91664935ec8a997fdc2cfd8a01 Mon Sep 17 00:00:00 2001 From: zoveki <349028329+zoveki@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:46:06 -0700 Subject: [PATCH 07/23] fix(google_genai): read one-object and null spellings of repeated fields in countTokens and generateContent (#48771) * fix(count_tokens): normalize Google system parts and null tools * fix(count_tokens): preserve typed validator return * fix(count_tokens): validate single system part without typing.cast * fix(count_tokens): accept every Google spelling of a repeated field Google countTokens now reads a repeated field sent as one object, null, or a list with null items the same way as its list form, for system parts, tools, and function declarations, matching what Vertex accepts. * fix(count_tokens): read every Google spelling of contents and skip null system text contents and each content's parts now read one object, null, and null items like their list form, the same as system parts and tools. A one-object parts used to translate to no messages, so non-Google models counted it as empty. A system part whose text is null is skipped, as Vertex AI does. * fix(google_genai): read null-text media system parts as media and one-object content parts on generateContent * fix(google_proxy): count null-text system parts that carry only part metadata, like Vertex AI A system part with null or missing text and only metadata such as thought or thoughtSignature, or an empty part, now counts as empty instead of answering 400. Parts that carry an image or file with null text still answer 400. --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- .../google_genai/adapters/transformation.py | 7 +- litellm/proxy/google_endpoints/endpoints.py | 73 +++++++++++++-- .../google_genai/test_google_genai_adapter.py | 12 +++ .../proxy/google_endpoints/test_endpoints.py | 90 ++++++++++++++++++- 4 files changed, 172 insertions(+), 10 deletions(-) diff --git a/litellm/google_genai/adapters/transformation.py b/litellm/google_genai/adapters/transformation.py index e1085dd7857..c1895376675 100644 --- a/litellm/google_genai/adapters/transformation.py +++ b/litellm/google_genai/adapters/transformation.py @@ -198,6 +198,11 @@ def _genai_message_part(part: object) -> _GenAIMessagePart | None: return ChatCompletionTextObject(type="text", text=text) if isinstance(text, str) else _genai_media_part(fields) +def _genai_content_parts(value: object) -> Sequence[object]: + single_part: Final = _validated(_CONFIG_FIELDS, value) + return (single_part,) if single_part is not None else _validated(_GENAI_CONTENT_PARTS, value) or () + + def _genai_message_parts(parts: object) -> tuple[_GenAIMessagePart, ...]: items: Final = _validated(_GENAI_CONTENT_PARTS, parts) or () return tuple(converted for part in items if (converted := _genai_message_part(part)) is not None) @@ -248,7 +253,7 @@ def _genai_content_messages(content: object) -> tuple[AllMessageValues, ...]: fields: Final = _validated(_CONFIG_FIELDS, content) if fields is None: return () - parts: Final = _validated(_GENAI_CONTENT_PARTS, fields.get("parts", ())) or () + parts: Final = _genai_content_parts(fields.get("parts", ())) converted: Final = _genai_message_parts(parts) role: Final = fields.get("role", "user") if role == "user": diff --git a/litellm/proxy/google_endpoints/endpoints.py b/litellm/proxy/google_endpoints/endpoints.py index 54976857584..c018f071b3c 100644 --- a/litellm/proxy/google_endpoints/endpoints.py +++ b/litellm/proxy/google_endpoints/endpoints.py @@ -1,11 +1,11 @@ from collections.abc import Mapping from itertools import chain from types import MappingProxyType -from typing import Final +from typing import Annotated, Final from fastapi import APIRouter, Depends, HTTPException, Request, Response from fastapi.responses import JSONResponse, ORJSONResponse -from pydantic import BaseModel, ConfigDict, Field, JsonValue, TypeAdapter, ValidationError +from pydantic import BaseModel, BeforeValidator, ConfigDict, Field, JsonValue, TypeAdapter, ValidationError from litellm.litellm_core_utils.json_validation_rule import normalize_json_schema_types from litellm.proxy._types import * @@ -27,14 +27,67 @@ from litellm.proxy.common_utils.token_count_settings import count_source_fields from litellm.types.llms.vertex_ai import TokenCountDetailsResponse +def _google_repeated_field(value: JsonValue) -> JsonValue: + match value: + case None: + return [] + case dict(): + return [value] + case list(): + return [item for item in value if item is not None] + case _: + return value + + +def _google_content(value: JsonValue) -> JsonValue: + match value: + case {"parts": parts}: + return {**value, "parts": _google_repeated_field(parts)} + case _: + return value + + +def _google_contents(value: JsonValue) -> JsonValue: + match _google_repeated_field(value): + case list() as contents: + return [_google_content(content) for content in contents] + case other: + return other + + +_GOOGLE_PART_TEXT_AND_METADATA_FIELDS: Final = frozenset( + {"text", "thought", "thoughtSignature", "thought_signature", "partMetadata", "part_metadata"} +) + + +def _google_part_has_non_text_content(part: Mapping[str, JsonValue]) -> bool: + return any(field is not None for key, field in part.items() if key not in _GOOGLE_PART_TEXT_AND_METADATA_FIELDS) + + +def _google_system_part(value: JsonValue) -> JsonValue: + match value: + case dict() if value.get("text") is None and _google_part_has_non_text_content(value): + return {key: field for key, field in value.items() if key != "text"} + case dict(): + return {"text": None, **value} + case _: + return value + + +_GOOGLE_REPEATED_FIELD: Final = BeforeValidator(_google_repeated_field) + + class _GoogleCountTokensTextPart(BaseModel): model_config = ConfigDict(frozen=True) - text: str + text: str | None class _GoogleCountTokensSystemInstruction(BaseModel): model_config = ConfigDict(frozen=True) - parts: tuple[_GoogleCountTokensTextPart, ...] + parts: Annotated[ + tuple[Annotated[_GoogleCountTokensTextPart, BeforeValidator(_google_system_part)], ...], + _GOOGLE_REPEATED_FIELD, + ] = () class _GoogleCountTokensFunctionDeclaration(BaseModel): @@ -47,16 +100,16 @@ class _GoogleCountTokensFunctionDeclaration(BaseModel): class _GoogleCountTokensTool(BaseModel): model_config = ConfigDict(frozen=True, populate_by_name=True) - function_declarations: tuple[_GoogleCountTokensFunctionDeclaration, ...] = Field( + function_declarations: Annotated[tuple[_GoogleCountTokensFunctionDeclaration, ...], _GOOGLE_REPEATED_FIELD] = Field( default=(), alias="functionDeclarations" ) class _GoogleCountTokensRequest(BaseModel): model_config = ConfigDict(frozen=True, extra="ignore", populate_by_name=True) - contents: tuple[Mapping[str, JsonValue], ...] = () + contents: Annotated[tuple[Mapping[str, JsonValue], ...], BeforeValidator(_google_contents)] = () system_instruction: _GoogleCountTokensSystemInstruction | None = Field(default=None, alias="systemInstruction") - tools: tuple[_GoogleCountTokensTool, ...] = () + tools: Annotated[tuple[_GoogleCountTokensTool, ...], _GOOGLE_REPEATED_FIELD] = () router: Final = APIRouter( @@ -112,7 +165,11 @@ def _google_count_tokens_request(model_name: str, data: object) -> TokenCountReq GoogleGenAIAdapter().translate_generate_content_to_completion(model_name, contents).get("messages", []) ) system: Final = ( - [{"type": "text", "text": part.text} for part in validated_data.system_instruction.parts] + [ + {"type": "text", "text": part.text} + for part in validated_data.system_instruction.parts + if part.text is not None + ] if validated_data.system_instruction is not None else None ) diff --git a/tests/unit/google_genai/test_google_genai_adapter.py b/tests/unit/google_genai/test_google_genai_adapter.py index 0292e58c029..4ab642dc99d 100644 --- a/tests/unit/google_genai/test_google_genai_adapter.py +++ b/tests/unit/google_genai/test_google_genai_adapter.py @@ -158,6 +158,18 @@ def test_native_function_response_preserves_json_when_media_is_malformed(invalid assert messages == [{"role": "tool", "tool_call_id": "call_lookup", "content": '{"ok": true}'}] +@pytest.mark.parametrize("role", ["user", "model"]) +def test_one_object_content_parts_translate_like_their_list_form(role: str) -> None: + part: Final = {"text": "Reply with OK"} + + def messages(parts: object) -> object: + return GoogleGenAIAdapter().translate_generate_content_to_completion( + model="anthropic/claude-haiku-5-5", contents=[{"role": role, "parts": parts}] + )["messages"] + + assert messages(part) == messages([part]) != [] + + @pytest.mark.parametrize( ("args", "expected_arguments"), [(None, "null"), ('{"query":"x"}', '"{\\"query\\":\\"x\\"}"')], diff --git a/tests/unit/proxy/google_endpoints/test_endpoints.py b/tests/unit/proxy/google_endpoints/test_endpoints.py index 80e45edf897..9dd2e267e64 100644 --- a/tests/unit/proxy/google_endpoints/test_endpoints.py +++ b/tests/unit/proxy/google_endpoints/test_endpoints.py @@ -6,7 +6,7 @@ from typing import Final import pytest from dotenv import load_dotenv -from pydantic import JsonValue +from pydantic import JsonValue, ValidationError from starlette.requests import Request from litellm.proxy.google_endpoints.endpoints import _google_count_tokens_request, google_count_tokens @@ -105,3 +105,91 @@ async def test_proxy_gemini_to_openai_like_model_token_counting(): ) assert response.get("totalTokens") > 0 + + +_DECLARATION: Final = {"name": "lookup", "description": "Find a record"} +_SYSTEM: Final = {"systemInstruction": {"parts": [{"text": "Follow these rules"}]}} +_NO_SYSTEM_PARTS: Final = {"systemInstruction": {"parts": []}} +_TOOLS: Final = {"tools": [{"functionDeclarations": [_DECLARATION]}]} +_TURN: Final = {"role": "user", "parts": [{"text": "Count this request"}]} +_CONTENTS: Final = {"contents": [_TURN]} + + +@pytest.mark.parametrize( + ("spelled", "canonical"), + ( + ({"systemInstruction": {"parts": {"text": "Follow these rules"}}}, _SYSTEM), + ({"system_instruction": {"parts": {"text": "Follow these rules"}}}, _SYSTEM), + ({"systemInstruction": {"parts": [{"text": "Follow these rules"}, None]}}, _SYSTEM), + ({"systemInstruction": {"parts": None}}, _NO_SYSTEM_PARTS), + ({"systemInstruction": {"parts": [{"text": None}, {"text": "Follow these rules"}]}}, _SYSTEM), + ({"systemInstruction": {"parts": {"text": None}}}, _NO_SYSTEM_PARTS), + ({"systemInstruction": {"parts": {"text": None, "inlineData": None}}}, _NO_SYSTEM_PARTS), + ({"systemInstruction": {"parts": {"text": None, "thought": False}}}, _NO_SYSTEM_PARTS), + ({"systemInstruction": {"parts": [{"thoughtSignature": "c2ln"}, {"text": "Follow these rules"}]}}, _SYSTEM), + ({"systemInstruction": {"parts": [{}]}}, _NO_SYSTEM_PARTS), + ({"systemInstruction": {}}, _NO_SYSTEM_PARTS), + ({"tools": None}, {}), + ({"tools": [None]}, {}), + ({"tools": [{"functionDeclarations": None}]}, {}), + ({"tools": {"functionDeclarations": [_DECLARATION]}}, _TOOLS), + ({"tools": [{"functionDeclarations": _DECLARATION}]}, _TOOLS), + ({"tools": {"functionDeclarations": _DECLARATION}}, _TOOLS), + ({"contents": _TURN}, _CONTENTS), + ({"contents": [None, _TURN]}, _CONTENTS), + ({"contents": None}, {"contents": []}), + ({"contents": [{"role": "user", "parts": {"text": "Count this request"}}]}, _CONTENTS), + ({"contents": [{"role": "user", "parts": [None, {"text": "Count this request"}]}]}, _CONTENTS), + ({"contents": [{"role": "user", "parts": None}]}, {"contents": [{"role": "user", "parts": []}]}), + ), +) +def test_google_count_tokens_counts_every_google_spelling_of_a_repeated_field_like_its_list_form( + spelled: dict[str, JsonValue], canonical: dict[str, JsonValue] +) -> None: + contents: Final = [{"role": "user", "parts": [{"text": "Count this request"}]}] + + assert _google_count_tokens_request("counted", {"contents": contents, **spelled}) == _google_count_tokens_request( + "counted", {"contents": contents, **canonical} + ) + + +@pytest.mark.parametrize( + "malformed", + ( + {"tools": "lookup"}, + {"tools": [{"functionDeclarations": "lookup"}]}, + {"systemInstruction": {"parts": 7}}, + {"contents": 5}, + {"contents": ["Count this request"]}, + ), +) +def test_google_count_tokens_rejects_a_scalar_where_google_expects_an_object_or_list( + malformed: dict[str, JsonValue], +) -> None: + with pytest.raises(ValidationError): + _google_count_tokens_request("counted", {"contents": [_TURN], **malformed}) + + +@pytest.mark.parametrize( + "parts", + ( + {"inlineData": {"mimeType": "image/png", "data": "aGVsbG8="}}, + [{"inlineData": {"mimeType": "image/png", "data": "aGVsbG8="}}], + {"text": None, "inlineData": {"mimeType": "image/png", "data": "aGVsbG8="}}, + [{"text": "Follow these rules"}, {"text": None, "fileData": {"fileUri": "gs://bucket/rules.pdf"}}], + ), +) +def test_google_count_tokens_rejects_media_only_system_parts(parts: JsonValue) -> None: + with pytest.raises(ValidationError): + _google_count_tokens_request( + "counted", + {"contents": [{"role": "user", "parts": [{"text": "Hello"}]}], "systemInstruction": {"parts": parts}}, + ) + + +def test_google_count_tokens_keeps_counting_system_text_that_sits_beside_media() -> None: + text_with_media: Final = {"text": "Follow these rules", "inlineData": {"mimeType": "image/png", "data": "aGVsbG8="}} + + assert _google_count_tokens_request( + "counted", {**_CONTENTS, "systemInstruction": {"parts": [text_with_media]}} + ) == _google_count_tokens_request("counted", {**_CONTENTS, **_SYSTEM}) From cbf4e40d381042e454209f8c54cfb3e76062ceb4 Mon Sep 17 00:00:00 2001 From: tavren27 <348969968+tavren27@users.noreply.github.com> Date: Wed, 28 Oct 2026 21:49:03 -0700 Subject: [PATCH 08/23] fix(proxy)!: stop labelling management and health rejections as auth failures (#48739) * test(proxy): cover management and health routes labelling rejections as auth failures * fix(proxy): name management and health route errors by their status instead of auth_error * fix(proxy): keep auth_error for 401 and 403 and answer database outages with 503 in route catch-alls /key/list and /key/aliases now share the catch-all helper too, so they stop adding the Authentication Error prefix and typing a 400 as internal_server_error * fix(proxy): answer 503 when the database drops mid-query and prisma fails to name the error A real outage surfaces from prisma's query engine as a builtin AttributeError, which the prisma-module check skipped, so the route catch-alls still answered 500 or 400 * fix(proxy): report wrapped and stalled database outages as 503 and label upstream failures by their own status * fix(proxy): answer the upstream status on the catch-all, keep auth_error on tag denials, report model insert outages as 503 * fix(proxy): answer 503 for database failovers and label provider auth errors like chat A database that refuses connections while starting up, shutting down, in recovery, or read-only after a failover now answers 503 no_db_connection instead of 400. A provider's 401 or 403 keeps the type /chat/completions gives it, while a 401 or 403 the proxy raises keeps auth_error. An exception with no message is named by its type. * fix(proxy): scope failover 503s to management route errors and keep a re-raised error's cause * test(proxy): expect the OpenAI error shape from management route refusals Team-not-found 404s now answer invalid_request_error, and every handler-raised refusal answers param null instead of the string None. --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- litellm/proxy/_types.py | 18 +- .../common_utils/openai_error_payload.py | 96 +++++- litellm/proxy/db/exception_handler.py | 4 +- .../health_endpoints/_health_endpoints.py | 20 +- .../internal_user_endpoints.py | 19 +- .../key_management_endpoints.py | 55 +--- .../model_management_endpoints.py | 69 ++-- .../organization_endpoints.py | 19 +- .../management_endpoints/team_endpoints.py | 19 +- litellm/proxy/proxy_server.py | 59 +--- .../authorization/test_team_admin_gate.py | 2 +- .../test_user_self_update_guard.py | 4 +- .../test_team_delete_large_membership.py | 4 +- .../common_utils/test_openai_error_payload.py | 294 ++++++++++++++++++ .../health_endpoints/test_health_endpoints.py | 9 + .../test_internal_user_endpoints.py | 15 + .../test_key_management_endpoints.py | 72 ++++- .../test_model_management_endpoints.py | 75 ++++- .../test_organization_endpoints.py | 31 ++ .../test_team_endpoints.py | 45 +++ tests/unit/proxy/test_proxy_server.py | 99 ++++++ 21 files changed, 808 insertions(+), 220 deletions(-) diff --git a/litellm/proxy/_types.py b/litellm/proxy/_types.py index 5ce6cd93a22..df139a9b84d 100644 --- a/litellm/proxy/_types.py +++ b/litellm/proxy/_types.py @@ -3816,6 +3816,16 @@ class ManagementEndpointLoggingPayload(LiteLLMPydanticObjectBase): end_time: datetime | None = None +def proxy_exception_status_code(message: str, code: str) -> str: + # Litellm router.py returns "No healthy deployment available" when there are no deployments available + # Should map to 429 errors https://github.com/BerriAI/litellm/issues/2487 + if "No healthy deployment available" in message or "No deployments available" in message: + return "429" + if RouterErrors.no_deployments_with_tag_routing.value in message: + return "401" + return code + + class ProxyException(Exception): # NOTE: DO NOT MODIFY THIS # This is used to map exactly to OPENAI Exceptions @@ -3844,13 +3854,7 @@ class ProxyException(Exception): headers[k] = str(v) self.headers = headers or {} self.provider_specific_fields = provider_specific_fields - # rules for proxyExceptions - # Litellm router.py returns "No healthy deployment available" when there are no deployments available - # Should map to 429 errors https://github.com/BerriAI/litellm/issues/2487 - if "No healthy deployment available" in self.message or "No deployments available" in self.message: - self.code = "429" - elif RouterErrors.no_deployments_with_tag_routing.value in self.message: - self.code = "401" + self.code = proxy_exception_status_code(self.message, self.code) def to_dict(self) -> dict: """Converts the ProxyException instance to a dictionary.""" diff --git a/litellm/proxy/common_utils/openai_error_payload.py b/litellm/proxy/common_utils/openai_error_payload.py index 2f01dbe11f7..3c91e87ee51 100644 --- a/litellm/proxy/common_utils/openai_error_payload.py +++ b/litellm/proxy/common_utils/openai_error_payload.py @@ -2,14 +2,17 @@ ``type`` is a required string and ``param`` is nullable, neither of which the literal string ``"None"`` satisfies.""" +import sys from collections.abc import Mapping from types import MappingProxyType from typing import Final -from fastapi import status +from fastapi import HTTPException, status from litellm.constants import STRINGIFIED_NONE -from litellm.proxy._types import ProxyException +from litellm.proxy._types import ProxyErrorTypes, ProxyException, proxy_exception_status_code +from litellm.proxy.db.db_lookup_gate import DBLookupDeadlineExceeded +from litellm.proxy.db.exception_handler import PrismaDBExceptionHandler, exception_chain LITELLM_CALL_ID_HEADER: Final = "x-litellm-call-id" @@ -21,6 +24,19 @@ _OPENAI_ERROR_TYPE_BY_STATUS: Final[Mapping[int, str]] = MappingProxyType( } ) +_AUTH_FAILURE_STATUS_CODES: Final = frozenset({status.HTTP_401_UNAUTHORIZED, status.HTTP_403_FORBIDDEN}) + +_FAILOVER_SQLSTATES: Final = frozenset({"25006", "57P01", "57P02", "57P03"}) + +_FAILOVER_REFUSALS: Final = ( + "is not currently accepting connections", + "the database system is starting up", + "the database system is shutting down", + "the database system is in recovery mode", + "the database system is not yet accepting connections", + "terminating connection due to administrator command", +) + def attribute_of(value: object, name: str, default: object = None) -> object: return getattr(value, name, default) @@ -61,6 +77,82 @@ def openai_error_param(exc: object) -> str | None: return carried if isinstance(carried, str) and carried != STRINGIFIED_NONE else None +def proxy_exception_for(exc: Exception, default_status_code: int) -> ProxyException: + match exc: + case ProxyException(): + return exc + case _ if _is_database_outage(exc): + return ProxyException( + message=PrismaDBExceptionHandler.database_unavailable_message(exc), + type=ProxyErrorTypes.no_db_connection.value, + param=None, + code=status.HTTP_503_SERVICE_UNAVAILABLE, + ) + case HTTPException(status_code=status_code, detail=detail): + return _openai_shaped_proxy_exception(exc, str(detail), status_code) + case _: + return _openai_shaped_proxy_exception( + exc, str(exc) or type(exc).__name__, error_status_code(exc, default_status_code) + ) + + +def _is_database_outage(exc: Exception) -> bool: + return any(map(_is_database_outage_link, exception_chain(exc))) + + +def _is_database_outage_link(exc: BaseException) -> bool: + match exc: + case DBLookupDeadlineExceeded(): + return True + case Exception() if _prisma_is_loaded(): + return _is_prisma_outage(exc) + case _: + return False + + +def _prisma_is_loaded() -> bool: + return sys.modules.get("prisma") is not None + + +def _is_prisma_outage(exc: Exception) -> bool: + if PrismaDBExceptionHandler.is_prisma_engine_internal_error(exc): + return True + if type(exc).__module__.partition(".")[0] != "prisma": + return False + return PrismaDBExceptionHandler.is_database_service_unavailable_error(exc) or _is_failover_refusal(exc) + + +def _is_failover_refusal(exc: Exception) -> bool: + if PrismaDBExceptionHandler.is_read_only_transaction_error(exc): + return True + if PrismaDBExceptionHandler.postgres_sqlstate(exc) in _FAILOVER_SQLSTATES: + return True + message: Final = str(exc).lower() + return any(refusal in message for refusal in _FAILOVER_REFUSALS) + + +def _openai_shaped_proxy_exception(exc: Exception, message: str, status_code: int) -> ProxyException: + answered_status: Final = int(proxy_exception_status_code(message, str(status_code))) + return ProxyException( + message=message, + type=_catch_all_error_type(exc, answered_status), + param=openai_error_param(exc), + code=answered_status, + ) + + +def _catch_all_error_type(exc: Exception, status_code: int) -> str: + if _rejects_the_caller(exc, status_code): + return ProxyErrorTypes.auth_error.value + return openai_error_type(exc, status_code) + + +def _rejects_the_caller(exc: Exception, status_code: int) -> bool: + raised_as_http_answer: Final = isinstance(exc, HTTPException) + status_from_upstream: Final = error_status_code(exc, 0) == status_code + return status_code in _AUTH_FAILURE_STATUS_CODES and (raised_as_http_answer or not status_from_upstream) + + def litellm_call_id_headers(litellm_call_id: str | None) -> dict[str, str] | None: # mutable-ok: ProxyException.headers if litellm_call_id is None: return None diff --git a/litellm/proxy/db/exception_handler.py b/litellm/proxy/db/exception_handler.py index 5dfcaa4b2f8..3f7ea334a99 100644 --- a/litellm/proxy/db/exception_handler.py +++ b/litellm/proxy/db/exception_handler.py @@ -36,7 +36,7 @@ _LOCK_TIMEOUT_SQLSTATE: Final = "55P03" _LOCK_TIMEOUT_PHRASE: Final = "canceling statement due to lock timeout" -def _exception_chain(e: BaseException) -> Iterator[BaseException]: +def exception_chain(e: BaseException) -> Iterator[BaseException]: current = e # rebind-ok: advances one link per iteration of the bounded walk for _ in range(_MAX_EXCEPTION_CHAIN_DEPTH): yield current @@ -49,7 +49,7 @@ def _exception_chain(e: BaseException) -> Iterator[BaseException]: def _database_service_unavailable_errors(e: BaseException) -> tuple[Exception, ...]: return tuple( link - for link in _exception_chain(e) + for link in exception_chain(e) if isinstance(link, Exception) and PrismaDBExceptionHandler.is_database_service_unavailable_error(link) ) diff --git a/litellm/proxy/health_endpoints/_health_endpoints.py b/litellm/proxy/health_endpoints/_health_endpoints.py index 869e4953df0..396a00ab1a1 100644 --- a/litellm/proxy/health_endpoints/_health_endpoints.py +++ b/litellm/proxy/health_endpoints/_health_endpoints.py @@ -32,7 +32,6 @@ from litellm.proxy._types import ( EnterpriseLicenseData, Litellm_EntityType, LitellmUserRoles, - ProxyErrorTypes, ProxyException, SpecialModelNames, UserAPIKeyAuth, @@ -47,6 +46,7 @@ from litellm.proxy.auth.auth_utils import ( from litellm.proxy.auth.model_checks import get_key_models from litellm.proxy.auth.user_api_key_auth import user_api_key_auth from litellm.proxy.common_utils import http_parsing_utils +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.db.db_lookup_gate import db_lookup_stall_tracker from litellm.proxy.db.exception_handler import PrismaDBExceptionHandler from litellm.proxy.db.health_check_latest import ( @@ -683,21 +683,9 @@ async def health_services_endpoint( except Exception as e: verbose_proxy_logger.error("litellm.proxy.proxy_server.health_services_endpoint(): Exception occured - %s", e) verbose_proxy_logger.debug(traceback.format_exc()) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_500_INTERNAL_SERVER_ERROR), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_500_INTERNAL_SERVER_ERROR, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_500_INTERNAL_SERVER_ERROR) from e def convert_health_check_to_dict(check) -> dict: diff --git a/litellm/proxy/management_endpoints/internal_user_endpoints.py b/litellm/proxy/management_endpoints/internal_user_endpoints.py index f2f0bc5be0b..bb901f22649 100644 --- a/litellm/proxy/management_endpoints/internal_user_endpoints.py +++ b/litellm/proxy/management_endpoints/internal_user_endpoints.py @@ -46,6 +46,7 @@ from litellm.proxy.auth.password_policy import ( ) from litellm.proxy.auth.user_api_key_auth import user_api_key_auth from litellm.proxy.common_utils.auth_cache_invalidation_pubsub import evict_and_broadcast +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.common_utils.user_api_key_cache import ( AUTH_OBJECTS_TARGET, object_permission_cache_key, @@ -1729,21 +1730,9 @@ async def user_update( except Exception as e: verbose_proxy_logger.exception("litellm.proxy.proxy_server.user_update(): Exception occured - %s", e) verbose_proxy_logger.debug(traceback.format_exc()) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e async def bulk_update_processed_users( diff --git a/litellm/proxy/management_endpoints/key_management_endpoints.py b/litellm/proxy/management_endpoints/key_management_endpoints.py index a19ecb8a9e9..55e59ca5776 100644 --- a/litellm/proxy/management_endpoints/key_management_endpoints.py +++ b/litellm/proxy/management_endpoints/key_management_endpoints.py @@ -75,6 +75,7 @@ from litellm.proxy.common_utils.config_sync_pubsub import ( coordination_redis_cache, publish_config_change, ) +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.common_utils.rbac_utils import check_org_admin_can_generate_keys from litellm.proxy.common_utils.timezone_utils import get_budget_reset_time from litellm.proxy.common_utils.user_api_key_cache import AUTH_OBJECTS_TARGET, UserApiKeyCache @@ -4087,21 +4088,9 @@ async def update_key_fn( # update based on remaining passed in values except Exception as e: verbose_proxy_logger.exception("litellm.proxy.proxy_server.update_key_fn(): Exception occured - %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e @router.post( @@ -7244,21 +7233,9 @@ async def list_keys( except Exception as e: verbose_proxy_logger.exception("Error in list_keys: %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"error({e})"), - type=ProxyErrorTypes.internal_server_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", fastapi.status.HTTP_500_INTERNAL_SERVER_ERROR), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.internal_server_error, - param=getattr(e, "param", "None"), - code=fastapi.status.HTTP_500_INTERNAL_SERVER_ERROR, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=fastapi.status.HTTP_500_INTERNAL_SERVER_ERROR) from e async def _apply_non_admin_alias_scope( @@ -7402,21 +7379,9 @@ async def key_aliases( except Exception as e: verbose_proxy_logger.exception("Error in key_aliases: %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"error({e})"), - type=ProxyErrorTypes.internal_server_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_500_INTERNAL_SERVER_ERROR), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.internal_server_error, - param=getattr(e, "param", "None"), - code=status.HTTP_500_INTERNAL_SERVER_ERROR, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_500_INTERNAL_SERVER_ERROR) from e def _validate_sort_params( diff --git a/litellm/proxy/management_endpoints/model_management_endpoints.py b/litellm/proxy/management_endpoints/model_management_endpoints.py index 8cd3559ba86..e7ad7d04070 100644 --- a/litellm/proxy/management_endpoints/model_management_endpoints.py +++ b/litellm/proxy/management_endpoints/model_management_endpoints.py @@ -77,6 +77,7 @@ from litellm.proxy.common_utils.encrypt_decrypt_utils import ( decrypt_value_helper, encrypt_value_helper, ) +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.common_utils.user_api_key_cache import UserApiKeyCache from litellm.proxy.db.routing_prisma_wrapper import WriterPinnedClient from litellm.proxy.management.teams.authz import TEAM_ADMIN_ONLY, is_team_admin @@ -2845,21 +2846,9 @@ async def delete_model( except Exception as e: verbose_proxy_logger.exception("Failed to delete model. Due to error - %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e async def delete_team_model_alias( @@ -2899,6 +2888,13 @@ async def delete_team_model_alias( return removed_model_aliases +def _model_not_added_to_db() -> HTTPException: + return HTTPException( + status_code=500, + detail={"error": "Failed to add model to db. Check your server logs for more details."}, + ) + + @router.post( "/model/new", description="Allows adding new models to the model list in the config.yaml", @@ -3080,6 +3076,8 @@ async def add_new_model( if isinstance(e, HTTPException): raise verbose_proxy_logger.exception("Exception in add_new_model: %s", e) + if model_response is None: + raise _model_not_added_to_db() from e else: raise HTTPException( @@ -3088,10 +3086,7 @@ async def add_new_model( ) if model_response is None: - raise HTTPException( - status_code=500, - detail={"error": "Failed to add model to db. Check your server logs for more details."}, - ) + raise _model_not_added_to_db() ## CREATE AUDIT LOG ## asyncio.create_task( @@ -3121,21 +3116,9 @@ async def add_new_model( except Exception as e: verbose_proxy_logger.exception("litellm.proxy.proxy_server.add_new_model(): Exception occured - %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e #### MODEL MANAGEMENT #### @@ -3364,21 +3347,9 @@ async def update_model( return None if model_response is None else _model_write_response(model_response, member_write) except Exception as e: verbose_proxy_logger.exception("litellm.proxy.proxy_server.update_model(): Exception occured - %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e @router.post( diff --git a/litellm/proxy/management_endpoints/organization_endpoints.py b/litellm/proxy/management_endpoints/organization_endpoints.py index e1d19d8efae..8a1b9c112dc 100644 --- a/litellm/proxy/management_endpoints/organization_endpoints.py +++ b/litellm/proxy/management_endpoints/organization_endpoints.py @@ -41,6 +41,7 @@ from litellm.proxy.auth.auth_checks import ( ) from litellm.proxy.auth.user_api_key_auth import user_api_key_auth from litellm.proxy.common_utils.auth_cache_invalidation_pubsub import evict_and_broadcast +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.common_utils.timezone_utils import get_budget_reset_time from litellm.proxy.common_utils.user_api_key_cache import UserApiKeyCache from litellm.proxy.management_endpoints.budget_management_endpoints import ( @@ -1396,21 +1397,9 @@ async def organization_member_add( ) except Exception as e: verbose_proxy_logger.exception("Error adding member to organization: %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_500_INTERNAL_SERVER_ERROR), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_500_INTERNAL_SERVER_ERROR, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_500_INTERNAL_SERVER_ERROR) from e async def find_member_if_email(user_email: str, prisma_client: PrismaClient) -> LiteLLM_UserTable: diff --git a/litellm/proxy/management_endpoints/team_endpoints.py b/litellm/proxy/management_endpoints/team_endpoints.py index a256f417dfa..50b700e712d 100644 --- a/litellm/proxy/management_endpoints/team_endpoints.py +++ b/litellm/proxy/management_endpoints/team_endpoints.py @@ -132,6 +132,7 @@ from litellm.proxy.common_utils.auth_cache_invalidation_pubsub import ( ) from litellm.proxy.common_utils.callback_utils import encrypt_callback_vars from litellm.proxy.common_utils.json_merge_patch import apply_json_merge_patch +from litellm.proxy.common_utils.openai_error_payload import proxy_exception_for from litellm.proxy.common_utils.user_api_key_cache import ( UserApiKeyCache, team_membership_auth_cache_key, @@ -5526,21 +5527,9 @@ async def team_info( e, traceback.format_exc(), ) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e @router.get( diff --git a/litellm/proxy/proxy_server.py b/litellm/proxy/proxy_server.py index d6ec62b25c2..bb8fffd85bc 100644 --- a/litellm/proxy/proxy_server.py +++ b/litellm/proxy/proxy_server.py @@ -524,6 +524,7 @@ from litellm.proxy.common_utils.openai_error_payload import ( LITELLM_CALL_ID_HEADER, headers_with_litellm_call_id, litellm_call_id_headers, + proxy_exception_for, with_litellm_call_id, ) from litellm.proxy.common_utils.periodic_reload_schedule import ( @@ -18536,25 +18537,13 @@ async def async_queue_request( await proxy_logging_obj.post_call_failure_hook( user_api_key_dict=user_api_key_dict, original_exception=e, request_data=data ) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - elif isinstance(e, litellm.BadRequestError): + if isinstance(e, litellm.BadRequestError): raise ProxyException( message=e.message, type="invalid_request_error", param=getattr(e, "param", None), code=e.status_code - ) - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + ) from e + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e @app.get("/fallback/login", tags=["experimental"], include_in_schema=False) @@ -19833,21 +19822,9 @@ async def update_config( except Exception as e: verbose_proxy_logger.error("litellm.proxy.proxy_server.update_config(): Exception occured - %s", e) verbose_proxy_logger.debug(traceback.format_exc()) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_400_BAD_REQUEST) from e ### CONFIG GENERAL SETTINGS @@ -21030,21 +21007,9 @@ async def get_config( } except Exception as e: verbose_proxy_logger.exception("litellm.proxy.proxy_server.get_config(): Exception occured - %s", e) - if isinstance(e, HTTPException): - raise ProxyException( - message=getattr(e, "detail", f"Authentication Error({e})"), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=getattr(e, "status_code", status.HTTP_400_BAD_REQUEST), - ) - elif isinstance(e, ProxyException): - raise e - raise ProxyException( - message="Authentication Error, " + str(e), - type=ProxyErrorTypes.auth_error, - param=getattr(e, "param", "None"), - code=status.HTTP_400_BAD_REQUEST, - ) + if isinstance(e, ProxyException): + raise + raise proxy_exception_for(e, default_status_code=status.HTTP_500_INTERNAL_SERVER_ERROR) from e @router.get( diff --git a/tests/integration/authorization/test_team_admin_gate.py b/tests/integration/authorization/test_team_admin_gate.py index a7513277609..eff4060631e 100644 --- a/tests/integration/authorization/test_team_admin_gate.py +++ b/tests/integration/authorization/test_team_admin_gate.py @@ -746,7 +746,7 @@ def test_internal_user_model_creation_prohibition_refuses_team_admin_but_not_pro "error": { "message": "Model creation is disabled for internal users by disable_model_add_for_internal_users.", "type": "auth_error", - "param": "None", + "param": None, "code": "403", } }, diff --git a/tests/integration/authorization/test_user_self_update_guard.py b/tests/integration/authorization/test_user_self_update_guard.py index d83960e1e85..d058b3c6998 100644 --- a/tests/integration/authorization/test_user_self_update_guard.py +++ b/tests/integration/authorization/test_user_self_update_guard.py @@ -38,7 +38,7 @@ def _escalation_error(field: str) -> dict[str, JsonValue]: "error": { "message": f"{{'error': \"Non-admin users cannot modify '{field}' on their own record. Contact your proxy admin.\"}}", "type": "auth_error", - "param": "None", + "param": None, "code": "403", } } @@ -49,7 +49,7 @@ def _role_change_error() -> dict[str, JsonValue]: "error": { "message": "Only proxy admins can modify user roles.", "type": "auth_error", - "param": "None", + "param": None, "code": "403", } } diff --git a/tests/integration/management/test_team_delete_large_membership.py b/tests/integration/management/test_team_delete_large_membership.py index 1a8140373b0..8b3c6b06bba 100644 --- a/tests/integration/management/test_team_delete_large_membership.py +++ b/tests/integration/management/test_team_delete_large_membership.py @@ -255,8 +255,8 @@ def _team_not_found_body(team_id: str) -> dict[str, JsonValue]: return { "error": { "message": f"{{'message': 'Team not found, passed team id: {team_id}.'}}", - "type": "auth_error", - "param": "None", + "type": "invalid_request_error", + "param": None, "code": "404", } } diff --git a/tests/unit/proxy/common_utils/test_openai_error_payload.py b/tests/unit/proxy/common_utils/test_openai_error_payload.py index 40bb84ff538..acefc4c1e2c 100644 --- a/tests/unit/proxy/common_utils/test_openai_error_payload.py +++ b/tests/unit/proxy/common_utils/test_openai_error_payload.py @@ -1,16 +1,26 @@ import json +import sys +from typing import Final +import httpx +import prisma.errors import pytest from fastapi import HTTPException +from prisma._async_http import Response +from prisma.engine.utils import handle_response_errors +import litellm from litellm.proxy._types import ProxyErrorTypes, ProxyException +from litellm.proxy.db.db_lookup_gate import DBLookupDeadlineExceeded from litellm.proxy.common_utils.openai_error_payload import ( error_status_code, litellm_call_id_headers, openai_error_param, openai_error_type, + proxy_exception_for, with_litellm_call_id, ) +from litellm.types.router import RouterErrors @pytest.mark.parametrize( @@ -203,3 +213,287 @@ def test_a_proxy_error_keeps_the_call_id_it_was_raised_with(): assert with_litellm_call_id(raised_with_id, "second").headers == {"x-litellm-call-id": "first"} assert with_litellm_call_id(ProxyException(message="nope", type="None", param=None, code=400), None).headers == {} + + +@pytest.mark.parametrize( + "raised_status, expected_type", + [ + (400, "invalid_request_error"), + (404, "invalid_request_error"), + (401, "auth_error"), + (403, "auth_error"), + (422, "invalid_request_error"), + (500, "internal_server_error"), + ], +) +def test_a_catch_all_handler_keeps_the_status_its_route_answered_with(raised_status: int, expected_type: str) -> None: + wrapped: Final = proxy_exception_for( + HTTPException(status_code=raised_status, detail={"message": "boom"}), + default_status_code=400, + ) + + assert (wrapped.code, wrapped.type) == (str(raised_status), expected_type) + + +@pytest.mark.parametrize( + "default_status_code, expected_type", [(400, "invalid_request_error"), (500, "internal_server_error")] +) +def test_an_exception_carrying_no_status_falls_back_to_the_routes_default(default_status_code: int, expected_type: str) -> None: + wrapped: Final = proxy_exception_for(ValueError("boom"), default_status_code=default_status_code) + + assert (wrapped.code, wrapped.type) == (str(default_status_code), expected_type) + + +def test_a_proxy_exception_passes_through_with_the_type_it_already_named() -> None: + raised: Final = ProxyException( + message="Budget has been exceeded", + type=ProxyErrorTypes.budget_exceeded.value, + param="max_budget", + code=400, + ) + + assert proxy_exception_for(raised, default_status_code=500) is raised + + +def test_the_message_is_what_the_route_raised_without_an_invented_prefix() -> None: + assert proxy_exception_for(ValueError("boom"), default_status_code=400).message == "boom" + + +def test_an_http_exceptions_detail_survives_the_wrapping() -> None: + wrapped: Final = proxy_exception_for( + HTTPException(status_code=400, detail={"error": "Invalid budget_duration 'not-a-duration'."}), + default_status_code=400, + ) + + assert "Invalid budget_duration" in wrapped.message + + +def test_a_carried_type_survives_the_wrapping() -> None: + class _Carrier(Exception): + type: str = "context_window_exceeded" + status_code: int = 400 + + assert proxy_exception_for(_Carrier("boom"), default_status_code=500).type == "context_window_exceeded" + + +@pytest.mark.parametrize("exc", [HTTPException(status_code=404, detail="nope"), ValueError("boom")]) +def test_the_wrapped_error_serializes_as_an_openai_error_object(exc: Exception) -> None: + body: Final = json.loads(json.dumps({"error": proxy_exception_for(exc, default_status_code=400).to_dict()})) + + assert body["error"]["param"] is None + assert body["error"]["type"] == "invalid_request_error" + + +@pytest.mark.parametrize( + "provider_failure, expected", + [ + ( + litellm.AuthenticationError(message="invalid x-api-key", llm_provider="anthropic", model="claude-haiku-5-5"), + ("401", "authentication_error"), + ), + ( + litellm.PermissionDeniedError( + message="model not allowed", + llm_provider="anthropic", + model="claude-haiku-5-5", + response=httpx.Response(403, request=httpx.Request("POST", "https://api.anthropic.com/v1/messages")), + ), + ("403", "permission_error"), + ), + ], +) +def test_a_provider_credential_failure_is_labelled_the_way_chat_completions_labels_it( + provider_failure: Exception, expected: tuple[str, str] +) -> None: + wrapped: Final = proxy_exception_for(provider_failure, default_status_code=400) + + assert (wrapped.code, wrapped.type) == expected + + +@pytest.mark.parametrize("status_code", [401, 403]) +def test_a_rejection_the_route_raised_keeps_the_auth_label(status_code: int) -> None: + wrapped: Final = proxy_exception_for(HTTPException(status_code=status_code, detail="no"), default_status_code=400) + + assert (wrapped.code, wrapped.type) == (str(status_code), "auth_error") + + +def test_an_exception_without_a_message_is_named_by_its_type() -> None: + wrapped: Final = proxy_exception_for(TimeoutError(), default_status_code=500) + + assert wrapped.message == "TimeoutError" + + +def test_a_database_outage_answers_503_so_callers_retry_instead_of_fixing_their_request() -> None: + wrapped: Final = proxy_exception_for( + prisma.errors.PrismaError("Can't reach database server at `db:5432`"), default_status_code=400 + ) + + assert (wrapped.code, wrapped.type) == ("503", "no_db_connection") + + +@pytest.mark.parametrize( + "postgres_refusal", + [ + 'FATAL: database "litellm" is not currently accepting connections', + "FATAL: the database system is starting up", + "FATAL: the database system is shutting down", + "FATAL: the database system is in recovery mode", + "FATAL: the database system is not yet accepting connections", + "FATAL: terminating connection due to administrator command", + "ERROR: cannot execute UPDATE in a read-only transaction", + ], +) +def test_a_database_refusing_work_during_a_failover_answers_503(postgres_refusal: str) -> None: + refused: Final = prisma.errors.DataError( + {"user_facing_error": {"message": f"Error in connector: Error querying the database: {postgres_refusal}"}} + ) + + wrapped: Final = proxy_exception_for(refused, default_status_code=400) + + assert (wrapped.code, wrapped.type) == ("503", "no_db_connection") + + +@pytest.mark.parametrize( + "localized_refusal", + [ + { + "error_code": "P2010", + "message": "Raw query failed. Message: `FEHLER: kann UPDATE nicht in einer Nur-Lese-Transaktion ausführen`", + "meta": {"code": "25006"}, + }, + { + "message": 'PostgresError { code: "57P01", message: "Verbindung wird abgebrochen", severity: "FATAL" }', + }, + ], +) +def test_a_failover_refusal_in_a_localized_postgres_answers_503(localized_refusal: dict[str, object]) -> None: + refused: Final = prisma.errors.DataError({"user_facing_error": localized_refusal}) + + wrapped: Final = proxy_exception_for(refused, default_status_code=400) + + assert (wrapped.code, wrapped.type) == ("503", "no_db_connection") + + +def test_a_failover_phrase_outside_the_database_is_not_reported_as_a_database_outage() -> None: + callback_down: Final = ValueError("FATAL: the database system is starting up") + + wrapped: Final = proxy_exception_for(callback_down, default_status_code=400) + + assert (wrapped.code, wrapped.type) == ("400", "invalid_request_error") + + +def test_a_database_dropped_mid_query_answers_503_though_prisma_fails_to_name_the_error() -> None: + engine_reply_with_null_meta: Final = [{"user_facing_error": {"error_code": "P1001", "message": "", "meta": None}}] + with pytest.raises(AttributeError) as raised: + handle_response_errors(Response(httpx.Response(500)), engine_reply_with_null_meta) + + wrapped: Final = proxy_exception_for(raised.value, default_status_code=500) + + assert (wrapped.code, wrapped.type) == ("503", "no_db_connection") + + +def test_a_network_failure_outside_the_database_is_not_reported_as_a_database_outage() -> None: + callback_unreachable: Final = httpx.ConnectError("[Errno 111] Connection refused") + + wrapped: Final = proxy_exception_for(callback_unreachable, default_status_code=500) + + assert (wrapped.code, wrapped.type) == ("500", "internal_server_error") + + +def _add_member_failing_with(db_error: Exception) -> None: + try: + raise db_error + except Exception as e: + raise ValueError(f"Error adding member to organization: {e}") + + +@pytest.mark.parametrize( + "underlying_error, expected", + [ + (prisma.errors.PrismaError("Can't reach database server at `db:5432`"), ("503", "no_db_connection")), + (httpx.ConnectError("[Errno 111] Connection refused"), ("500", "internal_server_error")), + ], +) +def test_a_route_that_rewraps_its_error_keeps_the_database_outage_it_wrapped( + underlying_error: Exception, expected: tuple[str, str] +) -> None: + with pytest.raises(ValueError, match="Error adding member") as raised: + _add_member_failing_with(underlying_error) + + wrapped: Final = proxy_exception_for(raised.value, default_status_code=500) + + assert (wrapped.code, wrapped.type) == expected + + +def test_a_proxy_without_prisma_installed_still_answers_with_an_error_object(monkeypatch: pytest.MonkeyPatch) -> None: + monkeypatch.setitem(sys.modules, "prisma", None) + + wrapped: Final = proxy_exception_for(httpx.ConnectError("[Errno 111] Connection refused"), default_status_code=500) + + assert (wrapped.code, wrapped.type) == ("500", "internal_server_error") + + +def _look_up_team_failing_with(lookup_error: Exception) -> None: + try: + raise lookup_error + except Exception: + raise HTTPException(status_code=404, detail="Team doesn't exist in db") + + +@pytest.mark.parametrize( + "lookup_error, expected", + [ + (DBLookupDeadlineExceeded("team", 10.0), ("503", "no_db_connection")), + (prisma.errors.PrismaError("Can't reach database server at `db:5432`"), ("503", "no_db_connection")), + (KeyError("team_id"), ("404", "invalid_request_error")), + ], +) +def test_a_not_found_answer_raised_while_the_database_was_down_reports_the_outage( + lookup_error: Exception, expected: tuple[str, str] +) -> None: + with pytest.raises(HTTPException) as raised: + _look_up_team_failing_with(lookup_error) + + wrapped: Final = proxy_exception_for(raised.value, default_status_code=400) + + assert (wrapped.code, wrapped.type) == expected + + +def test_a_lookup_that_missed_its_deadline_answers_503() -> None: + wrapped: Final = proxy_exception_for(DBLookupDeadlineExceeded("team", 10.0), default_status_code=400) + + assert (wrapped.code, wrapped.type) == ("503", "no_db_connection") + + +def test_a_database_outage_answer_does_not_reveal_where_the_database_lives() -> None: + wrapped: Final = proxy_exception_for( + prisma.errors.PrismaError("Can't reach database server at `prod-db.internal:5432`"), default_status_code=400 + ) + + assert wrapped.code == "503" + assert "prod-db.internal" not in wrapped.message + + +def test_an_upstream_failure_answers_with_its_own_status_not_the_routes_default() -> None: + upstream_overloaded: Final = litellm.ServiceUnavailableError( + message="upstream overloaded", llm_provider="openai", model="gpt-5.4-mini" + ) + + wrapped: Final = proxy_exception_for(upstream_overloaded, default_status_code=400) + + assert (wrapped.code, wrapped.type) == ("503", "internal_server_error") + + +@pytest.mark.parametrize( + "router_rejection, expected", + [ + (f"{RouterErrors.no_deployments_with_tag_routing.value}. Passed model=gpt-5.4-mini", ("401", "auth_error")), + (f"{RouterErrors.no_deployments_available.value}. Passed model=gpt-5.4-mini", ("429", "rate_limit_error")), + ], +) +def test_a_router_rejection_is_labelled_by_the_status_it_answers_with( + router_rejection: str, expected: tuple[str, str] +) -> None: + wrapped: Final = proxy_exception_for(ValueError(router_rejection), default_status_code=400) + + assert (wrapped.code, wrapped.type) == expected diff --git a/tests/unit/proxy/health_endpoints/test_health_endpoints.py b/tests/unit/proxy/health_endpoints/test_health_endpoints.py index 49183a143c0..53c163b89ae 100644 --- a/tests/unit/proxy/health_endpoints/test_health_endpoints.py +++ b/tests/unit/proxy/health_endpoints/test_health_endpoints.py @@ -5480,6 +5480,15 @@ async def test_health_services_endpoint_langfuse_missing_keys_errors(monkeypatch assert "connection refused by lf.internal.example" in str(raised.value.message) +@pytest.mark.asyncio +async def test_health_services_reports_an_unknown_service_as_a_request_error_not_an_auth_error() -> None: + with pytest.raises(ProxyException) as exc_info: + await health_services_endpoint(service="totally_unknown_service_xyz") + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + @pytest.mark.asyncio @pytest.mark.parametrize("admin", [False, True]) async def test_unsaved_chatgpt_account_probe_requires_proxy_admin( diff --git a/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py b/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py index cb8a73d581b..d1bbf444d2c 100644 --- a/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py @@ -5211,3 +5211,18 @@ async def test_user_update_without_password_revokes_nothing(_admin_prisma, mocke await _update_single_user_helper(user_request=user_request, user_api_key_dict=admin_caller) revoke_mock.assert_not_awaited() + + +@pytest.mark.asyncio +async def test_user_update_reports_a_bad_budget_duration_as_a_request_error_not_an_auth_error(_admin_prisma: MagicMock) -> None: + from litellm.proxy.management_endpoints.internal_user_endpoints import user_update + + with pytest.raises(ProxyException) as exc_info: + await user_update( + data=UpdateUserRequest(user_id="target-user", budget_duration="not-a-duration"), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert "Invalid budget_duration" in exc_info.value.message + assert "Authentication Error" not in exc_info.value.message diff --git a/tests/unit/proxy/management_endpoints/test_key_management_endpoints.py b/tests/unit/proxy/management_endpoints/test_key_management_endpoints.py index b13a7bfc33e..859824e4a72 100644 --- a/tests/unit/proxy/management_endpoints/test_key_management_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_key_management_endpoints.py @@ -6538,7 +6538,7 @@ async def test_list_keys_with_invalid_status(): ) # Verify ProxyException properties - assert exc_info.value.code == "400" + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") assert "Invalid status value" in str(exc_info.value.message) assert "deleted" in str(exc_info.value.message) @@ -23377,3 +23377,73 @@ def test_key_info_database_not_connected_sanitized_500( assert "Database not connected" in caplog.text finally: proxy_server.app.dependency_overrides.pop(user_api_key_auth, None) + + +@pytest.mark.asyncio +async def test_update_key_reports_a_bad_budget_duration_as_a_request_error_not_an_auth_error(monkeypatch: pytest.MonkeyPatch) -> None: + from fastapi import Request + + from litellm.proxy.management_endpoints.key_management_endpoints import update_key_fn + + monkeypatch.setattr( # test-quality-ok: the endpoint reads proxy_server.prisma_client itself, no parameter to inject + "litellm.proxy.proxy_server.prisma_client", MagicMock() + ) + + with pytest.raises(ProxyException) as exc_info: + await update_key_fn( + request=MagicMock(spec=Request), + data=UpdateKeyRequest(key="sk-whatever", budget_duration="not-a-duration"), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + +@pytest.mark.asyncio +async def test_update_key_passes_its_own_rejection_through_without_making_it_its_own_cause( + monkeypatch: pytest.MonkeyPatch, +) -> None: + from fastapi import Request + + from litellm.proxy.management_endpoints.key_management_endpoints import update_key_fn + + prisma_client: Final = MagicMock() + prisma_client.db.litellm_verificationtoken.find_unique = AsyncMock(return_value=None) + monkeypatch.setattr( # test-quality-ok: the endpoint reads proxy_server.prisma_client itself, no parameter to inject + "litellm.proxy.proxy_server.prisma_client", prisma_client + ) + + with pytest.raises(ProxyException) as exc_info: + await update_key_fn( + request=MagicMock(spec=Request), + data=UpdateKeyRequest(key="sk-missing", max_budget=5), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("404", "not_found_error") + assert exc_info.value.__cause__ is None + + +@pytest.mark.asyncio +async def test_key_aliases_answers_503_when_the_database_is_unreachable(monkeypatch: pytest.MonkeyPatch) -> None: + import prisma.errors + + from litellm.proxy.management_endpoints.key_management_endpoints import key_aliases + + unreachable_db: Final = MagicMock() + unreachable_db.db.query_raw = AsyncMock( + side_effect=prisma.errors.PrismaError("Can't reach database server at `db:5432`") + ) + monkeypatch.setattr("litellm.proxy.proxy_server.prisma_client", unreachable_db) + + with pytest.raises(ProxyException) as exc_info: + await key_aliases( + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + page=1, + size=50, + search=None, + team_id=None, + ) + + assert (exc_info.value.code, exc_info.value.type) == ("503", "no_db_connection") diff --git a/tests/unit/proxy/management_endpoints/test_model_management_endpoints.py b/tests/unit/proxy/management_endpoints/test_model_management_endpoints.py index 437d948f8f5..b892dc97e5c 100644 --- a/tests/unit/proxy/management_endpoints/test_model_management_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_model_management_endpoints.py @@ -311,7 +311,7 @@ async def test_model_creation_fails_closed_when_authoritative_policy_is_unavaila Deployment(model_name="cannot-create", litellm_params={"model": "openai/test-model"}), UserAPIKeyAuth(user_id="test_user", user_role=LitellmUserRoles.INTERNAL_USER), ) - assert error.value.code == "503" + assert (error.value.code, error.value.type) == ("503", "internal_server_error") prisma.db.litellm_proxymodeltable.create.assert_not_called() prisma.db.litellm_teamtable.find_unique.assert_not_called() @@ -10913,3 +10913,76 @@ class TestNonAdminCannotSetPerUserOauthOnModel: user_api_key_dict=admin, ) assert result is created_row + + +@pytest.mark.asyncio +async def test_delete_model_reports_an_unknown_model_id_as_a_request_error_not_an_auth_error(monkeypatch: pytest.MonkeyPatch) -> None: + from litellm.proxy import proxy_server + from litellm.proxy._types import ModelInfoDelete + from litellm.proxy.management_endpoints.model_management_endpoints import delete_model + + prisma: Final = MagicMock() + prisma.db.litellm_proxymodeltable.find_unique = AsyncMock(return_value=None) + monkeypatch.setattr(proxy_server, "prisma_client", prisma) + + with pytest.raises(ProxyException) as exc_info: + await delete_model( + model_info=ModelInfoDelete(id="no-such-model"), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + +@pytest.mark.asyncio +async def test_update_model_reports_an_unknown_model_id_as_a_request_error_not_an_auth_error(monkeypatch: pytest.MonkeyPatch) -> None: + from litellm.proxy import proxy_server + from litellm.proxy.management_endpoints.model_management_endpoints import update_model + + prisma: Final = MagicMock() + prisma.db.litellm_proxymodeltable.find_unique = AsyncMock(return_value=None) + monkeypatch.setattr(proxy_server, "prisma_client", prisma) + monkeypatch.setattr(proxy_server, "llm_router", None) + + with pytest.raises(ProxyException) as exc_info: + await update_model( + model_params=updateDeployment(model_info=ModelInfo(id="no-such-model")), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert exc_info.value.message == "model not found" + + +@pytest.mark.asyncio +async def test_add_new_model_reports_a_database_outage_during_the_insert_as_503( + monkeypatch: pytest.MonkeyPatch, +) -> None: + import prisma.errors + + from litellm.proxy import proxy_server + from litellm.proxy.management_endpoints.model_management_endpoints import add_new_model + + unreachable_db: Final = MagicMock() + unreachable_db.db.query_raw = AsyncMock(return_value=[]) + unreachable_db.db.litellm_proxymodeltable.create = AsyncMock( + side_effect=prisma.errors.PrismaError("Can't reach database server at `db:5432`") + ) + monkeypatch.setattr(proxy_server, "prisma_client", unreachable_db) + monkeypatch.setattr(proxy_server, "store_model_in_db", True) + monkeypatch.setattr(proxy_server, "general_settings", {}) + monkeypatch.setattr(proxy_server, "premium_user", True) + monkeypatch.setenv("LITELLM_SALT_KEY", "sk-outage-salt") + + with pytest.raises(ProxyException) as exc_info: + await add_new_model( + model_params=Deployment( + model_name="outage-model", + litellm_params=LiteLLM_Params(model="openai/gpt-5.4-mini", api_key="fake-key"), + model_info={"id": "outage-model-1"}, + ), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("503", "no_db_connection") diff --git a/tests/unit/proxy/management_endpoints/test_organization_endpoints.py b/tests/unit/proxy/management_endpoints/test_organization_endpoints.py index 16c59aa20b9..5e06756f3a9 100644 --- a/tests/unit/proxy/management_endpoints/test_organization_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_organization_endpoints.py @@ -1617,6 +1617,37 @@ async def test_delete_organization_is_refused_while_one_of_its_teams_holds_a_ptu prisma_client.db.litellm_organizationtable.delete.assert_not_called() +@pytest.mark.asyncio +async def test_organization_member_add_reports_an_unknown_org_as_a_request_error_not_an_auth_error(monkeypatch: pytest.MonkeyPatch) -> None: + from fastapi import Request + + from litellm.proxy._types import ( + LitellmUserRoles, + OrganizationMemberAddRequest, + OrgMember, + ProxyException, + UserAPIKeyAuth, + ) + from litellm.proxy.management_endpoints.organization_endpoints import organization_member_add + + mock_prisma_client: Final = MagicMock() + mock_prisma_client.db.litellm_organizationtable.find_unique = AsyncMock(return_value=None) + monkeypatch.setattr("litellm.proxy.proxy_server.prisma_client", mock_prisma_client) + + with pytest.raises(ProxyException) as exc_info: + await organization_member_add( + data=OrganizationMemberAddRequest( + organization_id="no-such-org", + member=OrgMember(role="internal_user", user_id="someone"), + ), + http_request=MagicMock(spec=Request), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("404", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + @pytest.mark.asyncio @pytest.mark.parametrize("budget_duration", ["30d", None]) async def test_new_organization_schedules_budget_reset_from_duration(monkeypatch, budget_duration): diff --git a/tests/unit/proxy/management_endpoints/test_team_endpoints.py b/tests/unit/proxy/management_endpoints/test_team_endpoints.py index e51f26bf1c3..c6d12ade2a0 100644 --- a/tests/unit/proxy/management_endpoints/test_team_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_team_endpoints.py @@ -19372,3 +19372,48 @@ async def test_default_budget_cache_eviction_does_not_fail_after_redis_error() - ) user_api_key_cache.async_delete_cache.assert_awaited_once_with(key="team_member_default_budget:budget_456") + + +@pytest.mark.asyncio +async def test_team_info_reports_a_missing_team_as_a_request_error_not_an_auth_error(monkeypatch: pytest.MonkeyPatch) -> None: + from fastapi import Request + + from litellm.proxy._types import ProxyException + from litellm.proxy.management_endpoints import team_endpoints + + mock_prisma_client: Final = MagicMock() + mock_prisma_client.db.litellm_teamtable.find_unique = AsyncMock(return_value=None) + monkeypatch.setattr("litellm.proxy.proxy_server.prisma_client", mock_prisma_client) + + with pytest.raises(ProxyException) as exc_info: + await team_endpoints.team_info( + http_request=MagicMock(spec=Request), + team_id="no-such-team", + user_api_key_dict=UserAPIKeyAuth(user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("404", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + +@pytest.mark.asyncio +async def test_team_info_keeps_the_auth_label_for_a_caller_outside_the_team(monkeypatch: pytest.MonkeyPatch) -> None: + from fastapi import Request + + from litellm.proxy._types import ProxyException + from litellm.proxy.management_endpoints import team_endpoints + + other_team: Final = MagicMock() + other_team.model_dump.return_value = {"team_id": "team-a", "members_with_roles": []} + mock_prisma_client: Final = MagicMock() + mock_prisma_client.db.litellm_teamtable.find_unique = AsyncMock(return_value=other_team) + monkeypatch.setattr("litellm.proxy.proxy_server.prisma_client", mock_prisma_client) + + with pytest.raises(ProxyException) as exc_info: + await team_endpoints.team_info( + http_request=MagicMock(spec=Request), + team_id="team-a", + user_api_key_dict=UserAPIKeyAuth(user_id="outsider", user_role=LitellmUserRoles.INTERNAL_USER), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("403", "auth_error") diff --git a/tests/unit/proxy/test_proxy_server.py b/tests/unit/proxy/test_proxy_server.py index 976ed4f28a5..22d6316c448 100644 --- a/tests/unit/proxy/test_proxy_server.py +++ b/tests/unit/proxy/test_proxy_server.py @@ -3,6 +3,7 @@ import sys import traceback from collections.abc import AsyncGenerator, Awaitable, Callable, Coroutine, Mapping from contextlib import asynccontextmanager +from pathlib import Path from typing import Final, Literal, NoReturn, cast from unittest import mock @@ -3817,6 +3818,48 @@ def test_live_session_preserves_pretty_printed_start_frame( assert routed_data["live_session_start"] == expected_start +@pytest.mark.asyncio +async def test_update_config_reports_an_unsupported_router_setting_as_a_request_error_not_an_auth_error() -> None: + from fastapi import Request + + from litellm.proxy._types import ConfigYAML, ProxyException + from litellm.proxy.proxy_server import update_config + + body: Final = {"router_settings": {"not_a_router_setting": True}} + request: Final = MagicMock(spec=Request) + request.json = AsyncMock(return_value=body) + + with pytest.raises(ProxyException) as exc_info: + await update_config( + config_info=ConfigYAML(**body), + request=request, + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("400", "invalid_request_error") + assert "Authentication Error" not in exc_info.value.message + + +@pytest.mark.asyncio +async def test_get_config_callbacks_reports_an_unreadable_config_as_a_server_error_not_an_auth_error( + monkeypatch: pytest.MonkeyPatch, tmp_path: Path +) -> None: + from litellm.proxy import proxy_server + from litellm.proxy._types import ProxyException + from litellm.proxy.proxy_server import get_config + + empty_config: Final = tmp_path / "config.yaml" + empty_config.write_text("") + monkeypatch.delenv("LITELLM_CONFIG_BUCKET_NAME", raising=False) + monkeypatch.setattr(proxy_server, "user_config_file_path", str(empty_config)) + + with pytest.raises(ProxyException) as exc_info: + await get_config(user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN)) + + assert (exc_info.value.code, exc_info.value.type) == ("500", "internal_server_error") + assert exc_info.value.message == "Config cannot be None or Empty." + + @pytest.mark.parametrize("scope", [None, "expand"]) @pytest.mark.parametrize( "general_settings, wildcard_query, wildcard_listed", @@ -3861,6 +3904,62 @@ async def test_model_list_return_wildcard_routes_defaults_to_general_setting( assert ("openai/*" in listed) is wildcard_listed, listed +@pytest.mark.asyncio +async def test_queue_request_labels_an_upstream_failure_a_server_error_not_an_auth_error( + monkeypatch: pytest.MonkeyPatch, +) -> None: + from starlette.requests import Request + from starlette.responses import Response + + from litellm.proxy import proxy_server + from litellm.proxy._types import ProxyException + from litellm.proxy.proxy_server import async_queue_request + + body: Final = json.dumps( + {"model": "gpt-5.4-mini", "messages": [{"role": "user", "content": "hi"}], "priority": 0} + ).encode() + + async def receive() -> dict[str, object]: + return {"type": "http.request", "body": body, "more_body": False} + + request: Final = Request( + { + "type": "http", + "method": "POST", + "path": "/queue/chat/completions", + "headers": [(b"content-type", b"application/json")], + "query_string": b"", + "scheme": "http", + "server": ("testserver", 80), + "root_path": "", + }, + receive, + ) + router: Final = litellm.Router( + model_list=[ + { + "model_name": "gpt-5.4-mini", + "litellm_params": { + "model": "openai/gpt-5.4-mini", + "api_key": "sk-test", + "mock_response": "litellm.InternalServerError", + }, + } + ], + num_retries=0, + ) + monkeypatch.setattr(proxy_server, "llm_router", router) + + with pytest.raises(ProxyException) as exc_info: + await async_queue_request( + request=request, + fastapi_response=Response(), + user_api_key_dict=UserAPIKeyAuth(user_id="admin-1", user_role=LitellmUserRoles.PROXY_ADMIN), + ) + + assert (exc_info.value.code, exc_info.value.type) == ("500", "internal_server_error") + + _DEBUG_LOG_SENTINEL: Final = "sentinel-request-body-7f3a" _LONG_PROMPT: Final = f"{_DEBUG_LOG_SENTINEL} " + "Keep edits minimal and explain them briefly. " * 20 _TOOL_PARAMETERS: Final = {"type": "object", "properties": {"cmd": {"type": "string"}}} From a66dc50efbdb6984797304d6fdd91dc5358647e8 Mon Sep 17 00:00:00 2001 From: "devin-ai-integration[bot]" <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Wed, 28 Oct 2026 22:04:47 -0700 Subject: [PATCH 09/23] test(json_fragment_accumulator): assert peak allocation instead of a drain timing ratio (#43370) * test(json_fragment_accumulator): assert peak allocation instead of a drain timing ratio The drain regression guard compared the wall-clock time of draining 80,000 values against 40,000 and tripped its 3x bound whenever the CI runner was busy. A cursor drain allocates only per-value decode scratch while every re-slice of the remainder copies it, so the guard now bounds peak allocation during the drain, which does not move with runner load and still fails on every quadratic variant * test(json_fragment_accumulator): widen the drain's peak bound to a quarter of the payload * test(json_fragment_accumulator): guard copying drains by peak memory and rescanning drains by CPU-time scaling * test(json_fragment_accumulator): move the drain's timing guard from the unit suite into a CodSpeed benchmark * test(json_fragment_accumulator): measure only the pops after the buffer is joined, so a drain that copies once passes * test(json_fragment_accumulator): separate every other streamed value with a space, so a copy after whitespace fails the drain test --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- ...st_json_fragment_accumulator_benchmarks.py | 26 +++++++ .../test_json_fragment_accumulator.py | 71 +++++++++++-------- 2 files changed, 67 insertions(+), 30 deletions(-) create mode 100644 tests/benchmarks/test_json_fragment_accumulator_benchmarks.py diff --git a/tests/benchmarks/test_json_fragment_accumulator_benchmarks.py b/tests/benchmarks/test_json_fragment_accumulator_benchmarks.py new file mode 100644 index 00000000000..807dd8ff236 --- /dev/null +++ b/tests/benchmarks/test_json_fragment_accumulator_benchmarks.py @@ -0,0 +1,26 @@ +from collections.abc import Iterator +from typing import Final + +import pytest + +from litellm.litellm_core_utils.json_fragment_accumulator import JSONFragmentAccumulator + +CONCATENATED_VALUES: Final = 20_000 + + +def _popped_values(accumulator: JSONFragmentAccumulator) -> Iterator[object]: + while True: + found, value = accumulator.pop_next_value() + if not found: + return + yield value + + +@pytest.mark.benchmark +def test_draining_many_concatenated_values() -> None: + accumulator: Final = JSONFragmentAccumulator() + accumulator.append('{"a": 1}' * CONCATENATED_VALUES) + + drained: Final = sum(1 for _ in _popped_values(accumulator)) + + assert drained == CONCATENATED_VALUES diff --git a/tests/unit/litellm_core_utils/test_json_fragment_accumulator.py b/tests/unit/litellm_core_utils/test_json_fragment_accumulator.py index d16230afe3a..f27a5fd2307 100644 --- a/tests/unit/litellm_core_utils/test_json_fragment_accumulator.py +++ b/tests/unit/litellm_core_utils/test_json_fragment_accumulator.py @@ -1,5 +1,8 @@ import json import time +import tracemalloc +from collections.abc import Iterator +from typing import Final from unittest.mock import patch from litellm.litellm_core_utils.json_fragment_accumulator import JSONFragmentAccumulator @@ -175,40 +178,48 @@ def test_accumulation_of_many_fragments_is_not_quadratic(): assert elapsed_ms < 50, f"1000-fragment append took {elapsed_ms:.1f} ms (expected < 50 ms); O(n^2) regression?" -def test_draining_many_concatenated_values_is_not_quadratic(): - """ - Regression guard: peeling N JSON values already sitting in one buffer, - one pop_next_value() call per value with no new fragments in between, - must be O(n) total. Re-copying the shrinking remainder on every pop - (slicing a new string instead of advancing a cursor) makes total drain - time scale with the square of the buffer size. +def _popped_values(accumulator: JSONFragmentAccumulator) -> Iterator[object]: + while True: + found, value = accumulator.pop_next_value() + if not found: + return + yield value - Uses a doubling ratio rather than an absolute ms budget so it isn't - flaky on a slower or busier CI runner: doubling the input should - roughly double an O(n) drain's time but roughly quadruple an O(n^2) - drain's time, and that ratio holds regardless of machine speed. - """ - def drain_time_ms(n: int) -> float: - accumulator = JSONFragmentAccumulator() - accumulator.append('{"a": 1}' * n) - start = time.perf_counter() - drained = 0 - while True: - found, _ = accumulator.pop_next_value() - if not found: - break - drained += 1 - assert drained == n - return (time.perf_counter() - start) * 1000 +def _streamed(fragments: tuple[str, ...]) -> JSONFragmentAccumulator: + accumulator: Final = JSONFragmentAccumulator() + for fragment in fragments: + accumulator.append(fragment) + return accumulator - small_ms = drain_time_ms(40_000) - large_ms = drain_time_ms(80_000) - ratio = large_ms / max(small_ms, 0.001) - assert ratio < 3.0, ( - f"doubling drained values scaled time by {ratio:.2f}x ({small_ms:.1f} ms -> {large_ms:.1f} ms); " - "expected roughly 2x for O(n); O(n^2) regression?" +def _drain_peak_bytes(fragments: tuple[str, ...]) -> int: + accumulator: Final = _streamed(fragments) + first_found, _ = accumulator.pop_next_value() + assert first_found is True + already_tracing: Final = tracemalloc.is_tracing() + if not already_tracing: + tracemalloc.start() + tracemalloc.reset_peak() + baseline, _ = tracemalloc.get_traced_memory() + try: + drained: Final = sum(1 for _ in _popped_values(accumulator)) + _, peak = tracemalloc.get_traced_memory() + finally: + if not already_tracing: + tracemalloc.stop() + assert drained == len(fragments) - 1 + return peak - baseline + + +def test_draining_many_concatenated_values_never_copies_the_remainder(): + value: Final = '{"text": "' + "x" * 20 + '"}' + fragments: Final = tuple(value if index % 2 else f" {value}" for index in range(40_000)) + payload_bytes: Final = sum(len(fragment) for fragment in fragments) + peak_bytes: Final = _drain_peak_bytes(fragments) + assert peak_bytes < payload_bytes // 4, ( + f"draining {len(fragments)} values allocated a peak of {peak_bytes} bytes over a {payload_bytes} byte payload, " + "copying the remainder on every pop?" ) From b7da9a275581ccec82538428dfd0b84bbc4fb6fc Mon Sep 17 00:00:00 2001 From: tessellark <349031000+tessellark@users.noreply.github.com> Date: Wed, 28 Oct 2026 22:51:39 -0700 Subject: [PATCH 10/23] fix(credentials): keep the stored secret when PATCH echoes its masked read-back (#48950) * test(credentials): pin that PATCH keeps the stored secret when it echoes the masked read-back * fix(credentials): keep the stored secret when PATCH echoes its masked read-back * fix(credentials): only treat a mask on a key GET masks as a placeholder PATCH now skips mask-shaped values only on the keys get_masked_values masks, using the masker's own keyword check, so a value like api_base ab****cd is saved as sent again. Also drops the new test docstrings and tightens the new test helper types --------- Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- litellm/litellm_core_utils/litellm_logging.py | 34 +-- .../proxy/credential_endpoints/endpoints.py | 84 +++++- .../credential_endpoints/test_endpoints.py | 265 +++++++++++++++++- 3 files changed, 353 insertions(+), 30 deletions(-) diff --git a/litellm/litellm_core_utils/litellm_logging.py b/litellm/litellm_core_utils/litellm_logging.py index 620c8413f29..7f4b069ded6 100644 --- a/litellm/litellm_core_utils/litellm_logging.py +++ b/litellm/litellm_core_utils/litellm_logging.py @@ -5052,6 +5052,23 @@ class Logging(LiteLLMLoggingBaseClass): return result_copy +_SENSITIVE_KEYWORDS: Final = ( + "authorization", + "token", + "key", + "secret", + "vertex_credentials", + "credentials", + "password", + "passwd", +) + + +def has_sensitive_keyword(key: str) -> bool: + lowered: Final = key.lower() + return any(keyword in lowered for keyword in _SENSITIVE_KEYWORDS) + + def get_masked_values( sensitive_object: Mapping[str, object], ignore_sensitive_values: bool = False, @@ -5070,16 +5087,6 @@ def get_masked_values( masked_length: Optional length for the masked portion (number of *). If set, will use exactly this many * regardless of original string length. The total length will be unmasked_length + masked_length. """ - sensitive_keywords: Final = ( - "authorization", - "token", - "key", - "secret", - "vertex_credentials", - "credentials", - "password", - "passwd", - ) def _mask_value(v: object) -> object: if isinstance(v, dict): @@ -5106,12 +5113,7 @@ def get_masked_values( return v[: unmasked_length // 2] + "*" * (len(v) - unmasked_length) + v[-unmasked_length // 2 :] return { - k: ( - v - if ignore_sensitive_values - or not any(sensitive_keyword in k.lower() for sensitive_keyword in sensitive_keywords) - else _mask_value(v) - ) + k: (v if ignore_sensitive_values or not has_sensitive_keyword(k) else _mask_value(v)) for k, v in sensitive_object.items() } diff --git a/litellm/proxy/credential_endpoints/endpoints.py b/litellm/proxy/credential_endpoints/endpoints.py index d20b5602186..57c7a753d71 100644 --- a/litellm/proxy/credential_endpoints/endpoints.py +++ b/litellm/proxy/credential_endpoints/endpoints.py @@ -5,6 +5,7 @@ CRUD endpoints for storing reusable credentials. import time import unicodedata from collections.abc import Mapping +from types import MappingProxyType from typing import ( Annotated, Final, @@ -23,7 +24,7 @@ from litellm.constants import ( GITHUB_COPILOT_PER_USER_AUTH_TYPE, ) from litellm.litellm_core_utils.credential_accessor import CredentialAccessor -from litellm.litellm_core_utils.litellm_logging import get_masked_values +from litellm.litellm_core_utils.litellm_logging import get_masked_values, has_sensitive_keyword from litellm.llms.anthropic.wif import ( ExportedJwks, NotAnInternalIssuerCredential, @@ -83,6 +84,11 @@ _CREDENTIAL_DICT_ADAPTER: Final = TypeAdapter(dict[str, object]) _GITHUB_COPILOT_PROVIDER: Final = "github_copilot" _DISPLAY_NAME_MAX_LENGTH: Final = 255 _DISPLAY_NAME_FORBIDDEN_CATEGORIES: Final = frozenset({"Cc", "Cf", "Cs", "Zl", "Zp"}) +_MASK_UNMASKED_LENGTH: Final = 4 +_MASK_ASTERISKS: Final = 4 +_SHORT_SECRET_MASK: Final = "*****" +_MASKED_READ_BACK_DEPTH: Final = 20 +_NO_FIELDS: Final[Mapping[str, object]] = MappingProxyType({}) def _normalized_github_copilot_values( @@ -395,7 +401,14 @@ async def get_credentials( """ try: masked_credentials: Final = [ - _credential_view(credential, get_masked_values(credential.credential_values)) + _credential_view( + credential, + get_masked_values( + credential.credential_values, + unmasked_length=_MASK_UNMASKED_LENGTH, + number_of_asterisks=_MASK_ASTERISKS, + ), + ) for credential in litellm.credential_list ] return {"success": True, "credentials": masked_credentials} @@ -423,7 +436,11 @@ async def get_credential_by_name( if credential.credential_name == credential_name: return _credential_view( credential, - get_masked_values(credential.credential_values, unmasked_length=4, number_of_asterisks=4), + get_masked_values( + credential.credential_values, + unmasked_length=_MASK_UNMASKED_LENGTH, + number_of_asterisks=_MASK_ASTERISKS, + ), ) raise HTTPException( status_code=404, @@ -521,8 +538,8 @@ async def get_credential_by_model( raise HTTPException(status_code=404, detail="Model not found") masked_credential_values: Final = get_masked_values( credential_values, - unmasked_length=4, - number_of_asterisks=4, + unmasked_length=_MASK_UNMASKED_LENGTH, + number_of_asterisks=_MASK_ASTERISKS, ) credential: Final = CredentialItem( credential_name=f"{model.model_name}-credential-{model_id}", @@ -908,6 +925,48 @@ def update_db_credential( return merged_credential +def _is_masked_read_back(value: object) -> bool: + if not isinstance(value, str): + return False + if value == _SHORT_SECRET_MASK: + return True + shown: Final = _MASK_UNMASKED_LENGTH // 2 + return len(value) == _MASK_UNMASKED_LENGTH + _MASK_ASTERISKS and value[shown:-shown] == "*" * _MASK_ASTERISKS + + +def _as_fields(value: object) -> Mapping[str, object] | None: + try: + return _CREDENTIAL_DICT_ADAPTER.validate_python(value, strict=True) + except ValidationError: + return None + + +def _kept_value(key: str, value: object, stored: Mapping[str, object], depth: int) -> tuple[str, object] | None: + if not has_sensitive_keyword(key): + return key, value + fields: Final = _as_fields(value) + if fields is not None and depth < _MASKED_READ_BACK_DEPTH: + return key, _without_masked_read_backs(fields, _as_fields(stored.get(key)) or _NO_FIELDS, depth + 1) + if not _is_masked_read_back(value): + return key, value + if key in stored: + return key, stored[key] + return None + + +def _without_masked_read_backs( + requested: Mapping[str, object], stored: Mapping[str, object], depth: int = 0 +) -> Mapping[str, object]: + kept: Final = (_kept_value(key, value, stored, depth) for key, value in requested.items()) + return _CREDENTIAL_DICT_ADAPTER.validate_python( + MappingProxyType(dict(entry for entry in kept if entry is not None)) + ) + + +def _stored_objects(stored_values: Mapping[str, object]) -> Mapping[str, object]: + return MappingProxyType({key: value for key, value in stored_values.items() if _as_fields(value) is not None}) + + @router.patch( "/credentials/{credential_name:path}", dependencies=[Depends(user_api_key_auth)], @@ -936,12 +995,12 @@ async def update_credential( ) requested_display_name: Final = _normalized_display_name(credential.display_name) _reject_overlapping_credential_values(credential) - incoming_values: Final = _CREDENTIAL_DICT_ADAPTER.validate_python( + requested_values: Final = _CREDENTIAL_DICT_ADAPTER.validate_python( _resolve_deployment_credentials(llm_router, credential.model_id) if credential.model_id else credential.credential_values or {} ) - _reject_non_admin_wif_fields(_incoming_wif_fields(incoming_values, credential), user_api_key_dict) + _reject_non_admin_wif_fields(_incoming_wif_fields(requested_values, credential), user_api_key_dict) if prisma_client is None: raise HTTPException( status_code=500, @@ -952,19 +1011,20 @@ async def update_credential( if db_credential is None: raise _not_found_unless_config_defined(credential_name, "Credential not found in DB.") _reject_non_admin_wif_fields(_stored_wif_fields(db_credential), user_api_key_dict) + decrypted_stored_credential: Final = decrypted_credential(db_credential) + decrypted_values: Final = _CREDENTIAL_DICT_ADAPTER.validate_python( + decrypted_stored_credential.credential_values + ) + incoming_values: Final = _without_masked_read_backs(requested_values, _stored_objects(decrypted_values)) patch: Final = CredentialItem( credential_name=credential_name, display_name=( requested_display_name if "display_name" in credential.model_fields_set else db_credential.display_name ), credential_info=_CREDENTIAL_DICT_ADAPTER.validate_python(credential.credential_info), - credential_values=incoming_values, + credential_values=_CREDENTIAL_DICT_ADAPTER.validate_python(incoming_values), credential_values_to_delete=credential.credential_values_to_delete, ) - decrypted_stored_credential: Final = decrypted_credential(db_credential) - decrypted_values: Final = _CREDENTIAL_DICT_ADAPTER.validate_python( - decrypted_stored_credential.credential_values - ) stored_info: Final = _CREDENTIAL_DICT_ADAPTER.validate_python( db_credential.credential_info # pyright: ignore[reportUnknownMemberType] # untyped credential field ) diff --git a/tests/unit/proxy/credential_endpoints/test_endpoints.py b/tests/unit/proxy/credential_endpoints/test_endpoints.py index c905d38dd41..9dd36a535e4 100644 --- a/tests/unit/proxy/credential_endpoints/test_endpoints.py +++ b/tests/unit/proxy/credential_endpoints/test_endpoints.py @@ -2,8 +2,9 @@ import json from contextlib import contextmanager +from functools import reduce from types import SimpleNamespace -from typing import Final +from typing import Final, Protocol from unittest.mock import AsyncMock, MagicMock, call, patch import httpx @@ -12,14 +13,16 @@ from cryptography.hazmat.primitives import serialization from cryptography.hazmat.primitives.asymmetric import ec from fastapi import HTTPException, Request from fastapi.testclient import TestClient +from pydantic import TypeAdapter import litellm from litellm.litellm_core_utils.credential_accessor import CredentialAccessor +from litellm.litellm_core_utils.litellm_logging import get_masked_values from litellm.llms.github_copilot.per_user_auth import _SESSION_CACHE, _session_cache_key from litellm.models.credentials import CredentialSource, UserConnectionFlowHandle from litellm.proxy._types import LiteLLM_UserTable, LitellmUserRoles, UserAPIKeyAuth from litellm.proxy.auth.user_api_key_auth import user_api_key_auth -from litellm.proxy.common_utils.encrypt_decrypt_utils import encrypt_value_helper +from litellm.proxy.common_utils.encrypt_decrypt_utils import decrypt_value_helper, encrypt_value_helper from litellm.proxy.credential_endpoints.endpoints import _decode_flow_handle, get_llm_router from litellm.proxy.proxy_server import app from litellm.types.utils import CredentialItem @@ -460,6 +463,264 @@ def test_update_credential_never_syncs_a_null_into_the_in_memory_credential(rest assert synced.credential_values["api_key"] == "sk-rotated" +_WRITTEN_JSON: Final = TypeAdapter(dict[str, object]) + + +class _InstallCredentialStore(Protocol): + def __call__( + self, + *, + connected: bool = True, + in_memory: tuple[object, ...] = (), + llm_router: object | None = None, + **repository_calls: AsyncMock, + ) -> None: ... + + +def _encrypted_row(served: CredentialItem) -> CredentialItem: + return CredentialItem( + credential_name=served.credential_name, + credential_values={key: encrypt_value_helper(value) for key, value in served.credential_values.items()}, + credential_info=dict(served.credential_info), + ) + + +def _written_values(update_by_name: AsyncMock) -> dict[str, object]: + written: Final = _WRITTEN_JSON.validate_json(update_by_name.await_args.kwargs["data"]["credential_values"]) + return { + key: decrypt_value_helper(value, key) if isinstance(value, str) else value for key, value in written.items() + } + + +def _written_info(update_by_name: AsyncMock) -> dict[str, object]: + return _WRITTEN_JSON.validate_json(update_by_name.await_args.kwargs["data"]["credential_info"]) + + +def _serve_credential( + credential_store: _InstallCredentialStore, + served: CredentialItem, + in_memory: tuple[CredentialItem, ...] | None = None, +) -> AsyncMock: + update_by_name = AsyncMock(return_value=None) + credential_store( + in_memory=(served,) if in_memory is None else in_memory, + find_by_name=AsyncMock(side_effect=lambda _name: _encrypted_row(served)), + update_by_name=update_by_name, + ) + return update_by_name + + +def _service_account( + private_key: str = "pk-1234567890", client_email: str = "svc@example.com" +) -> dict[str, dict[str, str]]: + return {"vertex_credentials": {"private_key": private_key, "client_email": client_email}} + + +def test_update_credential_keeps_the_stored_secret_when_the_patch_echoes_its_masked_read_back( + credential_store: _InstallCredentialStore, +): + served = CredentialItem( + credential_name="existing", + credential_values={"api_key": "sk-real-secret-1234"}, + credential_info={"custom_llm_provider": "openai", "description": "original"}, + ) + update_by_name = _serve_credential(credential_store, served) + + response = _patch_credential( + "existing", + { + "credential_values": {"api_key": "sk****34"}, + "credential_info": {"custom_llm_provider": "openai", "description": "edited"}, + }, + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {"api_key": "sk-real-secret-1234"} + assert _written_info(update_by_name)["description"] == "edited" + assert CredentialAccessor.get_credential_values("existing") == {"api_key": "sk-real-secret-1234"} + assert litellm.credential_list[0].credential_info["description"] == "edited" + + +def test_update_credential_keeps_the_secret_when_the_patch_echoes_what_get_by_name_served( + credential_store: _InstallCredentialStore, +): + served = CredentialItem( + credential_name="existing", + credential_values={"api_key": "sk-real-secret-1234", "api_base": "https://api.example.com"}, + credential_info={"custom_llm_provider": "openai", "description": "original"}, + ) + update_by_name = _serve_credential(credential_store, served) + read_back = _call_as("GET", "/credentials/by_name/existing").json() + assert read_back["credential_values"]["api_key"] != "sk-real-secret-1234" + + response = _patch_credential( + "existing", {**read_back, "credential_info": {**read_back["credential_info"], "description": "edited"}} + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {"api_key": "sk-real-secret-1234", "api_base": "https://api.example.com"} + assert _written_info(update_by_name)["description"] == "edited" + + +def test_update_credential_keeps_a_short_secret_whose_read_back_is_all_asterisks( + credential_store: _InstallCredentialStore, +): + served = CredentialItem(credential_name="existing", credential_values={"api_key": "abc"}, credential_info={}) + update_by_name = _serve_credential(credential_store, served) + read_back = _call_as("GET", "/credentials/by_name/existing").json() + assert read_back["credential_values"]["api_key"] != "abc" + + response = _patch_credential( + "existing", {"credential_values": read_back["credential_values"], "credential_info": {}} + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {"api_key": "abc"} + assert CredentialAccessor.get_credential_values("existing") == {"api_key": "abc"} + + +@pytest.mark.parametrize( + "rotated_values", + ( + {"api_key": "sk-rotated-key-5678"}, + {"api_key": "new**secret"}, + _service_account(private_key="pk**rotated"), + ), +) +def test_update_credential_still_rotates_a_secret_sent_in_full( + credential_store: _InstallCredentialStore, rotated_values: dict[str, object] +): + served = CredentialItem( + credential_name="existing", + credential_values={"api_key": "sk-old-key-000011", **_service_account()}, + credential_info={}, + ) + update_by_name = _serve_credential(credential_store, served) + + response = _patch_credential("existing", {"credential_values": rotated_values, "credential_info": {}}) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {**served.credential_values, **rotated_values} + assert CredentialAccessor.get_credential_values("existing") == {**served.credential_values, **rotated_values} + + +def test_update_credential_saves_a_mask_shaped_value_on_a_key_get_never_masks( + credential_store: _InstallCredentialStore, +): + served = CredentialItem( + credential_name="existing", + credential_values={ + "api_key": "sk-real-secret-1234", + "api_base": "https://api.example.com", + "extra_headers": {"x-team": "platform"}, + }, + credential_info={}, + ) + update_by_name = _serve_credential(credential_store, served) + sent: Final = {"api_base": "ab****cd", "organization": "*****", "extra_headers": {"x-team": "*****"}} + assert get_masked_values(sent, unmasked_length=4, number_of_asterisks=4) == sent + + response = _patch_credential("existing", {"credential_values": sent, "credential_info": {}}) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {"api_key": "sk-real-secret-1234", **sent} + + +@pytest.mark.parametrize("client_email", ("svc@example.com", "new@example.com")) +def test_update_credential_keeps_a_masked_secret_inside_a_stored_object( + credential_store: _InstallCredentialStore, client_email: str +): + served = CredentialItem(credential_name="existing", credential_values=_service_account(), credential_info={}) + update_by_name = _serve_credential(credential_store, served) + + response = _patch_credential( + "existing", + { + "credential_values": _service_account(private_key="pk****90", client_email=client_email), + "credential_info": {}, + }, + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == _service_account(client_email=client_email) + assert CredentialAccessor.get_credential_values("existing") == _service_account(client_email=client_email) + + +def test_update_credential_drops_a_masked_leaf_the_stored_object_no_longer_has( + credential_store: _InstallCredentialStore, +): + served = CredentialItem(credential_name="existing", credential_values=_service_account(), credential_info={}) + update_by_name = _serve_credential(credential_store, served) + + response = _patch_credential( + "existing", + { + "credential_values": { + "vertex_credentials": { + "private_key": "pk****90", + "refresh_token": "rt****89", + "client_email": "svc@example.com", + } + }, + "credential_info": {}, + }, + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == _service_account() + + +@pytest.mark.parametrize( + "in_memory", + ( + pytest.param( + ( + CredentialItem( + credential_name="existing", + credential_values={"api_key": "sk-old-key-000011"}, + credential_info={"description": "original"}, + ), + ), + id="replica_not_resynced", + ), + pytest.param((), id="replica_never_loaded_it"), + ), +) +def test_update_credential_keeps_the_table_secret_whatever_this_replica_last_rendered( + credential_store: _InstallCredentialStore, in_memory: tuple[CredentialItem, ...] +): + served = CredentialItem( + credential_name="existing", + credential_values={"api_key": "sk-rotated-key-000099"}, + credential_info={"description": "original"}, + ) + update_by_name = _serve_credential(credential_store, served, in_memory=in_memory) + + response = _patch_credential( + "existing", + {"credential_values": {"api_key": "sk****11"}, "credential_info": {"description": "edited"}}, + ) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == {"api_key": "sk-rotated-key-000099"} + assert _written_info(update_by_name)["description"] == "edited" + + +@pytest.mark.parametrize("levels", (20, 21)) +def test_update_credential_keeps_a_secret_exactly_as_deep_as_the_masker_masks( + credential_store: _InstallCredentialStore, levels: int +): + nested = reduce(lambda inner, _level: {"credentials": inner}, range(levels), {"api_key": "leaf-secret-1234"}) + served = CredentialItem(credential_name="existing", credential_values=nested, credential_info={}) + update_by_name = _serve_credential(credential_store, served) + read_back = get_masked_values(served.credential_values, unmasked_length=4, number_of_asterisks=4) + + response = _patch_credential("existing", {"credential_values": read_back, "credential_info": {}}) + + assert response.status_code == 200, response.text + assert _written_values(update_by_name) == nested + + def _generate_es256_pem() -> str: key = ec.generate_private_key(ec.SECP256R1()) return key.private_bytes( From bad98c4b02f09076cd11fcf788888f36dce23e73 Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Wed, 28 Oct 2026 23:08:24 -0700 Subject: [PATCH 11/23] fix(responses): call the renamed drops_params helper on the compact path (#49030) Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com> --- litellm/llms/openai/responses/transformation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/litellm/llms/openai/responses/transformation.py b/litellm/llms/openai/responses/transformation.py index 64b2e61130d..45fc1fc3ff7 100644 --- a/litellm/llms/openai/responses/transformation.py +++ b/litellm/llms/openai/responses/transformation.py @@ -1218,7 +1218,7 @@ class OpenAIResponsesAPIConfig(BaseResponsesAPIConfig): def compact_dropped_params(self, litellm_params: GenericLiteLLMParams) -> frozenset[str]: if self.custom_llm_provider not in _PROVIDERS_WITH_STRICT_COMPACT_PARAMS: return frozenset() - if _drops_params(litellm_params): + if drops_params(litellm_params): return _COMPACT_TRACKING_PARAMS | _COMPACT_REJECTED_PARAMS return _COMPACT_TRACKING_PARAMS From c666df3dace0b5fa17140ea357c8d56d6e576c36 Mon Sep 17 00:00:00 2001 From: Mateo Wang <277851410+mateo-berri@users.noreply.github.com> Date: Wed, 28 Oct 2026 23:24:52 -0700 Subject: [PATCH 12/23] docs(qa): allow focused proof for mechanical PRs (#49031) --- .github/PULL_REQUEST_TEMPLATE/general.md | 7 ++++--- AGENTS.md | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/general.md b/.github/PULL_REQUEST_TEMPLATE/general.md index 243d121d626..86a23966671 100644 --- a/.github/PULL_REQUEST_TEMPLATE/general.md +++ b/.github/PULL_REQUEST_TEMPLATE/general.md @@ -84,9 +84,10 @@ If you're seeing a delay in your PR being merged, ping the LiteLLM Team on [Slac ## Screenshots / Proof of Fix