scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-11-05 07:37:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 233

fix(proxy): clarify atomic model provider updates

Browse source
This commit is contained in:
moe-berri 2026-10-28 13:56:09 -07:00
parent 71f9fc8707
commit cc692e8514
2 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
litellm/proxy/management_endpoints/model_management_endpoints.py
View file

@ -434,7 +434,11 @@ def _raise_on_unloadable_patch(db_model: Deployment, patch_data: updateDeploymen
Router.resolve_deployment_provider(reloaded.litellm_params)
except Exception as e: # noqa: BLE001 # the router drops the deployment on any exception from this check
raise ProxyException(
message=f"The router cannot load this deployment, so the update was not saved: {e}",
message=(
"The router cannot load this deployment, so the update was not saved. "
"Use a provider-prefixed model or include model and custom_llm_provider together in the same update. "
f"Provider error: {e}"
),
type=ProxyErrorTypes.validation_error.value,
code=status.HTTP_400_BAD_REQUEST,
param="litellm_params.model",

28
tests/unit/proxy/management_endpoints/test_model_management_endpoints.py
View file

@ -10229,6 +10229,34 @@ class TestPatchModelRejectsParamsTheRouterDrops:
assert exc_info.value.param == "litellm_params.model"
assert "@cf/cloudflare/clef-flash" in exc_info.value.message
def test_model_and_provider_can_be_updated_together_after_model_only_rejection(
self, monkeypatch: pytest.MonkeyPatch
) -> None:
from litellm.proxy.management_endpoints.model_management_endpoints import (
_raise_on_unloadable_patch,
update_db_model,
)
from litellm.proxy.proxy_server import proxy_config
monkeypatch.setenv("LITELLM_SALT_KEY", "fake-atomic-model-patch-test-salt")
stored: Final = self._stored(model="cloudflare/clef-flash")
with pytest.raises(ProxyException) as exc_info:
_raise_on_unloadable_patch(
stored, updateDeployment(litellm_params=updateLiteLLMParams(model="atomic-test-model"))
)
assert exc_info.value.code == "400"
assert "include model and custom_llm_provider together in the same update" in exc_info.value.message
combined: Final = updateDeployment(
litellm_params=updateLiteLLMParams(model="atomic-test-model", custom_llm_provider="openai")
)
_raise_on_unloadable_patch(stored, combined)
saved: Final = json.loads(update_db_model(db_model=stored, updated_patch=combined)["litellm_params"])
reloaded: Final = {key: proxy_config.resolve_db_litellm_param(key, value) for key, value in saved.items()}
assert reloaded["model"] == "atomic-test-model"
assert reloaded["custom_llm_provider"] == "openai"
assert self._router_loads(reloaded)
def test_patch_not_touching_routing_params_is_never_judged(self, monkeypatch: pytest.MonkeyPatch) -> None:
from litellm.proxy.management_endpoints.model_management_endpoints import _raise_on_unloadable_patch