From ca2fa744aac5ee00537bc2c474e5670e8978cad5 Mon Sep 17 00:00:00 2001 From: Krrish Dholakia Date: Mon, 13 Jul 2026 18:51:45 -0700 Subject: [PATCH] fix(ci): register new update_settings helper methods as indirectly-tested router_code_coverage.py detects test coverage via a static AST scan for literal `.method_name(` calls in test files, not real coverage instrumentation - it flagged _merge_default_litellm_params_setting and _apply_optional_pre_call_checks_setting as untested even though they're exercised through update_settings(default_litellm_params=...) / (optional_pre_call_checks=...) in test_router.py, matching the existing _merge_tools_from_deployment / _invalidate_access_groups_cache precedent for private helpers only called indirectly. --- tests/code_coverage_tests/router_code_coverage.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/code_coverage_tests/router_code_coverage.py b/tests/code_coverage_tests/router_code_coverage.py index 014f3a16b59..b23b2167150 100644 --- a/tests/code_coverage_tests/router_code_coverage.py +++ b/tests/code_coverage_tests/router_code_coverage.py @@ -80,6 +80,8 @@ ignored_function_names = [ "_override_vector_store_methods_for_router", # No-op placeholder, called during Router init "_merge_tools_from_deployment", # Tested indirectly via _update_kwargs_with_deployment (test files lack "router" in name) "_invalidate_access_groups_cache", # Tested indirectly via set_model_list, upsert_model etc. (test files lack "router" in name) + "_merge_default_litellm_params_setting", # Tested indirectly via update_settings(default_litellm_params=...) + "_apply_optional_pre_call_checks_setting", # Tested indirectly via update_settings(optional_pre_call_checks=...) ]