mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-05 02:41:56 +00:00
fix(proxy): describe rejected characters in key_alias validation error
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
parent
a8979fe054
commit
c5c70483b9
2 changed files with 4 additions and 1 deletions
|
|
@ -7447,7 +7447,7 @@ def _validate_key_alias_format(key_alias: str | None) -> None:
|
|||
raise_if_unsafe_secret_name(key_alias)
|
||||
except ValueError:
|
||||
raise ProxyException(
|
||||
message="Invalid key_alias",
|
||||
message='Invalid key_alias: must not contain control characters (such as tab or newline) or a ".." path segment',
|
||||
type=ProxyErrorTypes.bad_request_error,
|
||||
param="key_alias",
|
||||
code=400,
|
||||
|
|
|
|||
|
|
@ -9904,6 +9904,7 @@ class TestValidateKeyAliasFormat:
|
|||
"foo\n- !grant\n role: !!admin\n member: attacker",
|
||||
"foo\rbar",
|
||||
"foo\x00bar",
|
||||
"my-test-key\t",
|
||||
],
|
||||
)
|
||||
def test_validate_key_alias_format_rejects_traversal_and_control_chars_even_when_flag_disabled(
|
||||
|
|
@ -9922,6 +9923,8 @@ class TestValidateKeyAliasFormat:
|
|||
_validate_key_alias_format(unsafe_alias)
|
||||
assert str(exc.value.code) == "400"
|
||||
assert "Invalid key_alias" in str(exc.value.message)
|
||||
assert "control characters" in str(exc.value.message)
|
||||
assert '".." path segment' in str(exc.value.message)
|
||||
|
||||
def test_validate_key_alias_format_valid(self, monkeypatch):
|
||||
from litellm.proxy.management_endpoints.key_management_endpoints import (
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue