From c5a9f8875428f8045eb6ea74c4e30d10a8497800 Mon Sep 17 00:00:00 2001
From: liangwenfeng <1321852595@qq.com>
Date: Wed, 20 May 2026 16:27:22 +0800
Subject: [PATCH] Fix routing_groups being overwritten by config values in
 /router/settings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Problem:**
In `/router/settings` endpoint, `router_settings_from_config` was
overwriting `routing_groups` from `llm_router._routing_groups`, even
when the config value was empty or missing.

**Solution:**
Added special handling for `routing_groups` during config merge:
- If `llm_router` has `routing_groups` and config value is empty,
  keep the llm_router value
- If both have values, merge them (config takes precedence for same group)
- If only config has value, use config value

**Impact:**
- `/router/settings` now correctly returns `routing_groups` from
  llm_router when they exist
- Fixes the issue where routing_groups would disappear after config
  reload

🤖 Generated with [Claude Code](https://claude.com/code)
---
 .../router_settings_endpoints.py              | 26 ++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/litellm/proxy/management_endpoints/router_settings_endpoints.py b/litellm/proxy/management_endpoints/router_settings_endpoints.py
index 557eb608136..f0f7943a13e 100644
--- a/litellm/proxy/management_endpoints/router_settings_endpoints.py
+++ b/litellm/proxy/management_endpoints/router_settings_endpoints.py
@@ -119,7 +119,31 @@ async def get_router_settings(
                     current_values[field.field_name] = value
 
         # Merge with config values (config takes precedence)
-        current_values.update(router_settings_from_config)
+        # Fix: Special handling for routing_groups to prevent overwriting
+        # llm_router memory values with potentially empty config values
+        for key, value in router_settings_from_config.items():
+            if key == "routing_groups":
+                # If llm_router has routing_groups and config value is empty/missing,
+                # keep the llm_router value
+                if key in current_values and current_values[key]:
+                    # llm_router has value, check if config value is meaningful
+                    if not value:
+                        verbose_proxy_logger.debug(
+                            f"Skipping empty routing_groups from config, "
+                            f"keeping llm_router value: {len(current_values[key])} groups"
+                        )
+                        continue
+                    # Both have values, merge them (config takes precedence for same group)
+                    existing_groups = {g["group_name"]: g for g in current_values[key]}
+                    new_groups = {g["group_name"]: g for g in value}
+                    existing_groups.update(new_groups)
+                    current_values[key] = list(existing_groups.values())
+                    continue
+                # llm_router doesn't have value, use config value (even if empty)
+                current_values[key] = value if value else []
+            else:
+                # For other fields, config takes precedence
+                current_values[key] = value
 
         # Update field values with current values
         for field in router_fields: