scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-21 00:21:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 74

fix: correct falsy id test assertions per Greptile review

Browse source 
When response_object has a falsy id (None or ""), convert_to_model_response_object
replaces it with a new uuid.uuid4() — not the original chatcmpl- prefixed id.
Updated assertions to match actual behavior.
This commit is contained in:
Ryan Crabbe 2026-02-18 11:27:26 -08:00
parent 7a2e413201
commit c44f05bda5
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/llm_translation/test_llm_response_utils/test_convert_dict_to_chat_completion.py
View file

@ -1497,5 +1497,8 @@ def test_convert_to_model_response_object_falsy_id_preserves_auto_generated(fals
start_time=datetime.now(),
end_time=datetime.now(),
)
assert result.id == original_id
assert result.id.startswith("chatcmpl-")
# When response_object has a falsy id, convert_to_model_response_object
# replaces it with a new uuid.uuid4() (without "chatcmpl-" prefix),
# so the original auto-generated id is NOT preserved.
assert result.id != falsy_id
assert result.id != ""