scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-21 00:21:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 73

test(proxy): suppress TQ008 for pass-through CRUD global patches

Browse source 
The CRUD handlers reach their collaborators (config_passthrough_endpoints,
get/update_config_general_settings, route registry) through proxy_server
module globals imported at call time — there is no injection seam, so each
patch carries a test-quality-ok reason per the repo convention. The three
error-path tests now share one _db_only_crud_env contextmanager.
This commit is contained in:
pengzh1 2026-08-27 19:53:07 +08:00
parent 34f0d22d4a
commit c3465b9656
1 changed files with 23 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
tests/test_litellm/proxy/pass_through_endpoints/test_config_defined_endpoint_crud.py
View file

@ -1,17 +1,18 @@
"""
What is this?
Regression tests for #38195: config-file-defined pass-through endpoints are
merged into the GET list but can never be managed by the DB-backed CRUD
handlers. DELETE/UPDATE must return a targeted error pointing the operator
back to config.yaml instead of a misleading "not found".
"""
from collections.abc import Iterator
from contextlib import contextmanager
from unittest.mock import AsyncMock, patch
import pytest
from fastapi import HTTPException
from litellm.proxy._types import ConfigFieldInfo, UserAPIKeyAuth
from litellm.proxy._types import ConfigFieldInfo, PassThroughGenericEndpoint, UserAPIKeyAuth
from litellm.proxy.pass_through_endpoints.pass_through_endpoints import (
delete_pass_through_endpoints,
update_pass_through_endpoints,
@ -48,18 +49,27 @@ def _db_getter():
return _get
@pytest.mark.asyncio
async def test_delete_config_defined_endpoint_returns_targeted_error():
@contextmanager
def _db_only_crud_env() -> Iterator[None]:
"""Point the CRUD handlers at a DB copy plus one config-file endpoint,
the state a user of #38195 ends up in: the config endpoint is listed by
GET but absent from the DB-backed CRUD path."""
with (
patch(
patch( # test-quality-ok: proxy_server module global is the endpoint's only injection point
"litellm.proxy.proxy_server.config_passthrough_endpoints",
[dict(CONFIG_ENDPOINT)],
),
patch(
patch( # test-quality-ok: handlers import this from proxy_server at call time; no seam to inject
"litellm.proxy.proxy_server.get_config_general_settings",
side_effect=_db_getter(),
),
):
yield
@pytest.mark.asyncio
async def test_delete_config_defined_endpoint_returns_targeted_error():
with _db_only_crud_env():
with pytest.raises(HTTPException) as exc_info:
await delete_pass_through_endpoints(
endpoint_id="config-endpoint-id",
@ -73,18 +83,7 @@ async def test_delete_config_defined_endpoint_returns_targeted_error():
@pytest.mark.asyncio
async def test_update_config_defined_endpoint_returns_targeted_error():
from litellm.proxy._types import PassThroughGenericEndpoint
with (
patch(
"litellm.proxy.proxy_server.config_passthrough_endpoints",
[dict(CONFIG_ENDPOINT)],
),
patch(
"litellm.proxy.proxy_server.get_config_general_settings",
side_effect=_db_getter(),
),
):
with _db_only_crud_env():
with pytest.raises(HTTPException) as exc_info:
await update_pass_through_endpoints(
endpoint_id="config-endpoint-id",
@ -102,16 +101,7 @@ async def test_update_config_defined_endpoint_returns_targeted_error():
@pytest.mark.asyncio
async def test_delete_unknown_endpoint_keeps_generic_not_found():
with (
patch(
"litellm.proxy.proxy_server.config_passthrough_endpoints",
[dict(CONFIG_ENDPOINT)],
),
patch(
"litellm.proxy.proxy_server.get_config_general_settings",
side_effect=_db_getter(),
),
):
with _db_only_crud_env():
with pytest.raises(HTTPException) as exc_info:
await delete_pass_through_endpoints(
endpoint_id="does-not-exist",
@ -124,22 +114,20 @@ async def test_delete_unknown_endpoint_keeps_generic_not_found():
@pytest.mark.asyncio
async def test_delete_db_endpoint_still_works():
db_getter = _db_getter()
with (
patch(
patch( # test-quality-ok: proxy_server module global is the endpoint's only injection point
"litellm.proxy.proxy_server.config_passthrough_endpoints",
[dict(CONFIG_ENDPOINT)],
),
patch(
patch( # test-quality-ok: handlers import this from proxy_server at call time; no seam to inject
"litellm.proxy.proxy_server.get_config_general_settings",
side_effect=db_getter,
side_effect=_db_getter(),
),
patch(
patch( # test-quality-ok: handlers import this from proxy_server at call time; no seam to inject
"litellm.proxy.proxy_server.update_config_general_settings",
new_callable=AsyncMock,
) as mock_update,
patch(
patch( # test-quality-ok: mutates the live FastAPI route registry; no injection seam
"litellm.proxy.pass_through_endpoints.pass_through_endpoints.InitPassThroughEndpointHelpers.remove_endpoint_routes"
),
):