fix: add auth overrides to more spend tracking and model info tests

- Fix test_ui_view_spend_logs_pagination missing auth override (401)
- Fix test_view_spend_tags missing auth override (401)
- Fix test_view_spend_tags_no_database missing auth override (401)
- Fix test_empty_model_list.py to use app.dependency_overrides instead of patch()
  for FastAPI dependency injection auth

Co-authored-by: Ishaan Jaff <ishaan-jaff@users.noreply.github.com>

tests/test_litellm/proxy/spend_tracking/test_spend_management_endpoints.py

@@ -860,45 +860,52 @@ async def test_ui_view_spend_logs_pagination(client, monkeypatch):
         make_ui_spend_logs_mock_prisma(mock_spend_logs, lambda where: mock_spend_logs),
     )
 
-    start_date, end_date = _default_date_range()
-
-    # Test first page
-    response = client.get(
-        "/spend/logs/ui",
-        params={
-            "page": 1,
-            "page_size": 10,
-            "start_date": start_date,
-            "end_date": end_date,
-        },
-        headers={"Authorization": "Bearer sk-test"},
+    app.dependency_overrides[ps.user_api_key_auth] = lambda: UserAPIKeyAuth(
+        user_role=LitellmUserRoles.PROXY_ADMIN, user_id="admin_user"
     )
 
-    assert response.status_code == 200
-    data = response.json()
-    assert data["total"] == 25
-    assert len(data["data"]) == 10
-    assert data["page"] == 1
-    assert data["page_size"] == 10
-    assert data["total_pages"] == 3
+    try:
+        start_date, end_date = _default_date_range()
 
-    # Test second page
-    response = client.get(
-        "/spend/logs/ui",
-        params={
-            "page": 2,
-            "page_size": 10,
-            "start_date": start_date,
-            "end_date": end_date,
-        },
-        headers={"Authorization": "Bearer sk-test"},
-    )
+        # Test first page
+        response = client.get(
+            "/spend/logs/ui",
+            params={
+                "page": 1,
+                "page_size": 10,
+                "start_date": start_date,
+                "end_date": end_date,
+            },
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
-    assert response.status_code == 200
-    data = response.json()
-    assert data["total"] == 25
-    assert len(data["data"]) == 10
-    assert data["page"] == 2
+        assert response.status_code == 200
+        data = response.json()
+        assert data["total"] == 25
+        assert len(data["data"]) == 10
+        assert data["page"] == 1
+        assert data["page_size"] == 10
+        assert data["total_pages"] == 3
+
+        # Test second page
+        response = client.get(
+            "/spend/logs/ui",
+            params={
+                "page": 2,
+                "page_size": 10,
+                "start_date": start_date,
+                "end_date": end_date,
+            },
+            headers={"Authorization": "Bearer sk-test"},
+        )
+
+        assert response.status_code == 200
+        data = response.json()
+        assert data["total"] == 25
+        assert len(data["data"]) == 10
+        assert data["page"] == 2
+    finally:
+        app.dependency_overrides.pop(ps.user_api_key_auth, None)
 
 
 @pytest.mark.asyncio
@@ -1895,37 +1902,44 @@ async def test_view_spend_tags(client, monkeypatch):
         mock_get_spend_by_tags,
     )
 
-    # Test without date filters
-    response = client.get(
-        "/spend/tags",
-        headers={"Authorization": "Bearer sk-test"},
+    app.dependency_overrides[ps.user_api_key_auth] = lambda: UserAPIKeyAuth(
+        user_role=LitellmUserRoles.PROXY_ADMIN, user_id="admin_user"
     )
 
-    assert response.status_code == 200
-    data = response.json()
-    assert isinstance(data, list)
-    assert len(data) == 2
-    assert data[0]["individual_request_tag"] == "tag1"
-    assert data[0]["log_count"] == 10
-    assert data[0]["total_spend"] == 0.15
+    try:
+        # Test without date filters
+        response = client.get(
+            "/spend/tags",
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
-    # Test with date filters
-    start_date = "2024-01-01"
-    end_date = "2024-01-31"
+        assert response.status_code == 200
+        data = response.json()
+        assert isinstance(data, list)
+        assert len(data) == 2
+        assert data[0]["individual_request_tag"] == "tag1"
+        assert data[0]["log_count"] == 10
+        assert data[0]["total_spend"] == 0.15
 
-    response = client.get(
-        "/spend/tags",
-        params={
-            "start_date": start_date,
-            "end_date": end_date,
-        },
-        headers={"Authorization": "Bearer sk-test"},
-    )
+        # Test with date filters
+        start_date = "2024-01-01"
+        end_date = "2024-01-31"
 
-    assert response.status_code == 200
-    data = response.json()
-    assert isinstance(data, list)
-    assert len(data) == 2
+        response = client.get(
+            "/spend/tags",
+            params={
+                "start_date": start_date,
+                "end_date": end_date,
+            },
+            headers={"Authorization": "Bearer sk-test"},
+        )
+
+        assert response.status_code == 200
+        data = response.json()
+        assert isinstance(data, list)
+        assert len(data) == 2
+    finally:
+        app.dependency_overrides.pop(ps.user_api_key_auth, None)
 
 
 @pytest.mark.asyncio
@@ -1935,16 +1949,23 @@ async def test_view_spend_tags_no_database(client, monkeypatch):
     # Mock prisma_client as None
     monkeypatch.setattr("litellm.proxy.proxy_server.prisma_client", None)
 
-    response = client.get(
-        "/spend/tags",
-        headers={"Authorization": "Bearer sk-test"},
+    app.dependency_overrides[ps.user_api_key_auth] = lambda: UserAPIKeyAuth(
+        user_role=LitellmUserRoles.PROXY_ADMIN, user_id="admin_user"
     )
 
-    assert response.status_code == 500
-    data = response.json()
-    # Check the actual error message structure
-    assert "error" in data
-    assert "Database not connected" in data["error"]["message"]
+    try:
+        response = client.get(
+            "/spend/tags",
+            headers={"Authorization": "Bearer sk-test"},
+        )
+
+        assert response.status_code == 500
+        data = response.json()
+        # Check the actual error message structure
+        assert "error" in data
+        assert "Database not connected" in data["error"]["message"]
+    finally:
+        app.dependency_overrides.pop(ps.user_api_key_auth, None)
 
 
 @pytest.mark.asyncio

tests/test_litellm/proxy/test_empty_model_list.py

@@ -16,7 +16,9 @@ sys.path.insert(
     0, os.path.abspath("../../..")
 )  # Adds the parent directory to the system-path
 
+from litellm.proxy._types import LitellmUserRoles, UserAPIKeyAuth
 from litellm.proxy.proxy_server import app
+import litellm.proxy.proxy_server as ps
 
 
 @pytest.fixture
@@ -25,6 +27,16 @@ def client():
     return TestClient(app)
 
 
+@pytest.fixture(autouse=True)
+def mock_auth():
+    """Override auth dependency for all tests."""
+    app.dependency_overrides[ps.user_api_key_auth] = lambda: UserAPIKeyAuth(
+        user_role=LitellmUserRoles.PROXY_ADMIN, user_id="test-user"
+    )
+    yield
+    app.dependency_overrides.pop(ps.user_api_key_auth, None)
+
+
 class TestEmptyModelListHandling:
     """Test suite for empty model list scenarios."""
 
@@ -40,20 +52,10 @@ class TestEmptyModelListHandling:
         monkeypatch.setattr("litellm.proxy.proxy_server.user_model", None)
         monkeypatch.setattr("litellm.proxy.proxy_server.general_settings", {})
 
-        with patch(
-            "litellm.proxy.auth.user_api_key_auth.user_api_key_auth",
-            return_value=MagicMock(
-                user_id="test-user",
-                team_id=None,
-                team_models=[],
-                models=[],
-                user_role="proxy_admin",
-            ),
-        ):
-            response = client.get(
-                "/v2/model/info",
-                headers={"Authorization": "Bearer sk-test"},
-            )
+        response = client.get(
+            "/v2/model/info",
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
         assert response.status_code == 200
         data = response.json()
@@ -78,20 +80,10 @@ class TestEmptyModelListHandling:
         monkeypatch.setattr("litellm.proxy.proxy_server.user_model", None)
         monkeypatch.setattr("litellm.proxy.proxy_server.general_settings", {})
 
-        with patch(
-            "litellm.proxy.auth.user_api_key_auth.user_api_key_auth",
-            return_value=MagicMock(
-                user_id="test-user",
-                team_id=None,
-                team_models=[],
-                models=[],
-                user_role="proxy_admin",
-            ),
-        ):
-            response = client.get(
-                "/v2/model/info",
-                headers={"Authorization": "Bearer sk-test"},
-            )
+        response = client.get(
+            "/v2/model/info",
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
         assert response.status_code == 200
         data = response.json()
@@ -116,22 +108,12 @@ class TestEmptyModelListHandling:
         monkeypatch.setattr("litellm.proxy.proxy_server.user_model", None)
         monkeypatch.setattr("litellm.proxy.proxy_server.general_settings", {})
 
-        with patch(
-            "litellm.proxy.auth.user_api_key_auth.user_api_key_auth",
-            return_value=MagicMock(
-                user_id="test-user",
-                team_id=None,
-                team_models=[],
-                models=[],
-                user_role="proxy_admin",
-            ),
-        ):
-            # Test with custom pagination parameters
-            response = client.get(
-                "/v2/model/info",
-                params={"page": 2, "size": 25},
-                headers={"Authorization": "Bearer sk-test"},
-            )
+        # Test with custom pagination parameters
+        response = client.get(
+            "/v2/model/info",
+            params={"page": 2, "size": 25},
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
         assert response.status_code == 200
         data = response.json()
@@ -153,20 +135,10 @@ class TestEmptyModelListHandling:
         monkeypatch.setattr("litellm.proxy.proxy_server.user_model", None)
         monkeypatch.setattr("litellm.proxy.proxy_server.general_settings", {})
 
-        with patch(
-            "litellm.proxy.auth.user_api_key_auth.user_api_key_auth",
-            return_value=MagicMock(
-                user_id="test-user",
-                team_id=None,
-                team_models=[],
-                models=[],
-                user_role="proxy_admin",
-            ),
-        ):
-            response = client.get(
-                "/model_group/info",
-                headers={"Authorization": "Bearer sk-test"},
-            )
+        response = client.get(
+            "/model_group/info",
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
         assert response.status_code == 200
         assert response.json() == {"data": []}
@@ -186,20 +158,10 @@ class TestEmptyModelListHandling:
         monkeypatch.setattr("litellm.proxy.proxy_server.user_model", None)
         monkeypatch.setattr("litellm.proxy.proxy_server.general_settings", {})
 
-        with patch(
-            "litellm.proxy.auth.user_api_key_auth.user_api_key_auth",
-            return_value=MagicMock(
-                user_id="test-user",
-                team_id=None,
-                team_models=[],
-                models=[],
-                user_role="proxy_admin",
-            ),
-        ):
-            response = client.get(
-                "/model_group/info",
-                headers={"Authorization": "Bearer sk-test"},
-            )
+        response = client.get(
+            "/model_group/info",
+            headers={"Authorization": "Bearer sk-test"},
+        )
 
         assert response.status_code == 200
         assert response.json() == {"data": []}