scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-16 23:41:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 102

feat(mcp): wire OAuth disconnect handler and filter unapproved servers for non-admins

Browse source
This commit is contained in:
Ishaan Jaffer 2026-04-25 16:02:03 -07:00
parent 8759d6086b
commit bde67b182c
No known key found for this signature in database
1 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ui/litellm-dashboard/src/components/mcp_tools/mcp_servers.tsx
View file

@ -7,7 +7,7 @@ import React, { useEffect, useState, useMemo, useCallback } from "react";
import { useMCPServers } from "../../app/(dashboard)/hooks/mcpServers/useMCPServers";
import { useMCPServerHealth } from "../../app/(dashboard)/hooks/mcpServers/useMCPServerHealth";
import NotificationsManager from "../molecules/notifications_manager";
import { deleteMCPServer } from "../networking";
import { deleteMCPOAuthUserCredential, deleteMCPServer } from "../networking";
import { MCPSubmissionsTab } from "./MCPSubmissionsTab";
import { MCPToolsetsTab } from "./MCPToolsetsTab";
import { DataTable } from "../view_logs/table";
@ -130,6 +130,10 @@ const MCPServers: React.FC<MCPServerProps> = ({ accessToken, userRole, userID })
server.mcp_access_groups?.some((g: any) => (typeof g === "string" ? g === group : g && g.name === group)),
);
}
// Non-admins only see approved/active servers
if (isInternalUser) {
filtered = filtered.filter((server) => !server.approval_status || server.approval_status === "active");
}
const sorted = [...filtered].sort((a, b) => {
if (!a.created_at && !b.created_at) return 0;
if (!a.created_at) return 1;
@ -137,7 +141,7 @@ const MCPServers: React.FC<MCPServerProps> = ({ accessToken, userRole, userID })
return new Date(b.created_at).getTime() - new Date(a.created_at).getTime();
});
setFilteredServers(sorted);
}, [serversWithHealth]);
}, [serversWithHealth, isInternalUser]);
// Handle team filter change
const handleTeamChange = (teamId: string) => {
@ -156,6 +160,18 @@ const MCPServers: React.FC<MCPServerProps> = ({ accessToken, userRole, userID })
filterServers(selectedTeam, selectedMcpAccessGroup);
}, [serversWithHealth, selectedTeam, selectedMcpAccessGroup, filterServers]);
const handleOAuthDisconnect = useCallback(async (server: MCPServer) => {
if (!accessToken) return;
try {
await deleteMCPOAuthUserCredential(accessToken, server.server_id);
NotificationsManager.success("Disconnected from " + (server.server_name ?? server.server_id));
refetch();
} catch (error) {
console.error("Error disconnecting OAuth credential:", error);
NotificationsManager.fromBackend("Failed to disconnect credential");
}
}, [accessToken, refetch]);
const columns = React.useMemo(
() =>
mcpServerColumns(
@ -173,8 +189,11 @@ const MCPServers: React.FC<MCPServerProps> = ({ accessToken, userRole, userID })
(server: MCPServer) => setByokModalServer(server),
recheckServerHealth,
recheckingServerIds,
accessToken ?? undefined,
handleOAuthDisconnect,
refetch,
),
[userRole, isLoadingHealth, recheckServerHealth, recheckingServerIds],
[userRole, isLoadingHealth, recheckServerHealth, recheckingServerIds, accessToken, handleOAuthDisconnect, refetch],
);
function handleDelete(server_id: string) {