scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-17 23:51:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 67

fix(proxy/memory): omit metadata field when None on create

Browse source 
Prisma's Python client rejects `metadata=None` on a `Json?` field with
"A value is required but not set" — the field must be omitted from the
`data` dict entirely to store SQL NULL. Build the create payload
conditionally in both `create_memory` and the PUT-create branch of
`upsert_memory`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Krrish Dholakia 2026-04-23 07:28:15 -07:00
parent c1954017cc
commit bd9e1ba0a0
1 changed files with 27 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
litellm/proxy/memory/memory_endpoints.py
View file

@ -121,18 +121,22 @@ async def create_memory(
user_id = user_api_key_dict.user_id
team_id = user_api_key_dict.team_id
# Prisma's Python client rejects `metadata=None` on a `Json?` field —
# the field must be omitted entirely to store SQL NULL. Build the data
# dict conditionally so we only include metadata when the caller sent it.
create_data: dict = {
"key": body.key,
"value": body.value,
"user_id": user_id,
"team_id": team_id,
"created_by": user_api_key_dict.user_id,
"updated_by": user_api_key_dict.user_id,
}
if body.metadata is not None:
create_data["metadata"] = body.metadata
try:
row = await prisma_client.db.litellm_memorytable.create(
data={
"key": body.key,
"value": body.value,
"metadata": body.metadata,
"user_id": user_id,
"team_id": team_id,
"created_by": user_api_key_dict.user_id,
"updated_by": user_api_key_dict.user_id,
}
)
row = await prisma_client.db.litellm_memorytable.create(data=create_data)
except Exception as e:
# Unique constraint (key, user_id, team_id) → 409.
msg = str(e)
@ -270,17 +274,18 @@ async def upsert_memory(
status_code=400,
detail="Cannot create a new memory via PUT without a 'value'.",
)
row = await prisma_client.db.litellm_memorytable.create(
data={
"key": key,
"value": body.value,
"metadata": body.metadata,
"user_id": user_api_key_dict.user_id,
"team_id": user_api_key_dict.team_id,
"created_by": user_api_key_dict.user_id,
"updated_by": user_api_key_dict.user_id,
}
)
# Omit `metadata` when None — Prisma rejects None on Json? fields.
create_data: dict = {
"key": key,
"value": body.value,
"user_id": user_api_key_dict.user_id,
"team_id": user_api_key_dict.team_id,
"created_by": user_api_key_dict.user_id,
"updated_by": user_api_key_dict.user_id,
}
if body.metadata is not None:
create_data["metadata"] = body.metadata
row = await prisma_client.db.litellm_memorytable.create(data=create_data)
except HTTPException:
raise
except Exception as e: