From bc14992545c6107906981e2ef5eedb77c7cdf1b3 Mon Sep 17 00:00:00 2001 From: Jack Danger Date: Sun, 18 Oct 2026 09:46:22 +0000 Subject: [PATCH] test: assert the allowed self-edit path returns clean (test-quality TQ001) Generated-by: termag --- .../management_endpoints/test_internal_user_endpoints.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py b/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py index 5e9be008892..b2956d3ed42 100644 --- a/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py +++ b/tests/unit/proxy/management_endpoints/test_internal_user_endpoints.py @@ -5278,11 +5278,13 @@ def test_user_update_self_write_of_innocuous_field_allowed(): ) data = UpdateUserRequest(user_id="self", user_alias="me") - _reject_ceiling_self_update( + no_raise = _reject_ceiling_self_update( sent_fields=set(data.fields_set()), non_default_values={"user_alias": "me"}, user_api_key_dict=UserAPIKeyAuth(user_id="self", user_role=LitellmUserRoles.INTERNAL_USER), ) + # The observable on an allowed self-edit is that the guard raised nothing. + assert no_raise is None def test_user_update_admin_self_write_unrestricted(): @@ -5293,11 +5295,13 @@ def test_user_update_admin_self_write_unrestricted(): ) data = UpdateUserRequest(user_id="admin", rpm_limit=1000000, models=[]) - _reject_ceiling_self_update( + no_raise = _reject_ceiling_self_update( sent_fields=set(data.fields_set()), non_default_values={"rpm_limit": 1000000, "models": []}, user_api_key_dict=UserAPIKeyAuth(user_id="admin", user_role=LitellmUserRoles.PROXY_ADMIN), ) + # The observable on an admin self-edit is that the guard raised nothing. + assert no_raise is None # ---------------------------------------------------------------------------