fix: address review feedback — remove redundant guard, preserve summary in translate_anthropic_to_openai

- Remove redundant isinstance(thinking, dict) check in handler.py since
  early return on line 64 guarantees thinking is a dict at that point
- Preserve summary in translate_anthropic_to_openai() for consistency
  across all code paths (adapter, guardrail, main.py)
This commit is contained in:
Chesars 2026-03-04 10:51:59 -03:00
parent ece0325234
commit ba5d32b6b8
2 changed files with 6 additions and 2 deletions

View file

@ -78,7 +78,7 @@ class LiteLLMMessagesToCompletionTransformationHandler:
completion_kwargs["model"] = f"responses/{model}"
reasoning_effort = completion_kwargs.get("reasoning_effort")
summary = thinking.get("summary") if isinstance(thinking, dict) else None
summary = thinking.get("summary")
if isinstance(reasoning_effort, str) and reasoning_effort:
reasoning_dict: Dict[str, Any] = {"effort": reasoning_effort}
if summary:

View file

@ -892,7 +892,11 @@ class LiteLLMAnthropicMessagesAdapter:
cast(Dict[str, Any], thinking)
)
if reasoning_effort:
new_kwargs["reasoning_effort"] = reasoning_effort
summary = thinking.get("summary") if isinstance(thinking, dict) else None
if summary:
new_kwargs["reasoning_effort"] = {"effort": reasoning_effort, "summary": summary}
else:
new_kwargs["reasoning_effort"] = reasoning_effort
## CONVERT OUTPUT_FORMAT to RESPONSE_FORMAT
if "output_format" in anthropic_message_request: