From ba0233c4ce72e0f74dadb51a04c836834ce9ec79 Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Thu, 18 Jun 2026 15:47:51 -0700 Subject: [PATCH] fix(test): drop references to removed Agent Shin workflows (#30791) PR #30784 deleted .github/workflows/review_gate.yml and triage_pr_with_llm.yml, but test_github_triage_workflows.py still listed both in its parametrize tables, so _load_workflow raised FileNotFoundError for every case naming them. Remove the two stale entries from DESTRUCTIVE_GATE_ENV and LLM_CLIENT_INSTALLER_WORKFLOWS; the remaining four workflows that still exist keep their guardrail coverage. --- tests/test_litellm/test_github_triage_workflows.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/test_litellm/test_github_triage_workflows.py b/tests/test_litellm/test_github_triage_workflows.py index 7e718fd0ea8..ec6e9fc2381 100644 --- a/tests/test_litellm/test_github_triage_workflows.py +++ b/tests/test_litellm/test_github_triage_workflows.py @@ -46,19 +46,12 @@ WORKFLOWS_DIR = REPO_ROOT / ".github" / "workflows" # (rather than scraping every workflow file) means a new workflow file # that bypasses the dry-run gating doesn't silently slip past this test. DESTRUCTIVE_GATE_ENV: dict[str, str] = { - "triage_pr_with_llm.yml": "DISPATCH_CLOSE", "triage_issue_with_llm.yml": "DISPATCH_CLOSE", "close_low_quality_prs.yml": "CLOSE_FLAG", # The reconsider workflow has no per-run "really do it?" knob — its # only kill switch is `AGENT_SHIN_ENABLED`, which already serves as # both the destructive gate and the global enablement gate. "triage_reconsider.yml": "AGENT_SHIN_ENABLED", - # The review gate can add/remove labels, post comments, and close PRs. - # Its per-run knob is `CLOSE_FLAG` (from the workflow_dispatch input), - # gated by an outer `AGENT_SHIN_ENABLED = "true"` check. Listing it - # here ensures the same fail-safe `= "true"` and kill-switch invariants - # we enforce on every other destructive workflow are enforced here too. - "review_gate.yml": "CLOSE_FLAG", } @@ -67,9 +60,7 @@ DESTRUCTIVE_GATE_ENV: dict[str, str] = { # release would otherwise execute in that context. A new workflow that # installs the client must be added here and use the same pinned file. LLM_CLIENT_INSTALLER_WORKFLOWS = ( - "triage_pr_with_llm.yml", "triage_issue_with_llm.yml", - "review_gate.yml", "triage_reconsider.yml", "triage_rollout_heads_up.yml", )