scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-09 03:18:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 108

refactor(router_strategy): drop now-dead timedelta branch after up-front normalization

Browse source 
response_ms is normalized to float seconds at the top of both handlers,
so the isinstance(response_ms, timedelta) guard inside the ModelResponse
branch was unreachable and the Union[float, timedelta] annotation on
final_value was wider than reality. Review follow-up, no behavior change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mihidum Hettiyahandi 2026-07-15 09:30:53 +10:00
parent b5c363e016
commit b9a7b807b0
1 changed files with 12 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
litellm/router_strategy/lowest_latency.py
View file

@ -86,7 +86,7 @@ class LowestLatencyLoggingHandler(CustomLogger):
# only log ttft for streaming request
time_to_first_token_response_time = kwargs.get("completion_start_time", end_time) - start_time
final_value: Union[float, timedelta] = response_ms
final_value: float = response_ms
time_to_first_token: Optional[float] = None
total_tokens = 0
@ -96,15 +96,12 @@ class LowestLatencyLoggingHandler(CustomLogger):
completion_tokens = _usage.completion_tokens
total_tokens = _usage.total_tokens
# Handle both timedelta and float response times
if isinstance(response_ms, timedelta):
response_seconds = response_ms.total_seconds()
else:
response_seconds = response_ms
# response_ms is already normalized to float seconds above
response_seconds = response_ms
final_value = safe_divide_seconds(response_seconds, completion_tokens)
if final_value is not None:
final_value = float(final_value)
normalized_value = safe_divide_seconds(response_seconds, completion_tokens)
if normalized_value is not None:
final_value = float(normalized_value)
else:
final_value = response_seconds
@ -281,7 +278,7 @@ class LowestLatencyLoggingHandler(CustomLogger):
# only log ttft for streaming request
time_to_first_token_response_time = kwargs.get("completion_start_time", end_time) - start_time
final_value: Union[float, timedelta] = response_ms
final_value: float = response_ms
total_tokens = 0
time_to_first_token: Optional[float] = None
@ -291,15 +288,12 @@ class LowestLatencyLoggingHandler(CustomLogger):
completion_tokens = _usage.completion_tokens
total_tokens = _usage.total_tokens
# Handle both timedelta and float response times
if isinstance(response_ms, timedelta):
response_seconds = response_ms.total_seconds()
else:
response_seconds = response_ms
# response_ms is already normalized to float seconds above
response_seconds = response_ms
final_value = safe_divide_seconds(response_seconds, completion_tokens)
if final_value is not None:
final_value = float(final_value)
normalized_value = safe_divide_seconds(response_seconds, completion_tokens)
if normalized_value is not None:
final_value = float(normalized_value)
else:
final_value = response_ms