From b4c3adc37d1be33550803bce9c88bc190c8f4ec6 Mon Sep 17 00:00:00 2001
From: Yuneng Jiang <yuneng@berri.ai>
Date: Thu, 17 Sep 2026 23:12:33 -0700
Subject: [PATCH] test(ui): assert dashboard form cleanup

---
 tests/e2e/ui/tests/prompts/addPrompt.spec.ts  | 39 ++++++++++++-------
 .../tests/tagManagement/tagManagement.spec.ts | 30 +++++++-------
 2 files changed, 40 insertions(+), 29 deletions(-)

diff --git a/tests/e2e/ui/tests/prompts/addPrompt.spec.ts b/tests/e2e/ui/tests/prompts/addPrompt.spec.ts
index f9868f7b04b..a4a6cf62b7e 100644
--- a/tests/e2e/ui/tests/prompts/addPrompt.spec.ts
+++ b/tests/e2e/ui/tests/prompts/addPrompt.spec.ts
@@ -17,21 +17,32 @@ test.describe("Prompt upload form", () => {
     await navigateToPage(page, DashboardPage.Prompts);
     await page.getByRole("button", { name: "Upload .prompt File" }).click();
 
-    try {
-      await expect(
-        page.getByRole("dialog", { name: "Add New Prompt" }),
-      ).toBeVisible();
-      await page.getByLabel("Prompt ID").fill(promptId);
-      await page.locator('input[type="file"]').setInputFiles({
-        name: "e2e.prompt",
-        mimeType: "text/plain",
-        buffer: Buffer.from(
-          `model: fake-openai-gpt-4\ntemplate: "${promptContent}"\n`,
-        ),
-      });
-      await expect(page.getByText("Selected: e2e.prompt")).toBeVisible();
-      await page.getByRole("button", { name: "Create Prompt" }).click();
+    await expect(
+      page.getByRole("dialog", { name: "Add New Prompt" }),
+    ).toBeVisible();
+    await page.getByLabel("Prompt ID").fill(promptId);
+    await page.locator('input[type="file"]').setInputFiles({
+      name: "e2e.prompt",
+      mimeType: "text/plain",
+      buffer: Buffer.from(
+        `model: fake-openai-gpt-4\ntemplate: "${promptContent}"\n`,
+      ),
+    });
+    await expect(page.getByText("Selected: e2e.prompt")).toBeVisible();
+    await page.getByRole("button", { name: "Create Prompt" }).click();
 
+    await expect
+      .poll(async () => {
+        const response = await page.request.get(
+          `/prompts/${encodeURIComponent(promptId)}/info?environment=development`,
+          {
+            headers: { Authorization: `Bearer ${masterKey()}` },
+          },
+        );
+        return response.ok();
+      })
+      .toBe(true);
+    try {
       await expect
         .poll(async () => {
           const response = await page.request.get(
diff --git a/tests/e2e/ui/tests/tagManagement/tagManagement.spec.ts b/tests/e2e/ui/tests/tagManagement/tagManagement.spec.ts
index e1d5138ea90..1104031263e 100644
--- a/tests/e2e/ui/tests/tagManagement/tagManagement.spec.ts
+++ b/tests/e2e/ui/tests/tagManagement/tagManagement.spec.ts
@@ -17,22 +17,22 @@ test.describe("Tag management", () => {
     await navigateToPage(page, DashboardPage.TagManagement);
     await page.getByRole("button", { name: "+ Create New Tag" }).click();
 
-    try {
-      await expect(
-        page.getByRole("dialog", { name: "Create New Tag" }),
-      ).toBeVisible();
-      await page.getByLabel("Tag Name").fill(tagName);
-      await page.getByLabel("Description").fill(description);
-      await page.getByRole("button", { name: "Create Tag" }).click();
+    await expect(
+      page.getByRole("dialog", { name: "Create New Tag" }),
+    ).toBeVisible();
+    await page.getByLabel("Tag Name").fill(tagName);
+    await page.getByLabel("Description").fill(description);
+    await page.getByRole("button", { name: "Create Tag" }).click();
 
-      await expect
-        .poll(async () => {
-          const response = await readBack<
-            Record<string, Record<string, unknown>>
-          >(page, "/tag/list");
-          return Object.values(response).some((tag) => tag.name === tagName);
-        })
-        .toBe(true);
+    await expect
+      .poll(async () => {
+        const response = await readBack<
+          Record<string, Record<string, unknown>>
+        >(page, "/tag/list");
+        return Object.values(response).some((tag) => tag.name === tagName);
+      })
+      .toBe(true);
+    try {
       await expect(page.getByText(tagName, { exact: true })).toBeVisible();
 
       await page.getByText(tagName, { exact: true }).click();