From b3ac8fc0650cfab5c816b96aa0f13ddc2e3f1a48 Mon Sep 17 00:00:00 2001
From: Krrish Dholakia <krrishdholakia@berri.ai>
Date: Wed, 1 Jul 2026 03:37:51 +0000
Subject: [PATCH] fix: remove unnecessary isinstance check and restore
 basedpyright budget

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
---
 basedpyright-code-budget.json                 | 195 +++++++++++++++++-
 .../object_permission_utils.py                |   8 +-
 2 files changed, 198 insertions(+), 5 deletions(-)

diff --git a/basedpyright-code-budget.json b/basedpyright-code-budget.json
index 0967ef424bc..f2b54e1f889 100644
--- a/basedpyright-code-budget.json
+++ b/basedpyright-code-budget.json
@@ -1 +1,194 @@
-{}
+{
+  "reportAny": {
+    "baseline": 24989,
+    "slack": 2500
+  },
+  "reportArgumentType": {
+    "baseline": 1814,
+    "slack": 180
+  },
+  "reportAssignmentType": {
+    "baseline": 220,
+    "slack": 22
+  },
+  "reportAttributeAccessIssue": {
+    "baseline": 346,
+    "slack": 35
+  },
+  "reportCallIssue": {
+    "baseline": 87,
+    "slack": 10
+  },
+  "reportConstantRedefinition": {
+    "baseline": 39,
+    "slack": 4
+  },
+  "reportDeprecated": {
+    "baseline": 217,
+    "slack": 22
+  },
+  "reportDuplicateImport": {
+    "baseline": 28,
+    "slack": 3
+  },
+  "reportExplicitAny": {
+    "baseline": 6931,
+    "slack": 700
+  },
+  "reportFunctionMemberAccess": {
+    "baseline": 7,
+    "slack": 3
+  },
+  "reportGeneralTypeIssues": {
+    "baseline": 151,
+    "slack": 15
+  },
+  "reportIncompatibleMethodOverride": {
+    "baseline": 52,
+    "slack": 5
+  },
+  "reportIncompatibleVariableOverride": {
+    "baseline": 8,
+    "slack": 3
+  },
+  "reportInconsistentOverload": {
+    "baseline": 12,
+    "slack": 3
+  },
+  "reportIndexIssue": {
+    "baseline": 26,
+    "slack": 3
+  },
+  "reportInvalidTypeForm": {
+    "baseline": 23,
+    "slack": 3
+  },
+  "reportInvalidTypeVarUse": {
+    "baseline": 2,
+    "slack": 3
+  },
+  "reportMatchNotExhaustive": {
+    "baseline": 1,
+    "slack": 0
+  },
+  "reportMissingParameterType": {
+    "baseline": 3933,
+    "slack": 390
+  },
+  "reportMissingTypeArgument": {
+    "baseline": 10612,
+    "slack": 1000
+  },
+  "reportMissingTypeStubs": {
+    "baseline": 27,
+    "slack": 10
+  },
+  "reportOperatorIssue": {
+    "baseline": 6,
+    "slack": 3
+  },
+  "reportOptionalCall": {
+    "baseline": 4,
+    "slack": 3
+  },
+  "reportOptionalIterable": {
+    "baseline": 3,
+    "slack": 3
+  },
+  "reportOptionalMemberAccess": {
+    "baseline": 724,
+    "slack": 72
+  },
+  "reportOptionalOperand": {
+    "baseline": 3,
+    "slack": 3
+  },
+  "reportOptionalSubscript": {
+    "baseline": 11,
+    "slack": 3
+  },
+  "reportPossiblyUnboundVariable": {
+    "baseline": 52,
+    "slack": 10
+  },
+  "reportPrivateUsage": {
+    "baseline": 1625,
+    "slack": 160
+  },
+  "reportRedeclaration": {
+    "baseline": 8,
+    "slack": 3
+  },
+  "reportReturnType": {
+    "baseline": 126,
+    "slack": 100
+  },
+  "reportTypedDictNotRequiredAccess": {
+    "baseline": 20,
+    "slack": 3
+  },
+  "reportUndefinedVariable": {
+    "baseline": 2,
+    "slack": 3
+  },
+  "reportUnknownArgumentType": {
+    "baseline": 30603,
+    "slack": 3000
+  },
+  "reportUnknownLambdaType": {
+    "baseline": 75,
+    "slack": 10
+  },
+  "reportUnknownMemberType": {
+    "baseline": 27037,
+    "slack": 2500
+  },
+  "reportUnknownParameterType": {
+    "baseline": 13612,
+    "slack": 1000
+  },
+  "reportUnknownVariableType": {
+    "baseline": 21445,
+    "slack": 2000
+  },
+  "reportUnnecessaryCast": {
+    "baseline": 118,
+    "slack": 10
+  },
+  "reportUnnecessaryComparison": {
+    "baseline": 683,
+    "slack": 100
+  },
+  "reportUnnecessaryContains": {
+    "baseline": 4,
+    "slack": 3
+  },
+  "reportUnnecessaryIsInstance": {
+    "baseline": 808,
+    "slack": 80
+  },
+  "reportUntypedBaseClass": {
+    "baseline": 110,
+    "slack": 11
+  },
+  "reportUntypedFunctionDecorator": {
+    "baseline": 22,
+    "slack": 3
+  },
+  "reportUnusedClass": {
+    "baseline": 22,
+    "slack": 3
+  },
+  "reportUnusedFunction": {
+    "baseline": 137,
+    "slack": 10
+  },
+  "reportUnusedImport": {
+    "baseline": 670,
+    "slack": 50
+  },
+  "reportUnusedVariable": {
+    "baseline": 865,
+    "slack": 50
+  }
+}
diff --git a/litellm/proxy/management_helpers/object_permission_utils.py b/litellm/proxy/management_helpers/object_permission_utils.py
index c9c96816ed2..ffa78ef4d19 100644
--- a/litellm/proxy/management_helpers/object_permission_utils.py
+++ b/litellm/proxy/management_helpers/object_permission_utils.py
@@ -422,12 +422,12 @@ def _extract_requested_mcp_server_ids(
 def _has_all_mcp_servers_sentinel(
     object_permission: Optional[ObjectPermissionDict],
 ) -> bool:
-    if not object_permission or not isinstance(object_permission, dict):
+    if not object_permission:
         return False
     mcp_servers = object_permission.get("mcp_servers")
-    if isinstance(mcp_servers, list):
-        return SpecialMCPServerNames.all_mcp_servers.value in mcp_servers
-    return False
+    if not mcp_servers:
+        return False
+    return SpecialMCPServerNames.all_mcp_servers.value in mcp_servers
 
 
 def _extract_requested_mcp_access_groups(