scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-19 00:01:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 122

test(ui): raise timeout to 60s for 3 slow MCP OAuth create flows

Browse source 
The three OAuth-delegate / true-passthrough create-server tests in
create_mcp_server.test.tsx run ~8s locally, which flakes past the
default 30s testTimeout in CI when the vitest `--pool forks
--poolOptions.forks.maxForks=14` fan-out pushes several such tests
onto a single runner CPU at once. Give them 60s headroom instead of
the file-wide 30s; each still asserts real MCP OAuth token-boundary
behavior and must stay a real test, not a skip.

Co-authored-by: Krrish Dholakia <krrish-berri-2@users.noreply.github.com>
This commit is contained in:
Cursor Agent 2026-07-24 06:18:34 +00:00
parent 2798f39f5a
commit b3a3684004
No known key found for this signature in database
1 changed files with 55 additions and 50 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

105
ui/litellm-dashboard/src/app/(dashboard)/mcp-servers/_components/create_mcp_server.test.tsx
View file

@ -380,64 +380,68 @@ describe("CreateMCPServer", () => {
it.each([
["true_passthrough", "True Passthrough (no LiteLLM auth)"],
["oauth_delegate", "OAuth Delegate (client-supplied upstream token)"],
])("persists only tool config on create for %s; the token stays browser-held", async (_authType, optionLabel) => {
oauthHook.tokenResponse = { access_token: "upstream-tok", token_type: "Bearer" };
await selectHttpTransport();
])(
"persists only tool config on create for %s; the token stays browser-held",
async (_authType, optionLabel) => {
oauthHook.tokenResponse = { access_token: "upstream-tok", token_type: "Bearer" };
await selectHttpTransport();
const user = userEvent.setup({ delay: null });
await user.type(getServerNameInput(), "CF_Server");
await user.type(screen.getByPlaceholderText("https://your-mcp-server.com"), "https://example.com/mcp");
const user = userEvent.setup({ delay: null });
await user.type(getServerNameInput(), "CF_Server");
await user.type(screen.getByPlaceholderText("https://your-mcp-server.com"), "https://example.com/mcp");
await selectAntOption("Authentication", optionLabel);
await selectAntOption("Authentication", optionLabel);
await waitFor(() => expect(oauthHook.onTokenReceived).toBeTruthy());
await act(async () => {
oauthHook.onTokenReceived!({ access_token: "upstream-tok", token_type: "Bearer" }, undefined);
});
await waitFor(() => expect(oauthHook.onTokenReceived).toBeTruthy());
await act(async () => {
oauthHook.onTokenReceived!({ access_token: "upstream-tok", token_type: "Bearer" }, undefined);
});
fireEvent.click(screen.getByRole("button", { name: "Disable all tools" }));
fireEvent.click(screen.getByRole("button", { name: "Disable all tools" }));
// Previewing and configuring must stay stateless: nothing is persisted anywhere (server row,
// per-user DB credential, sessionStorage) until the admin submits.
expect(networking.createMCPServer).not.toHaveBeenCalled();
expect(networking.storeMCPOAuthUserCredential).not.toHaveBeenCalled();
expect(setToken).not.toHaveBeenCalled();
// Previewing and configuring must stay stateless: nothing is persisted anywhere (server row,
// per-user DB credential, sessionStorage) until the admin submits.
expect(networking.createMCPServer).not.toHaveBeenCalled();
expect(networking.storeMCPOAuthUserCredential).not.toHaveBeenCalled();
expect(setToken).not.toHaveBeenCalled();
const createdServer = {
server_id: "new-cf-server",
server_name: "CF_Server",
alias: "CF_Server",
url: "https://example.com/mcp",
transport: "http",
auth_type: _authType,
created_at: "2024-01-01T00:00:00Z",
created_by: "user-1",
updated_at: "2024-01-01T00:00:00Z",
updated_by: "user-1",
};
vi.mocked(networking.createMCPServer).mockResolvedValue(createdServer);
const createdServer = {
server_id: "new-cf-server",
server_name: "CF_Server",
alias: "CF_Server",
url: "https://example.com/mcp",
transport: "http",
auth_type: _authType,
created_at: "2024-01-01T00:00:00Z",
created_by: "user-1",
updated_at: "2024-01-01T00:00:00Z",
updated_by: "user-1",
};
vi.mocked(networking.createMCPServer).mockResolvedValue(createdServer);
const submitButton = screen.getByRole("button", { name: "Add MCP Server" });
await act(async () => {
fireEvent.click(submitButton);
});
const submitButton = screen.getByRole("button", { name: "Add MCP Server" });
await act(async () => {
fireEvent.click(submitButton);
});
await waitFor(() => expect(networking.createMCPServer).toHaveBeenCalledTimes(1));
const [, payload] = vi.mocked(networking.createMCPServer).mock.calls[0];
await waitFor(() => expect(networking.createMCPServer).toHaveBeenCalledTimes(1));
const [, payload] = vi.mocked(networking.createMCPServer).mock.calls[0];
// Only the tool configuration persists on the server row; the upstream token appears nowhere
// in the create payload and no per-user DB credential is written. The token is committed to
// sessionStorage only, keyed to the created server.
expect(payload.allowed_tools).toEqual([]);
expect(payload.credentials).toBeUndefined();
expect(JSON.stringify(payload)).not.toContain("upstream-tok");
expect(networking.storeMCPOAuthUserCredential).not.toHaveBeenCalled();
expect(setToken).toHaveBeenCalledWith(
"new-cf-server",
expect.objectContaining({ access_token: "upstream-tok" }),
undefined,
);
});
// Only the tool configuration persists on the server row; the upstream token appears nowhere
// in the create payload and no per-user DB credential is written. The token is committed to
// sessionStorage only, keyed to the created server.
expect(payload.allowed_tools).toEqual([]);
expect(payload.credentials).toBeUndefined();
expect(JSON.stringify(payload)).not.toContain("upstream-tok");
expect(networking.storeMCPOAuthUserCredential).not.toHaveBeenCalled();
expect(setToken).toHaveBeenCalledWith(
"new-cf-server",
expect.objectContaining({ access_token: "upstream-tok" }),
undefined,
);
},
60_000,
);
it.each([
["true_passthrough", "True Passthrough (no LiteLLM auth)"],
@ -504,6 +508,7 @@ describe("CreateMCPServer", () => {
undefined,
);
},
60_000,
);
it("preserves admin-entered app credentials when the URL changes after authorize for true_passthrough", async () => {
@ -561,7 +566,7 @@ describe("CreateMCPServer", () => {
client_secret: "org-app-secret",
});
expect(JSON.stringify(payload)).not.toContain("upstream-tok");
});
}, 60_000);
it("wipes oauth2-minted credentials when the auth type switches to a client-forwarded mode", async () => {
await selectHttpTransport();