From b110c8cfa7422be35753eb550807e1a7bdf9375b Mon Sep 17 00:00:00 2001 From: yuneng-jiang Date: Mon, 19 Oct 2026 15:06:02 -0700 Subject: [PATCH] test(integration): check SSO sign-in removal without reaching the public internet (#47409) The SSO removal test configured Google sign-in, which fetches its discovery document from accounts.google.com before redirecting. CircleCI blocks that egress, so the test failed on every main run since #46709 added it. Microsoft sign-in builds its endpoints locally and goes through the same SSO environment variable handling, so the test now uses it --- tests/integration/configuration/test_effective_settings.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/integration/configuration/test_effective_settings.py b/tests/integration/configuration/test_effective_settings.py index acdaacfcfb5..07477f1f048 100644 --- a/tests/integration/configuration/test_effective_settings.py +++ b/tests/integration/configuration/test_effective_settings.py @@ -1547,8 +1547,8 @@ def test_an_sso_client_removed_from_db_environment_variables_stops_sign_in_on_ev "DATABASE_URL_READ_REPLICA", "GENERIC_CLIENT_ID", "GOOGLE_CLIENT_ID", - "GOOGLE_CLIENT_SECRET", "MICROSOFT_CLIENT_ID", + "MICROSOFT_CLIENT_SECRET", "PROXY_BASE_URL", ) with ( @@ -1567,7 +1567,7 @@ def test_an_sso_client_removed_from_db_environment_variables_stops_sign_in_on_ev response: Final = first.request( "POST", "/config/update", - {"environment_variables": {"GOOGLE_CLIENT_ID": client_id, "GOOGLE_CLIENT_SECRET": secret}}, + {"environment_variables": {"MICROSOFT_CLIENT_ID": client_id, "MICROSOFT_CLIENT_SECRET": secret}}, ) assert response.status_code == 200, response.text @@ -1584,7 +1584,7 @@ def test_an_sso_client_removed_from_db_environment_variables_stops_sign_in_on_ev moved: Final = first.request( "PATCH", "/update/sso_settings", - {"google_client_id": sso_table_client, "google_client_secret": "sso-table-secret"}, + {"microsoft_client_id": sso_table_client, "microsoft_client_secret": "sso-table-secret"}, ) assert moved.status_code == 200, moved.text eventually(sign_in_clients, lambda clients: clients == (sso_table_client,) * 2, seconds=30)