scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-08 03:08:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 114

revert(ui): keep Projects nav visible to every role when the Projects UI flag is on

Browse source 
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
jesus 2026-09-08 17:41:19 +00:00
parent 194c06a30c
commit b0b595c177
2 changed files with 2 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
ui/litellm-dashboard/src/components/leftnav.test.tsx
View file

@ -3,8 +3,6 @@ import { afterEach, describe, expect, it, vi } from "vitest";
import { renderWithProviders } from "../../tests/test-utils";
import Sidebar, { menuGroups, getBreadcrumb } from "./leftnav";
const teamAdminState = vi.hoisted(() => ({ isTeamAdmin: false }));
vi.mock("../utils/roles", async (importOriginal) => {
const actual = await importOriginal<typeof import("../utils/roles")>();
return {
@ -15,7 +13,7 @@ vi.mock("../utils/roles", async (importOriginal) => {
rolesWithWriteAccess: ["admin", "internal"],
rolesAllowedToViewWriteScopedPages: ["admin", "internal", "admin_viewer"],
isAdminRole: (role: string) => role === "admin" || role === "admin_viewer",
isUserTeamAdminForAnyTeam: () => teamAdminState.isTeamAdmin,
isUserTeamAdminForAnyTeam: () => false,
};
});
@ -588,50 +586,6 @@ describe("Sidebar (leftnav)", () => {
expect(container.querySelector('a[href*="projects"]')).toBeNull();
});
describe("Projects visibility for delegated admins", () => {
const internalAuth = {
userId: "internal-user-id",
accessToken: "test-access-token",
userRole: "internal",
isViewOnly: false,
token: "test-token",
userEmail: "internal@example.com",
premiumUser: false,
disabledPersonalKeyCreation: false,
showSSOBanner: false,
};
afterEach(() => {
mockUseAuthorized.mockReset();
mockUseOrganizations.mockReset();
teamAdminState.isTeamAdmin = false;
});
it("hides Projects from a plain internal user", () => {
mockUseAuthorized.mockReturnValue(internalAuth);
renderWithProviders(<Sidebar {...defaultProps} enableProjectsUI />);
expect(screen.queryByText("Projects")).not.toBeInTheDocument();
});
it("shows Projects to an internal user who administers a team", () => {
mockUseAuthorized.mockReturnValue(internalAuth);
teamAdminState.isTeamAdmin = true;
renderWithProviders(<Sidebar {...defaultProps} enableProjectsUI />);
expect(screen.getByText("Projects")).toBeInTheDocument();
});
it("shows Projects to an internal user who administers an organization", () => {
mockUseAuthorized.mockReturnValue(internalAuth);
mockUseOrganizations.mockReturnValue({
data: [{ organization_id: "org-1", members: [{ user_id: "internal-user-id", user_role: "org_admin" }] }],
isLoading: false,
error: null,
});
renderWithProviders(<Sidebar {...defaultProps} enableProjectsUI />);
expect(screen.getByText("Projects")).toBeInTheDocument();
});
});
it("keeps a readable collapsed-rail tooltip for items whose label carries a badge", () => {
const { container } = renderWithProviders(<Sidebar {...defaultProps} enableProjectsUI collapsed />);

5
ui/litellm-dashboard/src/components/leftnav.tsx
View file

@ -475,10 +475,7 @@ const Sidebar_: React.FC<SidebarProps> = ({
if (!isAdmin && enabledPagesInternalUsers != null) return enabledPagesInternalUsers.includes(item.page);
return true;
}
if (item.key === "projects") {
if (!enableProjectsUI) return false;
return isAdmin || isOrgAdmin || isTeamAdmin;
}
if (item.key === "projects" && !enableProjectsUI) return false;
if (
!isAdmin &&
item.key === "agents" &&