scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-12 03:48:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 57

fix(tracing): classify tool attempts without optional span tags

Browse source
This commit is contained in:
moe-berri 2026-10-06 14:14:09 -07:00
parent a2eaafceaf
commit afad9c045a
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm-rust/crates/traces-clickhouse/query/span_detail.sql
View file

@ -66,7 +66,7 @@ SELECT o.SpanId AS span_id,
concat('[', arrayStringConcat(arrayFilter(result -> JSONExtractString(result, 'id') != '' AND NOT has(e.call_ids, JSONExtractString(result, 'id')),
JSONExtractArrayRaw(o.Output, 'tool_results')), ','), ']'), '[]'),
'lens.content.input_source', multiIf(o.native_tool AND length(i.values) = 1, i.source_span, o.Input != '', o.SpanId, ''),
'lens.content.execution_status', if(o.native_tool AND o.SpanAttributes['span.type'] = 'tool',
'lens.content.execution_status', if(o.native_tool,
if(x.execution_span_id != '', 'recorded', 'not_recorded'), ''),
'lens.content.output_source', multiIf(o.Output != '', o.SpanId, o.native_tool AND length(r.values) = 1, r.source_span, o.ObservationType = 'agent' AND a.output != '', a.source_span, ''),
'lens.content.input_status', multiIf(o.native_tool AND length(i.values) > 1, 'conflicting', input != '', 'recorded', 'not_recorded'),

11
litellm-rust/crates/traces-clickhouse/tests/reads.rs
View file

@ -844,14 +844,17 @@ async fn native_cost_correlation_survives_session_grouping_and_excludes_other_ow
}
#[rstest]
#[case::recorded(false, true)]
#[case::conflicting(true, true)]
#[case::invocation_without_execution(false, false)]
#[case::recorded(false, true, true)]
#[case::conflicting(true, true, true)]
#[case::invocation_without_execution(false, false, true)]
#[case::untyped_invocation_without_execution(false, false, false)]
#[case::untyped_invocation_with_execution(false, true, false)]
#[tokio::test]
async fn native_tool_content_agrees_between_single_and_bulk_reads(
#[future(awt)] migrated_database: TestResult<SeededDatabase>,
#[case] conflict: bool,
#[case] executed: bool,
#[case] span_type: bool,
) -> TestResult {
use litellm_storage_clickhouse::fetch;
use litellm_traces::query::named::{SpanDetailParams, SpanDetailsParams};
@ -977,7 +980,7 @@ async fn native_tool_content_agrees_between_single_and_bulk_reads(
("Output".into(), json!(output)),
(
"SpanAttributes".into(),
json!({"session.id":session,"tool_use_id":"call", "span.type": if kind == "tool" { "tool" } else { "" }}),
json!({"session.id":session,"tool_use_id":"call", "span.type": if span_type && kind == "tool" { "tool" } else { "" }}),
),
("TeamId".into(), json!(team)),
("ApiKeyHash".into(), json!(key)),