scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-17 23:51:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 139

address greptile review feedback (greploop iteration 5)

Browse source
This commit is contained in:
Ishaan Jaffer 2026-03-11 19:15:05 -07:00
parent 7d5eb0c558
commit ae9b2f93ef
2 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
litellm/proxy/_experimental/mcp_server/rest_endpoints.py
View file

@ -409,17 +409,21 @@ if MCP_AVAILABLE:
if server_id:
# Resolve a server name to its UUID if needed (MCPConnectPicker passes
# server_name strings, but allowed_server_ids_set contains UUIDs).
# _name_resolved is kept so the second check can reuse it for accurate
# IP-filter error reporting if the resolved UUID is not in allowed_server_ids.
_name_resolved = None
if server_id not in allowed_server_ids:
_resolved = global_mcp_server_manager.get_mcp_server_by_name(server_id)
if _resolved is not None and _resolved.server_id in set(allowed_server_ids):
server_id = _resolved.server_id
_name_resolved = global_mcp_server_manager.get_mcp_server_by_name(server_id)
if _name_resolved is not None and _name_resolved.server_id in set(allowed_server_ids):
server_id = _name_resolved.server_id
if server_id not in allowed_server_ids:
_server = global_mcp_server_manager.get_mcp_server_by_id(server_id)
if _server is None:
# server_id may be a name string — look up by name for accurate
# IP-filter error reporting (get_mcp_server_by_id only matches UUIDs).
_server = global_mcp_server_manager.get_mcp_server_by_name(server_id)
# Try UUID lookup first; fall back to the name-resolved server so that
# IP-filter reporting works correctly even when server_id is a name string.
_server = (
global_mcp_server_manager.get_mcp_server_by_id(server_id)
or _name_resolved
)
if (
_server is not None
and _rest_client_ip is not None

2
ui/litellm-dashboard/src/components/chat/MCPAppsPanel.tsx
View file

@ -319,7 +319,7 @@ const MCPAppsPanel: React.FC<Props> = ({ accessToken, selectedServers, onChange
// Ignore — credential may already be gone; update UI regardless.
}
setOauthConnected((prev) => { const n = new Set(prev); n.delete(detailServer.server_id); return n; });
onChange(selectedServers.filter((s) => s !== name));
onChangeRef.current(selectedServersRef.current.filter((s) => s !== name));
}}
style={{ borderRadius: 8, fontWeight: 600, height: 38, minWidth: 110 }}
>