scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-29 01:42:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 79

address greptile review: drop restating comments, type test params

Browse source
This commit is contained in:
aishwary-dongre 2026-09-04 17:22:50 +00:00
parent 7e02eb219b
commit abc80708c1
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tests/test_litellm/llms/bedrock/chat/test_converse_transformation.py
View file

@ -465,19 +465,15 @@ def test_reasoning_effort_none_omits_thinking_for_anthropic_converse(model):
@pytest.mark.parametrize(
"max_tokens,expect_thinking,expect_budget_below_max_tokens",
[
(1024, False, None), # at/below Bedrock's min thinking budget -> thinking dropped entirely
(2048, True, True), # medium's default budget (2048) equals max_tokens -> must be clamped below it
(4096, True, False), # budget already fits comfortably under max_tokens -> left unchanged
(1024, False, None),
(2048, True, True),
(4096, True, False),
],
)
def test_reasoning_effort_thinking_budget_clamped_to_max_tokens_converse(
max_tokens, expect_thinking, expect_budget_below_max_tokens
):
"""Regression #39627: a deployment-level reasoning_effort must not send a
thinking.budget_tokens that is >= max_tokens on Bedrock Converse. Bedrock
requires maxTokens strictly greater than thinking.budget_tokens, so the
mapped budget must be clamped the same way the adaptive-downgrade branch
already clamps it, or dropped when even the 1024 minimum can't fit."""
max_tokens: int, expect_thinking: bool, expect_budget_below_max_tokens: bool | None
) -> None:
"""Regression #39627."""
config = AmazonConverseConfig()
optional_params = config.map_openai_params(