scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-14 23:21:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 102

refactor(mcp-semantic-filter): extract _partition_mcp_tools to fix PLR0915

Browse source 
async_pre_call_hook hit ruff PLR0915 (54 > 50 statements). Move the
MCP/non-MCP partition block into a dedicated helper — same behavior,
fewer statements in the hook entrypoint.
This commit is contained in:
Lance Hsu 2026-04-24 17:21:54 +08:00
parent 3e23e17d17
commit ab64ae2bdb
No known key found for this signature in database
GPG key ID: CFF816BB8560B8B8
1 changed files with 26 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
litellm/proxy/hooks/mcp_semantic_filter/hook.py
View file

@ -5,7 +5,7 @@ Pre-call hook that filters MCP tools semantically before LLM inference.
Reduces context window size and improves tool selection accuracy.
"""
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Union
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Union
from litellm._logging import verbose_proxy_logger
from litellm.proxy._experimental.mcp_server.mcp_server_manager import (
@ -136,6 +136,29 @@ class SemanticToolFilterHook(CustomLogger):
return "litellm_metadata"
return "metadata"
def _partition_mcp_tools(self, tools: List[Any]) -> Tuple[List[Any], List[Any]]:
"""
Split tools into (mcp_tools, non_mcp_tools) using the live MCP server
registry. Building the known-prefix set from the registry prevents
hyphenated non-MCP tool names (e.g. "text-to-speech") from being
misclassified as MCP.
"""
known_prefixes = {
normalize_server_name(get_server_prefix(s))
for s in global_mcp_server_manager.get_registry().values()
if get_server_prefix(s)
}
mcp_tools: List[Any] = []
non_mcp_tools: List[Any] = []
for t in tools:
name = t.get("name", "") if isinstance(t, dict) else getattr(t, "name", "")
if is_tool_name_prefixed(name, known_server_prefixes=known_prefixes):
mcp_tools.append(t)
else:
non_mcp_tools.append(t)
return mcp_tools, non_mcp_tools
async def async_pre_call_hook(
self,
user_api_key_dict: "UserAPIKeyAuth",
@ -231,30 +254,8 @@ class SemanticToolFilterHook(CustomLogger):
f"with query: '{user_query[:50]}...'"
)
# Separate MCP tools (prefixed) from non-MCP tools — only filter
# MCP tools, always pass non-MCP tools through untouched. Build the
# known-prefix set from the live registry so hyphenated non-MCP
# tool names (e.g. "text-to-speech") aren't misclassified as MCP.
known_prefixes = {
normalize_server_name(get_server_prefix(s))
for s in global_mcp_server_manager.get_registry().values()
if get_server_prefix(s)
}
def _tool_name(t):
return (
t.get("name", "") if isinstance(t, dict) else getattr(t, "name", "")
)
mcp_tools: List[Any] = []
non_mcp_tools: List[Any] = []
for t in tools:
if is_tool_name_prefixed(
_tool_name(t), known_server_prefixes=known_prefixes
):
mcp_tools.append(t)
else:
non_mcp_tools.append(t)
# Only filter MCP tools; pass non-MCP tools through untouched.
mcp_tools, non_mcp_tools = self._partition_mcp_tools(tools)
if not mcp_tools:
return None