scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-11-15 09:12:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 311

test(guardrails): assert the wingback entry on the resolved metadata bucket

Browse source 
test_proxy_pre_call_hook_records_one_guardrail_entry_per_check read
data["litellm_metadata"] directly. That key existed only because the old
_ensure_litellm_metadata created it unconditionally, and on a chat-completions
request -- whose bucket is "metadata" -- creating it is the defect this PR
fixes: readers resolve the bucket by presence, so the new key moved them all
onto a near-empty dict.

The property the test protects, one entry per check with its status, is
unchanged; it now resolves the bucket with
get_metadata_variable_name_from_kwargs and asserts there. Third test of this
shape after the two in test_grayswan.py.

287 tests pass across the guardrail_hooks files that touch litellm_metadata.
This commit is contained in:
Vivek1898 2026-10-15 12:55:52 +05:30 • committed by Vivek1898
parent ba2bc7c9fe
commit aa3faa947b
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tests/unit/proxy/guardrails/guardrail_hooks/test_wingback.py
View file

@ -252,13 +252,29 @@ async def test_proxy_post_call_hook_blocks_on_wingback_verdict(registered: _Wing
@pytest.mark.asyncio
@pytest.mark.parametrize("registered", [("pre_call", ALLOWED)], indirect=True)
async def test_proxy_pre_call_hook_records_one_guardrail_entry_per_check(registered: _Wingback) -> None:
"""One guardrail entry per check, recorded in the request's metadata bucket.
Updated for #45543. This read the literal `litellm_metadata` key, which
existed only because the old `_ensure_litellm_metadata` created it
unconditionally -- and on a chat-completions request, whose bucket is
`metadata`, creating that key is the bug: every reader resolves the bucket
by presence, so a new key moves them all onto a near-empty dict. The
property being protected, one entry per check with its status, is
unchanged; it is now asserted on the resolved bucket.
"""
from litellm.litellm_core_utils.core_helpers import (
get_metadata_variable_name_from_kwargs,
)
data: Final = _chat_request("hello")
await ProxyLogging(user_api_key_cache=DualCache()).pre_call_hook(
user_api_key_dict=UserAPIKeyAuth(), data=data, call_type="completion"
)
entries: Final = data["litellm_metadata"]["standard_logging_guardrail_information"]
bucket_name = get_metadata_variable_name_from_kwargs(data)
assert bucket_name == "metadata"
entries: Final = data[bucket_name]["standard_logging_guardrail_information"]
assert [(entry["guardrail_name"], entry["guardrail_status"]) for entry in entries] == [
("wingback-runtime-security", "success")
]