mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-11 03:38:38 +00:00
fix(agentic): preserve provider prefixes for organization models
This commit is contained in:
parent
fe9b6fd603
commit
a1ea01c6f1
3 changed files with 84 additions and 2 deletions
|
|
@ -171,7 +171,7 @@ async def _execute_chat_completion_agentic_plan(
|
|||
raise ValueError("Agentic loop plan missing patched messages")
|
||||
|
||||
full_model_name = patch.model or model
|
||||
if "/" not in full_model_name:
|
||||
if custom_llm_provider and not full_model_name.startswith(f"{custom_llm_provider}/"):
|
||||
full_model_name = f"{custom_llm_provider}/{full_model_name}"
|
||||
|
||||
optional_params_for_followup: Final = {**optional_params, **patch.optional_params}
|
||||
|
|
|
|||
|
|
@ -5494,7 +5494,7 @@ class BaseLLMHTTPHandler:
|
|||
raise ValueError("Agentic loop plan missing patched messages")
|
||||
|
||||
full_model_name = patch.model or model
|
||||
if "/" not in full_model_name:
|
||||
if custom_llm_provider and not full_model_name.startswith(f"{custom_llm_provider}/"):
|
||||
full_model_name = f"{custom_llm_provider}/{full_model_name}"
|
||||
|
||||
optional_params_for_followup: Final = dict(optional_params)
|
||||
|
|
|
|||
82
tests/test_litellm/test_agentic_loop_prefix_44069.py
Normal file
82
tests/test_litellm/test_agentic_loop_prefix_44069.py
Normal file
|
|
@ -0,0 +1,82 @@
|
|||
from typing import Final, Literal
|
||||
from unittest.mock import AsyncMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
import litellm
|
||||
from litellm.integrations.custom_logger import CustomLogger
|
||||
from litellm.litellm_core_utils.chat_completion_agentic_loop import (
|
||||
_execute_chat_completion_agentic_plan,
|
||||
)
|
||||
from litellm.llms.custom_httpx.llm_http_handler import BaseLLMHTTPHandler
|
||||
from litellm.types.integrations.custom_logger import (
|
||||
AgenticLoopPlan,
|
||||
AgenticLoopRequestPatch,
|
||||
)
|
||||
from litellm.types.utils import ModelResponse
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
@pytest.mark.parametrize("execution_path", ("http", "sdk"))
|
||||
@pytest.mark.parametrize("use_patch_model", (False, True), ids=("original-model", "patch-model"))
|
||||
@pytest.mark.parametrize(
|
||||
("model_name", "custom_llm_provider", "expected_model"),
|
||||
(
|
||||
("zai-org/GLM-5.3-Flash", "hosted_vllm", "hosted_vllm/zai-org/GLM-5.3-Flash"),
|
||||
("hosted_vllm/zai-org/GLM-5.3-Flash", "hosted_vllm", "hosted_vllm/zai-org/GLM-5.3-Flash"),
|
||||
("hosted_vllm/zai-org/GLM-5.3-Flash", "", "hosted_vllm/zai-org/GLM-5.3-Flash"),
|
||||
),
|
||||
ids=("organization-model", "already-prefixed", "no-provider"),
|
||||
)
|
||||
async def test_agentic_followup_preserves_provider_prefix(
|
||||
execution_path: Literal["http", "sdk"],
|
||||
use_patch_model: bool,
|
||||
model_name: str,
|
||||
custom_llm_provider: str,
|
||||
expected_model: str,
|
||||
) -> None:
|
||||
model: Final = "original-model" if use_patch_model else model_name
|
||||
plan: Final = AgenticLoopPlan(
|
||||
run_agentic_loop=True,
|
||||
request_patch=AgenticLoopRequestPatch(
|
||||
model=model_name if use_patch_model else None,
|
||||
messages=[{"role": "user", "content": "Continue"}],
|
||||
),
|
||||
)
|
||||
followup: Final = AsyncMock(wraps=litellm.acompletion)
|
||||
|
||||
with patch("litellm.acompletion", new=followup):
|
||||
response: Final = (
|
||||
await BaseLLMHTTPHandler()._execute_chat_completion_agentic_plan(
|
||||
plan=plan,
|
||||
model=model,
|
||||
messages=[],
|
||||
optional_params={"mock_response": "Follow-up complete"},
|
||||
kwargs={"custom_llm_provider": custom_llm_provider},
|
||||
custom_llm_provider=custom_llm_provider,
|
||||
depth=0,
|
||||
max_loops=3,
|
||||
fingerprints=[],
|
||||
fingerprint="followup",
|
||||
)
|
||||
if execution_path == "http"
|
||||
else await _execute_chat_completion_agentic_plan(
|
||||
plan=plan,
|
||||
callback=CustomLogger(),
|
||||
model=model,
|
||||
optional_params={"mock_response": "Follow-up complete"},
|
||||
kwargs={"custom_llm_provider": custom_llm_provider},
|
||||
logging_obj=None,
|
||||
custom_llm_provider=custom_llm_provider,
|
||||
depth=0,
|
||||
max_loops=3,
|
||||
fingerprints=[],
|
||||
fingerprint="followup",
|
||||
)
|
||||
)
|
||||
|
||||
assert isinstance(response, ModelResponse)
|
||||
assert response.model == expected_model.removeprefix("hosted_vllm/")
|
||||
followup.assert_awaited_once()
|
||||
assert followup.await_args is not None
|
||||
assert followup.await_args.kwargs["model"] == expected_model
|
||||
Loading…
Add table
Reference in a new issue