chore: drop leftover Lens references and test the Helm warning

- remove trace_encode_error from the native type stub
- drop the deleted tests/unit/tracing path from the unit CI shard
- point the url-state skill at the remaining route module
- delete the unused OTLP test helpers
- test that NOTES.txt warns about obsolete lens values and stays quiet without them
This commit is contained in:
moe-berri 2026-11-10 13:32:48 -08:00
parent 569a794de1
commit a1aa619625
6 changed files with 32 additions and 12 deletions

View file

@ -506,7 +506,6 @@ jobs:
tests/unit/secret_managers
tests/unit/skills/test_skills_main.py
tests/unit/telemetry tests/unit/proxy/telemetry
tests/unit/tracing
python-version: "3.12"
workers: 4
reruns: 0

View file

@ -0,0 +1,14 @@
suite: removed lens values
templates:
- NOTES.txt
tests:
- it: warns that lens values are ignored
set:
lensWorker.enabled: true
asserts:
- matchRegexRaw:
pattern: lens and lensWorker values are ignored
- it: stays quiet without lens values
asserts:
- notMatchRegexRaw:
pattern: lensWorker

View file

@ -0,0 +1,17 @@
suite: removed lens values
templates:
- NOTES.txt
values:
- ./values/required.yaml
tests:
- it: warns that lens values are ignored
set:
lens.enabled: true
lens.url: http://lens.lens.svc:4318
asserts:
- matchRegexRaw:
pattern: lens and lensWorker values are ignored
- it: stays quiet without lens values
asserts:
- notMatchRegexRaw:
pattern: lensWorker

View file

@ -19,7 +19,6 @@ class ForkedAfterNativeRuntimeStarted(RuntimeError): ...
class ProcessReservedForForking(RuntimeError): ...
class NativeRedisStoreError(Exception): ...
def trace_encode_error(message: str) -> bytes: ...
def bundled_model_cost_map() -> bytes: ...
def native_redis_breaker_states() -> list[str]: ...
@ -739,7 +738,6 @@ __all__ = [
"process_state_started",
"reserve_process_for_forking",
"responses",
"trace_encode_error",
"transcription",
]

View file

@ -1587,14 +1587,6 @@ async def test_read_request_body_unexpected_error():
assert result == {}
async def _never_receive() -> Message:
raise AssertionError("the OTLP route check never reads the body")
async def _never_send(message: Message) -> None:
raise AssertionError("the OTLP route check never sends")
@pytest.mark.asyncio
async def test_form_data_metadata_with_lone_surrogate_escape_is_rejected_like_a_json_body():
"""``json.loads`` accepts ``"\\ud800"`` and yields a lone surrogate that no

View file

@ -15,7 +15,7 @@ Clear a param with `setter(null)`; nuqs keeps unrelated params and the hash. Upd
Raw reads are fine for one-time reads that never re-render on URL changes: OAuth callback pages, login, the legacy `?page=` redirect, and `networking.tsx`
Reuse the existing helpers before adding a hook: `useUrlTab` in `src/hooks/useUrlTab.ts`, `useUrlTableState` in `src/components/shared/DataTable`, and the route modules `src/components/lens/route.ts` and `src/components/logs/request/logDetailRouting.ts`
Reuse the existing helpers before adding a hook: `useUrlTab` in `src/hooks/useUrlTab.ts`, `useUrlTableState` in `src/components/shared/DataTable`, and the route module `src/components/logs/request/logDetailRouting.ts`
In tests, render with `renderWithProviders` from `tests/test-utils.tsx`, passing `searchParams` for the initial URL and `onUrlUpdate` to assert writes. When a test asserts `window.location` directly, wrap the render in `NuqsAdapter` from `nuqs/adapters/react`; writes flush asynchronously, so assert them inside `waitFor`. For inputs bound to URL state, set values with one `fireEvent.change` rather than `user.type`, which flakes when a re-render between keystrokes moves focus