mirror of
https://github.com/BerriAI/litellm.git
synced 2026-09-10 22:41:41 +00:00
refactor: return the collision check's failure instead of raising it
The checker raised a custom exception and caught it two lines down in the same module, which is the throw-then-catch the repo's coding guide rules out. `main` now prints the same message and returns the exit code, so the collision list stays a value the whole way out
This commit is contained in:
parent
d6a727fe0f
commit
9f379b36b9
1 changed files with 5 additions and 11 deletions
|
|
@ -51,10 +51,6 @@ MATRIX_DIRECTIVES: Final = frozenset({"include", "exclude"})
|
|||
LOCAL_CALL_PREFIX: Final = "./"
|
||||
|
||||
|
||||
class CheckRunNameCollision(Exception):
|
||||
pass
|
||||
|
||||
|
||||
class Job(BaseModel):
|
||||
name: str | None = None
|
||||
uses: str | None = None
|
||||
|
|
@ -264,18 +260,16 @@ def workflow_sources() -> Mapping[str, str]:
|
|||
return {path.relative_to(REPO_ROOT).as_posix(): path.read_text() for path in sorted(WORKFLOWS_DIR.glob("*.y*ml"))}
|
||||
|
||||
|
||||
def main() -> None:
|
||||
def main() -> int:
|
||||
sources: Final = workflow_sources()
|
||||
found: Final = collisions(sources)
|
||||
if found:
|
||||
raise CheckRunNameCollision("Check-run names are not unique:\n - " + "\n - ".join(found))
|
||||
print("ERROR: Check-run names are not unique:\n - " + "\n - ".join(found), file=sys.stderr)
|
||||
return 1
|
||||
|
||||
print(f"Check-run names are unique across {len(sources)} workflows")
|
||||
return 0
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
try:
|
||||
main()
|
||||
except CheckRunNameCollision as exc:
|
||||
print(f"ERROR: {exc}", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
sys.exit(main())
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue