From 95db4b5217eabeee62c8faac6ecafb2e5c38ceca Mon Sep 17 00:00:00 2001
From: mateo-berri <277851410+mateo-berri@users.noreply.github.com>
Date: Thu, 29 Oct 2026 14:34:13 -0700
Subject: [PATCH] fix(ui): drop the ChatGPT sign-in dialog's success text that
 closes before it shows

---
 .../src/components/model_add/ChatGPTSignInModal.tsx           | 4 +---
 .../src/components/model_add/chatgpt_sign_in_flow.test.ts     | 4 ++--
 .../src/components/model_add/chatgpt_sign_in_flow.ts          | 4 ++--
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/ui/litellm-dashboard/src/components/model_add/ChatGPTSignInModal.tsx b/ui/litellm-dashboard/src/components/model_add/ChatGPTSignInModal.tsx
index 0524ba9fdf4..ec3304a61a9 100644
--- a/ui/litellm-dashboard/src/components/model_add/ChatGPTSignInModal.tsx
+++ b/ui/litellm-dashboard/src/components/model_add/ChatGPTSignInModal.tsx
@@ -104,8 +104,6 @@ export default function ChatGPTSignInModal({ credentialName, request, onClose, o
           </div>
         )}
 
-        {state.kind === "connected" && <p className="text-sm">Signed in with ChatGPT.</p>}
-
         {state.kind === "failed" && (
           <p role="alert" className="text-sm text-destructive">
             {signInFailureMessage(state)}
@@ -118,7 +116,7 @@ export default function ChatGPTSignInModal({ credentialName, request, onClose, o
               Start again
             </Button>
           )}
-          <Button onClick={onClose}>{state.kind === "connected" ? "Done" : "Close"}</Button>
+          <Button onClick={onClose}>Close</Button>
         </DialogFooter>
       </DialogContent>
     </Dialog>
diff --git a/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.test.ts b/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.test.ts
index f12904818b4..e035f7ae8b7 100644
--- a/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.test.ts
+++ b/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.test.ts
@@ -58,8 +58,8 @@ describe("signInFlowReducer", () => {
     expect(pending).toEqual({ ...awaiting, pollCount: 1 });
   });
 
-  it("connects with the account id from the poll", () => {
-    expect(connected()).toEqual({ kind: "connected", attempt: 0, accountId: "acct-1" });
+  it("connects once the poll says connected", () => {
+    expect(connected()).toEqual({ kind: "connected", attempt: 0 });
   });
 
   it("expires locally once the code lifetime has passed", () => {
diff --git a/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.ts b/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.ts
index 34e08678335..9e763f98ebc 100644
--- a/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.ts
+++ b/ui/litellm-dashboard/src/components/model_add/chatgpt_sign_in_flow.ts
@@ -29,7 +29,7 @@ export type SignInFlowState =
       readonly intervalSeconds: number;
       readonly flowHandle: string;
     }
-  | { readonly kind: "connected"; readonly attempt: number; readonly accountId: string | null }
+  | { readonly kind: "connected"; readonly attempt: number }
   | {
       readonly kind: "failed";
       readonly attempt: number;
@@ -117,7 +117,7 @@ const afterPoll = (
     case "pending":
       return { ...state, pollCount: state.pollCount + 1 };
     case "connected":
-      return { kind: "connected", attempt: state.attempt, accountId: response.account_id };
+      return { kind: "connected", attempt: state.attempt };
   }
 };