scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-07 08:26:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 89

test(ui): query the screen in models page tests and drop restating comments

Browse source 
The merge of #38872 into staging kept the destructured render queries
in the models-and-endpoints page test, which pushes
testing-library/prefer-screen-queries to 21 against a budget of 18 and
fails frontend-lint for every PR on top of it. Two comments that only
restated the list merge below them are gone as well.

Claude-Session: https://claude.ai/code/session_01QvQzYztinxj8ZuD5YxbVdL
This commit is contained in:
ryan-crabbe-berri 2026-09-01 16:25:15 -07:00
parent c493fc855c
commit 944d018c72
3 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ui/litellm-dashboard/src/app/(dashboard)/models-and-endpoints/page.test.tsx
View file

@ -111,17 +111,17 @@ describe("ModelsAndEndpointsPage", () => {
// POST /model/new 403s a proxy_admin_viewer, so the form's tab must not render for one.
it("hides the Add Model tab for a view-only admin session", () => {
mockUseAuthorized.mockReturnValue(VIEW_ONLY_ADMIN);
const { getByRole, queryByRole } = renderPage();
expect(queryByRole("tab", { name: "Add Model" })).not.toBeInTheDocument();
expect(getByRole("tab", { name: "All Models" })).toBeInTheDocument();
renderPage();
expect(screen.queryByRole("tab", { name: "Add Model" })).not.toBeInTheDocument();
expect(screen.getByRole("tab", { name: "All Models" })).toBeInTheDocument();
});
// Read parity: the Auto-Routers list stays reachable for a view-only admin; only the
// create affordance inside it is withheld, which AutoRoutersTabPanel decides.
it("keeps the Auto-Routers tab for a view-only admin session", () => {
mockUseAuthorized.mockReturnValue(VIEW_ONLY_ADMIN);
const { getByRole } = renderPage();
expect(getByRole("tab", { name: /Auto-Routers/ })).toBeInTheDocument();
renderPage();
expect(screen.getByRole("tab", { name: /Auto-Routers/ })).toBeInTheDocument();
});
// Auto-routers are excluded from the All Models table, so this tab is their home: the only

1
ui/litellm-dashboard/src/components/permissions/AgentPermissions.tsx
View file

@ -57,7 +57,6 @@ export function AgentPermissions({
return agentId;
};
// Merge agents, inherited agents and access groups into one list
const mergedItems = [
...agents.map((agent) => ({ type: "agent", value: agent, inherited: false })),
...inheritedOnlyAgents.map((agent) => ({ type: "agent", value: agent, inherited: true })),

1
ui/litellm-dashboard/src/components/permissions/MCPServerPermissions.tsx
View file

@ -108,7 +108,6 @@ export function MCPServerPermissions({
const blocksAllMcpServers = mcpServers.includes(NO_MCP_SERVERS_SENTINEL);
const grantsAllProxyMcpServers = mcpServers.includes(ALL_PROXY_MCP_SERVERS_SENTINEL);
// Merge servers, inherited servers and access groups into one list
const mergedItems = [
...directServerIds.map((server) => ({ type: "server", value: server, inherited: false })),
...inheritedOnlyServerIds.map((server) => ({ type: "server", value: server, inherited: true })),