scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-24 00:52:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 90

fix(utils): drop model from extra_body for openai-compatible providers

Browse source 
A caller-supplied extra_body model overrode the authorized model in the request the shared HTTP handler sends upstream. Strip it before dispatch

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
yassin 2026-09-21 20:43:08 +00:00
parent 9dee1d86e7
commit 930c7e2638
2 changed files with 34 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
litellm/utils.py
View file

@ -4898,6 +4898,9 @@ def get_optional_params(
return optional_params
EXTRA_BODY_ROUTING_KEYS: Final = frozenset({"model"})
def add_provider_specific_params_to_optional_params(
optional_params: dict,
passed_params: dict,
@ -4923,10 +4926,8 @@ def add_provider_specific_params_to_optional_params(
**extra_body,
}
if additional_drop_params is not None:
processed_extra_body = {k: v for k, v in initial_extra_body.items() if k not in additional_drop_params}
else:
processed_extra_body = initial_extra_body
dropped_keys: Final = EXTRA_BODY_ROUTING_KEYS | frozenset(additional_drop_params or ())
processed_extra_body: Final = {k: v for k, v in initial_extra_body.items() if k not in dropped_keys}
_ensure_extra_body_is_safe: Final = getattr(sys.modules[__name__], "_ensure_extra_body_is_safe")
optional_params["extra_body"] = _ensure_extra_body_is_safe(extra_body=processed_extra_body)

29
tests/test_litellm/test_utils.py
View file

@ -2979,6 +2979,35 @@ class TestAdditionalDropParamsForNonOpenAIProviders:
assert result.get("custom_param") == "value"
class TestExtraBodyCannotOverrideModel:
@pytest.mark.parametrize("custom_llm_provider", ["edenai", "openai", "azure"])
def test_extra_body_model_is_dropped_for_openai_compatible_providers(self, custom_llm_provider: str) -> None:
from litellm.utils import add_provider_specific_params_to_optional_params
result = add_provider_specific_params_to_optional_params(
optional_params={"extra_body": {"model": "edenai/openai/gpt-4o", "provider_flag": True}},
passed_params={
"model": "edenai/openai/gpt-4o-mini",
"extra_body": {"model": "edenai/anthropic/claude-3-opus", "top_k": 5},
"custom_param": "kept",
},
custom_llm_provider=custom_llm_provider,
openai_params=["model", "temperature"],
additional_drop_params=None,
)
assert result == {"extra_body": {"provider_flag": True, "top_k": 5, "custom_param": "kept"}}, result
def test_get_optional_params_strips_extra_body_model_for_edenai(self) -> None:
result = litellm.get_optional_params(
model="openai/gpt-4o-mini",
custom_llm_provider="edenai",
extra_body={"model": "anthropic/claude-opus-4-1", "top_k": 5},
)
assert result["extra_body"] == {"top_k": 5}, result
class TestDropParamsWithPromptCacheKey:
"""
Test that drop_params: true correctly drops prompt_cache_key for non-OpenAI providers.