From 90f86258a8e94fc7cbc5a710cb63034eae70430d Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Tue, 19 May 2026 07:20:12 +0000 Subject: [PATCH] fix(triage): make reconsider mode fail-safe on malformed LLM verdict Only reopen on an explicit 'pass' verdict. Previously any non-'fail' value (including missing/empty/unknown verdicts) would trigger a reopen, undoing a prior auto-close based on an ambiguous response. Co-authored-by: Yassin Kortam --- .github/scripts/triage_with_llm.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/scripts/triage_with_llm.py b/.github/scripts/triage_with_llm.py index 60c051e3352..3584aa252c2 100644 --- a/.github/scripts/triage_with_llm.py +++ b/.github/scripts/triage_with_llm.py @@ -741,7 +741,10 @@ def triage( # fail -> leave closed + post a "still failing" comment so the # contributor can iterate again. When `close=False` we preview # the action instead of actually posting/reopening. - if decision != "fail": + # Only an explicit "pass" verdict triggers a reopen — any other + # value (including missing/malformed verdicts) is fail-safe and + # leaves the PR/issue closed. + if decision == "pass": reopen_body = format_reopen_comment(kind) if not close: return {