scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-07 02:59:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 103

test(proxy): stay within the test-quality TQ001/TQ008 budget

Browse source 
The two new cancel-path tests pushed TQ001 (an assertion-free test) and
TQ008 (patching a litellm internal) over their limits. Added a real
assertion to the cancellation test (finalized stays False, since
absorbing a second CancelledError isn't the failure path) and
test-quality-ok annotations on the three patch() calls, matching this
file's existing pattern for module functions with no DI seam.
This commit is contained in:
Abhyuday 2026-09-14 16:41:09 -04:00
parent e9836165d7
commit 90a6e8d423
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tests/test_litellm/proxy/test_budget_reservation.py
View file

@ -2799,13 +2799,16 @@ async def test_release_budget_reservation_on_cancel_swallows_a_second_cancellati
"finalized": False,
"input_cost": 0.5,
}
with patch(
with patch( # test-quality-ok: reconcile_budget_reservation is a module function, no DI seam for this test
"litellm.proxy.spend_tracking.budget_reservation.reconcile_budget_reservation",
new=AsyncMock(side_effect=asyncio.CancelledError()),
):
# must return without raising
# must return without raising, and without taking the finalize-on-failure path either:
# a second cancellation isn't a failure, it's the reconcile still running in the background
await release_budget_reservation_on_cancel(reservation)
assert reservation["finalized"] is False
@pytest.mark.asyncio
async def test_release_budget_reservation_on_cancel_swallows_invalidate_failure_after_every_retry_fails():
@ -2818,10 +2821,10 @@ async def test_release_budget_reservation_on_cancel_swallows_invalidate_failure_
"finalized": False,
"input_cost": 0.5,
}
with patch(
with patch( # test-quality-ok: reconcile_budget_reservation is a module function, no DI seam for this test
"litellm.proxy.spend_tracking.budget_reservation.reconcile_budget_reservation",
new=AsyncMock(side_effect=RuntimeError("redis down")),
), patch(
), patch( # test-quality-ok: invalidate_budget_reservation_counters is a module function, no DI seam for this test
"litellm.proxy.spend_tracking.budget_reservation.invalidate_budget_reservation_counters",
new=AsyncMock(side_effect=RuntimeError("redis still down")),
):