From 8f7018d83ddf4a4a4b318461f978fbfa31eba353 Mon Sep 17 00:00:00 2001 From: Vasilisa Parshikova Date: Wed, 11 Mar 2026 16:19:12 +0400 Subject: [PATCH] (sap) fix after bot review --- litellm/llms/sap/embed/transformation.py | 2 +- .../llms/sap/embed/test_sap_embed_transformation.py | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/litellm/llms/sap/embed/transformation.py b/litellm/llms/sap/embed/transformation.py index b8f27c48693..f6330d0706d 100644 --- a/litellm/llms/sap/embed/transformation.py +++ b/litellm/llms/sap/embed/transformation.py @@ -48,7 +48,7 @@ class EmbeddingsResponse(BaseModel): class EmbeddingModel(BaseModel): name: str version: str = "latest" - params: dict = Field(default_factory=dict, validation_alias="parameters") + params: dict = Field(default_factory=dict) timeout: int = Field(default=600, ge=1, le=600) max_retries: int = Field(default=2, ge=0, le=5) diff --git a/tests/test_litellm/llms/sap/embed/test_sap_embed_transformation.py b/tests/test_litellm/llms/sap/embed/test_sap_embed_transformation.py index 511828bf10a..4910ae5531c 100644 --- a/tests/test_litellm/llms/sap/embed/test_sap_embed_transformation.py +++ b/tests/test_litellm/llms/sap/embed/test_sap_embed_transformation.py @@ -47,4 +47,13 @@ def test_basic_config_transform(fake_token_creator, fake_deployment_url): optional_params={}, headers={} ) - assert body == expected_dict \ No newline at end of file + assert body == expected_dict + +def test_model_params(fake_token_creator, fake_deployment_url): + body = GenAIHubEmbeddingConfig().transform_embedding_request( + model="text-embedding-3-small", + input="Hi", + optional_params={"parameters": {"truncate": "END"}}, + headers={} + ) + assert body["config"]["modules"]["embeddings"]["model"]["params"] == {"truncate": "END"} \ No newline at end of file